CVS log for src/sys/dev/usb/if_umb.c
Up to [cvs.NetBSD.org] / src / sys / dev / usb
Request diff between arbitrary revisions
Keyword substitution: kv
Default branch: MAIN
Revision 1.25.10.2: download - view: text, markup, annotated - select for diffs
Wed Nov 4 23:22:36 2026 UTC (11 days, 14 hours ago) by perseant
Branches: perseant-exfatfs
Diff to: previous 1.25.10.1: preferred, colored; branchpoint 1.25: preferred, colored; next MAIN 1.26: preferred, colored
Changes since revision 1.25.10.1: +3 -3
lines
Sync with HEAD
Revision 1.27: download - view: text, markup, annotated - select for diffs
Mon Aug 18 20:59:55 2025 UTC (14 months, 4 weeks ago) by andvar
Branches: MAIN
CVS tags: perseant-exfatfs-base-20261102,
HEAD
Diff to: previous 1.26: preferred, colored
Changes since revision 1.26: +3 -3
lines
Fix various typos, mainly in comments:
s/invaid/invalid/
s/instad/instead/
s/wich/with/
s/tranform/transform/
s/tranmist/transmit/
s/tranceiver/transceiver/
s/Tranparent/Transparent/
s/tranlated/translated/
s/tranfer/transfer/
s/tranmissions/transmissions/
s/condtions/conditions/
s/Recient/Recent/
Revision 1.25.10.1: download - view: text, markup, annotated - select for diffs
Sat Aug 2 05:57:05 2025 UTC (15 months, 2 weeks ago) by perseant
Branches: perseant-exfatfs
Diff to: previous 1.25: preferred, colored
Changes since revision 1.25: +4 -6
lines
Sync with HEAD
Revision 1.26: download - view: text, markup, annotated - select for diffs
Fri Jul 5 04:31:52 2024 UTC (2 years, 4 months ago) by rin
Branches: MAIN
CVS tags: perseant-exfatfs-base-20250801,
netbsd-11-base,
netbsd-11-1-RELEASE,
netbsd-11-0-RELEASE,
netbsd-11-0-RC7,
netbsd-11-0-RC6,
netbsd-11-0-RC5,
netbsd-11-0-RC4,
netbsd-11-0-RC3,
netbsd-11-0-RC2,
netbsd-11-0-RC1,
netbsd-11
Diff to: previous 1.25: preferred, colored
Changes since revision 1.25: +4 -6
lines
sys: Drop redundant NULL check before m_freem(9)
m_freem(9) safely has accepted NULL argument at least since 4.2BSD:
https://www.tuhs.org/cgi-bin/utree.pl?file=4.2BSD/usr/src/sys/sys/uipc_mbuf.c
Compile-tested on amd64/ALL.
Suggested by knakahara@
Revision 1.25.8.2: download - view: text, markup, annotated - select for diffs
Thu Nov 16 05:13:13 2023 UTC (3 years ago) by thorpej
Branches: thorpej-ifq
Diff to: previous 1.25.8.1: preferred, colored; branchpoint 1.25: preferred, colored; next MAIN 1.26: preferred, colored
Changes since revision 1.25.8.1: +3 -3
lines
if_transmit_lock() and if_enqueue() are equivalent. if_enqueue() is
a better name, so collapse everything down to that and garbage-collect
if_transmit_lock().
Revision 1.25.8.1: download - view: text, markup, annotated - select for diffs
Thu Nov 16 04:30:21 2023 UTC (3 years ago) by thorpej
Branches: thorpej-ifq
Diff to: previous 1.25: preferred, colored
Changes since revision 1.25: +3 -3
lines
IFQ_CLASSIFY() -> ifq_classify_packet().
Revision 1.25: download - view: text, markup, annotated - select for diffs
Sat Aug 20 11:32:08 2022 UTC (4 years, 2 months ago) by riastradh
Branches: MAIN
CVS tags: thorpej-ifq-base,
thorpej-altq-separation-base,
thorpej-altq-separation,
perseant-exfatfs-base-20240630,
perseant-exfatfs-base,
netbsd-10-base,
netbsd-10-2-RELEASE,
netbsd-10-1-RELEASE,
netbsd-10-0-RELEASE,
netbsd-10-0-RC6,
netbsd-10-0-RC5,
netbsd-10-0-RC4,
netbsd-10-0-RC3,
netbsd-10-0-RC2,
netbsd-10-0-RC1,
netbsd-10,
bouyer-sunxi-drm-base,
bouyer-sunxi-drm
Branch point for: thorpej-ifq,
perseant-exfatfs
Diff to: previous 1.24: preferred, colored
Changes since revision 1.24: +3 -10
lines
umb(4): Use usbd_do_request as drivers are intended to do.
Revision 1.24: download - view: text, markup, annotated - select for diffs
Sun Apr 17 13:17:56 2022 UTC (4 years, 7 months ago) by riastradh
Branches: MAIN
Diff to: previous 1.23: preferred, colored
Changes since revision 1.23: +5 -4
lines
umb(4): Use memcpy, not potentially unaligned/aliased casts.
Revision 1.23: download - view: text, markup, annotated - select for diffs
Sun Apr 17 13:17:40 2022 UTC (4 years, 7 months ago) by riastradh
Branches: MAIN
Diff to: previous 1.22: preferred, colored
Changes since revision 1.22: +12 -2
lines
umb(4): Validate descriptor lengths.
Revision 1.22: download - view: text, markup, annotated - select for diffs
Sun Apr 17 13:15:27 2022 UTC (4 years, 7 months ago) by riastradh
Branches: MAIN
Diff to: previous 1.21: preferred, colored
Changes since revision 1.21: +5 -3
lines
umb(4): Use usb_cdc_descriptor_t for bDescriptorSubtype.
Note: This needs more length validation! TBD in a separate commit.
Revision 1.21: download - view: text, markup, annotated - select for diffs
Tue Sep 21 14:49:01 2021 UTC (5 years, 1 month ago) by christos
Branches: MAIN
Diff to: previous 1.20: preferred, colored
Changes since revision 1.20: +4 -4
lines
don't opencode kauth_cred_get()
Revision 1.19.8.1: download - view: text, markup, annotated - select for diffs
Thu Jun 17 04:46:30 2021 UTC (5 years, 5 months ago) by thorpej
Branches: thorpej-i2c-spi-conf
Diff to: previous 1.19: preferred, colored; next MAIN 1.20: preferred, colored
Changes since revision 1.19: +3 -9
lines
Sync w/ HEAD.
Revision 1.20: download - view: text, markup, annotated - select for diffs
Wed Jun 16 00:21:19 2021 UTC (5 years, 5 months ago) by riastradh
Branches: MAIN
CVS tags: thorpej-i2c-spi-conf2-base,
thorpej-i2c-spi-conf2,
thorpej-i2c-spi-conf-base,
thorpej-futex2-base,
thorpej-futex2,
thorpej-cfargs2-base,
thorpej-cfargs2
Diff to: previous 1.19: preferred, colored
Changes since revision 1.19: +3 -9
lines
if_attach and if_initialize cannot fail, don't test return value
These were originally made failable back in 2017 when if_initialize
allocated a softint in every interface for link state changes, so
that it could fail gracefully instead of panicking:
https://mail-index.NetBSD.org/source-changes/2017/10/23/msg089053.html
However, this spawned many seldom- or never-tested error branches,
which are risky to have around. And that softint in every interface
has since been replaced by a single global workqueue, because link
state changes require thread context but not low latency or high
throughput:
https://mail-index.NetBSD.org/source-changes/2020/02/06/msg113759.html
So there is no longer any reason for if_initialize to fail. (The
subroutine if_stats_init can't fail because percpu_alloc can't fail
either.)
There is a snag: the softint_establish in if_percpuq_create could
fail, potentially leading to bad consequences later on trying to use
the softint. This change doesn't introduce any new bugs because of
the snag -- if_percpuq_attach was already broken. However, the snag
can be better addressed without spawning error branches, either by
using a single softint or making softints less scarce.
(Separate commit will change the signatures of if_attach and
if_initialize to return void, scheduled to ride whatever is the next
convenient kernel bump.)
Patch and testing on amd64 and evbmips64-eb by maya@; commit message
soliloquy, and compile-testing on evbppc/i386/earmv7hf, by me.
Revision 1.8.4.4: download - view: text, markup, annotated - select for diffs
Mon Apr 13 08:04:49 2020 UTC (6 years, 7 months ago) by martin
Branches: phil-wifi
Diff to: previous 1.8.4.3: preferred, colored; branchpoint 1.8: preferred, colored; next MAIN 1.9: preferred, colored
Changes since revision 1.8.4.3: +9 -9
lines
Mostly merge changes from HEAD upto 20200411
Revision 1.8.4.3: download - view: text, markup, annotated - select for diffs
Wed Apr 8 14:08:13 2020 UTC (6 years, 7 months ago) by martin
Branches: phil-wifi
Diff to: previous 1.8.4.2: preferred, colored; branchpoint 1.8: preferred, colored
Changes since revision 1.8.4.2: +36 -29
lines
Merge changes from current as of 20200406
Revision 1.19: download - view: text, markup, annotated - select for diffs
Tue Mar 24 07:12:16 2020 UTC (6 years, 7 months ago) by maxv
Branches: MAIN
CVS tags: thorpej-futex-base,
thorpej-futex,
thorpej-cfargs-base,
thorpej-cfargs,
phil-wifi-20200421,
phil-wifi-20200411,
phil-wifi-20200406,
cjep_sun2x-base1,
cjep_sun2x-base,
cjep_sun2x,
cjep_staticlib_x-base1,
cjep_staticlib_x-base,
cjep_staticlib_x,
bouyer-xenpvh-base2,
bouyer-xenpvh-base1,
bouyer-xenpvh-base,
bouyer-xenpvh
Branch point for: thorpej-i2c-spi-conf
Diff to: previous 1.18: preferred, colored
Changes since revision 1.18: +3 -3
lines
Fix type confusion. Found by kASan when doing a normal attach+detach over
vHCI.
Revision 1.18: download - view: text, markup, annotated - select for diffs
Sat Mar 21 06:55:13 2020 UTC (6 years, 7 months ago) by skrll
Branches: MAIN
Diff to: previous 1.17: preferred, colored
Changes since revision 1.17: +5 -5
lines
KNF
Revision 1.17: download - view: text, markup, annotated - select for diffs
Thu Mar 19 07:51:22 2020 UTC (6 years, 7 months ago) by khorben
Branches: MAIN
Diff to: previous 1.16: preferred, colored
Changes since revision 1.16: +6 -7
lines
Only set the IPv4 address in umb(4) if both MBIM_IPCONF_HAS_ADDRINFO and
MBIM_IPCONF_HAS_GWINFO are available. Configuring umb(4) without gateway
wont work the system needs a destination address for the interface.
Problem found by jsg@.
OK jsg@ deraadt@
From OpenBSD.
Revision 1.16: download - view: text, markup, annotated - select for diffs
Thu Mar 19 07:50:27 2020 UTC (6 years, 7 months ago) by khorben
Branches: MAIN
Diff to: previous 1.15: preferred, colored
Changes since revision 1.15: +4 -4
lines
turn the success paths of FCC registration into debug prints. The
(unlikely) failure path remains noisy.
discussed with claudio
From OpenBSD.
Revision 1.15: download - view: text, markup, annotated - select for diffs
Thu Mar 19 07:49:29 2020 UTC (6 years, 7 months ago) by khorben
Branches: MAIN
Diff to: previous 1.14: preferred, colored
Changes since revision 1.14: +6 -3
lines
When there is no network around the state timeout fires over and over again.
Change the printf into a log and only under IFF_DEBUG to reduce dmesg spam.
Loudly requested by beck@ OK deraadt@
From OpenBSD.
Revision 1.14: download - view: text, markup, annotated - select for diffs
Sat Mar 14 02:35:33 2020 UTC (6 years, 8 months ago) by christos
Branches: MAIN
Diff to: previous 1.13: preferred, colored
Changes since revision 1.13: +6 -6
lines
revert the 0x% -> %# change for fixed width formats pointed out by uwe.
Revision 1.13: download - view: text, markup, annotated - select for diffs
Fri Mar 13 18:17:40 2020 UTC (6 years, 8 months ago) by christos
Branches: MAIN
Diff to: previous 1.12: preferred, colored
Changes since revision 1.12: +11 -11
lines
PR/55068: sc.dying: Fix printf formats:
- no %s/%p for kernel log
- 0x% -> %#
- always %j for kernel log
Revision 1.10.2.1: download - view: text, markup, annotated - select for diffs
Sat Feb 29 20:19:16 2020 UTC (6 years, 8 months ago) by ad
Branches: ad-namecache
Diff to: previous 1.10: preferred, colored; next MAIN 1.11: preferred, colored
Changes since revision 1.10: +11 -12
lines
Sync with head.
Revision 1.12: download - view: text, markup, annotated - select for diffs
Tue Feb 4 05:46:32 2020 UTC (6 years, 9 months ago) by thorpej
Branches: MAIN
CVS tags: is-mlppp-base,
is-mlppp,
ad-namecache-base3
Diff to: previous 1.11: preferred, colored
Changes since revision 1.11: +3 -3
lines
Use ifmedia_fini().
Revision 1.11: download - view: text, markup, annotated - select for diffs
Wed Jan 29 06:35:28 2020 UTC (6 years, 9 months ago) by thorpej
Branches: MAIN
Diff to: previous 1.10: preferred, colored
Changes since revision 1.10: +10 -11
lines
Adopt <net/if_stats.h>.
Revision 1.9.2.1: download - view: text, markup, annotated - select for diffs
Tue Dec 17 16:12:53 2019 UTC (6 years, 11 months ago) by martin
Branches: netbsd-9
CVS tags: netbsd-9-5-RELEASE,
netbsd-9-4-RELEASE,
netbsd-9-3-RELEASE,
netbsd-9-2-RELEASE,
netbsd-9-1-RELEASE,
netbsd-9-0-RELEASE,
netbsd-9-0-RC2
Diff to: previous 1.9: preferred, colored; next MAIN 1.10: preferred, colored
Changes since revision 1.9: +8 -2
lines
Pull up following revision(s) (requested by christos in ticket #569):
sys/dev/usb/if_umb.c: revision 1.10
sys/net/if.c: revision 1.466
sys/dev/ic/ath.c: revision 1.129
Protect network ioctls from non-authorized users. (Ilja Van Sprundel)
Revision 1.10: download - view: text, markup, annotated - select for diffs
Tue Dec 17 04:54:36 2019 UTC (6 years, 11 months ago) by christos
Branches: MAIN
CVS tags: ad-namecache-base2,
ad-namecache-base1,
ad-namecache-base
Branch point for: ad-namecache
Diff to: previous 1.9: preferred, colored
Changes since revision 1.9: +8 -2
lines
Protect network ioctls from non-authorized users. (Ilja Van Sprundel)
Revision 1.9: download - view: text, markup, annotated - select for diffs
Wed Jun 26 22:58:58 2019 UTC (7 years, 4 months ago) by khorben
Branches: MAIN
CVS tags: phil-wifi-20191119,
netbsd-9-base,
netbsd-9-0-RC1
Branch point for: netbsd-9
Diff to: previous 1.8: preferred, colored
Changes since revision 1.8: +11 -11
lines
Fix typos
Some were found by OpenBSD.
Revision 1.8.4.2: download - view: text, markup, annotated - select for diffs
Mon Jun 10 22:07:33 2019 UTC (7 years, 5 months ago) by christos
Branches: phil-wifi
Diff to: previous 1.8.4.1: preferred, colored; branchpoint 1.8: preferred, colored
Changes since revision 1.8.4.1: +2881 -0
lines
Sync with HEAD
Revision 1.8.4.1
Sun Jan 27 02:08:42 2019 UTC (7 years, 9 months ago) by christos
Branches: phil-wifi
FILE REMOVED
Changes since revision 1.8: +0 -2881
lines
file if_umb.c was added on branch phil-wifi on 2019-06-10 22:07:33 +0000
Revision 1.8: download - view: text, markup, annotated - select for diffs
Sun Jan 27 02:08:42 2019 UTC (7 years, 9 months ago) by pgoyette
Branches: MAIN
CVS tags: phil-wifi-20190609,
isaki-audio2-base,
isaki-audio2
Branch point for: phil-wifi
Diff to: previous 1.7: preferred, colored
Changes since revision 1.7: +2 -2
lines
Merge the [pgoyette-compat] branch
Revision 1.4.4.4: download - view: text, markup, annotated - select for diffs
Mon Nov 26 01:52:47 2018 UTC (7 years, 11 months ago) by pgoyette
Branches: pgoyette-compat
CVS tags: pgoyette-compat-merge-20190127
Diff to: previous 1.4.4.3: preferred, colored; branchpoint 1.4: preferred, colored; next MAIN 1.5: preferred, colored
Changes since revision 1.4.4.3: +3 -3
lines
Sync with HEAD, resolve a couple of conflicts
Revision 1.7: download - view: text, markup, annotated - select for diffs
Thu Nov 15 10:56:30 2018 UTC (8 years ago) by maxv
Branches: MAIN
CVS tags: pgoyette-compat-20190127,
pgoyette-compat-20190118,
pgoyette-compat-1226,
pgoyette-compat-1126
Diff to: previous 1.6: preferred, colored
Changes since revision 1.6: +3 -3
lines
Remove the 'copy' argument from m_devget(), unused. While here rename
off0->off.
Revision 1.4.4.3: download - view: text, markup, annotated - select for diffs
Sun Sep 30 01:45:51 2018 UTC (8 years, 1 month ago) by pgoyette
Branches: pgoyette-compat
Diff to: previous 1.4.4.2: preferred, colored; branchpoint 1.4: preferred, colored
Changes since revision 1.4.4.2: +17 -18
lines
Ssync with HEAD
Revision 1.6: download - view: text, markup, annotated - select for diffs
Thu Sep 20 09:48:54 2018 UTC (8 years, 1 month ago) by khorben
Branches: MAIN
CVS tags: pgoyette-compat-1020,
pgoyette-compat-0930
Diff to: previous 1.5: preferred, colored
Changes since revision 1.5: +13 -10
lines
Prevent a panic in umb(4) when roaming is disabled
From OpenBSD.
Revision 1.5: download - view: text, markup, annotated - select for diffs
Thu Sep 20 09:45:16 2018 UTC (8 years, 1 month ago) by khorben
Branches: MAIN
Diff to: previous 1.4: preferred, colored
Changes since revision 1.4: +6 -10
lines
Use usb_rem_task_wait() now that it is available
This should avoid panics while detaching devices.
Revision 1.4.4.2: download - view: text, markup, annotated - select for diffs
Thu Sep 6 06:56:04 2018 UTC (8 years, 2 months ago) by pgoyette
Branches: pgoyette-compat
Diff to: previous 1.4.4.1: preferred, colored; branchpoint 1.4: preferred, colored
Changes since revision 1.4.4.1: +2882 -0
lines
Sync with HEAD
Resolve a couple of conflicts (result of the uimin/uimax changes)
Revision 1.4.4.1
Wed Aug 1 18:27:58 2018 UTC (8 years, 3 months ago) by pgoyette
Branches: pgoyette-compat
FILE REMOVED
Changes since revision 1.4: +0 -2882
lines
file if_umb.c was added on branch pgoyette-compat on 2018-09-06 06:56:04 +0000
Revision 1.4: download - view: text, markup, annotated - select for diffs
Wed Aug 1 18:27:58 2018 UTC (8 years, 3 months ago) by khorben
Branches: MAIN
CVS tags: pgoyette-compat-0906,
jdolecek-ncqfixes-base,
jdolecek-ncqfixes
Branch point for: pgoyette-compat
Diff to: previous 1.3: preferred, colored
Changes since revision 1.3: +3 -3
lines
Fix building umb(4) on NetBSD-current
Patch by Robert Swindells; thank you!
Revision 1.3: download - view: text, markup, annotated - select for diffs
Wed Aug 1 12:36:56 2018 UTC (8 years, 3 months ago) by khorben
Branches: MAIN
Diff to: previous 1.2: preferred, colored
Changes since revision 1.2: +5 -12
lines
Allow kmem_alloc(9) to sleep when attaching
Without this, umb(4) may needlessly fail to attach, like when under memory
pressure.
Thanks skrll@ for the heads-up!
Revision 1.2: download - view: text, markup, annotated - select for diffs
Wed Aug 1 12:25:50 2018 UTC (8 years, 3 months ago) by khorben
Branches: MAIN
Diff to: previous 1.1: preferred, colored
Changes since revision 1.1: +15 -15
lines
Avoid parentheses in return statements (KNF)
NFCI.
Thanks skrll@ for the heads-up!
Revision 1.1: download - view: text, markup, annotated - select for diffs
Tue Jul 31 16:44:29 2018 UTC (8 years, 3 months ago) by khorben
Branches: MAIN
Add a port of the umb(4) driver from OpenBSD
The umb(4) driver provides support for USB MBIM (Mobile Broadband
Interface Model) devices.
MBIM devices establish connections via cellular networks such as GPRS,
UMTS, and LTE. They appear as a regular point-to-point network interface, transporting raw IP frames.
Required configuration parameters like PIN and APN have to be set with
umbctl(8), a new tool specific to this driver. The IP address is configured
automatically; the default route and DNS server information have to be set
separately.
The driver is not fully functional yet, it is therefore still marked as
experimental and disabled by default. Any help welcome to complete it!
Tested on NetBSD/amd64, with a Sierra Wireless EM7345 LTE modem on a Lenovo
ThinkPad T440s. No functional change expected otherwise.
CVSweb <webmaster@jp.NetBSD.org>