Up to [cvs.NetBSD.org] / pkgsrc / pkgtools / pkglint
Request diff between arbitrary revisions
Keyword substitution: kv
Default branch: MAIN
Revbump for Go update (ticket #7379)
Revbump all Go packages after go127 update
*: Revbump for go126, go127. Ticket #7311
Revbump all Go packages after go127 security update
Revbump all Go packages after go127 security update
Revbump all Go packages after go127 update
Revbump all Go packages after go127 became the default
Revbump all Go packages after go126 update
Revbump all Go packages after Go 1.26 update
Revbump all Go packages after go126 update
Revbump all Go packages after go126 update
pkgtools/pkglint: update to 23.21.1 Changes since 23.21.0 from 2026-06-03: Fix wrong warning about files that are still in CVS. (Since 23.21.0.)
Revbump all Go packages after go126 security update
pkgtools/pkglint: update to 23.21.0
Changes since 23.20.0 from 2026-01-31:
Warn about removed files that are still in CVS.
Allow the note about the "!=" assignment operator to be suppressed using
the standard rationale. Previously, the comment needed to be on the same
line, the line above didn't work.
Only allow ${RUN} at the beginning of a shell execution line, as that
variable expands to a "@".
Explain how to suppress diagnostics.
Allow the error about omf-scrollkeeper.mk to be suppressed.
Revbump all Go packages after go126 security update
Revbump all Go packages after go126 security fix
Revbump all Go packages after security update
Revbump all Go packages after go126 update
Revbump all Go packages after default version bump
pkgtools/pkglint: update to 23.20.0
Changes since 23.19.0 from 2025-08-15:
Warn on the condition "empty(${EXPR})" in .if directives, as typically
"empty(EXPR)" is intended.
Do not warn when a plain command "echo" or "printf" is not hidden, as
these commands are typically uninteresting.
Allow patch files to have abbreviated names. Previously, the only valid
names were the full path or the basename, now each possible suffix path
is valid.
Explain when and why the ":M*" modifier is necessary.
For GCC_REQD, allow only major versions such as 4.8 or 8 or 15.
Allow distinfo files with variant names, like distinfo-binutils or
distinfo-linux.
Revbump all Go packages after go125 update
Revbump all Go packages after go125 update
Revbump all Go packages after go125 update
Revbump all Go packages after go125 update
Revbump all Go packages after go125 security update
Revbump all Go packages after moving to go125
pkgtools/pkglint: update to 23.19.0 Changes since 23.18.0: Don't complain about using the current Node.js version in NODE_VERSIONS_ACCEPTED.
pkgtools/pkglint: update to 23.18.0 Changes since 23.17.0: For packages that use Meson as their build system and also require Python at runtime, do not warn that Python is usually only necessary at build time.
Revbump all Go packages after go124 update
pkgtools/pkglint: update to 23.17.0 Changes since 23.16.0: In packages that define POLICY_UPDATE_LIMITED, warn before committing that the package requires extensive testing.
Pulup ticket #6952 - Update PKGREVISION for all Go packages. Go had a security update to one of the builtin libraries.
Belated revbump for all Go packages after go124 update I forgot to do the revbump again, sorry for doing it so late after the update.
pkgtools/pkglint: update to 23.16.0 Changes since 23.15.3: Mark MESSAGE files as obsolete, see the pkgsrc guide for details. Detect fetch URLs with missing trailing slash in more cases.
pkgtools/pkglint: update to 23.15.3 Changes since 23.15.2: Fix a wrong note about WRKSRC being redundantly defined when the definition was in fact necessary. This only affects packages that define GITHUB_TAG.
Revbump all Go packages after go124 update I realize I forgot to do the revbump after updating the default Go version to 1.24, so let's do that now.
pkgtools/pkglint: update to 23.15.2 Changes since 23.15.1: Fix the wrong error message about a package not including its own options.mk when that file is included via a more complicated path, for example, from Makefile.common.
pkgtools/pkglint: update to 23.15.1 Changes since 23.15.0: Remove leftover tests that failed after removing the undocumented profiling option. Still require PATCHDIR to be well-formed; the directory it points to just doesn't have to exist.
pkgtools/pkglint: update to 23.15.0 Changes since 23.14.0: Complain if a package has an options.mk file but doesn't included it. Don't complain about pointing PATCHDIR to a nonexistent directory as long as PATCHDIR and DISTINFO_FILE match.
pkgtools/pkglint: update to 23.14.0 Changes since 23.13.0: Fix wrong warnings about MASTER_SITE_BACKUP being not known. Reduce the amount of log data when tracing variables that repeatedly use `+=` to append to a variable. Support the `.-include` directive, the `.ifmake` directive and the built-in `<` variable, to be able to check standalone makefiles outside pkgsrc. Complain about merge conflicts in makefiles, which were silently ignored before. Complain about package patterns whose bounds contradict each other, such as `pkgbase>=2<1`, as these never match and are probably typos. Do not warn about pkgsrc-wip packages that are missing a COMMIT_MSG file, as long as they have a TODO file, as it is fine to have work-in-progress packages in pkgsrc-wip.
pkgtools/pkglint: update to 23.13.0 Changes since 23.12.0: Check language version variables for Lua, PHP, Python and Ruby.
pkgtools/pkglint: update to 23.12.0 Changes since 23.11.0: Allow checking doc/pkg-vulnerabilities for malformed package patterns. In simple package makefiles, check for the order of common package variables. Be more specific about what to fix, and apply the check to more packages than before.
pkgtools/pkglint: update to 23.11.0 Changes since 23.10.0: Don't complain about ignored files in patches/. Don't check for deprecated variables outside pkgsrc. Warn about unusual single-character variables. Fix parsing of the ':!cmd!', ':S' and ':C' modifiers. Don't simplify unsatisfiable 'empty(VAR:M)' condition. Fix contradictory warnings about GMAKE_REQD, which is not a list, even though it follows the naming convention for list variables. Treat hyphens in package versions as errors, as the full package name "pkgbase-3g-7.4" is ambiguous, as the version could either start with "3g" or with "7", and depending on the context, either of these is used.
pkgtools/pkglint: update to 23.10.0
Changes since 23.9.1:
Check dependency patterns that include alternatives enclosed in braces,
such as {ssh,openssh}>=0.
Fix wrong warnings about invalid dependency patterns, include helpful
details, turn the warnings into errors.
Fix panic when guessing the type of a tool variable.
pkgtools/pkglint: update to 23.9.1 Changes since 23.9.0: Fix leftover bmake placeholder in test.
pkgtools/pkglint: update to 23.9.0 Changes since 23.8.1: Warn about DISTINFO_FILE and PATCHDIR that don't correspond.
pkgtools/pkglint: update to 23.8.1 Changes since 23.8.0: Fix wrong warning and autofix involving _ULIMIT_CMD, which was detected as an "unknown shell command". Reduce punctuation in the debug log when tracing function calls.
pkgtools/pkglint: update to 23.8.0
Changes since 23.7.0:
Prohibit vertical bar in COMMENT, to avoid generating syntactically wrong
INDEX files.
Explain in which cases a `distinfo` file is not needed.
Fix detection of redundant trailing semicolon at the end of a command line.
A semicolon that is escaped is not redundant, this pattern is often found
in `find` commands.
Recognize indirect modifiers such as `${VAR:${M_indirect}}`.
pkgtools/pkglint: update to 23.7.0 Changes since 23.6.0: Allow the '::=' modifier family in the pkgsrc infrastructure. Mark USE_CMAKE as deprecated. Fix the -Wall option not to imply -Werror. Note redundant trailing semicolons in shell commands.
Revbump all Go packages after go122 update
pkglint: fix pkglint warning about working outside WRKSRC
Revbump all Go packages after update
pkgtools/pkglint: update to 23.6.0 Changes since 23.5.0: Ignore all Git and GitHub files.
pkgtools/pkglint: update to 23.5.0 Changes since 23.4.2: Added the -Werror option, which treats warnings as errors.
Revbump all Go packages after go122 security update
Revbump all Go packages after go122 update
Revbump all Go packages, default Go version is now 1.22.
pkgtools/pkglint: update to 23.4.2
Changes since 23.4.1:
Fixed the wrong suggestion that list variables or variables of an
unknown type could be compared using `${LIST} == word` instead of
`${LIST:Mword}`.
Fixed the wrong warning when a value is appended using `+=` to a
variable of unknown type.
pkgtools/pkglint: update to 23.4.1 Changes since 23.4.0: Add riscv32 as a known hardware architecture. Don't suggest a runtime dependency instead of TOOL_DEPENDS.
Revbump all Go packages after go121 update
pkgtools/pkglint: update to 23.4.0 Changes since 23.3.0 from 2024-01-12: Add riscv64 to the list of known hardware architectures. Suggest removing parentheses around complete conditions. Warn about duplicate DESCR files, except when one of the packages is in pkgsrc-wip and the other is in main pkgsrc. Fix crash when parsing '.ifndef VAR'.
Revbump all Go packages after go121 update
pkgtools/pkglint: update to 23.3.0 Changes since 23.2.5: Do not warn about Meson packages that only use Python as a build-time tool. Warn about pkgsrc-wip packages that are missing COMMIT_MSG. Ignore errors when resolving the username of the current user. This can happen on systems where the user database uses NIS. In case of an error, assume that the user is neither maintainer nor owner of any package. Mark variables from expressions in .info, .warning and .error as used. Remove the word 'please' from the diagnostics, as the diagnostics are intended to help the package author, not some unrelated third-party person.
Revbump all Go packages after go121 update
pkgtools/pkglint: update to 23.2.5 Changes since 23.2.4: For Python packages that do not support Python 2, warn that egg.mk is deprecated and should be replaced with wheel.mk. Provide detailed migration instructions.
Pullup ticket #6822 - requested by bsiegert
lang/go120: security update
lang/go121: security update
lang/go: metadata update
audio/gospt: revision bump
audio/ymuse: revision bump
chat/coyim: revision bump
chat/gomuks: revision bump
chat/matterircd: revision bump
chat/senpai: revision bump
chat/ssh-chat: revision bump
databases/go-ldap: revision bump
databases/influxdb: revision bump
databases/mongo-tools: revision bump
databases/mysqld_exporter: revision bump
databases/postgres_exporter: revision bump
databases/prometheus: revision bump
databases/promscale: revision bump
databases/sqlc: revision bump
databases/timescaledb-tune: revision bump
devel/asmfmt: revision bump
devel/conftest: revision bump
devel/errcheck: revision bump
devel/fq: revision bump
devel/git-lfs: revision bump
devel/go-ed25519: revision bump
devel/go-gocode: revision bump
devel/go-golang-lru: revision bump
devel/go-gopkgs: revision bump
devel/go-goptlib: revision bump
devel/go-goreturns: revision bump
devel/go-gox: revision bump
devel/go-impl: revision bump
devel/go-logrus: revision bump
devel/go-nbreader: revision bump
devel/go-pty: revision bump
devel/go-review: revision bump
devel/go-siphash: revision bump
devel/go-staticcheck: revision bump
devel/go-swagger: revision bump
devel/go-sys: revision bump
devel/go-tools: revision bump
devel/go-wire: revision bump
devel/go-xerrors: revision bump
devel/golangci-lint: revision bump
devel/golint: revision bump
devel/gomodifytags: revision bump
devel/gopls: revision bump
devel/goredo: revision bump
devel/gotags: revision bump
devel/gotests: revision bump
devel/govulncheck: revision bump
devel/lazygit: revision bump
devel/mob: revision bump
devel/nancy: revision bump
devel/opa: revision bump
devel/packr: revision bump
devel/reftools: revision bump
devel/regal: revision bump
devel/revive: revision bump
devel/shfmt: revision bump
devel/syft: revision bump
editors/micro: revision bump
filesystems/kubo: revision bump
graphics/gif2png: revision bump
lang/joker: revision bump
mail/opensmtpd-filter-rspamd: revision bump
mail/opensmtpd-filter-senderscore: revision bump
mail/postforward: revision bump
misc/exercism: revision bump
net/amazon-ecs-cli: revision bump
net/amfora: revision bump
net/bombadillo: revision bump
net/croc: revision bump
net/czds: revision bump
net/dnscontrol: revision bump
net/dnscrypt-proxy2: revision bump
net/gh: revision bump
net/go-dnstap: revision bump
net/go-net: revision bump
net/go-websocket: revision bump
net/gunison: revision bump
net/gvproxy: revision bump
net/hub: revision bump
net/ipget: revision bump
net/kubectl: revision bump
net/libquic: revision bump
net/mangos: revision bump
net/nats-server: revision bump
net/obfs4proxy: revision bump
net/rclone: revision bump
net/stern: revision bump
net/syncthing: revision bump
net/terraform-provider-archive: revision bump
net/terraform-provider-aws: revision bump
net/terraform-provider-kubernetes: revision bump
net/terraform-provider-local: revision bump
net/terraform-provider-null: revision bump
net/terraform-provider-random: revision bump
net/terraform-provider-template: revision bump
net/terraform-provider-vultr: revision bump
net/terraform: revision bump
net/tut: revision bump
net/vultr-cli: revision bump
pkgtools/pkglint: revision bump
security/2fa: revision bump
security/age: revision bump
security/amass: revision bump
security/authelia: revision bump
security/cfssl: revision bump
security/dnsx: revision bump
security/go-asn1-ber: revision bump
security/go-crypto: revision bump
security/go-getpass: revision bump
security/go-mkcert: revision bump
security/gopass: revision bump
security/httpx: revision bump
security/nuclei: revision bump
security/oauth2c: revision bump
security/osv-scanner: revision bump
security/subfinder: revision bump
security/tlsx: revision bump
security/trufflehog: revision bump
security/vault: revision bump
shells/elvish: revision bump
shells/oh-my-posh: revision bump
sysutils/beats: revision bump
sysutils/consul: revision bump
sysutils/direnv: revision bump
sysutils/fzf: revision bump
sysutils/goreman: revision bump
sysutils/lf: revision bump
sysutils/node_exporter: revision bump
sysutils/packer: revision bump
sysutils/podman: revision bump
sysutils/restic: revision bump
sysutils/vultr: revision bump
textproc/glow: revision bump
textproc/go-kr-text: revision bump
textproc/go-md2man: revision bump
textproc/go-mmark: revision bump
textproc/go-text: revision bump
textproc/miller: revision bump
textproc/sift: revision bump
www/apisprout: revision bump
www/caddy: revision bump
www/gitea: revision bump
www/go-ffuf: revision bump
www/go-minify: revision bump
www/gotosocial: revision bump
www/grafana: revision bump
www/hugo: revision bump
www/jira-cli: revision bump
www/mycorrhiza: revision bump
www/pup: revision bump
www/restish: revision bump
www/shoutrrr: revision bump
Revisions pulled up:
- lang/go/version.mk 1.194
- lang/go120/PLIST 1.10
- lang/go120/distinfo 1.12
- lang/go121/PLIST 1.4
- lang/go121/distinfo 1.4
- audio/gospt/Makefile by patch
- audio/ymuse/Makefile by patch
- chat/coyim/Makefile by patch
- chat/gomuks/Makefile by patch
- chat/matterircd/Makefile by patch
- chat/senpai/Makefile by patch
- chat/ssh-chat/Makefile by patch
- databases/go-ldap/Makefile by patch
- databases/influxdb/Makefile by patch
- databases/mongo-tools/Makefile by patch
- databases/mysqld_exporter/Makefile by patch
- databases/postgres_exporter/Makefile by patch
- databases/prometheus/Makefile by patch
- databases/promscale/Makefile by patch
- databases/sqlc/Makefile by patch
- databases/timescaledb-tune/Makefile by patch
- devel/asmfmt/Makefile by patch
- devel/conftest/Makefile by patch
- devel/errcheck/Makefile by patch
- devel/fq/Makefile by patch
- devel/git-lfs/Makefile by patch
- devel/go-ed25519/Makefile by patch
- devel/go-gocode/Makefile by patch
- devel/go-golang-lru/Makefile by patch
- devel/go-gopkgs/Makefile by patch
- devel/go-goptlib/Makefile by patch
- devel/go-goreturns/Makefile by patch
- devel/go-gox/Makefile by patch
- devel/go-impl/Makefile by patch
- devel/go-logrus/Makefile by patch
- devel/go-nbreader/Makefile by patch
- devel/go-pty/Makefile by patch
- devel/go-review/Makefile by patch
- devel/go-siphash/Makefile by patch
- devel/go-staticcheck/Makefile by patch
- devel/go-swagger/Makefile by patch
- devel/go-sys/Makefile by patch
- devel/go-tools/Makefile by patch
- devel/go-wire/Makefile by patch
- devel/go-xerrors/Makefile by patch
- devel/golangci-lint/Makefile by patch
- devel/golint/Makefile by patch
- devel/gomodifytags/Makefile by patch
- devel/gopls/Makefile by patch
- devel/goredo/Makefile by patch
- devel/gotags/Makefile by patch
- devel/gotests/Makefile by patch
- devel/govulncheck/Makefile by patch
- devel/lazygit/Makefile by patch
- devel/mob/Makefile by patch
- devel/nancy/Makefile by patch
- devel/opa/Makefile by patch
- devel/packr/Makefile by patch
- devel/reftools/Makefile by patch
- devel/regal/Makefile by patch
- devel/revive/Makefile by patch
- devel/shfmt/Makefile by patch
- devel/syft/Makefile by patch
- editors/micro/Makefile by patch
- filesystems/kubo/Makefile by patch
- graphics/gif2png/Makefile by patch
- lang/joker/Makefile by patch
- mail/opensmtpd-filter-rspamd/Makefile by patch
- mail/opensmtpd-filter-senderscore/Makefile by patch
- mail/postforward/Makefile by patch
- misc/exercism/Makefile by patch
- net/amazon-ecs-cli/Makefile by patch
- net/amfora/Makefile by patch
- net/bombadillo/Makefile by patch
- net/croc/Makefile by patch
- net/czds/Makefile by patch
- net/dnscontrol/Makefile by patch
- net/dnscrypt-proxy2/Makefile by patch
- net/gh/Makefile by patch
- net/go-dnstap/Makefile by patch
- net/go-net/Makefile by patch
- net/go-websocket/Makefile by patch
- net/gunison/Makefile by patch
- net/gvproxy/Makefile by patch
- net/hub/Makefile by patch
- net/ipget/Makefile by patch
- net/kubectl/Makefile by patch
- net/libquic/Makefile by patch
- net/mangos/Makefile by patch
- net/nats-server/Makefile by patch
- net/obfs4proxy/Makefile by patch
- net/rclone/Makefile by patch
- net/stern/Makefile by patch
- net/syncthing/Makefile by patch
- net/terraform-provider-archive/Makefile by patch
- net/terraform-provider-aws/Makefile by patch
- net/terraform-provider-kubernetes/Makefile by patch
- net/terraform-provider-local/Makefile by patch
- net/terraform-provider-null/Makefile by patch
- net/terraform-provider-random/Makefile by patch
- net/terraform-provider-template/Makefile by patch
- net/terraform-provider-vultr/Makefile by patch
- net/terraform/Makefile by patch
- net/tut/Makefile by patch
- net/vultr-cli/Makefile by patch
- pkgtools/pkglint/Makefile by patch
- security/2fa/Makefile by patch
- security/age/Makefile by patch
- security/amass/Makefile by patch
- security/authelia/Makefile by patch
- security/cfssl/Makefile by patch
- security/dnsx/Makefile by patch
- security/go-asn1-ber/Makefile by patch
- security/go-crypto/Makefile by patch
- security/go-getpass/Makefile by patch
- security/go-mkcert/Makefile by patch
- security/gopass/Makefile by patch
- security/httpx/Makefile by patch
- security/nuclei/Makefile by patch
- security/oauth2c/Makefile by patch
- security/osv-scanner/Makefile by patch
- security/subfinder/Makefile by patch
- security/tlsx/Makefile by patch
- security/trufflehog/Makefile by patch
- security/vault/Makefile by patch
- shells/elvish/Makefile by patch
- shells/oh-my-posh/Makefile by patch
- sysutils/beats/Makefile by patch
- sysutils/consul/Makefile by patch
- sysutils/direnv/Makefile by patch
- sysutils/fzf/Makefile by patch
- sysutils/goreman/Makefile by patch
- sysutils/lf/Makefile by patch
- sysutils/node_exporter/Makefile by patch
- sysutils/packer/Makefile by patch
- sysutils/podman/Makefile by patch
- sysutils/restic/Makefile by patch
- sysutils/vultr/Makefile by patch
- textproc/glow/Makefile by patch
- textproc/go-kr-text/Makefile by patch
- textproc/go-md2man/Makefile by patch
- textproc/go-mmark/Makefile by patch
- textproc/go-text/Makefile by patch
- textproc/miller/Makefile by patch
- textproc/sift/Makefile by patch
- www/apisprout/Makefile by patch
- www/caddy/Makefile by patch
- www/gitea/Makefile by patch
- www/go-ffuf/Makefile by patch
- www/go-minify/Makefile by patch
- www/gotosocial/Makefile by patch
- www/grafana/Makefile by patch
- www/hugo/Makefile by patch
- www/jira-cli/Makefile by patch
- www/mycorrhiza/Makefile by patch
- www/pup/Makefile by patch
- www/restish/Makefile by patch
- www/shoutrrr/Makefile by patch
-------------------------------------------------------------------
Module Name: pkgsrc
Committed By: bsiegert
Date: Fri Nov 10 15:39:34 UTC 2023
Modified Files:
pkgsrc/lang/go: version.mk
pkgsrc/lang/go120: PLIST distinfo
pkgsrc/lang/go121: PLIST distinfo
Log Message:
Update go120 to 1.20.11 and go121 to 1.21.4 (security).
These minor releases include 2 security fixes following the security policy:
- path/filepath: recognize \??\ as a Root Local Device path prefix.
On Windows, a path beginning with \??\ is a Root Local Device path equivalent
to a path beginning with \\?\. Paths with a \??\ prefix may be used to access
arbitrary locations on the system. For example, the path \??\c:\x is
equivalent to the more common path c:\x.
The filepath package did not recognize paths with a \??\ prefix as special.
Clean could convert a rooted path such as \a\..\??\b into
the root local device path \??\b. It will now convert this
path into .\??\b.
IsAbs did not report paths beginning with \??\ as absolute.
It now does so.
VolumeName now reports the \??\ prefix as a volume name.
Join(`\`, `??`, `b`) could convert a seemingly innocent
sequence of path elements into the root local device path
\??\b. It will now convert this to \.\??\b.
This is CVE-2023-45283 and https://go.dev/issue/63713.
- path/filepath: recognize device names with trailing spaces and superscripts
The IsLocal function did not correctly detect reserved names in some cases:
reserved names followed by spaces, such as "COM1 ".
"COM" or "LPT" followed by a superscript 1, 2, or 3.
IsLocal now correctly reports these names as non-local.
This is CVE-2023-45284 and https://go.dev/issue/63713.
To generate a diff of this commit:
cvs rdiff -u -r1.193 -r1.194 pkgsrc/lang/go/version.mk
cvs rdiff -u -r1.9 -r1.10 pkgsrc/lang/go120/PLIST
cvs rdiff -u -r1.11 -r1.12 pkgsrc/lang/go120/distinfo
cvs rdiff -u -r1.3 -r1.4 pkgsrc/lang/go121/PLIST pkgsrc/lang/go121/distinfo
Revbump all Go packages after go121 update
Revbump all Go packages after go121 update
Revbump all Go packages because go121 is now the default
Pullup ticket #6812 - requested by bsiegert
lang/go120: security update
lang/go: version info update
audio/gospt: RevBump
audio/ymuse: RevBump
chat/coyim: RevBump
chat/gomuks: RevBump
chat/matterircd: RevBump
chat/senpai: RevBump
chat/ssh-chat: RevBump
databases/go-ldap: RevBump
databases/influxdb: RevBump
databases/mongo-tools: RevBump
databases/mysqld_exporter: RevBump
databases/postgres_exporter: RevBump
databases/prometheus: RevBump
databases/promscale: RevBump
databases/sqlc: RevBump
databases/timescaledb-tune: RevBump
devel/asmfmt: RevBump
devel/conftest: RevBump
devel/errcheck: RevBump
devel/fq: RevBump
devel/git-lfs: RevBump
devel/go-ed25519: RevBump
devel/go-gocode: RevBump
devel/go-golang-lru: RevBump
devel/go-gopkgs: RevBump
devel/go-goptlib: RevBump
devel/go-goreturns: RevBump
devel/go-gox: RevBump
devel/go-impl: RevBump
devel/go-logrus: RevBump
devel/go-nbreader: RevBump
devel/go-pty: RevBump
devel/go-review: RevBump
devel/go-siphash: RevBump
devel/go-staticcheck: RevBump
devel/go-swagger: RevBump
devel/go-sys: RevBump
devel/go-tools: RevBump
devel/go-wire: RevBump
devel/go-xerrors: RevBump
devel/golangci-lint: RevBump
devel/golint: RevBump
devel/gomodifytags: RevBump
devel/gopls: RevBump
devel/goredo: RevBump
devel/gotags: RevBump
devel/gotests: RevBump
devel/govulncheck: RevBump
devel/lazygit: RevBump
devel/mob: RevBump
devel/nancy: RevBump
devel/opa: RevBump
devel/packr: RevBump
devel/reftools: RevBump
devel/regal: RevBump
devel/revive: RevBump
devel/shfmt: RevBump
devel/syft: RevBump
editors/micro: RevBump
filesystems/kubo: RevBump
graphics/gif2png: RevBump
lang/joker: RevBump
mail/opensmtpd-filter-rspamd: RevBump
mail/opensmtpd-filter-senderscore: RevBump
mail/postforward: RevBump
meta-pkgs/bulk-test-essential: RevBump
misc/exercism: RevBump
net/amazon-ecs-cli: RevBump
net/amfora: RevBump
net/bombadillo: RevBump
net/croc: RevBump
net/czds: RevBump
net/dnscontrol: RevBump
net/dnscrypt-proxy2: RevBump
net/gh: RevBump
net/go-dnstap: RevBump
net/go-net: RevBump
net/go-websocket: RevBump
net/gunison: RevBump
net/gvproxy: RevBump
net/hub: RevBump
net/ipget: RevBump
net/kubectl: RevBump
net/libquic: RevBump
net/mangos: RevBump
net/nats-server: RevBump
net/obfs4proxy: RevBump
net/rclone: RevBump
net/stern: RevBump
net/syncthing: RevBump
net/terraform-provider-archive: RevBump
net/terraform-provider-aws: RevBump
net/terraform-provider-kubernetes: RevBump
net/terraform-provider-local: RevBump
net/terraform-provider-null: RevBump
net/terraform-provider-random: RevBump
net/terraform-provider-template: RevBump
net/terraform-provider-vultr: RevBump
net/terraform: RevBump
net/tut: RevBump
net/vultr-cli: RevBump
pkgtools/pkglint: RevBump
security/2fa: RevBump
security/age: RevBump
security/amass: RevBump
security/authelia: RevBump
security/cfssl: RevBump
security/dnsx: RevBump
security/go-asn1-ber: RevBump
security/go-crypto: RevBump
security/go-getpass: RevBump
security/go-mkcert: RevBump
security/gopass: RevBump
security/httpx: RevBump
security/nuclei: RevBump
security/oauth2c: RevBump
security/osv-scanner: RevBump
security/subfinder: RevBump
security/tlsx: RevBump
security/trufflehog: RevBump
security/vault: RevBump
shells/elvish: RevBump
shells/oh-my-posh: RevBump
sysutils/beats: RevBump
sysutils/consul: RevBump
sysutils/direnv: RevBump
sysutils/fzf: RevBump
sysutils/goreman: RevBump
sysutils/lf: RevBump
sysutils/node_exporter: RevBump
sysutils/packer: RevBump
sysutils/podman: RevBump
sysutils/restic: RevBump
sysutils/vultr: RevBump
textproc/glow: RevBump
textproc/go-kr-text: RevBump
textproc/go-md2man: RevBump
textproc/go-mmark: RevBump
textproc/go-text: RevBump
textproc/miller: RevBump
textproc/sift: RevBump
www/apisprout: RevBump
www/caddy: RevBump
www/gitea: RevBump
www/go-ffuf: RevBump
www/go-minify: RevBump
www/gotosocial: RevBump
www/grafana: RevBump
www/hugo: RevBump
www/jira-cli: RevBump
www/mycorrhiza: RevBump
www/pup: RevBump
www/restish: RevBump
www/shoutrrr: RevBump
Revisions pulled up:
- lang/go/version.mk 1.190,1.192
- lang/go120/PLIST 1.9
- lang/go120/distinfo 1.10-1.11
-------------------------------------------------------------------
Module Name: pkgsrc
Committed By: bsiegert
Date: Sat Oct 7 18:09:35 UTC 2023
Modified Files:
pkgsrc/lang/go: version.mk
pkgsrc/lang/go120: PLIST distinfo
Log Message:
go120: update to 1.20.9 (security).
cmd/go: line directives allows arbitrary execution during build
"//line" directives can be used to bypass the restrictions on "//go:cgo_"
directives, allowing blocked linker and compiler flags to be passed during
compliation. This can result in unexpected execution of arbitrary code when
running "go build". The line directive requires the absolute path of the file in
which the directive lives, which makes exploting this issue significantly more
complex.
This is CVE-2023-39323 and Go issue https://go.dev/issue/63211.
View the release notes for more information:
https://go.dev/doc/devel/release#go1.20.9
To generate a diff of this commit:
cvs rdiff -u -r1.189 -r1.190 pkgsrc/lang/go/version.mk
cvs rdiff -u -r1.8 -r1.9 pkgsrc/lang/go120/PLIST
cvs rdiff -u -r1.9 -r1.10 pkgsrc/lang/go120/distinfo
-------------------------------------------------------------------
Module Name: pkgsrc
Committed By: bsiegert
Date: Sun Oct 15 11:02:08 UTC 2023
Modified Files:
pkgsrc/lang/go: version.mk
pkgsrc/lang/go120: distinfo
Log Message:
go120: update to 1.20.10 (security)
net/http: rapid stream resets can cause excessive work
A malicious HTTP/2 client which rapidly creates requests and
immediately resets them can cause excessive server resource consumption.
While the total number of requests is bounded to the
http2.Server.MaxConcurrentStreams setting, resetting an in-progress
request allows the attacker to create a new request while the existing
one is still executing.
HTTP/2 servers now bound the number of simultaneously executing
handler goroutines to the stream concurrency limit. New requests
arriving when at the limit (which can only happen after the client
has reset an existing, in-flight request) will be queued until a
handler exits. If the request queue grows too large, the server
will terminate the connection.
This issue is also fixed in golang.org/x/net/http2 v0.17.0,
for users manually configuring HTTP/2.
The default stream concurrency limit is 250 streams (requests)
per HTTP/2 connection. This value may be adjusted using the
golang.org/x/net/http2 package; see the Server.MaxConcurrentStreams
setting and the ConfigureServer function.
This is CVE-2023-39325 and Go issue https://go.dev/issue/63417.
This is also tracked by CVE-2023-44487.
To generate a diff of this commit:
cvs rdiff -u -r1.191 -r1.192 pkgsrc/lang/go/version.mk
cvs rdiff -u -r1.10 -r1.11 pkgsrc/lang/go120/distinfo
Revbump all Go packages after go120 security update
pkgtools/pkglint: update to 23.2.4 Changes since 23.2.3: Do not warn about buildlink3 identifiers that are only known when the package includes a buildlink3.mk file from the infrastructure.
Revbump all Go packages after go120 update
pkgtools/pkglint: update to 23.2.3 Changes since 23.2.2: Warn about platform-specific variables in parameterized variables, except for OPSYS-specific variables in conditions for that particular operating system. Allow the tilde character in lists of Go modules. Use correct plural form in messages about invalid characters.
pkgtools/pkglint: update to 23.2.2
Changes since 23.2.1:
Do not wrongly warn when adding a tool that is only available on
${OPSYS} to CONFIGURE_ENV.${OPSYS}.
Use proper capitalization for 'makefile' in a few places, when referring
to the general file format instead of a file named exactly 'Makefile'.
pkgtools/pkglint: update to 23.2.1 Changes since 23.2.0: Warn about language features that are listed in USE_LANGUAGES but rather belong in USE_CC_FEATURES or USE_CXX_FEATURES. Check each addition to GITHUB_SUBMODULES to have the correct number of words.
Revbump all Go packages after go120 update
Revbump all Go packages after go120 update
pkgtools/pkglint: update to 23.2.0 Changes since 23.1.13: Warn about attempts to set CONFIGURE_ARGS that are already handled by mk/configure/gnu-configure.mk. Warn about possible incomplete expressions that are missing the initial '$'.
pkgtools/pkglint: update to 23.1.12
Changes since 23.1.11:
No longer warn about the expression ${VAR:=:${VAR2}}. Previously,
pkglint warned that the ':' did not start a new expression modifier.
pkgtools/pkglint: update to 23.1.11 Changes since 23.1.10: Warn about packages that append to BUILD_DEPENDS, as in all practical cases, TOOL_DEPENDS should be used instead.
pkgtools/pkglint: update to 23.1.10 Changes since 23.1.9: Don't warn about variables that are being appended to, as long as their names ends with 'S', such as GITHUB_SUBMODULES.
pkgtools/pkglint: update to 23.1.9 Changes since 23.1.8: Warn when REQD variables defined using '=' instead of '+=', even before bsd.prefs.mk has been included, for consistency and simplicity. In packages that define PLIST_SRC, don't check for duplicates.
Revbump all Go packages after go120 security update
pkgtools/pkglint: update to 23.1.8 Changes since 23.1.7: Warn if GCC_REQD is defined using '=' instead of the usual '+=', to avoid accidentally overwriting previous values.
pkgtools/pkglint: update to 23.1.7 Changes since 23.1.0: No functional changes. Instead of having two copies of the code, install the package by downloading the releases from GitHub. Reduce the build-time dependencies by delivering pre-generated parser code.
Revbump all Go packages after yesterday's go120 security update
Update pkgtools/pkglint to 23.1.0 Changes since 22.4.1: In makefiles outside pkgsrc, don't require the first line to contain the CVS Id. When simplifying conditions, correctly handle the edge case that a single-word value may evaluate numerically to zero. In dependency lines, parse '#' signs correctly. In error messages about malformed patch files, use the correct plural form.
Revbump all Go packages after go119 security update
pkgtools/pkglint: Update to 22.4.1 Changes since 22.4.0: Allow pkglint to be run outside the pkgsrc top directory, in order to allow individual makefiles to be formatted and checked as well. The many pkgsrc-specific checks don't apply in this case. This mode is experimental, there are still crashes to be expected. Fix a crash for syntactically invalid conditions in '.if'. Fix parsing of dependency lines that contain an escaped '#', which is used for switching to another shell using a '.SHELL: ...' line.
Revbump all Go packages after go119 update
pkgtools/pkglint: update to 22.4.0 Changes since 22.3.2: Numeric comparisons of _PYTHON_VERSION generate an error since that variable can have the value 'none', which is not numeric. Furthermore, the variable is from the internal namespace and thus should not be used by packages at all. Warnings about COMPILER_RPATH_FLAG no longer suggest different and conflicting replacements. Cleanup: Handling of doc/CHANGES was moved to changes.go, and since go1.19.4, comments are formatted differently.
Revbump all Go packages after go119 update
Revbump all Go packages after go119 security update
pkgtools/pkglint: update to 22.3.2 Changes since 22.3.1: Complain about conditions of the form '_PYTHON_VERSION < 38', as they lead to 'Malformed conditional' when _PYTHON_VERSION is 'none' instead of a number.
pkgtools/pkglint: Update to 22.3.1 Changes since 22.3.0: In doc/CHANGES files, check for typos in month and day of the dates. In conditions for YesNo variables, suggest to replace the modifier ':M[yY][eE][sS]' with a simpler comparison. https://mail-index.netbsd.org/tech-pkg/2022/11/16/msg026992.html
Revbump all Go packages after go119 security update
Revbump all Go packages after go119 security update
pkgtools/pkglint: update to 22.3.0 Changes since 22.2.7: Pkglint no longer wrongly warns about package options from optional or required option groups. Fixes PR 57038.
Revbump all Go packages after 1.19 became default
pkglint: use Go module build, simplify Makefile Add a go.mod file to the sources and pull in goyacc through a TOOL_DEPENDS. Bump version to 22.2.7.
Revbump all Go packages after go118 security update
pkgtools/pkglint: update to 22.2.6 Changes since 22.2.5: A makefile that adds a _VARGROUPS section is partly considered part of the infrastructure. It may define and use variables from its own namespace. For example, devel/cmake/build.mk adds _VARGROUPS+=cmake, thereby reserving the namespace '_CMAKE_*' for itself. Dependencies in BUILDLINK_API_DEPENDS and BUILDLINK_ABI_DEPENDS that contain unresolved variable expressions are no longer marked as redundant. They were marked as redundant before because '$', when interpreted as a package version, was smaller than 0.0.
pkgtools/pkglint: update to 22.2.5 Changes since 22.2.4: Makefiles in wip/mk may use internal variables (starting with '_'), just like their counterparts in main mk/. Package versions containing letters are now parsed like in pkg_install.
Revbump all Go packages after go118 security update
pkgtools/pkglint: update to 22.2.4 Changes since 22.2.3: Manual pages must not be listed in the ALTERNATIVES file. Instead, they are handled automatically based on the program in bin/ or sbin/. Detect packages that use the tool pkg-config even though they don't need it.
pkgtools/pkglint: update to 22.2.3
Changes since 22.2.2:
CHECK_WRKREF is known to pkglint, which prevents conditions using this
variable from being simplified in a wrong way.
For variables that are guaranteed to be defined, suggest to simplify the
condition '!empty(VAR:M[Yy][Ee][Ss])' to '${VAR:M[Yy][Ee][Ss]}', as that
reduces the number of negations in the condition.
Detect redundant WRKSRC definitions and suggest to remove them.
Fix wrong "c99 is not valid for USE_LANGUAGES" warnings.
Revbump all Go packages after go118 update
pkgtools/pkglint: update to 22.2.2 Changes since 22.2.1: Require the current checksum algorithms for pkgsrc-wip packages as well. SHA1 and RMD160 are no longer allowed for distfiles. Do not warn about 'Package should not' when checking .mk files in the pkgsrc infrastructure.
pkgtools/pkglint: update to 22.2.1 Changes since 22.2.0: Suggest simpler condition when matching a variable against a pattern (occurs 220 times in pkgsrc). Improve explanation for documenting patches.
*: recursive bump for perl 5.36
pkgtools/pkglint: update to 22.2.0 Changes since 22.1.0: In ALTERNATIVES files, the wrapper path must be either in bin, @PKGMANDIR@ or sbin. This catches typos like "in" instead of "bin", as well as hard-coded "man".
Revbump all Go packages after go118 update
Revbump all Go packages after go118 update
Revbump all Go packages after go117 update
pkgtools/pkglint: update to 22.1.0 Changes since 21.4.4: Python packages that declare 2.7 as an incompatible Python version no longer need to provide a rationale for this since it is common knowledge that Python 2.7 is old and therefore unsupported by many modern packages.
pkgtools/pkglint: update to 21.4.4 Changes since 21.4.3: Do not install the pkglint source code and libraries since no other tool uses them.
pkgtools/pkglint: update to 21.4.3 Changes since 21.4.2: In simple Makefiles, do not allow the GitHub variables like GITHUB_RELEASE to occur above DISTNAME anymore. Previously, these variables had 2 possible places in the "canonical" order.
Revbump all Go packages after go117 update
Revump all Go packages after go117 update
pkgtools/pkglint: update to 21.4.2 Changes since 21.4.1: When checking a package, check for naming collision with other packages from the same category, on case-insensitive file systems. For packages from pkgsrc-wip, additionally perform the same check for the main category of the package, to prepare for importing the package.
Revbump all Go packages after go117 update
pkgtools/pkglint: update to 21.4.1 Changes since 21.4.0: Running 'pkglint doc/CHANGES-2021' now warns about issues for this single file. Previously, it was necessary to specify '-Cglobal' as well, but then pkglint also warned about issues in all other CHANGES files. Pkglint no longer warns about the characters '!' and '@' in GO_MODULES_FILES, since these are legitimate. Fixes PR pkg/56595. Small cleanups in the pkglint testing infrastructure.
pkglint: update version number to match the upcoming branch No changes since 21.3.4.
Revbump all Go packages after go117 update
pkgtools/pkglint: update to 21.3.4 Changes since 21.3.3: For wip packages, allow SHA1 to be used as digest algorithm. An example package that needs this is wip/doomlegacy-devel.
pkgtools/pkglint: update to 21.3.3 Changes since 21.3.2: Explain warning about invalid symlink. Do not warn when a package uses MAKE_JOBS without adding it to BUILD_DEFS, since MAKE_JOBS is supposed to be a build-time only variable.
Revbump all Go packages after go117 update
pkglint: update to 21.3.2 Changes since 21.3.1: Replace RMD160 with BLAKE2s for distfiles in main pkgsrc, keep the previous RMD160 for pkgsrc-wip, at least until 2021Q4.
pkgtools/pkglint: update to 21.3.1 Changes since 21.3.0: When checking a standalone makefile fragment, pkglint reports redundant variable declarations. In pathname patterns, spaces and other escaping is allowed. This is needed for devel/meson. While here, register MESON_REQD. Adjust to the removal of SHA1 for distfiles. Only RMD160, SHA512 and Size remain now. Patches continue to use SHA1 since they don't come via untrusted paths.
Revbump all Go packages after go117 update
pkglint: update to 21.3.0 No changes since 21.2.6, the version bump is only to mark it for the upcoming stable branch.
Revbump all Go packages after go117 update
pkgtools/pkglint: update to 21.2.6 Changes since 21.2.5: Do not warn when a variable SITES.* refers to a GitHub URL directly instead of using MASTER_SITE_GITHUB. The variable expression for supporting multiple master sites would become quite complicated for human readers, especially with a leading '-' and a long trailing path.
pkgtools/pkglint: update to 21.2.4 Changes since 21.2.3: Fixed loading of the tool definitions. This adds 76 warnings for packages that use tools without adding them to USE_TOOLS. It also fixes the warning about gmake and Meson.
pkgtools/pkglint: update to 21.2.3 Changes since 21.2.2: Temporarily disable the warning about Meson and gmake. It led to a false positive in x11/libxkbcommon, where pkglint wrongly assumed that the package would use gmake. For packages using Meson, do not warn if an included package uses CONFIGURE_ARGS.
Revbump all Go packages after go116 update
pkgtools/pkglint: update to 21.2.2 Changes since 21.2.1: Check the variable names of OPSYS-specific variables for typos, such as 'Dragonfly' with a lowercase 'f'. Suggested by David A. Holland in PR pkg/56352. Warn if variables like CFLAGS are assigned using the operator '='. Suggested by David A. Holland in PR pkg/56352.
Revbump all Go packages after go116 update
pkgtools/pkglint: update to 21.2.1 Changes since 21.2.0: Files whose names ends in '~' are ignored by pkglint since they are ignored by CVS as well. Variables with name BUILDLINK_TRANSFORM.* may contain '-Wl,-rpath,' directly in commands of the form 'rm:*', just like their counterpart BUILDLINK_TRANSFORM without a package name in the variable name. Several new tests.
pkglint: bump version to match the upcoming quarterly release No changes since 21.1.4.
pkgtools/pkglint: update to 21.1.4 Changes since 21.1.3: Allow slash in Git tags like 'refs/tags/v1.0.0', as well as in make targets like 'subdir/build'.
pkgtools/pkglint: update to 21.1.3 Changes since 21.1.2: The entries in doc/CHANGES are checked more strictly, they must always consist of 4 words (for removed packages) or 6 words (for all other changes). Packages that include curses.buildlink3.mk may use all buildlink3 variables with the identifier "curses". The previous pkglint warnings had been wrong. Python packages that directly contain .egg-info in their PLIST files should include egg.mk instead. Pkglint can now fix these packages automatically.
pkglint: update to 21.1.2
Changes since 21.1.1:
Fixed the check for BUILDLINK3_PKGSRCDIR. Previously, pkglint had
complained about ${_EMACS_PKGDIR} in buildlink3.mk.
*: recursive bump for perl 5.34
Revbump all Go packages after go116 update
pkgtools/pkglint: update to 21.1.1 Changes since 21.1.0: Added check for packages that have been migrated to Meson but still refer to their previous build system, most often involving GNU make and GNU autotools. Suggested by nia.
pkgtools/pkglint: bump version to 21.1.0 Just to match the upcoming pkgsrc branch 2021Q1. No functional change.
pkgtools/pkglint: update to 20.4.2 Changes since 20.4.1: Error out on package directories that differ only in case. This ensures that pkgsrc can be used on case-insensitive file systems as well, such as on macOS or Windows.
pkgtools/pkglint: update to 20.4.1 Changes since 20.4.0: When a package has MAINTAINER set and there are modified local files, only remind the user once per package that changes should likely be approved by the maintainer. Previously there was a reminder once per file, which was just too much for a package that has Makefile and PLIST and maybe some patches changed. Small performance improvement for loading the doc/CHANGES files, since that costs a few tenths of seconds at every startup.
Revbump all Go packages after go115 update
pkgtools/pkglint: fix manpage and catpage installation Reported by Chris Pinnock via private mail.
Revbump all Go packages after go115 update
pkgtools/pkglint: update to 20.4.0 No changes since 20.3.2, the version bump only synchronizes pkglint with the upcoming branch.
Revbump all Go packages after go115 update
Revbump all Go packages after Go 1.15 update.
pkgtools/pkglint: update to 20.3.2 Changes since 20.3.1: The available Java versions are parsed from mk/java-vm.mk instead of hard-coding them in pkglint.
Revbump all Go packages after go115 update.
pkgtools/pkglint: update to 20.3.1 Changes since 20.3.0: URLs from cpan.metacpan.org should not be used as HOMEPAGE for Perl packages since they don't provide an overview over the package, instead the just list the distribution files. Lines in doc/CHANGES may contain the pattern "Removed <pkgpath> version <version>". Before, only "Removed <pkgpath>" (without additional information) or "Removed <pkgpath> successor <pkgpath>" were allowed. Mentioning the last seen version number sounds useful. It is not cross-checked right now; that check may be added later.
pkgtools/pkglint: update to 20.3.0 Changes since 20.2.6: None
Revbump all Go packages after default Go version was changed to 1.15.1
Revbump all Go packages after go114 update
pkgtools/pkglint: update to 20.2.6 Changes since 20.2.5: Some selected absolute paths, such as /etc/passwd, /etc/shadow and /etc/hosts are allowed in patch files. Other files in /etc should still use PKG_SYSCONFDIR, to keep the package portable between platforms and also in unprivileged mode. (Fixes PR pkg/55524.) Absolute pathnames are also allowed in C-style end-of-line comments (fixes PR pkg/55516) and in continuations of C-style block comments (fixes PR pkg/55524). The explanation for make's :ts modifier has been adjusted to the 2020 bmake update. The modifier :ts\040 is now interpreted as octal, as opposed to decimal.
pkgtools/pkglint: update to 20.2.5 Changes since 20.2.4: The warning about "unknown options" has been reworded to "undocumented options", since that is more precise and less confusing. In pathnames and pathname patterns, the exclamation mark is allowed. This is necessary for Go packages like devel/gopls.
pkgtools/pkglint: update to 20.2.4 Changes since 20.2.3: Complain about buildlink3.mk files that accidentally set their own BUILDLINK_PKGSRCDIR variable to a different directory than their own.
pkgtools/pkglint: update to 20.2.3 Changes since 20.2.2: Complain about patches that add a hard-coded interpreter. Even if that interpreter is /bin/sh, which is available on most platforms, it is still inappropriate on old Solaris installations. Other popular paths start with /usr/pkg or /usr/local, and these are not controlled by pkgsrc either.
pkgtools/pkglint: update to 20.2.2 Changes since 20.2.1: Emit notes about redundant != assignments, as well as those that overwrite each other. For packages that set DISTINFO_FILE to their own distinfo file, don't check that file twice.
Revbump all Go packages after go114 update.
pkgtools/pkglint: update to 20.2.1
Changes since 20.2.0:
Don't warn about a possibly redundant PKGNAME=${DISTNAME} assignment if
PKGNAME is defined somewhere else in the package Makefile.
Warn if NO_CONFIGURE=yes and REPLACE_* are combined.
Suggest to replace ${VAR:@l@-l${l}@} with the simpler ${VAR:S,^,-l,},
as well as ${VAR:@l@${l}suffix@} with the simpler ${VAR:=suffix}.
Allow lua in CATEGORIES.
pkgtools/pkglint: update version to 20.2.0 No code changes. This is just to align the pkglint version number with the upcoming branch name.
pkgtools/pkglint: update to 20.1.19 Changes since 20.1.18: Fixed a wrong warning about unknown buildlink identifier "lua" in mail/neomutt, reported by wiz.
pkgtools/pkglint: update to 20.1.18 Changes since 20.1.17: Fixed the algorithm for checking whether two patterns overlap, such as MACHINE_PLATFORM:MNetBSD-[0-9].*-*. Fixed wrong warning about foreign variable in SUBST block, as seen in geography/qgis.
Revbump Go packages after Go 1.14.4 update.
pkgtools/pkglint: update to 20.1.17 Changes since 20.1.16: Conditions that contradict each other in the same file are reported as errors. Inspired by lang/rust/Makefile r1.174.
pkgtools/pkglint: update to 20.1.16 Changes since 20.1.15: When a package adds an additional version requirement for another package, it must do so using BUILDLINK_API_DEPENDS instead of BUILDLINK_ABI_DEPENDS. Most packages already do this. When a values is appended to an undefined variable using the += operator, bmake does not add a space before, and pkglint caught up to do the same. This change has no practical consequences though. As always, a bit of refactoring. The method names of MkAssignChecker contained the redundant word "varassign".
pkgtools/pkglint: update to 20.1.15 Changes since 20.1.14: Fix confusing wording of diagnostic "should contain text". It's more precise to say "this line should consist of this text". Otherwise it's too easy to interpret it as "the text should occur somewhere in the line". Allow BUILDLINK_PREFIX.* to be used in helper files. Especially for programming language packages, files like plugin.mk often include buildlink3.mk and therefore may refer to the BUILDLINK_PREFIX of this package. Warn about redundant BUILDLINK_API_VERSION restrictions. Previously, the check had only been enabled if the operators from the default dependency pattern (buildlink3.mk) and the additional dependency pattern (package) used the same operators, which already covered most practical cases. Determine SuSE versions from the pkgsrc tree.
pkgtools/pkglint: update to 20.1.14 Changes since 20.1.13: Packages that don't define DISTNAME probably don't download any files and thus may not need a distinfo file. (There are several other conditions involved in this, though.) When reporting wrong distinfo hashes, always report them in the order in which they appear in the distinfo file, not by hashmap order. Fix panic when parsing the Makefile line "./=value", which according to bmake is a variable assignment. This is not used in practice though. Disallow a leading hyphen in package option names. There are only very few packages that wrongly use these option selectors in PKG_SUGGESTED_OPTIONS. Distinguish between a tool dependency (USE_TOOLS) and a plain tool name (TOOLS_NOOP, TOOLS_BROKEN, TOOLS_FAIL). Allow packages to add arbitrary tools to these lists.
pkgtools/pkglint: update to 20.1.13 Changes since 20.1.12: Numeric comparison in conditions should not be used. It is currently only used for comparing version numbers. https://mail-index.netbsd.org/pkgsrc-changes/2020/06/02/msg215278.html
pkgtools/pkglint: update to 20.1.12 Changes since 20.1.11: The file bsd.pkg.mk must only ever be included by package Makefiles directly, not by other Makefile fragments. Seen in www/w3m. The variable BUILDLINK_PREFIX.* should only be used for packages that have actually been included by the package. This catches the use of BUILDLINK_PREFIX.libiconv, which should have been iconv instead. Allow comments before line 3 in buildlink3.mk files. This is necessary for mariadb55-client since its buildlink identifier is mysql-client, which is so non-obvious that it needs to be documented.
pkgtools/pkglint: update to 20.1.11 Changes since 20.1.10: PKG_SYSCONFDIR and VARBASE must not appear in INSTALLATION_DIRS. Patch files in which the line number have been edited manually are marked with notes.
pkgtools/pkglint: update to 20.1.10 Changes since 20.1.8: Recognize SUBST_NOOP_OK and SUBST_SHOW_DIFF. Allow plain -Wl,-R and -Wl,-rpath in BUILDLINK_TRANSFORM, when they are used to remove compiler options. Recognize ggrep and other platform tools as valid tool names. Seen in lang/rust.
pkgtools/pkglint: remove runtime dependency on devel/go-check Since 2019-11-16, the main pkglint code does not require this package anymore. It is still used in the test code.
pkgtools/pkglint: update to 20.1.8 Changes since 20.1.7: There are about 300 cases where a package defines a PLIST conditional in PLIST_VARS but none of its PLIST files actually uses that condition. These cases get a warning.
pkgtools/pkglint: update to 20.1.7 Changes since 20.1.6: Versioned Python dependencies may end with :test or :tool, as the code in lang/python/versioned_dependencies.mk says.
pkgtools/pkglint: update to 20.1.6 Changes since 20.1.5: Category Makefiles must only list subdirectories in SUBDIR that actually contain a package. There is no need to mention the other directories. This is the same as in the top-level Makefile, where mk/ and regress/ are not listed. Packages from pkgsrc-wip may have a COMMIT_MSG file with a suggested commit message for importing the package into main pkgsrc.
pkgtools/pkglint: update to 20.1.5 Changes since 20.1.4: No more wrong warnings about the Solaris /bin/sh. These warnings had been there for 14 years, preventing pkgsrc developers from using the $$(...) command substitution and negation in shell conditions. https://mail-index.netbsd.org/pkgsrc-changes/2020/05/01/msg212194.html
pkgtools/pkglint: update to 20.1.4 Changes since 20.1.3: For patches that patch a single file, the filename of the patch should correspond to the patched file. There are a few different naming schemes in action, therefore the check is relatively loose. Patches that are called patch-[a-z][a-z] continue to be allowed for historic reasons. Patches that are called patch-CVE-* are also allowed. The entries in doc/CHANGES-* are checked for consistency. For example, it doesn't make sense to add a package twice or "update" a package from version 1.0 to version 1.0. All version numbers in these entries must be valid pkgsrc versions, i.e. start with a digit and only use characters from -.0-9A-Z_a-z.
pkgtools/pkglint: update to 20.1.3
Changes since 20.1.2:
Stricter check for Python version numbers. Before, 25 and 26 had not
been marked as wrong.
In assignments like PKGNAME=${DISTNAME:S,from,to,}, modifiers that don't
have any effect generate a note. Most of these modifiers are redundant
or outdated.
Patches must not add well-known absolute paths like /usr/pkg, /var and
/etc since these must be overridable by the pkgsrc user. Other absolute
paths continue to be allowed.
pkgtools/pkglint: update to 20.1.2
Changes since 20.1.1:
Ensure that relative paths to other packages have the canonical form
../../category/package.
Add notes about pathname patters that mention ${WRKSRC} even though they
are already defined to be relative to WRKSRC.
Fix check for redundantly added categories. The check had previously
reported that the included file would be redundant, which was wrong.
It's always the including file that provides the redundancy.
Revbump all Go packages after default version switch to 1.14.
pkgtools/pkglint: update to 20.1.1 Changes since 20.1.0: In UNLIMIT_RESOURCES, the recently added virtualsize is allowed. Packages that have distfiles without any digit in their name should define DIST_SUBDIR to avoid polluting the global namespace. The top-level distfiles directory should only contain versioned filenames.
pkgtools/pkglint: update to 20.1.0 Changes since 19.4.13: It is an error to have TODO lines in DESCR files. These are typically generated by url2pkg and should be replaced with proper text before committing the package.
pkgtools/pkglint: update to 19.4.13 Changes since 19.4.12: Files that are mentioned redundantly in PLIST files generate an error. Missing DESCR files generate an error. Hard-coded /usr/pkg in patches generates an error.
Revbump all Go packages after go113 update.
pkgtools/pkglint: update to 19.4.12 Changes since 19.4.11: Redundant additions to BUILDLINK_API_DEPENDS and BUILDLINK_ABI_DEPENDS get warnings since they may have been needed in the past but the dependent package has increased its required version numbers over time.
pkgtools/pkglint: update to 19.4.11 Changes since 19.4.10: The use of PKG_OPTIONS and PKG_BUILD_OPTIONS in buildlink3.mk and other files is checked for common mistakes. Checking the indentation of a continuation line no longer crashes in edge cases.
pkgtools/pkglint: update to 19.4.10 Changes since 19.4.9: In continuation lines with long values, pkglint no longer suggests to move the continuation backslash in the middle of the variable value, as that would be impossible. Warn when a shell command is assigned to a variable that only takes pathnames. Shell commands can contain command line options, and these are not pathnames. The TOOLS_PLATFORM.tool variables are not defined on every platform. When these variables are used outside an OPSYS check, a warning lists the platforms where the tool is undefined or only defined conditionally.
pkgtools/pkglint: update to 19.4.9 Changes since 19.4.8: Packages that include omf-scrollkeeper.mk even though their PLIST doesn't contain any .omf files will generate an error message, suggesting that the .include line be removed.
pkgtools/pkglint: update to 19.4.8 Changes since 19.4.7: The diagnostic for homepages using FTP is simpler now. When running pkglint recursively on the top-level directory, the inter-package checks (distfile hashes, unused licenses) are enabled implicitly. This way, the only effect of the -Cglobal option is now whether the pkgsrc infrastructure files are checked as well. The check for removed packages that have not been recorded in doc/CHANGES prints the correct lines when pkglint is run with the --source option. Fatal technical errors are no longer treated as diagnostics since they are none. That was an early conceptual mistake, but since these fatal error didn't happen often, it didn't matter. In diagnostics, when referring to other lines, the previously used words before/after have been replaced with above/below to avoid any confusion whether space or time is meant. In CONF_FILES, spaces and quotes are allowed. See https://gnats.netbsd.org/42191. Fixed unintended side-effects when running pkglint --autofix --only. Before, all fixes were applied to the file, whether or not they matched the --only option. Fixed resolution of relative paths of the form ../../category/package when they appeared in an infrastructure file. Lots of refactorings and housekeeping, as usual.
pkgtools/pkglint: update to 19.4.7 Changes since 19.4.6: HOMEPAGE definitions that use http no longer get a warning that they should migrate to https. Those that could be migrated have been migrated, and the remaining homepages are not yet ready, so there's no benefit in having this warning by default. Only in --network mode and when the https site is indeed reachable, the warning is shown. In long continued lines, the continuation backslash should be preceded by a single space. Pkglint had wrongly removed that space in a few cases before.
Revbump all Go packages after go113 update.
pkgtools/pkglint: update to 19.4.6 Changes since 19.4.5: Added the --network option, which allows pkglint to use HTTP calls for determining whether the homepage of a package is reachable. Added migration from http URLs to the corresponding https URLs. This is only done if the https URL is indeed reachable or well-known to support https. Added migration from https SourceForge URLs back to http URLs since a previous pkglint run had migrated URLs to non-working https URLs. See https://mail-index.netbsd.org/pkgsrc-changes/2020/01/18/msg205146.html. Added a warning for HOMEPAGE that uses ftp:// since that is not user-friendly. In the same way, download-only host names on SourceForge are not suitable as a homepage since they usually only generate a 404.
pkgtools/pkglint: update to 19.4.5 Changes since 19.4.4: Fixed automatic replacement from http SourceForge URLs to their https counterparts. According to their official documentation, the https URLs are not on the same hosts as before, but on *.sourceforge.io.
pkgtools/pkglint: update to 19.4.4 Changes since 19.4.3: Packages that still use http in their HOMEPAGE URL generate warnings that the URL should use https instead.
pkgtools/pkglint: update to 19.4.3
Changes since 19.4.2:
PLIST_VARS identifiers must not contain characters that are interpreted
specially in regular expressions.
All pkgsrc text files except for doc/pkgsrc.{html,txt} must use the
default CVS keyword substitution.
Revbump Go packages after Go default version bump.
pkgtools/pkglint: update to 19.4.2 Changes since 19.4.1: Fixed variable resolution. Before, variables that had not been defined in an included file could still end up in the scope of the package, which made many of the pkglint checks unreliable. Each condition that is used in the PLIST should be defined somewhere in the package Makefile or its included files. When loading a package Makefile, hacks.mk is loaded implicitly at the end, just as the pkgsrc infrastructure does in mk/bsd.hacks.mk.
pkgtools/pkglint: update to 19.4.1 Changes since 19.4.0: The notes for inserting an empty line have been changed from "insert after this line" to "insert before this line" to make the line numbers in the diagnostics contiguous. There had been several places where the diagnostics went from line 1 to line 2 and then back to line 1, which was confusing. The lines in ALTERNATIVES files are checked for trailing whitespace. This is only for consistency with the other checks. In the whole pkgsrc tree all ALTERNATIVES files are already fine. The diagnostics for comments in .endif/.endfor lines that don't correspond to their .if/.elif/.for counterparts now includes the exact line number of the corresponding condition, to make the warning easier to fix. The diagnostics for wrong variable value alignment now mention the current column in addition to the desired column, to make it easier to see by how much and in which direction the indentation should be fixed. Variables that are used in conditions before they are actually defined need the :U modifier.
pkgtools/pkglint: update to 19.4.0 Changes since 19.3.19: Empty PLIST files now generate an error instead of a warning since there is no reason for having these empty files. If a follow-up line in a Makefile is completely empty, there is no note about trailing whitespace anymore since the warning about the misleading empty line already covers this case. The remaining code changes are only refactorings.
pkgtools/pkglint: update to 19.3.19 Changes since 19.3.18: Small improvements to edge cases in SUBST blocks. Small improvements to edge cases in variable assignment and alignment of the continuation backslashes. The --source option shows the changes from autofix, even when the --show-autofix option is not given. This is a welcome side-effect of making the autofix logging simpler and more predictable.
pkgtools/pkglint: update to 19.3.18 Changes since 19.3.17: The SUBST check has been completely rewritten. It can handle several SUBST classes at the same time now. This reduces the number of wrong warnings.
Revbump all Go packages after Go 1.12.14 update.
pkgtools/pkglint: update to 19.3.17 Changes since 19.3.16: Pkglint now handles SUBST blocks correctly, even those in which some of the variables are defined conditionally. It correctly reports those that are missing in at least one of the possible branches. PKG_JVM is no longer marked as deprecated. It was once package-settable. Since 2002 it is system-provided, and the package-settable counterpart is PKG_JVM_DEFAULT. This does not fit into pkglint's simple model of deprecating variables since the variable name is still valid, it should just not be defined by packages anymore. The alignment of variable assignments has been fixed in some edge cases. In continuation lines where the backslash is beyond column 72, the whitespace before the continuation backslash is fixed to a single space.
pkgtools/pkglint: update to 19.3.16 Changes since 19.3.15: When a package-settable variable gets a default value using the ?= operator, pkglint no longer suggests to include bsd.prefs.mk, since that doesn't make sense. Including bsd.prefs.mk only defines user-settable and system-provided variables. User and group names may be a single character only. While not widely used, it's syntactically valid and there's no reason to prevent this. In variable assignments, when pkglint removes unnecessary whitespace between the variable name and the operator, it keeps the indentation of the variable value the same as before. Previously, the indentation had been changed, which required another run of pkglint --autofix. PREFIX can only be used as a replacement for LOCALBASE after the whole package Makefile has been loaded. This is because PREFIX is defined very late, by bsd.pkg.mk. Therefore, don't suggest to replace LOCALBASE with PREFIX in .if conditions. When pkglint suggests to replace INSTALL_DATA_DIR commands with setting INSTALLATION_DIRS instead, paths with a trailing slash are correctly looked up in the PLIST. This suggests to use AUTO_MKDIRS more often.
pkgtools/pkglint: update pkglint to 19.3.15 Changes since 19.3.14: Invalid lines in PLIST files are now reported as errors instead of warnings. If pkglint doesn't know about it, it must be an error. In PLIST files, all paths are validated to be canonical. That is, no dotdot components, no absolute paths, no extra slashes, no intermediate dot components. Fewer notes for unexpanded variable expressions in DESCR files. Before, the text $@ was reported as possible Makefile variable even though it was just a Perl expression. README files are allowed again in pkgsrc package directories. There was no convincing argument why these should be forbidden. A few diagnostics have been changed from NOTE to WARNING or from WARNING to ERROR, to match their wording. When pkglint suggests to replace :M with ==, the wording is now "can be made" instead of "should".
pkgtools/pkglint: update to 19.3.14
Changes since 19.3.13:
When pkglint suggests to replace !empty(VARNAME:Mfixed) with ${VARNAME}
== fixed, the exact suggested expression is now part of the diagnostic.
The check and the autofix have been improved. They now apply only to the
last modifier in the whole chain, everything else was a bug in pkglint.
Pkglint now knows the scope of variables better than before. It knows
the difference between variables from <sys.mk> like MACHINE_ARCH, which
are always in scope, and those from mk/defaults/mk.conf, which only come
into scope later, after bsd.prefs.mk has been included. It warns when
variables are used too early, for example in .if conditions.
The pathnames in ALTERNATIVES files are now checked for absolute
pathnames. This mistake doesn't happen in practice, but the code for
converting the different path types internally made it necessary to add
these checks. At least this prevents typos.
The special check for obsolete licenses has been removed since their
license files have been removed and that is checked as well.
Variables named *_AWK may be appended to.
The variables _PKG_SILENT and _PKG_DEBUG are no longer deprecated, they
are obsolete now. They are not used in main pkgsrc and pkgsrc-wip
anymore.
When a package sets a default value for a user-settable variable (which
is something that should not happen anyway), it should .include
bsd.prefs.mk before, in order to not accidentally overwrite the
user-specified value.
Variable modifiers of the form :from=to are now parsed like in bmake.
They are greedy and eat up any following colons as well. This means that
${VAR:.c=.o:Q} replaces source.c with source.o:Q, instead of quoting it.
Pkglint now warns about such cases.
The handling of relative paths in diagnostics is now consistent. All
paths that are part of a diagnostic are relative to the line that issues
the diagnostic.
Fatal errors are no longer suppressed in --autofix mode.
Plus lots of refactoring, to prevent accidental mixing of incompatible
relative paths.
pkgtools/pkglint: update to 19.3.13 Changes since 19.3.12: The command line option -Wspace has been removed. Warnings and notes about whitespace are now generated by default and cannot be switched off. This is to ensure a consistent visual appearance of the package Makefiles. Shell programs that are indented unnecessarily deep generate a note by default now. Before, the option -Wall was necessary to get these notes. The check for unintended comments in multi-line shell programs is now enabled again. It had been disabled some time ago as byproduct of a bug fix in the shell parser. The check for unique buildlink3 package identifiers now also works if pkglint is run from a package directory instead of the pkgsrc root directory.
pkgtools/pkglint: update to 19.3.12 Changes since 19.3.11: The command line option -Wstyle has been removed since it didn't have any effect. License names may contain underscores. This fixes 3 parse errors and 2 wrong notes about seemingly unused licenses. The parser for Makefile variables has been improved for some edge cases. The :M and :N modifiers behave surprisingly when they contain unbalanced parentheses or braces. Pkglint now parses them in the same way as bmake, but doesn't warn since these cases are not actually used in pkgsrc.
pkgtools/pkglint: update to 19.3.11 Changes since 19.3.10: The check for buildlink3.mk files that are included conditionally in one place and unconditionally in another place have been refined. Now they also work in cases that do not involve any variables, such as when the condition is a mere exists(filename). References to variables that use parentheses instead of the usual braces produce a warning now, even if pkglint cannot fix them automatically. This affects only a few instances where more than one such variable reference appeared in a single line. The --log-verbose command line option has been removed since it does not have any practical use other than improving the performance during pkglint development itself. Because of that it hadn't even been mentioned in the manual page. Warnings for missing license files now report the path to the license file relative to the line where the warning occurs, like everywhere else.
pkgtools/pkglint: update to 19.3.10 Changes since 19.3.9: In diagnostics for suggested package updates, the exact line of doc/TODO is mentioned. If a suggested update has an additional comment, the brackets around that comment are not output anymore. The check for defined but not used variables has been improved for the edge case of defining a variable in the package Makefile and using it in the buildlink3.mk file of the same package, which just doesn't work. Makefile fragments in patches/ directories are now completely ignored. It was a hypothetical case anyway. Comparing PKGSRC_COMPILER using the == or != operators is now considered an error instead of a warning. The common cases can be autofixed.
pkgtools/pkglint: update to 19.3.9
Changes since 19.3.8:
Match man pages in ALTERNATIVES with their counterparts in PLIST. In
PLIST files, ${PKGMANDIR} may be abbreviated as a simple "man", but not
in ALTERNATIVES.
Pullup ticket #6083 - requested by leot
lang/go112: security update
lang/go: update available version
Revisions pulled up:
- lang/go/version.mk 1.70
- lang/go112/PLIST 1.8
- lang/go112/distinfo 1.8
Revision bump for:
- archivers/go-xz/Makefile
- chat/coyim/Makefile
- chat/matterircd/Makefile
- databases/go-etcd/Makefile
- databases/go-ldap/Makefile
- databases/influxdb/Makefile
- databases/postgres_exporter/Makefile
- databases/prometheus/Makefile
- devel/git-lfs/Makefile
- devel/go-afero/Makefile
- devel/go-amber/Makefile
- devel/go-appengine/Makefile
- devel/go-assert/Makefile
- devel/go-blackfriday/Makefile
- devel/go-buffruneio/Makefile
- devel/go-cast/Makefile
- devel/go-check/Makefile
- devel/go-cli/Makefile
- devel/go-cobra/Makefile
- devel/go-colorable/Makefile
- devel/go-colortext/Makefile
- devel/go-colour/Makefile
- devel/go-consul-api/Makefile
- devel/go-debounce/Makefile
- devel/go-ed25519/Makefile
- devel/go-emoji/Makefile
- devel/go-errors/Makefile
- devel/go-flags-svent/Makefile
- devel/go-fnmatch/Makefile
- devel/go-fs/Makefile
- devel/go-fsnotify/Makefile
- devel/go-fsync/Makefile
- devel/go-gitmap/Makefile
- devel/go-glog/Makefile
- devel/go-gls/Makefile
- devel/go-gocode/Makefile
- devel/go-godef/Makefile
- devel/go-godirwalk/Makefile
- devel/go-godotenv/Makefile
- devel/go-golang-lru/Makefile
- devel/go-goorgeous/Makefile
- devel/go-gopkgs/Makefile
- devel/go-goptlib/Makefile
- devel/go-goreturns/Makefile
- devel/go-gox/Makefile
- devel/go-hashstructure/Makefile
- devel/go-homedir/Makefile
- devel/go-humanize/Makefile
- devel/go-i18n/Makefile
- devel/go-immutable-radix/Makefile
- devel/go-ini/Makefile
- devel/go-iochan/Makefile
- devel/go-isatty/Makefile
- devel/go-jwalterweatherman/Makefile
- devel/go-kingpin.v3-unstable/Makefile
- devel/go-locker/Makefile
- devel/go-logrus/Makefile
- devel/go-mapstructure/Makefile
- devel/go-mapstructure-bep/Makefile
- devel/go-mow-cli/Makefile
- devel/go-nbreader/Makefile
- devel/go-nitro/Makefile
- devel/go-osext/Makefile
- devel/go-pflag/Makefile
- devel/go-properties/Makefile
- devel/go-protobuf/Makefile
- devel/go-purell/Makefile
- devel/go-ratelimit/Makefile
- devel/go-repr/Makefile
- devel/go-review/Makefile
- devel/go-sanitized_anchor_name/Makefile
- devel/go-shellwords/Makefile
- devel/go-shuffle/Makefile
- devel/go-siphash/Makefile
- devel/go-sync/Makefile
- devel/go-sys/Makefile
- devel/go-termbox/Makefile
- devel/go-testify/Makefile
- devel/go-thrift/Makefile
- devel/go-tools/Makefile
- devel/go-try/Makefile
- devel/go-viper/Makefile
- devel/go-yaml/Makefile
- devel/golint/Makefile
- devel/google-api-go-client/Makefile
- graphics/go-image/Makefile
- graphics/go-imaging/Makefile
- graphics/go-resize/Makefile
- graphics/go-smartcrop/Makefile
- lang/go-hcl/Makefile
- mail/postforward/Makefile
- math/go-stats/Makefile
- math/go-units/Makefile
- misc/go-genproto/Makefile
- misc/go-genproto-googleapis-rpc/Makefile
- net/aws-sdk-go/Makefile
- net/dnscrypt-proxy2/Makefile
- net/gcloud-golang-metadata/Makefile
- net/go-dns/Makefile
- net/go-dnstap/Makefile
- net/go-framestream/Makefile
- net/go-grpc/Makefile
- net/go-net/Makefile
- net/go-ovh/Makefile
- net/go-websocket/Makefile
- net/hub/Makefile
- net/obfs4proxy/Makefile
- net/syncthing/Makefile
- pkgtools/pkglint/Makefile
- security/2fa/Makefile
- security/go-asn1-ber/Makefile
- security/go-crypt/Makefile
- security/go-crypto/Makefile
- security/go-mkcert/Makefile
- security/go-oauth2/Makefile
- security/go-sftp/Makefile
- security/vault/Makefile
- sysutils/beats/Makefile
- sysutils/consul/Makefile
- sysutils/fzf/Makefile
- sysutils/goreman/Makefile
- sysutils/lf/Makefile
- sysutils/node_exporter/Makefile
- sysutils/vultr/Makefile
- textproc/go-chroma/Makefile
- textproc/go-diff/Makefile
- textproc/go-glob/Makefile
- textproc/go-inflect/Makefile
- textproc/go-md2man/Makefile
- textproc/go-mmark/Makefile
- textproc/go-prose/Makefile
- textproc/go-regexp2/Makefile
- textproc/go-runewidth/Makefile
- textproc/go-sentences/Makefile
- textproc/go-tablewriter/Makefile
- textproc/go-text/Makefile
- textproc/sift/Makefile
- www/caddy/Makefile
- www/gitea/Makefile
- www/go-ace/Makefile
- www/go-cssmin/Makefile
- www/go-gogs-client/Makefile
- www/go-gohtml/Makefile
- www/go-libsass/Makefile
- www/go-minify/Makefile
- www/go-parse/Makefile
- www/go-spritewell/Makefile
- www/go-tocss/Makefile
- www/go-toml-burntsushi/Makefile
- www/go-toml-pelletier/Makefile
- www/go-urlesc/Makefile
- www/go-webhooks/Makefile
- www/grafana/Makefile
- www/hugo/Makefile
- www/pup/Makefile
-------------------------------------------------------------------
Module Name: pkgsrc
Committed By: bsiegert
Date: Fri Oct 18 14:48:29 UTC 2019
Modified Files:
pkgsrc/lang/go: version.mk
pkgsrc/lang/go112: PLIST distinfo
Log Message:
Update go112 to 1.12.12.
qo1.12.11 (released 2019/10/17) includes security fixes to the crypto/dsa
package. See the Go 1.12.11 milestone on our issue tracker for details.
go1.12.12 (released 2019/10/17) includes fixes to the go command, runtime,
syscall and net packages. See the Go 1.12.12 milestone on our issue tracker
for details.
To generate a diff of this commit:
cvs rdiff -u -r1.69 -r1.70 pkgsrc/lang/go/version.mk
cvs rdiff -u -r1.7 -r1.8 pkgsrc/lang/go112/PLIST pkgsrc/lang/go112/distinfo
pkgtools/pkglint: update to 19.3.8 Changes since 19.3.7: Made check for doc/CHANGES file stricter. The check now catches entries for added packages that are missing the word "version".
pkgtools/pkglint: update to 19.3.7
Changes since 19.3.6:
Improved variable value alignment.
Fixed wrong warning about comment lines that were interpreted as shell
commands before.
Warn when the first category of a package doesn't correspond to the
path in the filesystem. This affects 603 packages.
No longer warn about deprecated BUILDLINK_TRANSFORM.${OPSYS}. The
deprecation warning was meant for BUILDLINK_TRANSFORM.${pkgbase}, but
since pkglint cannot distinguish between these, the warnings were wrong.
pkgtools/pkglint: update to 19.3.6 Changes since 19.3.5: Improved indentation and alignment of multi-line variable assignments. Improved indentation of multi-line shell commands. Added warning for adding unquoted words to PKG_FAIL_REASON, which is a list of messages, one per line. Lines that start with tabs followed by a # are not shell commands, they are comments. Bmake treats them in the same way. Change the type of BROKEN to be a list of messages, instead of a single message. This allows at least a bit of formatting in the error messages.
pkgtools/pkglint: update to 19.3.5
Changes since 19.3.4:
Variable uses in parentheses (such as $(VAR) instead of ${VAR}) are
treated the same. The ones in parentheses had less support before.
Improved the checks for options.mk files, adding support for options
that are defined using .for loops and those referring to other
variables.
Packages that set DISTFILES to an empty list no longer require a
distinfo file.
Patches whose filename contains the word CVE may patch more than one
target file.
pkgtools/pkglint: update to 19.3.4 Changes since 19.3.3: In cases where the conditions for including buildlink3.mk files differ between the package itself and its own buildlink3.mk file, explain how to determine PKG_OPTIONS for dependencies. Don't issue wrong warnings in options.mk files when the options are handled in a .for loop.
pkgtools/pkglint: update to 19.3.3 Changes since 19.3.2: The rationale for variables like BROKEN, GCC_REQD and for direct inclusion of builtin.mk files may span multiple lines, and it may end with an empty comment line.
pkgtools/pkglint: update to 19.3.2
Changes since 19.3.1:
* Pkglint no longer warns about a missing :Q modifier if there is also
a :D modifier, since the latter hides the original variable value
from the expression value.
* Variable names like .CURDIR are now allowed in the _VARGROUPS section.
* In dependency lines like "${_COOKIE.extract}:", pkglint no longer
warns about the unknown target. No matter whether this is a file name
or even a list of other targets, there's no chance for a typo here.
* If some dependencies are included conditionally, and the package
Makefile and buildlink3.mk disagree, and the conditions depend on
PKG_OPTIONS, pkglint outputs a helpful explanation.
* The check for including builtin.mk directly can be disabled by giving
a reason in a comment at the end of the line.
Revbump all Go packages after lang/go112 update
pkgtools/pkglint: update to 19.3.1 Changes since 19.3.0: * In buildlink3.mk files, the package identifier doesn't have to match the PKGBASE from the package Makefile exactly. The PKGBASE may have a leading "lib" (for libiconv and libgettext), as well as a trailing number (for emacs20 and netatalk22). * GITHUB_RELEASE is added to the variables that should appear in a fixed order in the package Makefile. * In the MASTER_SITE URLs, the transport protocol is irrelevant for matching direct URLs to the predefined MASTER_SITE_* variables.
pkgtools/pkglint: update to 19.3.0
Changes since 5.7.24:
* There is no need to ask the dummy MAINTAINER from url2pkg whether
committing changes is ok.
* When autofixing a condition like !empty(PKGPATH:Mliteral), don't
generate unnecessary parentheses around ${PKGPATH} == literal.
* In a _VARGROUPS section, the public variables should be listed
before the private variables, to put important things first.
* When pkglint suggests to be run again with the -e, -fs or -F options,
repeat the whole command line, to allow for copy-and-paste.
* The checks for PKGPATH are fixed and enhanced. It is not a relative
path like in ../../category/package, but relative to the pkgsrc root.
* Unintended file globbing in sed commands such as s,.*,any, gets a
warning.
* MASTER_SITES should normally end with a slash, in rare cases an
equals sign or a colon are correct, too.
* Detect redundant directories in INSTALLATION_DIRS.
Revbump all Go packages after 1.12.10 update. ok wiz@ for PMC
pkgtools/pkglint: update to 5.7.24
Changes since 5.7.23:
* Improved the _VARGROUPS check for ignored variables
* Removed wrong warnings for variable expressions like ${VAR:Dyes:Uno}
* Used correct terminology for the :Q modifier (it's not an operator)
pkgtools/pkglint: update to 5.7.23
Changes since 5.7.22:
* Added a warning for lines that look empty but are actually follow-up
lines from a previous line.
* Added notes for unusual placement of the continuation backslash. It
should always be preceded by a single space or tab, or be in column
73.
* Improved check for needlessly complicated !empty(PKGPATH:Mcat/pkg)
that is transformed into the simpler ${PKGPATH} == cat/pkg, even if
the package name contains hyphens, dots, plus or slashes.
* Added check for the _VARGROUPS section since that section contains
many redundancies that can easily be checked. For example, in
mk/compiler/gcc.mk the _VARGROUPS section is 67 lines long and
contains far more than 100 variables. It's tedious to manually check
this file for internal consistency. That's better left to pkglint.
* The empty variable is no longer flagged as "used but not defined".
It appears in expressions like ${:Ustring}.
* When --source is combined with --explain, don't unnecessarily
repeat the source code for a single line if there are several
diagnostics. Instead, even omit the empty line between the diagnostics
for the same line.
pkgtools/pkglint: update to 5.7.22 Changes since 5.7.21: * The files from wip/mk do not belong to the main pkgsrc infrastructure. Therefore, when loading the package Makefile to look for defined but unused variables, parsing doesn't stop in these files.
pkgtools/pkglint: update to 5.7.21 Changes since 5.7.20: * PKG_OPTIONS that are handled using patterns are correctly identified. * Simple R packages should follow the canonical variable order. * Fixed some edge cases for aligning variable assignments. * Improved detection of allowed values for USE_LANGUAGES.
pkgtools/pkglint: update to 5.7.20 Changes since 5.7.19: * Fixed warning about unknown C++ standard versions, which had appeared after the code in mk/compiler.mk changed.
Recursive bump of all packages using Go after Go 1.12.8 update.
pkgtools/pkglint: update to 5.7.19
Changes since 5.7.18:
* The tricky construct for generating case-items from a Make variable
no longer produces parse errors. Example:
case $$expr in ${PATTERNS:@p@ (${p}) action ;; @} esac
pkgtools/pkglint: update to 5.7.18 Changes since 5.7.17: * Added "R" to the list of valid secondary categories.
pkgtools/pkglint: update to 5.7.17 Changes since 5.7.16: * The warnings for doc/CHANGES are only enabled when the -Cglobal option is given. This is to avoid warnings that are unrelated to the package that is being checked.
pkgtools/pkglint: update to 5.7.16 Changes since 5.7.15: * Completely rewrote the code for aligning multiple variable assignment lines. It works on the actual lines of the file now instead of the parsed lines. This provides more exact diagnostics and also makes the handling of these lines easier so that future requirements can be implemented more easily. * Added support for exotic conditions in .if clauses. These conditions are not seen in the wild though. * Fixed wrong diagnostics for ALTERNATIVES files that appear conditionally in the PLIST. * As always: lots of refactorings and newly added tests.
pkgtools/pkglint: update to 5.7.15 Changes since 5.7.14: * Added a check for packages that have been removed from the file system but not been recorded in doc/CHANGES. This will help produce more accurate release statistics. * Small refactorings, as usual.
pkgtools/pkglint: update to 5.7.14 Changes since 5.7.13: - Removed the -Cextra command line option since it didn't produce useful warnings. - Removed unwarranted warnings about _WRAP_EXTRA_ARGS.CC being used in packages. - Cleaned up the canonical order of variables in package Makefiles. - Added a few commands to those that cannot fail, to reduce the number of "at the left of the | operator" in shell programs. - Fixed warnings about "-ggdb" being an unknown shell command. - Reduced number of warnings about lists being used where a single value is expected. - Replaced unreliable check for invalid CFLAGS and LDFLAGS with a more practical check. - Renamed "RCS tag" to "CVS tag" to make the diagnostics more modern. - Added warning when PKGNAME or PKGVERSION is used in MASTER_SITES. - Reworded warning for missing or superfluous PLIST files. - Lots of other detail changes, refactorings and automatic tests.
pkgtools/pkglint: updated to 5.7.13 Changes since 5.7.12: * Fixed a warning in the variable permissions that previously said "this variable should not be used at load time in this file, it would be ok in .", with an empty list of alternative files. * Lots of refactoring and new tests.
Revbump all Go packages after go112 update.
pkgtools/pkglint: update to 5.7.12 Changes since 5.7.11: * Fixed an alignment bug when pkglint replaced SUBST_SED with SUBST_VARS. * Added many test cases.
pkgtools/pkglint: ignore hidden files during extraction Fixes pkg/54204.
pkgtools/pkglint: update to 5.7.11 Changes since 5.7.10: Fixed wrong warnings about autoconf being an unknown shell command when an included file had defined USE_TOOLS+=autoconf213.
pkgtools/pkglint: update to 5.7.10
Changes since 5.7.9:
* Fixed URL checking for MASTER_SITES, especially remove the wrong error
message about URLs of the form ${MASTER_SITE:S,^,-,:=subdir/}.
* Made warnings about invalid filenames, filename patterns, pathnames and
pathname patterns more detailed.
pkgtools/pkglint: update to 5.7.9 Changes since 5.7.8: * Buildlink3.mk files are checked for typos in the identifier that is used for BUILDLINK_TREE, to detect copy-and-paste mistakes. * Having a rationale is recommended for some variables, especially those that make a package fail to build or crash at runtime. This check is only active when -Wextra is given, since it is still actively debated whether such a check is actually useful. * Files called Makefile.php can easily be mistaken to be PHP files. Therefore the recommended naming convention is to have auxiliary files called *.mk. There are already many more files called *.mk than those being called Makefile.*. * The check for unquoted sed substitution commands has been made more detailed, but since it is completely disabled, there's nothing to see for now. * The definitions for MASTER_SITE_* are loaded directly from the pkgsrc infrastructure instead of hard-coding them in pkglint.
pkgtools/pkglint: update to 5.7.8 Changes since 5.7.7: Warn about definitions of NOT_FOR_* and ONLY_FOR_* which are missing a rationale. When maintaining such packages it helps a lot to know why the package cannot be built on a particular platform or with a particular compiler or Python version.
pkgtools/pkglint: update to 5.7.7 Changes since 5.7.6: Warn about packages that override user-settable variables. Packages that define variables with the same value as the default value only get a note instead of the warning since these definitions do not cause any confusion. Do not suppress technical error messages in autofix mode. Do not warn about the package version being greater than the latest from doc/CHANGES if the file defining the package version has been modified locally and is about to be committed.
pkgtools/pkglint: update to 5.7.6
Changes since 5.7.5:
* The explanation for distfile hashes is only given when the distfiles
actually need to be downloaded. If they are already there, no
explanation is necessary.
* Makefile lines that are commented and have line continuations are
properly parsed. This affects the autofix for variable value
realignment.
* Variable permissions are not checked in hacks.mk since pkgsrc
developers who know about hacks.mk probably know what they are doing.
From hacks.mk files, builtin.mk files may be included directly, for
the same reason.
* Expressions of the form !empty(PKGPATH:Mpattern), when PKGPATH is not
a list variable and pattern has no wildcards, can be written in a
simpler form, and pkglint autofixes this. For example the above
expression is transformed into ${PKGPATH} == pattern. This
transformation reduces the amount of double negations (!empty) in the
code.
* Duplicate warnings about invalid relative ../package have been merged.
* TOOLS_ALIASES are properly resolved. The line USE_TOOLS=ggrep makes
the tools grep, egrep and fgrep known to pkglint, in the same way as
in the pkgsrc infrastructure.
* The diagnostics for missing or unnecessary distinfo files have been
improved to provide some guidance.
* Packages that use MESSAGE_SRC to build the message from multiple files
no longer produce a warning for malformed message files. These files
are simply skipped.
pkgtools/pkglint: update to 5.7.5
Changes since 5.7.4:
* Warn about invalid variable uses in directives like
.if and .for
* Do not warn when a package-settable variable is assigned using the ?=
operator before including bsd.prefs.mk. This warning only makes sense
for user-settable and system-provided variables.
* The parser for variable uses like ${VAR:@v@${v:Q}} is more robust now,
which reduces the number of parse errors and leads to more appropriate
diagnostics, in cases like ${URL:Mftp://*}, which should really be
${URL:Mftp\://*}.
* The valid values for OPSYS are now determined by the files in
mk/platform instead of allowing arbitrary identifiers. This catches a
few instances where "Solaris" is used instead of the correct "SunOS".
* Setting USE_LANGUAGES only has an effect if mk/compiler.mk has not yet
been included. In all other cases, pkglint warns now.
* Missing entries in doc/CHANGES produce a note now. This will lead to
more accurate statistics for the release notes.
Revbump all Go packages after go112 update
pkgtools/pkglint: update to 5.7.4
Changes since 5.7.3:
* Warn about dependency patterns that are missing a version number,
such as ${PYPKGPREFIX}-sqlite3:../../databases/py-sqlite3.
* Suggest to replace the := assignment operator with the :sh modifier,
in some cases where the variable is not obviously used at load time.
pkgtools/pkglint: update to 5.7.3
Changes since 5.7.2:
PLIST files are checked for non-ASCII characters. Even though pkgsrc
sets up the environment with LC_ALL=C, there are still some cases
of encoding errors. The case discussed on the tech-pkg mailing list
was lang/go112.
The checks for variable permissions ("may not be set in this file")
have been reworked completely. Many of the variable permissions had
different rules for Makefile and Makefile.common. These different
rules tried to prevent accidental overwriting of variables. Starting
in July 2018, pkglint got a check for redundant variables that is
far more accurate than the previous variable permissions. Therefore
these fine-grained permissions are no longer necessary. This removes
a few hundred wrong warnings about insufficient permissions.
The check that adds missing SHA512 hashes to distinfo files has been
fixed to work correctly in DIST_SUBDIR cases.
Improved the checks regarding tools that are used by a package but
not added to USE_TOOLS. For example, the "make" tool is always
available, as are all tools that are added to TOOLS_CREATE.
Lots of small improvements, as always.
Revbump all Go packages after Go 1.12.1 update.
pkgtools/pkglint: update to 5.7.2
Changes since 5.7.1:
* Fixed detection of GNU_CONFIGURE=yes combined with USE_LANGUAGES
missing c. This combination tends to fail in the configure phase.
* When the distinfo doesn't contain all hashes for the downloaded
distfiles (typically SHA512 is missing) and the distfiles are actually
downloaded to ${PKGSRCDIR}/distfiles, pkglint can now add the missing
hashes. It only does this if there is at least one existing hash
and if all existing hashes are correct.
* The check for redundant variables has been improved considerably.
Before there were several situations in which pkglint didn't get the
redundant variable definitions right because its internal model only
mimicked reality. The model has been improved and so have the
diagnostics.
* Pkglint only warns about wrong permissions (for defining or using
a variable) when it knows the type of the variable and the permissions
for the current file. Before, it had also warned if the permissions
for the current file were not explicitly defined.
* CFLAGS and LDFLAGS may be appended in buildlink3.mk files. This
had been disallowed before, for no apparent reason. There are several
places in pkgsrc where especially CFLAGS.${OPSYS} is appended to.
* Cleaned up internal handling of relative paths. Previously pkglint
sometimes resolved relative paths using the wrong base directory,
which led to all kinds of wrong warnings and strange behavior.
* Fixed lots of edge cases when parsing Makefile lines. These cases
don't occur often but experience tells that the most fundamental code
must be as correct as possible (see the handling of relative paths
above).
* Lots of refactoring and housekeeping, as always.
all: revbump Go packages, now that they use go112 to build
pkgtools/pkglint: update to 5.7.1 Changes since 5.7.0: * Removed a line of code that was meant only for development, not for production use, from util.go.
pkgtools/pkglint: update to 5.7.0 Changes since 5.6.12: * Many of the -C and -W command line options have been removed since they are not used in practice. The -Wall and -Call options continue to work though; these are the only options mentioned in the pkgsrc guide. * When a PLIST file contains redundant libtool libraries (.la and the corresponding .so), there is only a single warning per file. * Warnings about the package COMMENT are now strictly ordered from left to right. * The hashes for all distfiles must now contain the SHA512 hash. This hash has been added to many distfiles in 2015. It's time now to enforce it on all other distfiles as well. * Makefile fragments that are included inside an .elif exists(...) are not reported as missing. * The check for redundant variables and accidentally overwritten variables has been improved. Now the warning occurs at the later definition. This especially applies to cases where a file is included and after that, some of its variables are overridden. Variables in unrelated files are no longer marked as redundant. * When a package contains multiple definitions of a single variable (typical for Makefile.common), the later definition overrides the earlier definition. That way, the location of DISTINFO_FILE and PATCHDIR is resolved correctly.
revbump go dependents after lang/go111 and lang/go110 updates
pkgtools/pkglint: update to 5.6.12
Changes since 5.6.11:
* In buildlink3.mk files, print the paths relative
to the line, not to the pkgsrc root.
* When explaining that a variable cannot be set/used because of wrong
permissions, list the permissions. This provides more transparency
than just stating that the desired action is not allowed.
* When pkglint checks a pkgsrc-wip package, don't warn about malformed
lines in doc/CHANGES-* since pkgsrc-wip users typically cannot do
anything about these errors.
* In profiling mode, not only the code coverage and the performance
statistics are dumped, the whole heap is also dumped to see which
parts of pkglint consume the most heap memory. Pkglint now needs
less heap memory than before, which mainly affects full scans.
* The checks for absolute pathnames have gone. They were of questionable
value since pkglint has failed to give proper advice on how to fix
them properly, at least for the last 12 years.
* The check that pkgsrc-wip packages should only use exact CVS Ids
(the unexpanded variant) has been disabled again. It occurred about
16000 times but even fixing it wouldn't improve anything since it
was mostly a formatting issue without any practical consequences.
* Warn about trailing variable modifiers like in ${VAR:S,from,to,extra}.
* Properly parse ${VAR:!command!}.
* Suggest to replace SUBST_SED with SUBST_VARS where possible, even
with complicated shell quoting. Pkglint can autofix most of these
overly verbose cases.
* Load builtin.mk whenever the corresponding buildlink3.mk file is
included. This fixes several warnings about undefined variables
(especially for packages using OpenSSL).
* Parse .for lines like bmake does since 2015, splitting words like
in brk_string.
* Optionally show a warning even if it cannot be autofixed by pkglint.
This is useful for the SUBST_VARS replacement since even when
pkglint cannot automatically replace the code, there are still cases
where it can warn at least.
* As always, several refactorings.
Revbump Go packages after lang/go111 update.
pkgtools/pkglint: update to 5.6.11
Changes since 5.6.10:
* Improved the wording of several warnings
* Fixed parsing of complicated dependency patterns such as
{ssh{,6}-[0-9]*,openssh-[0-9]*}. Pkglint still doesn't understand
them but at least it doesn't mark them as "unknown" anymore.
* Lots of refactoring, as usual. This is the last part of the big
refactoring, therefore future changes to pkglint are expected to be
smaller than in the previous 3 months.
pkgtools/pkglint: mention the update to 5.6.10 in Makefile The actual update has been this morning.
Revbump all Go packages after go111 update.
pkgtools/pkglint: update to 5.6.9 Changes since 5.6.8: * In addition to the pkglint binary, the whole pkglint code is installed as a library, so that other packages can use the code for doing their own checks on pkgsrc packages, Makefiles, shell programs, or the other file types from pkgsrc. * BUILDLINK_*.* may be used in all files. * Lots of refactorings
pkgtools/pkglint: update to 5.6.8 Changes since 5.6.7: In pkgsrc-wip, if the first line of a file contains an expanded CVS Id, it is not an error but only a note that it should be an unexpanded CVS Id. The autofix for this no longer inserts a new line but replaces the existing line. Several refactorings and small improvements to the existing diagnostics.
pkgtools/pkglint: update to 5.6.7
Changes since 5.6.6:
User-defined variables that are not yet added to BUILD_DEFS are only
reported once per file.
Unnecessary space after variable names is only worth a note instead of
a warning. Example:
MASTER_SITES = https://cdn.example.org/
All variable names that are defined in the pkgsrc infrastructure are
assumed to be available to the package Makefiles. This reduces the
number of wrong "used but not defined" warnings, at the expense of
Variable names that are used in other variable names are checked
whether they are defined somewhere. Example:
CFLAGS+= ${CFLAGS.${PARAM}} # PARAM is now checked
In SUBST_SED, when the pattern is s,@VAR@,${VAR}, or a slight variant
thereof, pkglint suggests to define SUBST_VARS instead, which frees the
package author from thinking about how to escape special characters and
is generally easier to read. Example:
SUBST_SED.class= s,@VAR@,${VAR:Q},
SUBST_VARS.class= VAR
Directives like .if !defined(...) are now handled the same whether or
not there is a space after before the (...).
The check for locally modified files now works independently of the
timezone.
As always, lots of refactorings have happened under the hood. Many small
bugs have been discovered and fixed accordingly.
pkgtools/pkglint: make goyacc accessible to the build
pkgtools/pkglint: fix build go-package.mk needs to be included at the bottom of the package Makefile since it defines several make targets that pkglint also defines.
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
pkgtools/pkglint: fix build when PKGSRC_RUN_TEST is not set
pkgtools/pkglint: update to 5.6.6 Changes since 5.6.5: - Removed plist-clash since it had crashed unconditionally whenever it was called. This means that in the last 3 years, nobody can have used it in the originally intended way. - Fixed interactions between the --source, --explain, --show-autofix, --autofix and --only options. - Fixed "defined but not used" and "used but not defined" for variables from the pkgsrc infrastructure. - Lots of small fixes and improvements found by the large pkglint code review (12% done).
Revbump all Go packages after go111 update.
pkglint: go-package.mk needs to come before bsd.prefs.mk
pkgtools/pkglint: update to 5.6.5 Changes since 5.6.4: * GCC_REQD should only contain the major version. For GCC versions up to 4.x, this consists of the first two numbers, such as 4.8, while starting with the 5.x series, the major version is only the first number, such as 7.
pkgtools/pkglint: update to 5.6.4 Changes since 5.6.3: * Allow += for COMMENT * Sync variable type definitions with reality * Fix check for "used but not defined" variables. This check had been broken since pkgtools/pkglint/files/pkglint.pl r1.776 from 2008-10-18 (3cd071958e63), which missed its 10-year anniversary by just 9 days. After fixing this check, pkglint produces about 800 new warnings spread all over pkgsrc, most of which are real typos. * Detect used variables also in .if and .elif conditions. This is closely related to the above fix and reduces the number of "defined but not used" variables, while at the same time producing new warnings because these variables are used at load time, where some of these variables are not yet defined. * Detect variables for which pkglint doesn't know the exact data type by scanning all files under mk/ at startup. Currently there are about 470 of these variables. No "used but not defined" warnings are issued for these variables anymore. * To speed up pkglint when checking the whole pkgsrc tree at once, the most often needed files are cached to reduce IO load. The checks for USE_TOOLS are optimized now since they were a major bottleneck. Together with other performance improvements this makes pkglint about 50% faster when checking the whole pkgsrc tree including pkgsrc-wip.
pkgtools/pkglint: Update to 5.6.3 Changes since 5.6.2: * Add check for version patterns 1.5*, which should rather be 1.5.* * Re-enable check for "set -e" and commands that may silently fail because of missing error checking * Lots of internal clean-up and tests
pkgtools/pkglint: update to 5.6.2
Changes since 5.6.1:
* Improved checks that depend on whether bsd.prefs.mk is included or
not.
* Improved checks for tools, whether they may be used at load time
or at run time.
* Improved tokenizer for shell commands. $| is not a variable but a
dollar followed by a pipe.
* Warnings about SUBST context are now shown by default.
* A warning is shown when a SUBST block is declared for *-configure
but the package has defined USE_CONFIGURE=no.
* Don't warn about USE_TOOLS:= ${USE_TOOLS:Ntool}.
* Don't warn about using the ?= operator in buildlink3.mk files before
including bsd.prefs.mk (for some more variables, but not all).
* Report an error for packages from main pkgsrc that have a TODO or
README file. Packages should be simple enough that they don't need
a README file and ready for production so that they don't need a TODO.
* Lots of small bug fixes and new tests.
pkgtools/pkglint: update to 5.6.1
Changes since 5.6.0:
* Fix output of relative paths in the diagnostics (thanks @wiz)
* Fix parsing of ${VAR:ts---}; it is now a syntax error
* Load more type definitions from mk/* instead of hard-coding them
* Lots of refactoring to improve test coverage, fixing several
small bugs as they were found
pkgtools/pkglint: update to 5.6.0
Changes since 5.5.16:
* Check for negated shell commands (if ! test -z "foo"); they are not
supported by Solaris.
* Don't check variable permissions for infrastructure files. A warning
like "may not be set by any package" doesn't make sense for them.
* Check that PLIST_VARS matches PLIST.*, which is especially useful in
options.mk files.
* Improve checks for options.mk files (for PKG_OPTIONS_SET).
* Prefer options handling with !empty() over checking empty() first.
* Prefer ${MACHINE_ARCH} == i386 over !empty(MACHINE_ARCH:Mi386), for
single-valued variables.
pkgtools/pkglint: make the tests run cleanly
pkgtools/pkglint: Update to 5.5.16 Changes since 5.5.15: * Add checks for options.mk files * Treat redundant variable definitions as notes, not as warnings * Check doc/CHANGES-* for typos in the dates (only for 2018 and later) * Lots of cleanup in the test code
pkgtools/pkglint: update to 5.5.15 Changes since 5.5.14: * Check that the comments in .endif and .endfor lines match the corresponding conditions. * Check for redundant variables (e.g. MASTER_SITES for R packages). * Check for accidentally overwritten variables. * Miscellaneous code cleanup and refactoring.
pkgtools/pkglint: updated to 5.5.14 Changes since 5.5.13: * Suppress duplicate warnings for unknown options in the same file * Grab acceptable package versions directly from the infrastructure files * Note about too deeply indented shell programs
pkgtools/pkglint: Update to 5.5.13 Changes since 5.5.12: * Allow underscore in package version. * Warn about SUBST in post-patch and pre-patch phases. * Allow multiple SUBST blocks per paragraph. * Code cleanup.
Revbump all Go packages after lang/go update.
pkgtools/pkglint: update to 5.5.12 Changes since 5.5.11: * Improve support for TEST_DEPENDS and USE_TOOLS+= *:test (thanks @leot) * Add checks for ALTERNATIVES files
Update pkglint to 5.5.11 Changes since 5.5.10: * Read JVMs and compiler languages from mk/* instead of predefined lists. * Support TEST_DEPENDS.
Update pkglint to 5.5.10. Changes since 5.5.9: * Fix wrong pkglint behavior for .include lines that are guarded by corresponding .if exists(...) * A little bit of refactoring, as always.
Update pkglint to 5.5.9 Changes since 5.5.8: * Improved support for the "strip" tool, which has a special definition and is not directly connected to the STRIP variable. * Miscellaneous code cleanup and new tests.
pkgtools/pkglint: update to 5.5.8 Changes since 5.5.7: * Enable the check for variable order in Makefiles by default.
Revbump all Go packages after 1.10.1 update. ok wiz@ for committing during freeze
pkgtools/pkglint: remove duplicate files The definitions from globaldata.go had been moved to pkgsrc.go. Having these definitions twice led to compile errors. While here, the file package_test.go doesn't need to be patched anymore since it gets its @VERSION@ from the constants defined in pkglint.go.
Update pkglint to 5.5.7
Changes since 5.5.6:
* When pkglint warns about files that are accidentally executable, it
offers to fix the file permissions.
* Warn about ${HOMEPAGE:=repository/}, since the := modifier should
only be used with MASTER_SITES.
* When the distinfo file is missing, suggest setting NO_CHECKSUM.
* Several refactorings.
pkgtools/pkglint: update to 5.5.6 Changes since 5.5.5: * Only offer explanations if an explainable diagnostic has actually been logged. * Clean up code. * Improve a few diagnostics. * In any Makefile, treat documented variables as used. This prevents warning about defined but unused variables. * Add support for some variables not previously known to pkglint.
Revbump all Go packages after Go 1.10 update.
pkgtools/pkglint: update to 5.5.5 Changes since 5.5.3: - Removed check for PERL5_PACKLIST, since it was not fixable by the package author. - Completely rewrote the check for ordering variables in simple package Makefiles. Now it reports the variables in the correct order instead of just saying "this above that" for a few variables. - Lots of code cleanup and documentation.
pkgtools/pkglint: update to 5.5.3 Changes since 5.5.2: * Fixed lots of bugs regarding autofixing variable assignments in continuation lines. * Fixed checking of MESSAGE files, which also get fixed now. * In variable assignments, commented assignments are aligned too. * Fixed a crash when checking an empty patch file. * The :Q modifier is only checked on predefined variables, to prevent the --autofix mode from removing :Q from user-defined variables. * Fixed lots of bugs in PLIST autofixing: relevant lines had been removed, and the sorting was not correct.
pkgtools/pkglint: update HOMEPAGE
pkgtools/pkglint: Update to 5.5.2 Changes since 5.5.1: * Fixed command line parsing for the --only option. * Improved alignment of variable values in Makefiles. * Code cleanup: better abstraction in the tests.
pkglint: Update to 5.5.1 Changes since 5.5: * Allow filtering log messages by keyword (--only) * In --autofix and --show-autofix mode, show only fixable diagnostics * When called with --source, show the source below the diagnostics * Don't warn about USE_LANGUAGES in ../../mk/compiler.mk * Fix autofix for .gz in PLIST
pkglint: Update to 5.5 Changes since 5.4.26: SUBST blocks are now checked correctly even if they contain conditionals like .if ... .elif ... .endif. AUTO_MKDIRS is only suggested for those directories that actually appear in the PLIST since other directories are not affected by this variable.
Updated pkglint to 5.4.26.
Changes since 5.4.25:
* When autofixing a patch, fix the corresponding distinfo file as well.
* Properly parse ${VARNAME:[\#]};
the # was interpreted as a comment before.
* Don't add unnecessary :Q to PKG_OPTIONS and related variables.
* Don't warn about missing manual pages. While Debian and other
distributions do this work, pkgsrc keeps the packages as original as
possible.
* Autofix redundant ".gz" for manual pages in PLISTs.
Updated pkglint to 5.4.25. Changes since 5.4.24: * More specific warning for "exitcode with pipe shell commands" * Don't warn that the echo in "echo | sed" could fail * Allow packages to define custom make targets * Don't warn about a misplaced LICENSE when a package doesn't define it * Skip .git directories * Reduce number of hicolor-icon-theme error messages in PLIST files * Remove MKCRYPTO, USE_CRYPTO, CRYPTO variable definitions
pkglint 5.4.24: remove references to crypto restrictions. Discussed with rillig.
Updated pkglint to 5.4.23.
Changes since 5.4.22:
Only autofix PLIST sorting in simple cases. Before this version, pkglint
sorted the PLIST even when it contained unresolved variable references like
${IMAKE_MAN_DIR}, which resulted in strange and unintuitive orders. These
complicated files are left for human inspection.
Updated pkglint to 5.4.22. Changes since 5.4.21: * Refactoring: moved packages line and linechecks back into main * Fixed panic when autofixing package Makefiles * Removed apache22 * Added a bit of inline documentation
Updated pkglint to 5.4.21 Changes since 5.4.20: * Removed obsolete kde3 check * Removed obsolete WindowMaker variables * Removed postgresql91 * Removed teTeX * Removed old Emacs versions 22, 23, 24 * Allow db6 * Allow c++11 in USE_LANGUAGES * New check for GNOME icon themes * Added CHECK_RELRO variables * Refactoring: new package linechecks * Refactoring: regex.Pattern
c++11 is valid for USE_LANGUAGES. Bump PKGREVISION.
Sprinkle CHECK_RELRO_SKIP on go packages. go14 has no relro support AFAICT. go-1.8.3 has if you use -buildmode=pie, but it claims it's not supported on Linux. Disable relro checking for go packages until bsiegert has time to look at this.
Allow db6 in BDB_* variables. Bump PKGREVISION.
Revbump all Go packages after the Go 1.8.1 update.
Pullup ticket #5247 - requested by sevan
pkgtools/pkglint: bugfix
Revisions pulled up:
- pkgtools/pkglint/Makefile 1.513
- pkgtools/pkglint/files/vardefs.go 1.23
---
Module Name: pkgsrc
Committed By: rillig
Date: Wed Apr 5 19:17:19 UTC 2017
Modified Files:
pkgsrc/pkgtools/pkglint: Makefile
pkgsrc/pkgtools/pkglint/files: vardefs.go
Log Message:
Updated pkglint to 5.4.20.
Changes since 5.4.19:
* Updated allowed Python versions to include py36.
Updated pkglint to 5.4.20. Changes since 5.4.19: * Updated allowed Python versions to include py36.
Updated pkglint to 5.4.19. Changes since 5.4.18: * Added generated Go yacc source files to CVS, since starting with Go 1.8 the yacc tool is no longer part of the core distribution. The dependency on yacc would pull in all the Go tools, which are quite a few, and some of these do not currently build since they depend on go-crypto. See https://mail-index.netbsd.org/tech-pkg/2017/03/17/msg017900.html
pkglint 5.4.18. Changes: - go tool yacc -> goyacc to fix building with Go 1.8 (PR pkg/52081).
Updated pkglint to 5.4.17. Changes since 5.4.16: * allow multiple definitions for MASTER_SITES in the package Makefile, without triggering a warning about wrong ordering. See https://mail-index.netbsd.org/tech-pkg/2017/01/18/msg017698.html
Updated pkglint to 5.4.16. Changes since 5.4.15: * updated vardefs from mk/defaults/mk.conf from v1.118 (2006) to v1.269 Gone: * PKG_SUFX * USETBL * PKGSRC_SHOW_PATCH_ERRORMSG * USE_XPKGWEDGE * PKGVULNDIR Adjusted: * USE_GAMESGROUP * BIN_INSTALL_FLAG -> BIN_INSTALL_FLAGS * fixed license parsing to be more realistic (the previous version didn't handle parentheses correctly) * lots of housekeeping * moved some code to separate packages, allowing re-use * separated Line checks into LineChecker type * separated MkLine checks into MkLineChecker type * made Line an interface, for further refactorings
Fix build under Mac OS X where "pax" doesn't seem to automatically create the target directory. We therefore do that manually.
Updated pkglint to 5.4.15. Changes since 5.4.14: * Definitions for CONF_FILES should always come in pairs (pkg/37284)
Cleaned up and refactored code. The getopt and pkgver code have been extracted to separate packages to make them reusable. Several other functions have been moved to make the structure easier to understand: * dir.go and main.go have been moved to pkglint.go * utility functions from pkglint.go have been moved to mkline.go Now pkglint.go contains only high-level code.
Fix build warning on DragonFly. Fixes pkg/51713
Updated pkglint to 5.4.14.
Changes since 5.4.13:
* Pkglint can fix $(VARIABLES) in parentheses to ${VARIABLES} in braces
automatically
Updated pkglint to 5.4.13. Changes since 5.4.12: * Added check for unintended # comments, especially in HOMEPAGE * Added check for quotes in COMMENT * Fixed hardcoded package versions for PHP, Python, Lua, etc. * Code cleanup in the tests
Revbump Go packages after 1.7.4 update.
Updated pkglint to 5.4.12.
Changes since 5.4.11:
* warn when PKGSRC_COMPILER is compared with "==", since it may be a chain
of compilers
* warn about listing Python .egg-info files directly in PLIST files, since
lang/python/egg.mk takes care of this
* code cleanup: unify Error{0,1,2,3} into Errorf to make understanding the
code easier; use interface{} for MkLine data; use regular expression
instead of handwritten matching code, since one line is easier to read
than 50
Updated pkglint to 5.4.11.
Changes since 5.4.10:
* Replaced regular expression with hand-written matching code, since
it is 30 times as fast.
* Reduced number of syscalls by remembering os.Lstat results and
CVS/Entries.
* Reduced number of syscalls by querying the current user only once.
* Added warning for comparing ${PKGSRC_COMPILER} == "clang", which
should rather be ${PKGSRC_COMPILER:Mclang}.
* Added variable definitions for NOT_PAX_ASLR_SAFE and NOT_PAX_MPROTECT_SAFE.
Updated pkglint to 5.4.10.
Changes since 5.4.9:
* Check for mismatch between conditional and unconditional includes
of other files (mostly depending on PKG_OPTIONS or OPSYS)
* Check that PLIST files contain "man" instead of "${PKGMANDIR}"
Revbump packages depending on Go after the Go 1.7.3 update.
pkglint has hardcoded php55 referenced a couple times. That package was removedi and caused pkglint errors like: ERROR: ../../lang/php/ext.mk:25: Cannot read "./../../lang/php55/Makefile.common". So update to later php56. I don't understand why the ChecklinesDistinfo function in distinfo.go has an exception for the php patches directory but changed there too. I received an okay on packages@ list. Note that the make check for the pkglint package failed for me but the pkglint worked for me in my tests of some php using packages. Increase version of pkglint.
Updated pkglint to 5.4.9. Changes since 5.4.8: * Disallow lib/charset.alias in PLIST. This file may only be installed by converters/libiconv. (That package is currently broken, since it only touches that file when installing from source, not from a binary package. But pkglint is prepared for it to be fixed.)
Revbump all Go packages after the Go 1.7.1 update.
Updated pkglint to 5.4.8. Changes since 5.4.7: * Added cputime as an allowed keyword for UNLIMIT_RESOURCES.
Revbump packages using Go for Go 1.7 release.
Updated pkglint to 5.4.7.
Changes since 5.4.6:
* Allow conditionals of the form "${var1}" == "${var2}"
* Check for indentation of .include directives
* Check arbitrarily complex license conditions
* General code cleanup
Updated pkglint to 5.4.6. Changes since 5.4.5: * Fixed shell command parser to correctly parse redirections * Added type definitions for several variables * Allowed version numbers to be single digits
Updated pkglint to 5.4.5. Changes since 5.4.4: * Removed autofix for variables in BUILDLINK_TREE, since that change affects multiple variables in the file and therefore cannot be done automatically * Fixed PLIST sorting to not lose lines
Updated pkglint to 5.4.4. Changes since 5.4.3: * Improved detection for undocumented patches from Git * Added warning about unnecessary space after variable names * Lots of internal housekeeping
Updated pkglint to 5.4.3.
Changes since 5.4.2:
* Variables like ${VAR_${OTHER_VAR}} are no longer checked for
use/define mismatch
* The check for plural variable names has been removed
* The type of variables called *DESTDIR is no longer guessed to be a
directory name
* The check for unknown shell commands is disabled in Makefile
sections that depend on OPSYS
* The experimental hand-written shell parser has been replaced with
a Yacc-generated one
* Meta packages don't need a LICENSE
* When PKGNAME is defined in terms of ${DISTNAME:S/from/to/:tl}, more
modifiers (like :tl) are handled properly
* When the MAINTAINER or OWNER of a package is not the current user,
a warning is printed for modified files
* The check for share/applications/*.desktop has been disabled, since
pkglint would need to inspect the file's actual contents to see
whether desktopdb.mk must be included or not
* SUBST_CLASSES may also be SUBST_CLASSES.NetBSD
* Loosened the usage restrictions for several variables, e.g. many
variables that may be appended in a Makefile may also be set
unconditionally
* PKG_OPTIONS_VAR must be of the form PKG_OPTIONS.*
USE_CROSSBASE is deprecated, remove it. Bump version.
Updated pkglint to 5.4.1. Changes since 5.4.0: * PKG_SKIP_REASON is no longer marked as deprecated, since it still has its value * When PKG_SKIP_REASON is defined depending on OPSYS, suggest to use NOT_FOR_PLATFORM instead. * Check for ROOT_USER/ROOT_GROUP being used in special file permissions; using REAL_ROOT_USER/REAL_ROOT_GROUP is better.
Updated pkglint to 5.4.0.
Changes since 5.3.7:
* Replaced the -D... debug options with a single -d
* Omitted duplicate diagnostics
* Marked the :Q operator unnecessary for some variables
* Improved detection of whether bsd.prefs.mk has been included,
which fixed unwarranted warnings about load time evaluation of
some variables like ${ECHO} and ${SED}
* Improved detection for $(VAR) with round parentheses
* Fixed allowed locations for several variables
* Improved detection for used variables (still not perfect)
* Added warning that MASTER_SITES should not be used in HOMEPAGE
* Fixed warning about manual patches not being in distinfo
* Added a check for missing MASTER_SITE_* variables
* Added a check for unfinished url2pkg work
* Fixed several wrong warnings
USE_DESTDIR is gone.
Updated pkglint to 5.3.6.
Changes since 5.3.5:
* Warn about !empty(${VARNAME}), which should be !empty(VARNAME)
* Distinguish ${VARNAME} == "value" and ${VARNAME:Mpattern}
* Corrected isQuotingNecessary for some variable types
* Generally, parse files from mk/, since they define variables
used by packages. This avoids wrong warnings about possible
spelling mistakes.
* Warn about $(VARNAME) (with parentheses instead of braces)
* Warn about missing final @ in ${VAR:@var@...@}
* Updated list of hardware architectures
* Enabled CPU profiling on NetBSD
Revbump packages that build-depend on Go after 1.6 update. They all build, I checked :)
Updated pkglint to 5.3.5 Changes since 5.3.4: * Added parser for Makefile conditionals * Variables that are matched using the :M modifier are checked whether the matched value is sensible * Reworded and explained warning for variable ordering in packages * Fixed bug in Tree.String * Fixed a few variable types
Updated pkglint to 5.3.4 Changes since 5.3.3: * Added some unit tests * Fixed the Makefile parser to recognize seldomly-used variable modifiers like :S///S/// without intermediate colon or :ts\n * Cleaned up some unit tests * Combined diagnostics that span multiple lines into single-line ones
Updated pkglint to 5.3.3
Changes since 5.3.2:
* The -e, -fs, -F options are advertised even when no warnings and errors
occurred. In such a case, there were only notes, and some of these can
also be autofixed.
* Special handling for autoconf{,213} tools, since mentioning these in
USE_TOOLS makes available more than just one tool command.
* Downgrades from 1.0nb17 to 1.0 are no longer flagged as warnings.
* Files in /wip/mk/ are scanned like all other files, to prevent warnings
about undefined or unused variables.
Updated pkglint to 5.3.2 Changes since 5.3.1: Alignment of variable values is no longer checked by single line, but by the complete block (e.g. SUBST_*). Pkglint now checks that all variables belonging to a block are indented consistently, so that their values are aligned nicely. Since pkglint does not report warnings, but only notes, and since it can fix them automatically, the burden on the package developers will be very low. Especially, since these notes are only printed when pkglint is called with the -Wspace or -Wall options. Also, pkglint supports running its unit tests now.
Revbump all Go packages after the go-1.5.3 security update (hint: static linking).
Updated pkglint to 5.3.1 Changes since 5.3: * disabled CPU profiling on NetBSD, since it crashes without any output; see https://github.com/golang/go/issues/13914
Updated pkglint to 5.3
Changes since 5.2.2.2:
* Makefile variables
The warnings about missing permissions sound more natural than before
and give a hint for alternative operators (e.g. set-default instead
of append), or an alternative file where setting this variable is
allowed instead (e.g. PKGREVISION may not be set in Makefile.common,
but in Makefile it is ok).
Warnings about "unknown" allowed permissions are not shown anymore,
since they didn't provide any benefit. To see them again, pkglint must
be run with the -Dunchecked option.
User-defined variables may be used by builtin.mk. They may also be
used during load time, not only during run time, under the assumption
that in most cases the bsd.prefs.mk has already been loaded.
Some individual variables may be defined or used in places where this
was not allowed before. CHECK_BUILTIN.*, BUILDLINK_TARGETS,
TOOLS_DEPENDS.*, BUILDLINK_DEPMETHOD.*, SUBST_CLASSES.
A new parser for Makefile expressions detects and reports more
mistakes than bmake itself. Currently it is only used to check the
basic syntax; more applications are possible.
* PLIST
In PLIST files, conditionals of the form ${PLIST.*} are recognized and
are not part of the pathname. This allows pkglint to better check for
missing manual pages and correctly sorted PLIST files.
In --autofix mode, pkglint can sort PLIST files, which makes these
rather annoying warnings easy to fix.
No more warnings for man pages whose filename doesn't match exactly
the section, e.g. man/man3/exit.3c.
* Patches
The code for checking patch files has been completely rewritten, so
that it is easier understandable and well-structured. As an additional
benefit, it also became faster. Support for context diffs has been
dropped to a minimum, since they are not popular anymore.
Pkglint no longer warns about missing trailing whitespace in a line,
since all patch programs can handle these lines. It also doesn't
request empty lines between multiple diffs in a single file, since
that is simply not necessary.
Pkglint is picky when a patch file continues after the diff with some
text that still looks like a diff, since that means the patch doesn't
do what it looks like on first sight
(example: audio/faad2/patches/patch-au).
* Distinfo
When a patch file listed in distinfo cannot be found in the
filesystem, this is reported clearly instead of complaining about
missing SHA512 hashes (example: audio/libopus).
The inter-package distinfo check that verifies whether a distfile has
different hashes has been enabled. It had been disabled before, but
unintentionally so.
* Misc
- The check for COMMENT has been updated to reflect the changed
default value from url2pkg.
- BUILDLINK_API_DEPENDS.* may be set in buildlink3.mk, even if the
package is not the current one. (The other variables may be only set
for the current package.)
- In shell commands, the escape sequence \. (and similar ones, which
are often seen in sed(1) commands) no longer produces a warning,
since the different shells handle these escape sequences
consistently. (It is the echo(1) implementations that actually
differ, therefore this warning was superfluous.)
- Compiler flags in backticks (typically `pkg-config --cflags`) are
properly recognized.
- Internal pkglint errors when parsing shell commands have been fixed.
- No more warnings about PKGCONFIG_FILE.* being defined but unused.
- Dependencies of the form pkgbase>=1.0<5.0 are recognized.
- Diagnostics use quotes more often to indicate the placeholders.
- The type of GENERATE_PLIST has been changed from List of ShellWord
to ShellCommands, since that is what the variable is really about.
- The type ShellCommand used to mean "a shell command line in a
Makefile", which was confusing. Now it means what the name says,
which reduces the wrong warnings for variables like CC (example:
x11/kdebase3/options.mk).
- Improved buildlink3.mk checks to generate more helpful diagnostics.
- Fixed the parsing of dependency patterns, so that all but the most
exotic ones are properly recognized.
- Fixed the parsing of shell variables of the form ${var%.c}.
- Updated the check for the default COMMENT from url2pkg.
- Many more small improvements.
- Performance has improved again, though only a little bit.
- Unit test coverage has increased from 64.2 % to 78.9 %.
This fixes most of the points mentioned in PR pkg/46570.
Add Bitrig and MirBSD to the list of OSes.
Bump php default version to 55 to follow pkgsrc. Bump version.
Updated pkglint to 5.2.2. Changes since 5.2.1: * Fixed wrong error messages about "Unknown Makefile line format"
Updated pkglint to 5.2.1. Changes since 5.2: * Fixed wrong warning about patches/CVS being an unrecorded patch * pkgsrc-wip also needs NetBSD as RCS Id, instead of Id * Code cleanup: grouped the checklineMk functions into one file
Updated pkglint to 5.2. Changes since 5.1: * Fixed distinfo check for unrecorded patch files (thanks, wiz) * Command line options parser accepts abbreviations (--a instead of --autofix) * Realistic unit tests using temporary files * General code cleanup (using gometalinter)
Updated pkglint to 5.1.
Changes since 5.0:
* Fixed --autofix mode (it hadn't been enabled before)
* The --autofix mode now advertises itself when it can do something
* The --autofix mode now adds missing empty lines to patch files
(only in the leading text section, not in the actual patch content)
* Made --autofix code simpler ({prepend,append}{Before,After} was not
really needed)
* Fixed unit tests to report invalid command lines
* Added some more unit tests
Explicitly added conflict with pkglint4
Updated pkglint to 5.0 Notable changes include: * The whole code has been rewritten in Go * It is much faster, especially in recursive mode * The code has unit tests, providing examples of use * Some new explanations for existing warnings * Some adjustments to previous warnings
Updated pkglint to 4.158 This mainly fixes wrong patch detection when checking distinfo.
Bump version for recent fixes.
Update pkglint to 4.156 - "8" is also a valid USE_JAVA2 value
Fix some perl-5.22 warnings. Bump version.
Recursive PKGREVISION bump for all packages mentioning 'perl', having a PKGNAME of p5-*, or depending such a package, for perl-5.22.0.
Add BOOTSTRAP_PKG and USE_GCC_RUNTIME variables to makevars. Patch from Olivier Duclos on tech-pkg. Bump package version.
Removed the comment about updating the version from the Makefile I had used the pkglint_current tag in the past to summarize the changes whenever I bumped the version number. In the last 7 years, this hasn't been done, so there seems to be no need for it.
Fixed a wrong warning for the HOMEPAGE variable
WARN: Makefile:9: Please use ${MASTER_SITE_GITHUB:=glmark2/glmark2}
instead of "https://github.com/glmark2/glmark2".
This warning is wrong because HOMEPAGE is neither a plural variable nor
does it contain a "fetch URL".
To fix this, there is a new data type FetchURL, which has one more check
than the existing data type URL, namely the MASTER_SITES abbreviation.
The existing definitions in makevars.map have been updated accordingly
to the appropriate data types.
Note: This patch is not perfect, since ideally only variables of type
"List of FetchURL" should be suggested to be replaced with MASTER_SITES,
but since currently all these variables are actually "List of FetchURL"
and not simply "FetchURL", this should be fine.
Add GITHUB_*. Bump version.
Allow https in sites.mk. Bump version.
Add BROKEN_ON_PLATFORM and BROKEN_EXCEPT_ON_PLATFORM and bump version.
Don't complain about exact (non-range, non-wildcard) dependencies. Now that mail/qmail-run "looks fine", replace it with another of my errant packages as a test case. Bump version.
Add emacs25, xemacs21[45]nox for makevars.map Thanks wiz@ for OK. I don't believe we need emacs25nox ;-(
Remove pkgviews: don't set PKG_INSTALLATION_TYPES in Makefiles.
Bump version.
Allow '+' in another place checking for package names. Needed e.g. for gtk2+. Bump version.
Add PYTHON_VERSIONED_DEPENDENCIES. Bump version.
Add LIBTOOL_REQD. Bump version.
Sync mysql version list with reality. From John Nemeth. Bump version.
pkglint-4.142: Remove apache13 and apache2 values.
pkglint-4.141: PAM_ACCEPTED and PAM_TYPE are gone
Remove giflib/libungif special cases. Bump version.
Bump version instead of PKGREVISION. Noted by Wen Heping.
Bump for perl-5.20.0. Do it for all packages that * mention perl, or * have a directory name starting with p5-*, or * depend on a package starting with p5- like last time, for 5.18, where this didn't lead to complaints. Let me know if you have any this time.
Add REPLACE_LUA. Bump version.
Bump PKGREVISION to refrect recent changes.
No need to define fake DISTNAME and empty MASTER_SITES and DISTFILES now. Just define PKGNAME and use it.
dd REPLACE_CSH. Bump version.
pkglint now warns about broken dependencies like >=x.y.* Version->4.135
Skip :build and :run from tools to recognize 'perl:run' etc. Allow https in one more place. Bump version.
pkglint is written in perl; it should depend on perl and not just some perl modules. (fix USE_TOOLS to have perl:run instead of just perl)
- Added check for unused license files - Improved allowed filenames for patches - Added license for pkglint itself - Cleaned up Makefile and TODO
Use CATMAN_SECTION_SUFFIX in packages which perform their own catman page installation.
Recognize apache24. Noted by Patrick Welche. Bump version.
Bump version for deprecated USE_GNU_READLINE.
Bump all packages for perl-5.18, that a) refer 'perl' in their Makefile, or b) have a directory name of p5-*, or c) have any dependency on any p5-* package Like last time, where this caused no complaints.
rillig clarified: "u" means "use at runtime", i.e. the variable may not be available during preprocessing. "t" wasn't used at all (my error -- wiz) Bump version.
pkglint-4.129
* explain when desktop-file-utils is required.
* error missing {hicolor,gnome}-icon-theme.
Respond to wiz's code review: * In test, match the "make makesum" warning more loosely. * In test, find packages to run against in $PKGSRCDIR explicitly. * Bump version. This is the last commit in a set developed for my "Rehabilitating pkglint" talk at pkgsrcCon 2013. Reviewed-at-pkgsrcCon-and-approved-during-the-freeze-by: wiz
Bag-compare all vartypes_basictypes, not just two. pkglint greps itself (really) to generate this list of types. Test exhaustively for all types in the list today, so that the tested code can become more civilized tomorrow. Adds a test-time dependency on Test::Deep for cmp_bag().
Subst paths for both test and install.
In the configure stage, tell pkglint to find *.map in ${FILESDIR}.
That lets tests run even when pkglint isn't installed (which means
it also makes the tests less wrong when pkglint is installed!).
In the install stage, tell pkglint to find *.map under ${PREFIX},
as before (no functional change to the installed package).
Specify USE_TOOLS=perl to quell pkglint. :-)
Extract PkgLint::* to files, then inline them. These bits of non-main functionality are distracting to the casual reader, and also to your intrepid refactorer. Since we recently added some characterization tests that run the pkglint executable against real packages, we can safely extract bits of code to separate files and prove nothing broke in the move. Instead of installing the new Perl modules where pkglint can find them at runtime, I've added a build step to inline them right back where they used to be (same order and everything). This is a little annoying, but less annoying than suddenly needing to deal with Perl runtime paths just for these few tiny modules. Also, loading modules at runtime would affect pkglint's performance, and I don't yet have performance tests to prove that this would be fine (or not), so I can't safely do it. No functional change intended.
Make it possible to easily write automated tests: * minimally adapt pkglint(1) into a "modulino" for testability * verify it still runs normally as a program * create a test script with a few very simple test cases * hook it up to 'make test' * verify that the tests really fail if I go breaking the code under test Meta-addresses PR pkg/46570. New BUILD_DEPENDS, but no functional change, so no PKGREVISION bump. Approved by wiz@.
Update to 4.127
* Add sun-{jre,jdk}7 support
Add openjdk7 & openjdk7-bin to other JVM lists
Bump version for python25 removal changes.
Bump all packages that use perl, or depend on a p5-* package, or are called p5-*. I hope that's all of them.
Update documentation for {PYTHON,RUBY,PHP}_VERSION_REQD variables, move them
to "user variables" section. pkglint is now aware of them. Bump pkglint
version. Oked by wiz@
Do not warn about setting PKG_DESTDIR_SUPPORT any longer, it is now set by default by the infrastructure. Remove highly obsolete TODO entry about destdir. Bump version.
"user-destdir" is default these days
Improve expand_permission some more. Should fix the Use of uninitialized value in concatenation (.) or string at /usr/pkg/bin/pkglint line 4777. warnings. Bump version.
If I get to fix the bugs, I might as well OWN it.
Recognize make syntax (make variable) in one more place.
Don't enforce purely aesthetic changes.
Recognize emacs24nox; bump version.
Really bump version for comment-missing-error change.
pkgtools/pkglint: Add "ada" as valid value for USE_LANGUAGES The mk/compiler/gcc.mk was recently updated to handle USE_LANGUAGES+= ada which requires the use of the lang/gcc-aux compiler.
Update to 4.117: Recognize another possible permission. Reported by Bug Hunting.
Two more bugfixes, version++
Bump version again for more fixes.
Do not parse Makefiles in files/ or patches/ Addresses another part of PR 46570 by David Holland. Bump version.
Bump version again for more games fixes.
Allow "." in package names (needed e.g. for gst-plugins0.10-base). Check package patterns in DEPENDS. Requested by diro in PR 46570. Bump version.
Update to 4.111.
adjust to current default php/python srcdir.
Do not treat variable GNU_PROGRAM_PREFIX as a special one. Dump version.
Pullup ticket #3724 - requested by sbd pkgtools/pkglint: option syntax fix Revisions pulled up: - pkgtools/pkglint/Makefile 1.400 - pkgtools/pkglint/files/pkglint.pl 1.832 ------------------------------------------------------------------- Module Name: pkgsrc Committed By: sbd Date: Sun Apr 8 04:42:39 UTC 2012 Modified Files: pkgsrc/pkgtools/pkglint: Makefile pkgsrc/pkgtools/pkglint/files: pkglint.pl Log Message: Update the pattern used for checking option name to allow the plus (+) character (e.g. as in "c++") Bump version number. To generate a diff of this commit: cvs rdiff -u -r1.399 -r1.400 pkgsrc/pkgtools/pkglint/Makefile cvs rdiff -u -r1.831 -r1.832 pkgsrc/pkgtools/pkglint/files/pkglint.pl
Update the pattern used for checking option name to allow the plus (+) character (e.g. as in "c++") Bump version number.
Add missing clang, hp and pcc to ONLY_FOR_COMPILER. Dump package version.
Reset maintainer, he resigned.
Add openjdk7* to recognized java versions. From B.ICT A.P. deBROUWER Jr. in PR 45789. Bump version.
Bump version for NOT_FOR_COMPILER improvement.
Update to 4.104 * Allow value "6" and "7" in USE_JAVA2.
Avoid use of qw as parentheses. Silences a warning with perl-5.14. Bump version to 4.103.
Update "pkglint" package to version 4.102. Changes since version 4.101:
Allow "@" as a character for directories in "${WRKSRC}". This stop bogus
warnings for the "phpmyadmin" package which contains directory names
like "locale/sr@latin/LC_MESSAGES".
Change suggested by Thomas Klausner in private e-mail.
Recognize PY_PATCHLIST and add py27 and py31 to python versions. Welcome to pkglint-4.101!
Support for variable SUPERSEDES Bump version
Warn that one should NOT use jpeg, giflib, or libungif directly, but go through
mk/{jpeg,giflib}.buildlink3.mk instead. Bump version.
fix. pkglint doesn't treat files ending with .mk under patches/ directory as Makefiles. Version bumped. Oked by wiz@
Make a missing LICENSE an error. Be more permissive wrt what characters are allowed in patch file names. Bump version to 4.97.
Allow emacs24, emacs23 and emacs23nox to EMACS_VERSIONS_ACCEPTED and EMACS_VERSION_REQD.
Allow fortran77 in USE_LANGUAGES.
Put LICENSE into MAINTAINER section, where other documentation puts it. Bump version.
Updated pkglint to 4.93. Changes since 4.92: - Changes for the changing pkgsrc infrastructure - Added basic support for LICENSE expressions
Bump version simply because it hasn't been bumped for some time and many changes have been made in the meantime. These way people will know that there are updates that don't give bogus warnings.
Don't prevent others from increasing the version number, since I don't follow recent pkgsrc developments as carefully as necessary.
Remove redundant NO_CHECKSUM and EXTRACT_ONLY definitions.
Updated pkglint to 4.91. Important changes since 4.90: - Fixed some issues with "package has been downgraded" warnings. - The doc/CHANGES-* files can be checked individually now. - Emit a warning if a package does not define PKG_DESTDIR_SUPPORT. - In patch files, warnings about absolute pathnames, CPP macros and the like are only emitted if the line starts with a "+". If the -Wextra option is given, the context lines (starting with a " ") are also checked. - Added support for the new buildlink3.mk format.
Updated pkglint to 4.90. Changes since 4.89: - Packages are checked whether they are being downgraded. - Several small fixes and improvements.
Updated pkglint to 4.89. Changes since 4.88: - Fixed the remaining PLIST_VARS warnings. - Adjusted pkglint to work together with Perl 5.10.0.
Updated pkglint to 4.88. Changes since 4.87: - Added support for PLIST_VARS and PLIST.*, which had been added in April. That's a long time ago ...
Fixed two pkglint warnings.
Update to 4.87: - Add explanation for "Unquoted shell variable" warning. Patch by rillig.
update pkglint to 4.86 - necessary bu not sufficient to handle OWNER in Makefiles. As a first pass make MAINTAINER optional and add an optional OWNER directly after it in the same section. This will pass valid OWNER/MAINTAINER combinations but not reject some invalid ones. Full fix (hopefully) coming soon...
Updated pkglint to 4.85. Changes since 4.84: - Fixed the splitting of PKGNAME into PKGBASE and PKGVERSION. - Added a warning about usage of LOCALBASE in packages, provided by jlam.
Updated pkglint to 4.84. Changes since 4.82: - Whenever a Makefile.common is included by another file, that file should be mentioned in the Makefile.common. - Added spell checker for .if directives. - Added warnings for uncommented patches (only for -Wstyle). - Added spell checker for invalid macro names, like __NetBSD_Version. - Deprecated INSTALLATION_DIRS_FROM_PLIST in favor of AUTO_MKDIRS. - Many more small things.
I don't want others to update the pkglint version number.
Add to explanation for empty PLIST: not needed for meta packages.
Updated pkglint to 4.82. Changes since 4.81: - Moved lintpkgsrc to its own package. - Less internal errors when parsing shell code. - White-space checks in PLIST.
Updated pkglint to 4.81. Changes since 4.80: - Stricter CVS Id check - REQD_FILES_PERMS, META_PACKAGE, PKGSRC_COMPILER - Warning if info pages are installed into share/info.
Updated pkglint to 4.80.
Important changes since 4.79:
- Fixed some internal errors.
- Adjusted pkglint to changes in the pkgsrc infrastructure: SUBST_VARS.*,
PKG_USERS_VARS, PKG_GROUPS_VARS.
- Improved the parser for shell code.
- Cleaned up the handling of the :Q operator, so that pkglint warns about
it places where it is not required.
- ${RUN} has deprecated ${_PKG_SILENT}${_PKG_DEBUG}.
Removed USE_TOOLS+=perl:run, since Perl is not used as a tool, only as a dependency which is included automatically by the various Perl modules. I wonder why the PERL5 variable is still defined without perl being in USE_TOOLS.
fix obsolete URLs for www.NetBSD.org close PR pkg/37071 reviewd by xtraeme@
Honour the setting of MANINSTALL.
xorg-dirs is gone. Bump to 4.79.
Update pkglint to 4.78: - lintpkgsrc.pl - less brokenly parse the contents of make conditionals like "if empty(FOO)". Specifically handle the case where FOO contains a :M modifier or a variable expansion. Fixes 'lintpkgsrc -r' incorrectly deleting ruby18-base-1.8.6nb1 each time Mmm... lintpkgsrc.pl needs to die
Update to 4.77. (hi Roland!) Teach pkglint about OSF1 and HPUX.
Before using any variables in .if conditionaly, bsd.prefs.mk should be included. In the special case of the BATCH variable, this does not make a difference, since it is set via an environment variable.
INSTALLATION_DIRS_FROM_PLIST is more comfortable than specifying INSTALLATION_DIRS explicitly. It also removes some redundancy.
pkglint-4.76; teach emacs22{,nox}.
Oops, I forgot to add the dependency to p5-enum. That makes pkglint go to version 4.75.
No substitutions are needed for the pkglint manual page. Re-added a post-install selftest to detect syntax errors in pkglint.pl.
PostgreSQL-7.4 support is about to be removed.
DESTDIR support.
Add PKG_DESTDIR_SUPPORT to variable list. Bump to 4.73.
Update to 4.72: check for .tbz as well as .tgz
Update pkgtools/pkglint to 4.71 - lintpkgsrc changes:
- Handle 'badly named' patch files
- In the event of a distint checksum mismatch, report the affected file
as well as package
- If we need to call out to make to parse a makefile and it returns any
errors, ensure we prefix the error output with the Makefile path
- run through perltidy. Ugly, but consistent
De-recognise XFree86. Update to 4.70.
Updated pkglint to 4.69. Changes since 4.68: - Improved the checks for BUILD_DEFS. - Improved the shell word parser. - Improved the heuristics for detecting absolute pathnames. - The :M* operator is only required with GNU configure scripts. Committed during the freeze to have a unique version number that includes the features from the last days.
Updated pkglint to 4.68.
Changes since 4.67:
- Adjusted to the ongoing changes in the pkgsrc infrastructure.
- Many small improvements in the makevars.map file.
- Stricter checking of dependency patterns, to catch foo-*.
- Small improvement on the use of stack space due to complicated regular
expressions.
- Many more absolute pathnames are found in patch files, no matter which
type of file is patched.
- All user-defined variables that are used should be added to BUILD_DEFS.
- All packages that set GNU_CONFIGURE are assumed to need a C compiler.
- Instead of ${TOOL}, tool may be used directly, since the tool wrappers
are installed very early in the build process.
- Removed the --debug option.
... and many more.
Updated pkglint to 4.67. Changes since 4.66: - Fixed the stack overflow in Perl in long variable assignment lines. - Improved the SUBST check. - For all files in bin/ and sbin/, pkglint now complains if the package does not have a manual page, too. (Only with -Wextra) - Lists of pathnames may be used in .for loops, since they are _assumed_ to not contain any additional white-space. - Some more small improvements.
In URLs, the "NetBSD" should be capitalized as such, i.e. "NetBSD.org", not "netbsd.org".
Updated pkglint to 4.66.
This change includes all the things I thought of during the freeze of
2006Q2.
Some variables have disappeared from pkgsrc without notice. Marked them
deprecated to help the package authors at least a bit.
Renamed some ACL abbreviations in makevars.map and adjusted the variable
definitions.
Added the command line options -Dtrace, -Dunchecked and -Dunused.
Some variables may contain unexpected white-space and therefore should
not be used in .for loops.
The -Dmisc option replaces the --verbose option (and the log_info
subroutine), which does not exist any longer. This eliminates all
instances of "OK:" from the output, which I didn't like from the
beginning. The -Dmisc option also takes over many warnings that have
been issued by --debug before.
Improved the check for absolute pathnames. Especially, everything that
follows ${DESTDIR} or $(DESTDIR) in a Makefile is considered an absolute
pathname. This reveals many wrong uses of DESTDIR (as defined by the GNU
coding standards), for example $(DESTDIR)/$(prefix), which should be
$(DESTDIR)$(prefix) instead.
Almost every use of a make(1) variable is checked for spelling mistakes.
Before, only the definitions of variables have been checked.
Restricted the use of variables to specific files, which are defined in
makevars.map. This catches especially buildlink3.mk files with
unexpected side effects.
In shell commands, neither "echo" nor "echo -n" or "${ECHO} -n" should
be used. Since the INSTALL_*_DIR commands can only handle one directory
at a time, suggest to use INSTALLATION_DIRS instead.
Greatly improved the checks for dependency specifications, especially to
find foo-*, which should rather be foo-[0-9]*.
Fixed the incorrect handling of LICENSE_FILE (now using $line->text
instead of $line).
Improved the wording of the "plural names" warnings, so that for known
variables it is "The += operator should only be used with lists." now.
In buildlink3.mk files the uppercase and lowercase names of the package
should correspond with the package name. This catches many
copy-and-paste mistakes. Fixed many null pointer exceptions as well. In
addition, every buildlink3.mk file needs a definition of
BUILDLINK_API_DEPENDS.
In patch files, absolute pathnames and unportable macro names are
checked not only in added lines, but also in the context lines.
In the pkgsrc root directory and the category directories, the Makefiles
are checked like every other Makefile, too.
Fixed the place where the global variables for the package context are
defined and later undefined.
Variables that are mentioned in EVAL_PREFIX may be used in the current
file and are not flagged as "used but not defined".
When parsing shell words in Makefiles, recognize $<, $@, $^ and $/.
(The latter is used extensively by openoffice to represent a directory
separator.)
Fixed some minor bugs:
* $makevar had been defined unintentionally by using the -> operator.
Updated pkglint to 4.65. Changes since 4.64: - Many refinements of quoting checks and variable type definitions. - Improved the wording of diagnostics and added some explanations. - Adjusted pkglint to the many recent changes in the infrastructure part. - Improved detection of absolute pathnames. Updated during the freeze because the version number has not changed for two weeks, but many features were added. Therefore the old version number was not reliable for determining the real functionality of pkglint exactly.
I prefer #none over #empty in USE_LANGUAGES.
Updated pkglint to 4.64. Changes since 4.63: - Many diagnostics for the :Q operator have been wrong. They are currently left out, but will be re-added later. In the mean time, no diagnostics are better than wrong ones. - Made defining the permissions for variables easier by providing a way to define "permission constants".
Updated pkglint to 4.63. Changes since 4.62: - Improved checking of variable permissions. - Improved detection of unused variables, for spell checking. - Added warnings for variables that are used at load time but should not. - Much code cleanup.
Updated pkglint to 4.62. Changes since 4.61: - Bug fixes.
Updated pkglint to 4.61. Changes since 4.60: - Added ACL-based checks that restrict the files which may define variables. - Many, many small improvements.
clean up after doing a quick-install.
Updated pkglint to 4.60. Changes since 4.59: - For many variables the :Q operator is not needed (by definition), for example some pathnames, user names, group names. - Improved the diagnostics for planned package updates. - Various catch-ups to recent changes in the infrastructure, among them BUILDLINK_ABI_DEPENDS and gettext.mk. - When the PLIST contains a libtool archive, the *.a and *.so files don't have to be mentioned explicitly.
Removed superfluous :Q operators.
Updated pkglint to 4.59. Changes since 4.58: - Improved checking of patch files. - Adjusted the variable names to the recent pkgsrc changes. - Print a note if the pkglint version does not match the one from the checked pkgsrc tree.
Updated pkglint to 4.58. Changes since 4.57: - New parser for patch files. - New command line options -Wplist-depr and -Wstyle. - Variable assignments are no longer allowed in variables that should only contain identifiers. - builtin.mk files must not be included directly. - Better checks for sed commands. - Some commands like ktrace should never appear in Makefiles. - The package version is compared to the requested update in file doc/TODO.
Fixed pkglint warnings.
Added sed quotes
Fixed pkglint warnings.
PKGMANDIR instead of "man". (When do I use PKGMANDIR:Q or no :Q??)
Updated pkglint to 4.57. Changes since 4.56: - Added warnings for variables that are defined, but not used. This is a simple spell-checker. - Variables that appear as a single shell word should be quoted unless they have the type "List of something". - Many small enhancements.
Updated pkglint to 4.56.
Changes since 4.55:
- Avoided false positive warnings about bsd.prefs.mk being required before
using buildlink3.mk files.
- Restricted the files that are checked for absolute pathnames in patch
files.
- Some tools that are often used as ${TOOLNAME} need to be explicitly
added to the USE_TOOLS variable. When complaning about their direct
use, add a proper advice.
- Readded all the deprecated variables. The warnings will have to stay
longer than just three months.
Updated pkglint to 4.55. Changes since 4.54: - -Wvarorder works now as expected. - distinfo files are checked more strictly. - Reduced the number of false positives. - Make(1) variables of the form $(...) are detected properly.
Even in quick-install mode, the self test should be run.
Added a ``quick-install'' target that allows me to install pkglint in three seconds instead of 40.
Updated pkglint to 4.54. Changes since 4.53: - Added about 50 new variables to be type-checked. - For unknown variables, the type is guessed from the variable name. - In patch files that patch Makefiles, added lines are checked for absolute pathnames. - Replaced the -Wdebug option with --debug, so that the debugging warnings don't show up when using -Wall. - Many minor improvements.
Updated pkglint to 4.53. Changes since 4.52: - New warning categories "debug", "space", "quoting" that can be selected independently. - Improved the parsers for shell commands and shell words. - Added warning for using $(...) in shell programs, as the Solaris /bin/sh doesn't support it. - Added some warnings about quoting. - Some other minor changes.
- Added plist-clash.pl to the list of files that have @PERL@ replaced.
Updated pkglint to 4.52. Changes since 4.51: - The occurence of a symlink other than work* inside the pkgsrc tree is not an error, just a warning. - SUBST_MESSAGE should not be quoted. - If -Wextra is enabled, all make variables that are used in shell commands are checked for proper quoting. - Improved the parser for shell commands. - Some other minor changes.
Fixed the simple part of the pkglint -Wall warnings.
Updated pkglint to 4.51. Welcome to the Fahrenheit release. Changes since 4.50: - Extended the quoting checks for make variables to shell commands. - Added a check for unquoted shell variables (only with -Wextra). - Some other minor changes.
Updated pkglint to 4.50. Changes since 4.49: - Added checks for shell commands whose exitcodes are ignored. - Added checks for CFLAGS, CPPFLAGS and CXXFLAGS. - Improved diagnostics. - Various bugfixes. Changes to lintpkgsrc: - Avoided double occurrence of pkg_install.
lintpkgsrc needs pkgtools/digest, so readd it to the DEPENDS.
Updated pkglint to 4.49.
Changes since 4.48:
- Added a check for .include lines in all Makefiles and *.mk files to make
sure that only existant files are referenced and that pkgsrc packages do
not contain references to packages in pkgsrc-wip.
- Extended the --autofix option to all Makefile* and *.mk files. Before, only the
package Makefile could be fixed.
- Rewrote the detection of direct use of tool names.
- Append-only lists may be initialized using the "?=" operator.
- The typical form of ShellWords for CONFIGURE_ARGS, --foo=${FOODIR}, is checked for
quoting errors.
- All PKG_OPTIONs are checked whether they are documented in mk/defaults/\
options.description.
- Many small fixes and improvements.
Adjusted the version number to the one that has been announced. (4.49 => 4.48.)
Updated pkglint to 4.48. Changes since 4.47: - Output warnings for partial RCS tags in patch files. - Added many warnings concerning Makefile directives and make targets.
Updated pkglint to 4.47. Changes since 4.46: - Made the --explain command line option work. - Added many explanations for existing diagnostics. - Improved the diagnostics. - In --autofix mode, no backup files are created anymore. - Temporarily disabled the check for direct use of tool names. - Fixed some false positive warnings. - Added a check for the use of absolute pathnames in shell commands.
Updated pkglint to 4.46.3.
- Added the $line->replace() method for a convenient way to achieve simple
autofix tasks.
- When autofixing, no backup file is created (it had been created before).
1. Usually "cvs diff" is available.
2. All current autofixed changes are trivial.
3. The fixed file is first written to disk in a new file and then renamed
to the original file, greatly reducing the risk of data loss.
- Fixed a bug in checkdir_package(): In the call to load_package_Makefile(),
the last parameter had not been passed by reference, but by value.
Luckily this had not influenced any other part of pkglint.
- While there, I noticed that it is not necessary to pass some subroutines
the lines of all included Makefiles, so I removed that parameter.
Updated pkglint to 4.36.2. - Improved diagnostics for URLs that are not strictly pkgsrc-compliant, as requested on tech-pkg.
Updated pkglint to 4.46.1. - Marked ALLFILES as deprecated. - Degraded white-space warnings to notes. - Added many explanations for the diagnostics.
Updated pkglint to 4.46. Changes since 4.45: - Added the type ShellWord. - Added quoting checks for variables that are appended to a List of ShellWord. - Multiple -v increase the verbosity. - The --autofix option is no longer undocumented, but still experimental, as this is the only part of pkglint that can modify external files. - Added an --explain option that provides additional help for the diagnostics. - Added checks for unportable CPP macro names in patches. - Updated the documentation.
Updated pkglint to 4.45.3. - Added detection of redirection operators and comments to the regex_shellword constant. - Changed the naming conventions for list data types. Now List simply means a list. List+ means a list that should only be modified using "+=", not "=". List! means an internal list. And List!+ is the combination of both. The distinction is necessary because of the introduction of redirection operators in the regex_shellword. When checking the data type of list elements, the lists are split up into shell words instead of simply using split(). This leads to much better results. - When splitting a variable value or shell command into words, anchor the regular expression at the beginning of the string.
Updated pkglint to 4.45.2. - Removed log_subinfo(). - Added log_debug(). - Multiple -v command line options increase the verbosity. - Added the regex_shellword constant that will allow better parsing of shell commands. Currently it is only producing debugging information. - Long [info] messages have been changed to [debug] messages.
Updated pkglint to 4.45.1.
- Added a new type ShellWord that is used for MAKE_ENV and the like to
check for invalid FOO="${VALUE}" additions. They really should be
FOO=${VALUE:Q}, as they may already contain embedded quotes. This is
especially important for CPPFLAGS and CFLAGS.
Updated pkglint to 4.45.
- Fixed perl -T warnings:
- Replaced $#{@{$lines}} with $#{$lines}.
- Avoided calls to external programs (sed and digest).
- Removed redundant warning if DISTNAME is set to an invalid package name
and PKGNAME is not defined.
- Changed dependency from pkgtools/digest to security/p5-Digest-SHA1.
Updated pkglint to 4.44. Changes since 4.43: - Removed the remaining code that had been imported from FreeBSD's portlint. - Removed the (undocumented) -Wvague option. - Removed the -Wexec and -Wparen options. The latter had no effect at all, and the former cannot lead to false positives, so it is always enabled. - Variable names starting with an underscore are reserved for internal pkgsrc use. - Added some more type checks.
Updated pkglint to 4.43.2. - Renamed the type Dependency to DependencyWithPath. - Added new types Dependency, PlatformTuple and RelativePkgDir. - Added some of the common variables to the list of typed variables.
Updated lintpkgsrc to 4.43.1.
- In BATCH mode, that is for the bulk builds, hardcode PKGSRCDIR as
/usr/pkgsrc. Otherwise take ${PKGSRCDIR}.
Oops, covered the tracks from last-minute tests.
Updated pkglint to 4.43. Changes since 4.42: - Reduced the number of duplicate diagnostics when checking multiple files. Only diagnostics concerning the current package are printed. - Added checks for EXTRACT_SUFX and PKG_INSTALLATION_TYPES. - Added a work-around for the PHP patches warnings. - PERL5_PACKLIST should not contain references to other variables. - Added the -s|--source command line option to show the code along with the diagnostics. - Fixed a bug in get_logical_line(); logical lines have not had their physical lines attached. - Deprecated variables are not only checked when they are defined but also when they are used.
Updated pkglint to 4.42.2.
- Added a check that PERL5_PACKLIST does not contain references to other
variables. Some packages have ${PERL5_SITEARCH} in it, which results in
a double slash, and the CHECK_FILES framework cannot handle this.
Updated pkglint to 4.42.1. Added a work-around for the warnings from PHP modules when including lang/php/ext.mk.
Don't hide errors in the post-install stage.
MANINSTALL is a user-settable variable and thus must not be defined by the package Makefile.
Updated pkglint to 4.42.
Changes since 4.41:
- In .mk files, line continuations are properly handled.
- An open bracket is allowed in variable and tool names.
- Added checks for ALTERNATIVES and INSTALL/DEINSTALL files.
- By default, don't check files in ${FILESDIR}.
- Warn about unknown file and directory names.
Updated pkglint to 4.41. - Documented the --recursive option. - Added an option -Cmk for checking .mk files besides buildlink3.mk. - pkglint can handle individual files on the command line, not only packages. (experimental) - Replaced checkfile_buildlink3_mk() with checkfile_mk(). - Factored out the checkfile() subroutine from checkdir_package().
The exitcode from running pkglint in the post-install target is ignored, since the pkglint Makefile sets MANINSTALL but shouldn't, as this variable is intended to be user-defined. This is only a work-around, which needs to be addressed properly for the other packages setting MANINSTALL, too.
Updated pkglint to 4.40.
- Removed all references to the build-time pkgsrc directory, ${PKGSRCDIR}.
This makes the binary package independent of the build location.
Fixes PR 32006.
Updated pkglint to 4.39. Changes since 4.38: - Disabled the check on Makefile variable order, as the discussion on tech-pkg has not finished yet. - Improved detection of valid tool names. - Improved detection of direct use of tool names. (Less false positives.) - Improved the diagnostics for direct use of tool names.
Updated pkglint to 4.38.4. - Improved detection of valid tool names. - In the post-install target, output does to stderr instead of stdout.
Removed the -l command line option from lintpkgsrc(1). Use "pkglint -r" instead.
Updated pkglint to 4.38.2. - pkglint(1) does not use the hard-coded PKGSRCDIR anymore. This fix is related to PR 32006, but doesn't fix it, since the PR is about lintpkgsrc(1), not pkglint(1).
Updated pkglint to 4.38.1. - It is an error if packages define a variable whose name starts with an underscore. - Removed the (vague) "wip" check, as it has been replaced by special checks for DEPENDS and .include directives. - Disabled the check for variable ordering until the discussion on tech-pkg has led to any results.
Updated pkglint to 4.38. - PKGNAME is checked for being a valid package name. - PLIST files should not contain filenames that match */CVS/*. - Completely rewrote the check for variable ordering. The new code operates on a data structure that's easily understandable and extendable (see the source for an example). It also generates greatly improved diagnostics. As the old code had been enabled only when checking with -Wvague or -Wall, it has been seldom used anyway.
Updated pkglint to 4.37.2. - Removed the hard-coded values for valid tool names. The detection is good enough. - Make sure that the domain part NetBSD.org is written like this in mail addresses.
Updated pkglint to 4.37.1. - Improved detection of valid tool names.
Updated pkglint to 4.37.
- Added checks for TOOL_* variables.
- Added {pre,do,post}-extract to the list of valid stages.
- Fixed the regular expression for detecting tool names.
- Added a check for invalid syntax in tool names.
- Improved the diagnostic for enumerations.
Updated pkglint to 4.36.1. - Added many of the variables found in pkgsrc/mk/* to makevars.map. - Added the function log_fatal, whose output goes to stderr instead of stdout. - All files in pkgsrc/mk/ are excluded from checking, as they may use private variables and do other questionable things. - Removed the Language type, as it is a simple enumeration. - Added the Userdefined type to distinguish user-definable and read-only variables.
Updated pkglint to 4.36. Implemented checking for enumeration types. Added new types Filemask, Filename, Language, Option, Pathmask, Pathname, Stage, Varname and WrksrcSubdirectory. Made the check for URLs stricter. Added some variables to the makevars.map file.
I knew there had been a program that uses the (now removed) -Wno-workdir option. I just didn't think it was pkglint itself. :) Thanks to Martti for notifying me about that.
Updated pkglint to 4.35. Removed the -Wworkdir option. Added an --import option that replaces -Wworkdir. Changed the warning about uncleaned work* directories into an error. Updated the man page.
Updated pkglint to 4.34. Fixed the --autofix handling of category Makefiles. Added an --import option that helps importing packages from pkgsrc-wip. When checked with --import, the package is checked as if it weren't part of pkgsrc-wip.
Updated pkglint to 4.33.1.
Fixed undefined behavior when reading a file that ends in a continuation
line. Any use of ${WRKSRC}/.. is considered an error, as ${WRKSRC} is
meant to point to the top of the build directories. A proper combination
of WRKSRC, CONFIGURE_DIRS and BUILD_DIRS should be used instead. Sorted
the makevars.map file and added SUBST_CLASSES.
Updated pkglint to 4.33. Changes since 4.32.2: - Added checks for CATEGORIES. - Modernized checks for DEPENDS and BUILD_DEPENDS. - Simplified PLIST directive checks.
Updated pkglint to 4.32.2. Added a check for invalid uses of MASTER_SITE_* variables.
Updated pkglint to 4.32.1. Added type check for USE_TOOLS. Fixed false warning about direct use of tools in comments.
Updated pkglint to 4.32. The --autofix support has been rewritten to be more easily usable. Automatic fixes are currently restricted to the sort order of SUBDIR entries in category Makefiles. It had been the complete category Makefile before. Added a new diagnostic, prefixed with "NOTE:", that is used for important informational diagnostics, for example autofixed files.
Updated pkglint to 4.31.2. Added the expected and actual checksums to the diagnostics if they differ for patches.
When checking Makefiles, get rid of the "physical" lines as soon as possible and base all other checks on the logical lines. The physical source lines are saved literally to make implementing the --autofix option easier.
Updated pkglint to 4.31. Changed the names of the datatypes (Yes_Or_Undefined => Yes, Boolean => YesNo, Integer => PkgRevision) in makevars.map. It is now an error if PKGREVISION appears outside a package Makefile. Improved detection of Makefile.common. Improved wording of the warning for relative directories in the form ../package.
Updated pkglint to 4.30. Rewrote the typechecking code for Makefile variables. The variable definitions are extracted from logical lines instead of physical lines, comments are separated from actual values, for Lists of something, each something is checked. All URLs are subject to MASTER_SITES expansion. MASTER_SITES is checked to be a List of URLs.
Updated pkglint to 4.29.1. Added CONFLICT to the list of deprecated variables (actually it's a typo). Added PLIST_SUBST to makevars.map as a List. Allow comments after a YES/yes/NO/no value of variables.
Updated pkglint to 4.29. Fixed the detection of list variables that are modified with operators other than "+=". Added *_SKIP to the list of plural variable names. Removed some unused variables from main(). (This change include white-space changes.)
Updated pkglint to 4.28.2. Added a data type Readonly for variables that must not be given any value at all by the package Makefile. Marked PKGBASE and PKGVERSION read-only, because leaving them read-write would make the way PKGNAME is calculated too complex. Made the check for the "+=" operator independent of the data type. Added more patterns for accepted variable names for lists.
Updated pkglint to 4.28.1. Declared some more variables as List types. Added a check that PERL5_PACKLIST matches the PKGNAME.
Updated pkglint to 4.28. Added support to typecheck "List of Something" in Makefile variables. DEPENDS and BUILD_DEPENDS are of type List of Dependency, CFLAGS are simply a List.
Updated pkglint to 4.27.
Added a warning that ${PKGNAME} and ${PKGVERSION} should not be used in
some other variables, as they may contain the PKGREVISION.
Updated pkglint to 4.26. Improved the wording of two diagnostics. Added a check for SUBST_STAGE.
Updated pkglint to 4.25.
Improved heuristics for packages that use some common Makefiles,
reducing the number of false diagnostics in -Wvague mode. Moved checks
for SVR4_PKGNAME out of -Wvague mode. Added check for misspelled
NO_{SRC,BIN}_ON_{FTP,CDROM}.
Updated pkglint to 4.24. Warn if option names contain underscore characters (suggested by dillo). NO_TOOLS and NO_WRAPPER are deprecated, as they are not used anymore.
Removed unused NO_TOOLS.
Updated pkglint to 4.23.2. The use of "# defined" as variable value in Makefiles is deprecated. It has too weak semantics, compared to "# none", "# empty" or "yes".
Updated pkglint to 4.23.1. BUILD_USES_MSGFMT should always be set to YES/yes or left undefined. When checking for direct use of tools, respect shell commands.
Updated to pkglint-4.23. Added the -R command line option to allow more RCS Id tags than $NetBSD$ to appear in line 1 of almost every file. Suggested by dillo.
Updated pkglint to 4.22. A distfile that only has an SHA1 checksum, but not an RMD160 one, is considered an error. While at it, made the distinfo file check a little stricter.
Updated pkglint to 4.21.5. Insist that PKGREVISION should be an integer or be undefined at all.
Updated pkglint to 4.21.4. The last change introduced some false positive diagnostics. If a distinfo file contains the checksum for a patch that does not exist, this is not considered to be an error, but only a warning, as the additional checksums do not influence the package.
Updated pkglint to 4.21.3. Fixed false positive errors for PHP packages.
Updated pkglint to 4.21.2. Changed the file name pattern for patch files to avoid false positives for DISTFILES that start with "patch-" (requested by salo). Added a warning for invalid patch file names.
The diagnostics for the COMMENT variable checks include the location and are therefore enabled by default. Requested by wiz. Set the version to 4.21.1.
This is pkglint-4.21. Changes since 4.20 include: - In the diagnostics, FATAL is replaced with ERROR. - The command line option -g changes the format of the diagnostics to be similar to the one of gcc. - Removed false warnings when checking if PLISTS are ordered. - Removed the check for contiguous blank lines. - Added a check to PLISTs that man pages are not installed in share/man. - pkglint -r allows to recursively check directories. - The pkgsrc root directory can be checked. - Removed false warnings for patches that contain "---" lines. - Switched to checking logical lines instead of physical lines. Diagnostics for logical lines contain the range of physical lines instead of a single line number. - Some ../.. path components are stripped from the diagnostics. - When checking for the direct use of tool names, only the context of the use, not the whole shell command is output. - Patches that contain RCS Ids should not have the -ko CVS mode anymore. - Variables that are modified using the "+=" operator are considered to be lists, so they should have a name indicating a plural.
This is pkglint-4.20. Changes since 4.19 include: - Very much code cleanup - Introduction of the --autofix flag for category Makefiles - Rewrite of the code to check the DISTNAME section in package Makefiles - Rewrite of the code to check category Makefiles
Run a quick self-test after installation.
Allow PATCH_DIST_CAT in the PATCH_SITES section. Bump version to 4.19.
Drop support for TOOLS_DEPMETHOD.<tool>. The new way to specify a run-time dependency (DEPENDS) on a tool is to append a ":run" modifier to the tool name, e.g., USE_TOOLS+= perl:run Tools without modifiers or with an explicit ":build" modifier will cause build dependencies (BUILD_DEPENDS) on those tools to be added. This makes the notation a bit more compact.
Don't use reserved variable names (${_f_} => ${f}).
Don't warn on empty scripts/ directories, which may occur during CVS updates. Don't write logging messages for Makefiles that are being read but for Makefiles that are included and for those whose inclusion is skipped. Skip include files that contain Make variables. When checking for direct use of shell commands, don't print the line continuation, that is the trailing white-space and backslash. These changes lead to pkglint-4.18.
pkglint complains about empty DESCR files again. Fixes PR 30509. Updated version number to 4.17.1.
Made perl a run-time dependency.
Converted USE_PERL5 into USE_TOOLS. Changed the SUBST stage to post-configure. Removed DISTVER variable.
Bugfix release for lintpkgsrc. Now I know why some packages use
${.CURDIR} when including other Makefiles. This is no longer necessary.
Welcome to 4.17.
Fixed man page handling on platforms that don't have the mandoc macros. Together will all the other changes of the last days, this makes up version 4.16. Most changes affected the elimination of false warnings.
4.15.1: Fix PLIST (hi Roland!).
Removed the check for absolute filenames, as it has produced too many false positive warnings. Added a reminder to TODO that a similar check be added to pkglint. Welcome to 4.15.
Added a command line option to disable warnings on unsorted things like PLISTs and SUBDIRs in category Makefiles. The default behavior is unchanged. Updated the man pages. Bumped PKGREVISION.
The TOOLS phase is not needed for pkglint.
Refer doc/pkgsrc.html instead of Packages.txt (HOMEPAGE variable).
Swapped out the definition of deprecated variables to an external file. Welcome to 4.13. Approved by wiz.
Remove NO_BUILDLINK from makevars.map -- no-op now, but changed the package, so number this 4.12.1.
Took over maintainership. Suggested and approved by wiz.
Remove USE_BUILDLINK3 and NO_BUILDLINK; these are no longer used.
Remove USE_BUILDLINK3 support, and deprecate the name instead. 4.12.
Update to 4.11: Remove references to PLIST-mi, and substitute check for PLIST.common instead. Fixes pkg/29848 by me. Approved by wiz.
Update pkglint to 4.10: Fix variable usage when checking distinfo Size values, and more than one package references the same distinfo file with different sizes.
update pkglint to 4.09: Handle ! in .if conditionals, plus move slightly closer to the real 'make's behaviour when using defined() and empty(). Should fix pkg/28346
Minor wording changes. Fixed a bug. (The string "$line->text" does not call the method text() on $line, so I had to get the method call out of the string quotes. Approved by jlam.
4.07: Use correct variable in workdir-cleanup warning.
Claim maintainership.
Sign over maintainership to tech-pkg@
Included the location of the warning or error in the messages for everything except Makefiles. (Makefiles which will follow soon.) This makes most warnings more useful. Together with the last few changes, we are now at version 4.06. Approved by wiz.
pkgtools/pkglint: Added checks for proper quoting of shell variables ($ vs. $$). Welcome to 4.05. Approved by wiz.
Make file(1) happy about plist-clash.pl. Fixes PR#29366 by Akio OBATA. Welcome to version 4.04.
Pkglint now checks that the file entries in PLIST files are correctly sorted. Welcome to 4.03.
Added type checking for Makefile variables. The typechecking is experimental and has been announced on tech-pkg to make the package developers aware of it.
Fixed bug in checkline_trailing_whitespace. No warnings were emitted before. Stripped non-leading "." path components in the log messages. Welcome to 4.01.
Another fix for python and ruby packages, this time for installed ones. Standardize the prefix so they can be compared with the packages more easily (pkg_chk is better at this anyway, but since I fixed the other cases already...). Welcome to 4.00!
Update to 3.99: Fix lintpkgsrc handling of python and ruby packages. Remove invalid-dewey test that broke more things than it helped. Add support for "pre" in version strings. Update comment about recognised strings.
3.98: Teach pkglint about BUILD_TARGET, and let it warn about ALL_TARGET.
Report trailing slash of the package directory part of *_DEPENDS specification as a fatal error as this greatly confuses mk/scripts/mkdatabase. Update to version 3.97.
Ignore use of words which when used in make shell commands should
be used in variable-expansion version, e.g. `test' vs `${TEST}' in
settings of TEST_TARGET and ALL_TARGET. Gets rid of warning about
"test" in TEST_TARGET setting from lang/perl5/module.mk.
Bump package version.
Reviewed by wiz.
Test if pkgname is defined before using it; gets rid of some warnings: Use of uninitialized value in pattern match (m//) at /usr/pkg/bin/lintpkgsrc line 747. Patch from Nicolas Joly in PR 27875.
Add - and . to characters allowed in patch names. Welcome to 3.94.
Update to 3.93, from Roland Illig: - Renamed PORTSDIR to PKGSRCDIR - Added warning option -Wno-workdir - Fixed some places where absolute and relative pathnames had been used incorrectly. Clean up Makefile.
Update to 3.92: Include each .include'd file only once. Solves the 'Out of memory!' problem for big packages, and avoids repeated warnings about problems coming from bl3 or Makefile.common files. From Roland Illig in private mail.
* Make PKGSRC_TOPDIR a private variable by renaming it to _PKGSRC_TOPDIR,
as it's only used internally by bsd.prefs.mk.
* Make _PKGSRCDIR a public variable by renaming it to PKGSRCDIR.
Also, generate its value from ${_PKGSRC_TOPDIR} so it's less fragile
than the old method of stripping off the last two components of
${.CURDIR}. PKGSRCDIR may now be used after bsd.prefs.mk is defined.
* Change all references to _PKGSRCDIR to PKGSRCDIR.
3.91: - added options for enabling/disabling specific checks - added options for enabling/disabling specific warnings - improved the --help message and corresponding man page updates. From Roland Illig with slight fixes by me.
Update to version 3.90. Lintpkgsrc package version comparison bug fix. When comparing two version numbers vector the shorter one needs to be extended with 0. Cf. src/usr.sbin/pkg_install/lib/str.c:vtest(). Previously lintpkgsrc considered that 'png-1.2.6', which version vector is [1,0,2,0,6], is "less" than 'png-1.2.6rc1', which version vector is [1,0,2,0,6,-1,1]. No wonder lintpksrc -V considered the package png-1.2.6 being vulnerable wrt the 'png<1.2.6rc1' entry in pkg-vulnerabilities files. While here teach lintpkgsrc about the 'alpha' and 'beta' version elements.
Apply two patches from Roland Illig: First two chunks of diff: Fix for perl-5.6.1; addresses PR 26718. Remainder: - made $category a local variable of checkfile_Makefile - redefined the meaning of the return value of the check_* subs (siehe Zeile 37 des Patches) Welcome to 3.89.
Update to 3.88: Fix some bugs wrt MESSAGE and PLIST checking. From Roland Illig in private mail.
agc says we do not want binary mode files in the pkgsrc repository, so let's not suggest using -ko. Welcome to 3.87.
Code cleanup, by Roland Illig. More to come. Bump to 3.86.
Look for buildlink3 instead of 2, and complain about USE_BUILDLINK2 being set. Welcome to 3.85!
Update pkglint 3.84
Parse Make .{if,endif,else,elif,include} directives which
contain a space between the . and the directive. Fix an include
path issue which this threw up. Now 'lintpkgsrc -d' correctly
extracts the PKGNAMEs for the gcc3 packages.
It still doesn't understand 'dewey' versions with alpha chars, or
some of the more interesting makefile constructs, but it looks closer
to reality.
Update pkglint to 3.83. Changes:
- made the program compile with "use strict"
- completely rewrote some subs to make the code more readable
- converted the global ("local") variables into local ("my") ones ;-)
- limited the scope of variables where possible
- added file and line number to the error messages where possible
Patch contributed by Roland Illig in private mail.
Update to 3.82, committing yesterday's changes from Roland Illig. Changes: - Handle a rarely used patch format correctly - Do not output superflouus linebreaks anymore - Check the contents of the COMMENT field only if it exists - Handle invalid dependency specifications correctly - Correctly handle Makefile variables ordering - Output complete filename of absolute filenames - Added a new scheme for loading text files into memory so that the location of an error or warning can be given exactly (file + line) to the user. - Refactored the checkfile_patches_patch subprogram to use the new text file processing and to make clearer what is checked.
Update pkglint to 3.81
- Rework undefined variable handling. Fixes issue introduces in 3.80
- Never run a pkg_info in pkgdistdir. Avoids a serious misfeature of
pkg_info whereby it looks for a package in the current directory
by default.
Update pkglint to 3.80. Changes to lintpkgsrc.
- Append appropriate dirs to path - should fix pkg/23534
- Undefined variables evaluate to blank not UNDEFINED - should fix pkg/24475
- Handle ${C and ${S constructs that use separators other than /
- Slightly more debugging
- die if uname fails
Update to pkglint 3.79
== functional changes ==
- prints the various "OK: ..." messages only when called with "-v".
- prints a summary after pkgsrc category checks
- fixed a bug for commented category entries (in line 1718)
- removed the option "-q". It has become unnecessary
== refactoring ==
- more consistent naming scheme for variables and functions
- replaced some "local" with "my" when possible
- clustered the variables that are processed by the ${SED} commands
- provided function prototypes for argument checking
- replaced the old perror by log_{error,warning,info}.
- Avoided the (implicit or explicit) use of $_ in many places
Patch contributed by Roland Illig via private mail.
Commit patch from PR 25222 by Roland Illig: * use strict mode (already found one error... hi wiz!) * add -q (quiet) flag * Identifie if patch files don't patch any or more than one file
Warn if a file is marked executable. Welcome to 3.77.
It's misleading to have uninstalled rc.d scripts in ${FILESDIR}
marked executable just because they were inadvertently committed
that way; they need to be processed by the install machinery in
order to work.
Since we set desired permissions at install time, it's generally
best to avoid having "executable" files in pkgsrc (with the notable
exception of pkglocate, which runs in place).
For files not yet committed, please correct the permissions before
committing. For files already in the repository, you'll need help
from an administrator.
Back out changes made in 3.75, it's too slow for lintpkgsrc. Make it 3.76.
Welcome to 3.75. Use real value of PKGNAME, suppress bogus warnings when PKGNAME is created from altering DISTNAME with make modifiers (e.g., S or C).
The existence of the kde-i18n-sr@Latn pkg makes it clear that _pkg also needs escapement treatment so that the eval doesn't barf. Since _ver is the only thing left, do that one, too. This makes 3.74.
Resurrect do-extract target, following atatat's advice. This way, sources are extracted first as any other package, allowing for local patches.
pkglint now reports if sees etc/rc.d in Makefile or PLIST.
Should use RCD_SCRIPTS mechanism (which can automatically
install to ${RCD_SCRIPTS_EXAMPLEDIR}) which automatically
registers the rc.d script(s) in the PLIST.
New version is 3.73.
Update to version 3.72.
Use more portable Cwd::cwd() instead of $ENV{'PWD'}
Update to 3.71: print a fatal error if there are any direct dependencies to the -dirs packages. Suggest usage of USE_DIRS instead.
Update to 3.70: give errors if the package installs documenation files under PREFIX/doc or if it registers configuration files in PREFIX/etc (because it does not honour PKG_SYSCONFDIR properly).
Check for pkgsrc-wip remnants. Welcome to 3.69.
Add pre-formatted catman pages, so we don't rely on the OPSYS providing nroff, nor do we need to depend on textproc/groff. Regen .0 pages under SunOS and AIX as for audit-packages.
Improve pattern matching for possible RCS Ids to always check for a terminating dollar sign. Welcome to 3.68.
USE_LANGUAGES= # empty
update to pkglint 3.67: catch deprecated USE_GMAKE.
Move WRKSRC definition away from the first paragraph in a Makefile.
Fix for pkgviews. From Min Sik Kim in PR 24042.
bl3ify
Update to 3.66: warn if MAINTAINER contains @netbsd.org instead of @NetBSD.org.
Teach lintpkgsrc how to handle empty() conditionals. Closes second part of PR 23126. Welcome to 3.65!.
fix handling of DISTDIR. patch from Sebastian Prause on tech-pkg. bump to 3.64.
Update pkglint to 3.63:
perl 5.6.1 realpath() cannot handle files, only directories.
Handle this case, with the only downside that if the last component in
an include path is a symlink the 'performance boost' duplicate check
may not work. Reported by Todd Vierling
Update pkglint to 3.62:
lintpkgsrc - handle the buildlink include fest:
- Using realpath() to fix exclude of duplicate includes speeds
up 'lintpkgsrc -rp' on a PIII-500 from 40 minutes to 3
- Excluding buildlink[^/]*.mk files unless -d is specified further
speeds up to just under 1 minute
Make lintpkgsrc handle .includes correctly. Welcome to 3.61.
Update to 3.60: adapt for vulnerability file name change.
Update pkglint to 3.59 - handle bsd.pkg.mk's assumption that the caller is in pkgsrc/some/dir
Update to version 3.58. Teach pkglint about new rules related to info files handling. - remove old checks of PLIST related to install-info. - emit a FATAL error for "@exec install-info" and similar in PLIST. - emit a FATAL error for inclusion of texinfo.mk.
Check if HOMEPAGE URL has a trailing slash if it only consists of a hostname. From Ben Collver in PR 22215. Bump to 3.57.
s/netbsd.org/NetBSD.org/
Updated pkglint to 3.56: - COMMENTs should start with a capital letter.
Update pkglint to 3.55:
- In lintpkgsrc check for invalid PKGREVISION, and handle PKGREVISION=0
Remove "country code" check -- a remnant from FreeBSD times. Update to 3.54.
Add some code to the "stored database" to deal with counting packages that have multiple versions (eg, apache or emacs), so that the number of packages loaded when generating the database will match the number loaded from the database afterwards. Curiously, reorganizing the code a little makes the stored database about 20-25% smaller. Old stored databases are still completely supported. Jump to version 3.53.
3.52: Fix last in case the file exists (doh).
3.51: Yell if .included files do not exist.
Update pkglint to 3.50. This version does a (slightly) better job at Makefile variable parsing and lets "VARNAME=" override "VARNAME?=" definitions. This should also fix the current bogus warnings about distinfo in the weekly pkgsrc output.
Update to 3.49: make sure WRKSRC is properly placed in the second section, the one starting by DISTNAME (if present). Ok'ed by wiz.
Update to 3.48: Avoid including the same buildlink2 files over and over and over and over again. Among others, this makes pkglint work again for x11/gnomepanel.
Fill in default values for DESTDIR (empty), LOCALBASE ("/usr/pkg"),
and X11BASE ("/usr/X11R6"), which, while they might not be right for
*every* system, are certainly more right than UNDEFINED.
Give lang/python/pyversion.mk a little help by stuffing the material
from PYTHON_VERSIONS_ACCEPTED into the two places it expects it (since
lintpkgsrc doesn't do .for loops), add support for the ${FOO:S/foo/&/}
construction, and tweak the .if handling for && and || bits.
This has the following effect on the -g output (as a simple measure):
% grep -c UNDEFINED before after
before:58
after:1
Jump to 3.47.
Update pkglint to 3.46
Check MAKE_ENV and similar variables which contain ${ use :Q or are quoted
Add a simple "extract" step so that local patches can be maintained easily. This only affects the build process, so PKGREVISION is not bumped.
Update to 3.45: Accept commented out SUBDIRS in category Makefiles, if a comment with a reason is given.
Add -E and -I to lintpkgsrc for the "exporting" and "importing" of a "database" that lintpkgsrc can use in lieu of scanning all the pkgsrc Makefiles. This has several nice effects, chiefly: (1) Using any of -B, -O, -R, -S, -V, -d, -g, -i, -p, or -u, are now *much* faster since reading the "database" takes at most 3 seconds on my laptop, whereas reading all the Makefiles takes at least 3 minutes. (2) One can now check for out-of-date packages on machines which do not have an expanded pkgsrc tree simply by copying the "database" over. Note that the database will inherently have some dependencies on the environment of machine where it is generated (eg, mk.conf settings, architecture type, etc). Reviewed by the wiz.
Update pkglint to 3.43. Check for hard coded share/locale and lib/locale within PLIST.
Update pkglint to 3.42: * Add a PKGLOCALEDIR check to pkglint: warn if PKGLOCALEDIR is in PLIST, USE_BUILDLINK2 is set, and USE_PKGLOCALEDIR is not set.
Update to 3.41: - replace occurrences of "make" with @MAKE@ - add @MAKE@ to the list of variables to get sod (I never learned properly how to conjugate "sed") - warn about NO_PATCH, since it hinders more than it helps - remove NO_PATCH from Makefile to quell new pkglint warning
In the case that we really can't determine the PKGNAME properly, just punt and invoke "make show-vars VARNAMES=PKGNAME" and get make to tell us. This addresses the issue of: Cannot extract digest-UNDEFINED version (/usr/pkgsrc/pkgtools/digest/Makefile) Cannot extract pkg_install-UNDEFINED version (/usr/pkgsrc/pkgtools/pkg_install/Makefile) Unknown package: 'digest' version 20010807 Unknown package: 'pkg_install' version 20021123 Patch reviewed by the wiz.
3.39: note that IGNORE is deprecated in favor of PKG_{FAIL,SKIP}_REASON.
Nudged by wiz@, who sees all.
Update to 3.38: Complete handling of category/Makefile; now compares list of SUBDIRS against list of directories and complains about mismatches.
Any "digest" newer than 2001 is acceptable. This allows the "digest" installed by bootstrap-pkgsrc to satisfy the dependency requirement.
Only avoid checking mk/bsd*, not all files from mk/. Bump to 3.37.
Upgrade to 3.36. Fixes the problem with $pkg_installver being "uninitialized" for some cases. Approved by the wiz.
Slight fix for 3.34, so that "cd /usr/pkgsrc; for i in */; do pkglint $i; done" works. Bump to 3.35.
Update to 3.34: Can now also be run in Category directories and checks correct sorting order of SUBDIR entries.
Since MESSAGE files come by many names, hardwire the line length, independent of the actual filename. Update to 3.33.
lintpkgsrc was tweaked, so bump the version
3.31: Check MESSAGE file format. Patch from sco at openface ca in pkg/18276.
Merge changes from HEAD of pkgsrc/pkgtools to buildlink2 branch.
Strip leading './' from distinfo entry names before matching against the file system -- removes bogus warnings for at least opera and ymessenger, which have "DIST_SUBDIR=.". Bump to 3.30.
Updated pkglint to 3.29 Make -V work without -p, -O, or -R Fixes pkg/17558 from Dan McMahill
3.28: Note that USE_SSL is deprecated.
3.27: Warn about missing RCS Id in distinfo, and note that IS_INTERACTIVE is deprecated.
Merge from pkgsrc-current to buildlink2 branch.
Update to 3.26. Changes: . sync dewey support with pkg_info . fix 'elsif' handling (fixes bogus ns-flash warnings)
Recognize ${INSTALL_INFO} in PLISTs as install-info.
Bump to 3.25.
Update to 3.24: Report downlevel pkg_install version, too (in -i mode). Requested by gendalia and agc.
Update pkglint to 3.23: Correct inverted logic for DYNAMIC_MASTER_SITES check
Update pkglint to 3.22
Handle DYNAMIC_MASTER_SITES
Updated pkglint to 3.21
- lintpkgsrc - fixed -p to handle relative symlinks and symlink loops
Update pkglint to 3.20
lintpkgsrc - if we find one valid match in a DEPENDS entry, don't
bitch about any others expanding to a non-existant package:
Example: postgresql-{6.5.3*,7.0*,lib-*}
With this lintpkgsrc -d now outputs six lines on current pkgsrc.
Note to self: When you use 'cvs c^[P' the second time in an
evening for the same package... its enough.
Update pkglint to 3.19
lintpkgsrc.pl:
Finally we parse {x,y,z} constructs in DEPENDS, plus handle a
few more make conditionals. Now most of the lintpkgsrc -d output
is related to versions of software no longer in pkgsrc...
Does the fun ever start?
Update pkglint to 3.18:
Significant rototill of lintpkgsrc.pl, converting to a rather twisted
hierarchy of PkgVer Pkgs and PkgList objects with assorted arbitrary
methods, all based on existing usage rather than ideal design.
Actual fixes found along the way:
- Handle := in makefiles
- Better handle parenthesis and "" in make conditionals
- parse bsd.pkg.mk to extract _REQD values (hence the previous line)
- Add missing 'key' in hash iteration
- Do not repeat includes (evolution longer depends on jpeg 45 times)
Still have to handle such delightful constructs as
DEPENDS += {qt2-designer>=2.2.4,qt2-designer-kde>=2.3.1nb1} in a sane way
Making lintpkgsrc more usable, part 2. Reduces warnings from 'lintpkgsrc -d' from ~700 lines to ~100. [It won't get much better than this...]
Modify all references to PKGSRCDIR to _PKGSRCDIR, except in the external references of the pkglint package. _PKGSRCDIR is an internal definition in bsd.pkg.mk, and a few packages which would like to refer to other packages in the build tree. It should not be set by users, but neither should it stop a user from building a package if it is defined, so make it obvious that this is the case.
Handle PKGREVISION more properly, by allowing it being set, but empty. Bump to 3.16.
Update pkglint to 3.15
- lintpkgsrc: Set BSD_PKG_MK, and ensure .CURDIR is correct when running
with -D. Also remove an articulated lorry load of single quotes.
Many thanks to wiz who added PKGREVISION before I lamely managed to get
around to it :)
Make lintpkgsrc support PKGREVISION, in response to pkg/14767. Bump to 3.14 (next version 3.141? ;)
Teach pkglint about PKGREVISION (not complaining about it). TODO: warn about PKGNAME= ...nbX
Bump version to 3.12 for check of "nb" on DISTNAME
Bump to 3.11: warn about scripts/* and pkg/* dirs and contents
Bump version. Changed lintpkgsrc.pl to parse patchfiles in the distinfo files using the same patterns bsd.pkg.mk uses when building the file (via make patchsum)
o don't echo pkg/COMMENT, use $pkgdir/COMMENT instead o fit in 80 columns o s,pkg/DESCR,DESCR, and the same with PLIST in comments OK'd by wiz
If pkg/ doesn't exist, use ./, just like bsd.pkg.mk does nowadays. Requested by zuntum. Bump to 3.09.
NO_WRKSUBDIR is deprecated, while USE_LIBTOOL isn't anymore. Version now 3.08.
Deprecate NO_WRKSUBDIR, replacing it with an explicit assignment of:
WRKSRC= ${WRKDIR}
This is much cleaner, much more indicative of what happens, and removes
another of the negative definitions (NO_.* = value).
'file' should be replaced by '${FILE_CMD}' now.
Bump to 3.07.
Warn about some more directly used commands we now have ${CMD} for.
[cmp, dirname, sort, wc]
Update to 3.05: pkglint support for SVR4_PKGNAME, as requested by Bernd Ernesti.
add -O option to lintpkgsrc to report packages which have the OSVERSION_SPECIFIC flag set. bump version to 3.04
Update pkglint to 3.03: Fix incorrect ' at start of line in lintpkgsrc manpage. Fixes PR pkg/13354 by Ben Wong
Update pkglint to 3.02: Also check 'size' when crosschecking for checksum mismatches.
Update pkglint to 3.01: Correct wrong var usage in lintpkgsrc 'checksum mismatch' report.
If you install pkglint/lintpkgsrc from a binary pkg, make sure that digest is installed too (-> explicit DEPENDS).
Remove lots of dead and FreeBSD-specific code. Some slight improvements while I'm here. That's worth a new major: 3.00.
Warn about deprecated DIGEST_FILE and PATCH_SUM_FILE. Bump to 2.57.
Another day, another pkglint version.
lintpkgsrc:
If a binary package matches more than one vulnerability, only report once.
Ensure LINTPKGSRC is set when parsing mk.conf
Update pkglint to 2.55 Fix lintpkgsrc to correctly parse packages containing '+', from PR 12996 by Wolfgang Rupprecht
Updated pkglint to 2.54 - for lintpkgsrc fix case of PKGSRCDIR not set in environment, mk.conf, or command line.
Update pkglint to 2.53 Extend 'lintpkgsrc -u' to list REQUIRED entries for mismatched packages, handle PACKAGES?=xxx in mk.conf
Update pkglint to 2.52: Handle empty variable settings 'VAR=' in lintpkgsrc, to match recent postgresql package Makefiles
Warn on finding USE_PERL (not USE_PERL5), and on DEPENDS with continuation lines. Bump to 2.51.
Update pkglint to 2.50 Implement pkglint -V which displays pkglint version (Useful for ftp.netbsd.org automated checks)
Update pkglint to 2.49 lintpkgsrc now handles '/1' suffix in make S:x:y: expressions
Look for deprecated md5/patch-sum files in correct dir. Bump to 2.48.
Undo part of previous, since it doesn't work as expected. Bump to 2.47.
Use the same pattern for matching patch files as in bsd.pkg.mk. Fixes a bogus warning for at least devel/patch.
DISTINFO_FILE, not DIGEST_FILE; fixes some 'missing distinfo file' warnings. Bump to 2.45.
Update pkglint to 2.44 to match distinfo enhancements to pkgsrc by agc
Teach pkglint about BUILD_USES_MSGFMT, and where it recommend using it.
BUILD_USES_MSGFMT is expected in the DEPENDs block now.
Also recognize ${PKGSRCDIR} in DIGEST_FILE.
Bump version to 2.43.
Update pkglint to 2.42 - teach lintpkgsrc about digest, including handling the same distfile used by different packages with different checksum methods.
Update to 2.41:
lintpkgsrc - when parsing ${VAR:S/x/y/} type constructs in Makefiles,
handle separators other than '/'.
Update pkglint to 2.40.
Now handles the digests other than md5. Expands variables in ${PKGNAME};
doesn't check Makefile comments or COMMENTs for use of reserved words;
and some minor cleanup. (Removes ~100 bogus warnings from lintpkgsrc -l).
Bump to 1.39: Catch a few cases where MKDIR/INSTALL -d can be replaced by INSTALL_*_DIR
Add length check for COMMENT. Bump to 2.38.
Update to new COMMENT style: COMMENT var in Makefile instead of pkg/COMMENT.
Change COMMENT handling: COMMENTs are now a variable in the Makefile instead of a pkg/COMMENT file. The COMMENT var should be in the maintainer block after the homepage. Modify bsd.pkg.mk, pkglint, url2pkg, and port2pkg (last one untested) for the new behaviour. Document new state in Packages.txt. This should save lots of inodes, and lots of time when untarring/updating. Idea by Alistair Crooks. For the time being, accept pkg/COMMENT instead of a COMMENT var to avoid a flag day.
Update to pkglint-2.36 On pre NetBSD-1.4 fall back to 'sysctl -n hw.machine_arch' for MACHINE_ARCH
Update to 2.35: Note deprecated LIBTOOL_OVERRIDE.
Use "FILE" instead of "file" as variable name to avoid a "pkglint" warning here.
Use "nroff -man" on Solaris for the moment so that this package builds at least.
Update pkglint to 2.34.
Changes to lintpkgsrc:
Fix DEPENDS error (was only checking first DEPENDS). Fix from Dan.
Fix uname to work on pre NetBSD 1.4 systems.
Update HOMEPAGE.
MIRROR_DISTFILE is deprecated; add tests for that and NO_{BIN,SRC}_ON_FTP
instead. Bump to 2.33.
pkglint: Recognize a different name for the main sunsite, and two sourceforge URLs. Bump to 2.32.
Update to pkglint-2.31 lintpkgsrc changes: Add '-S' - List packages not in category 'SUBDIRS', rename experimental '-S' to '-c'. Rework -h output to group by type. Fix poblem with handling certain glob expressions for depends, clean up manpage.
Add -B option to lintpkgsrc, to display broken packages. Update to 2.30
Update to 2.29 lintpkgsrc - Add '-S' to optionally generate pkgsrcmap file mapping pkgname to pkgdir and version
Update pkglint to 2.28 - Add '-V' to lintpkgsrc - check binary packages against /pkgsrc/distfiles/vulnerabilities.
Update to 2.27
lintpkgsrc: Remove over enthusiastic setting of {'PKGSRCDIR'} = '/usr/pkgsrc';
Update to 2.26 lintpkgsrc: Allow setting of any variable in mk.conf, including PACKAGES containing PKGSRCDIR.
Update pkglint to 2.25. If this keeps on I'm going to have to start using odd numbers for 'development' versions... lintpkgsrc: Rename set_pkgsrcdir to parse_mk_conf, and also extract PACKAGES as well as PKGSRCDIR. Update check_prebuilt_packages to handle the new package data structure that allos mulitple versions of the same package to be valid (for -current packages etc) - Missed in previous changes.
Update pkglint to 2.24:
lintpkgsrc tried to break DEPENDS up into a packagename and version
section, so if the version did not match it could lookup the matching
packages and suggest valid versions. Unfortunately this excessive
helpfulness meant globs that cover both sides such as
'perl-{5.0*,5.6.0nb2,base-5.[6-9]*}' gave it a certain degree of
indigestion. It also didn't handle the '.if ${BINNAME} != common'
correctly in www/ns-plugger-common/Makefile.
I believe now that any outstanding -i or -d warnings are genuine...
pkglint: lintpkgsrc - fix :S modifier behaviour - broken in last commit
lintpkgsrc:
Rework substitution handling to correctly deal with
${DISTNAME:S/-/-gnome-/:S/$/nb1/} and friends. I remember being
in something of a hurry when that code was fist written. Slight
cleanup to not completely blow up on DEPENDS such as
perl-{5.0*,5.6.0nb2,base-5.[6-9]*}, though we still do not
handle globbing that includes packagename and version.
Update to 2.22
lintpkgsrc: Clean up makefile variable parsing and use to extract PKGSRCDIR from /etc/mk.conf - now will understand .include and other make'isms in mk.conf Update to 2.21
Some cleanup; warning and error messages slightly improved. Major changes: .include lines are honoured now, and FILESDIR, PATCHESDIR, PKGDIR, SCRIPTSDIR, MD5_FILE, and PATCH_SUM_FILE aren't hardcoded anymore, but the corresponding Makefile variables are used. Adapt lintpkgsrc to the changes. Step to 2.20 to mark the occasion. Reviewed by hubertf.
Update to 2.16: make the actions of the switches -a, -b and -c on by default now, to get EVERYTHING checked by default. Suggested by Kimmo Suominen <kim@netbsd.org>
Avoid (harmless) uninitialised variable warnings in the even of a package not having any discernable version. Update to 2.15
Teach lintpkgsrc a little more about variable expansions. Update version to 2.14
Update lintpkgsrc -R to check for NO_BIN_ON_FTP or RESTRICTED Now 2.13
Bump version of pkglint to 2.12. (Forgot to include this in previous commit.)
Deal with depends dirs properly, esp. if pkglinted is not started in a pkg dir. Noted in PR 10584 by Damon Brodie <damon@brodiefamily.org> Bump version to 2.11.
Update to 2.10. Change: FATAL warnings for empty pkg/COMMENT and pkg/DESCR.
Update pkglint to 2.09. Adds a check for deprecated USE_PKGLIBTOOL.
- add "-M path" option to allow specifying a distfiles directory to handle cases where PKGSRC/distfiles isn't the correct location (like on ftp.netbsd.org). - document the option. - bump minor version number.
In the event of multiple non current versions of a package being found, take the one iwth the highest number as 'best'
* Only warn that EXTRACT_SUFX is superfluous if DISTFILES is set AND EXTRACT_SUFX is set to (only) .tar.gz. Fixes PRs 9771 and 9635 * use getopt() for option parsing - "pkgling -abc" will work now.
recognize commands directly after a '@'
have a bit more clue about md5-files: don't warn if there's no files/md5 but NO_CHECKSUM is set in the Makefile; bump version
Remove debug I stupidly left in after nb<N> suffix changes to dewey_cmp
Handle 'nb1.2.3' type suffixes (rather than just 'nb1')
Update to 2.01 - extend deweydecimal compare to handle nb<N> suffixes
fix lintpkgsrc -l usage - from Thomas Klausner
include Makefiles with LICENSE with -R, update to 1.99
warn about invalid dewey-decimal numbers, plus other makefile parsing tweaks
Cleanup conditional parsing some more, and add (undocumented as of yet) -u flag which will run -i then fetch updated sources for any out of date installed packages.
Rototill the makefile parsing again, resulting in a passable attempt to parse conditionals. Now picks up correct arch determined version of navigator and communicator packages.
added warning that @owner, @group and @mode in PLIST are deprecated; bumped version number
check for known RCS tags only, instead of all strings between a '$' and a '$' or a ':', bumped version number
Check pkg/COMMENT a little more closely, and generate warnings on: Leading/trailing whitespace Trailing '.' Leading '(a|an) ' (case insensitive)
.if parsing is now a touch less braindamaged (still lousy)
removed warning about adding info about restricted packages to ports/LEGAL, which is a FreeBSD-ism we don't have; bumped version number to 1.91
Recognize more directly used commands (like 'ln' instead of '${LN}')
Fix handling of items in PATCH_* section. Addresses PR 9049 by ITOH Yasufumi <itohy@netbsd.org>
If we find a 'distfiles' directory in what we have been told only contains binary packages, "Move on... move on... move on" (even if it offers to tell you about its mother).
Add -K, to specify basedir for binary packages. ftp.netbsd.org gives rather interesting results from: lintpkgsrc -P /pub/NetBSD/NetBSD-current/pkgsrc -K /pub/NetBSD/packages -R
Add '-R' to list any RESTRICTED binary packages (should be useful for ftp.netbsd.org), implement dewey-decimal version matching, and add some comments. lintpkgsrc now qualifies as "very lightly commented"
Update manpage and tweak parse_makefiles verbose output
Write package_globmatch, which makes a passable attempt at implementing the globs used in pkgsrc. Also optimise variable expansion in parse_makefile (The previous algorithm was somewhat.... dumb)
Add yet more magic to parse Makefiles better. (plus be more verbose when problems are encountered)
Update to handle wildcard dependencies
Bump to V1.81, adding code to check for existance of PLIST (unless PLIST_SRC or NO_PKG_REGISTER are set) Fixes PR 8953 by Thomas Klausner <wiz@danbala.ifoer.tuwien.ac.at>
Seems I'm maintaining this
Bump version to 1.80
Bump version to 1.79. Introduced four new warnings: WARN: no ./files/patch-sum file. Please run 'make makepatchsum'. WARN: no ./files/md5 file. Please run 'make makesum'. WARN: RUN_DEPENDS is deprecated, please use DEPENDS. WARN: LIB_DEPENDS is deprecated, please use DEPENDS. Fixes PR 8861 by Dan McMahill <mcmahill@mit.edu>
Handle package names with regex meta characters (eg gtk+ )
Allow package versions to contain more than one consecutive characters. Pointed out by Simon Burge <simonb@netbsd.org> on tech-pkg@netbsd.org. Bumped version to 1.77.
Don't recomment using MASTER_SITE_SUBDIR, recomment the new way instead. While there, add all our known MASTER_SITE_xxx's. Fixes PR 8350 by John A. Maier <johnam@mail.kemper.org>
Small change to make pkglint run on Linux, much the same as the change used to make it run on Solaris - force the osname to be NetBSD, since pkgsrc is the same on all these different operating systems. Bump version number to 1.75 accordingly.
Add -P flag to lintpkgsrc to override PKGSRCDIR
bsd.pkg.mk recognises patch files of the form "patches/patch-*", rather than "patches/patch-??" - fix pkglint.pl to mirror this. Bump version number to 1.73, and update CHANGELOG
Make this package work on Solaris.
Update to 1.72 (new '-p' flag to lintpkgsrc to report (and optionaly remove) old binary packages.
Update to 1.71. Avoid uninit var warning, plus tighten up 'Maybe ...' check for unknown packages
Add pkg_check (renamed to lintpkgsrc, and add orginal lintpkgsrc functionality
(fixed up to work a little better).
lintpkgsrc can:
-d : Check each Makefile's 'DEPENDS' matches current pkgsrc versions.
-i : Check versions of installed packages against pkgsrc.
-l : Run pkglint on every package in pkgsrc.
-m : Report md5 mismatches for files in 'distfiles'.
-o : Report old/obsolete 'distfiles' (not referenced by any md5).
-r : Remove any 'bad' distfiles (Without -m or -o, implies both).
If running on Solaris, just use the NetBSD settings - it's the same pkgsrc. Bump version number to denote Solaris support.
Storing ${.CURDIR} in a binary is not good for automounted paths.
PKGSRCDIR can now be set in /etc/mk.conf to remedy this.
Reflect that we no longer enforce full path for install-info, bump version to indicate change.
Bump version of PKGNAME to 1.67 to indicate that there are changes since 1.66.
Add "pkgtools" to "${CATEGORIES}".
The Grand Homepagification: - New, optional Makefile variable HOMEPAGE, specifies a URL for the home page of the software if it has one. - The value of HOMEPAGE is used to add a link from the README.html files. - pkglint updated to know about it. The "correct" location for HOMEPAGE in the Makefile is after MAINTAINER, in that same section.
remove me as MAINTAINER.
Our portlint has diverged significantly from FreeBSD's, so rename portlint to pkglint, and keep the sources right under files. This makes it much easier to maintain and keep up with changes to out package system.