The NetBSD Project

CVS log for pkgsrc/pkgtools/lintpkgsrc/files/t/parse_makefile.t

[BACK] Up to [cvs.NetBSD.org] / pkgsrc / pkgtools / lintpkgsrc / files / t

Request diff between arbitrary revisions


Keyword substitution: kv
Default branch: MAIN


Revision 1.12: download - view: text, markup, annotated - select for diffs
Sat Aug 13 12:22:20 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
CVS tags: pkgsrc-2026Q3-base, pkgsrc-2026Q3, pkgsrc-2026Q2-base, pkgsrc-2026Q2, pkgsrc-2026Q1-base, pkgsrc-2026Q1, pkgsrc-2025Q4-base, pkgsrc-2025Q4, pkgsrc-2025Q3-base, pkgsrc-2025Q3, pkgsrc-2025Q2-base, pkgsrc-2025Q2, pkgsrc-2025Q1-base, pkgsrc-2025Q1, pkgsrc-2024Q4-base, pkgsrc-2024Q4, pkgsrc-2024Q3-base, pkgsrc-2024Q3, pkgsrc-2024Q2-base, pkgsrc-2024Q2, pkgsrc-2024Q1-base, pkgsrc-2024Q1, pkgsrc-2023Q4-base, pkgsrc-2023Q4, pkgsrc-2023Q3-base, pkgsrc-2023Q3, pkgsrc-2023Q2-base, pkgsrc-2023Q2, pkgsrc-2023Q1-base, pkgsrc-2023Q1, pkgsrc-2022Q4-base, pkgsrc-2022Q4, pkgsrc-2022Q3-base, pkgsrc-2022Q3, HEAD
Diff to: previous 1.11: preferred, colored
Changes since revision 1.11: +35 -2 lines
lintpkgsrc: fix expansion of the ':U' modifier

In Perl, 0 is falsy, but in bmake, the modifier ':U' only cares about
undefined vs. defined.

Revision 1.11: download - view: text, markup, annotated - select for diffs
Sat Aug 13 10:23:40 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.10: preferred, colored
Changes since revision 1.10: +12 -6 lines
lintpkgsrc: clean up evaluation of conditions in makefiles

Having a variable named 'false' was confusing. Having a stack of
if-states in which 0 means true and 1 means false was even more
confusing. Using these magic numbers in the debug log without any
explanation was misleading.

The code, as well as the debug log, now uses the strings 'not_yet',
'active' and 'done' for the state of the conditionals. While it still
requires a bit of thought to read the debug log, it's at least possible
now.

Revision 1.10: download - view: text, markup, annotated - select for diffs
Fri Aug 12 22:45:14 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.9: preferred, colored
Changes since revision 1.9: +5 -4 lines
lintpkgsrc: fix parsing of modifiers in makefiles

Revision 1.9: download - view: text, markup, annotated - select for diffs
Fri Aug 12 22:40:40 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.8: preferred, colored
Changes since revision 1.8: +3 -5 lines
lintpkgsrc: fix parsing of comments in makefile lines

Revision 1.8: download - view: text, markup, annotated - select for diffs
Fri Aug 12 22:32:21 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.7: preferred, colored
Changes since revision 1.7: +2 -2 lines
lintpkgsrc: fix parsing of continuation lines in makefiles

Revision 1.7: download - view: text, markup, annotated - select for diffs
Fri Aug 12 22:18:35 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.6: preferred, colored
Changes since revision 1.6: +73 -14 lines
lintpkgsrc: clean up subroutine names, test conditionals

Revision 1.6: download - view: text, markup, annotated - select for diffs
Wed Aug 10 21:48:47 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.5: preferred, colored
Changes since revision 1.5: +46 -2 lines
lintpkgsrc: fix evaluation of conditions in makefiles

Previously, evaluating the conditions was a wild mixture of concepts
taken from bmake's cond.c, without attention to detail. For example, in
the condition 'exists(VAR:Mpattern)', the ':Mpattern' doesn't make any
sense, still lintpkgsrc parsed it as a modifier.

Instead of evaluating the ':M' modifier only in conditions, a better
idea is to have a general subroutine that expands an arbitrary strings,
taking care of all kinds of modifiers.

While the previous code was conceptually wrong, the number of practical
difference is small. Still, it's better to be precise and accurate,
there are enough places with bad heuristics in the rest of the
lintpkgsrc code.

Revision 1.5: download - view: text, markup, annotated - select for diffs
Wed Aug 10 07:12:52 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.4: preferred, colored
Changes since revision 1.4: +19 -1 lines
lintpkgsrc: cleanup

Mostly remove redundant punctuation around 'push' and 'defined'.

Revision 1.4: download - view: text, markup, annotated - select for diffs
Tue Aug 9 20:51:46 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.3: preferred, colored
Changes since revision 1.3: +4 -4 lines
lintpkgsrc: clean up parsing of make variables

Unknown lines are written to the debug log.

Revision 1.3: download - view: text, markup, annotated - select for diffs
Wed Aug 3 18:51:56 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.2: preferred, colored
Changes since revision 1.2: +2 -2 lines
lint: fail if one of the tests fails

Revision 1.2: download - view: text, markup, annotated - select for diffs
Wed Aug 3 18:24:59 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
Diff to: previous 1.1: preferred, colored
Changes since revision 1.1: +56 -56 lines
lintpkgsrc: use LF line endings in tests

Revision 1.1: download - view: text, markup, annotated - select for diffs
Wed Aug 3 16:15:49 2022 UTC (4 years, 3 months ago) by rillig
Branches: MAIN
lintpkgsrc: test parsing of package makefiles

Diff request

This form allows you to request diffs between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.

Log view options

CVSweb <webmaster@jp.NetBSD.org>