CVS log for pkgsrc/mk/tools/create.mk
Up to [cvs.NetBSD.org] / pkgsrc / mk / tools
Request diff between arbitrary revisions
Keyword substitution: kv
Default branch: MAIN
Revision 1.17: download - view: text, markup, annotated - select for diffs
Thu Nov 24 11:09:34 2022 UTC (3 years, 11 months ago) by jperkin
Branches: MAIN
CVS tags: pkgsrc-2026Q3-base,
pkgsrc-2026Q3,
pkgsrc-2026Q2-base,
pkgsrc-2026Q2,
pkgsrc-2026Q1-base,
pkgsrc-2026Q1,
pkgsrc-2025Q4-base,
pkgsrc-2025Q4,
pkgsrc-2025Q3-base,
pkgsrc-2025Q3,
pkgsrc-2025Q2-base,
pkgsrc-2025Q2,
pkgsrc-2025Q1-base,
pkgsrc-2025Q1,
pkgsrc-2024Q4-base,
pkgsrc-2024Q4,
pkgsrc-2024Q3-base,
pkgsrc-2024Q3,
pkgsrc-2024Q2-base,
pkgsrc-2024Q2,
pkgsrc-2024Q1-base,
pkgsrc-2024Q1,
pkgsrc-2023Q4-base,
pkgsrc-2023Q4,
pkgsrc-2023Q3-base,
pkgsrc-2023Q3,
pkgsrc-2023Q2-base,
pkgsrc-2023Q2,
pkgsrc-2023Q1-base,
pkgsrc-2023Q1,
pkgsrc-2022Q4-base,
pkgsrc-2022Q4,
HEAD
Diff to: previous 1.16: preferred, colored
Changes since revision 1.16: +23 -28
lines
mk: Revert override-tools performance change.
Unfortunately Linux appears to have a much smaller limit on the number
of arguments allowed, so while this change was absolutely fine on many
other platforms, on Linux it fails with:
bmake[1]: exec(/bin/bash) failed (Argument list too long)
It will hopefully be possible to rearchitect the change in a different
way to avoid this, while still retaining most of the performance win.
Revision 1.16: download - view: text, markup, annotated - select for diffs
Wed Nov 23 16:01:36 2022 UTC (3 years, 11 months ago) by jperkin
Branches: MAIN
Diff to: previous 1.15: preferred, colored
Changes since revision 1.15: +29 -24
lines
mk: Improve override-tools performance.
Use bmake loop expansion to create all of the tools within the same shell
instance rather than spawning a new one for each, as well as aliases and
executable suffixes. Saves over 100 execs per build.
Revision 1.15: download - view: text, markup, annotated - select for diffs
Fri Oct 7 11:42:51 2022 UTC (4 years, 1 month ago) by jperkin
Branches: MAIN
Diff to: previous 1.14: preferred, colored
Changes since revision 1.14: +2 -2
lines
mk: Avoid unnecessary separate shell invocation.
Reduces number of shells invoked during tools phase by around 100, and improves
performance by around 10%.
Revision 1.14: download - view: text, markup, annotated - select for diffs
Sun May 10 14:36:18 2020 UTC (6 years, 6 months ago) by rillig
Branches: MAIN
CVS tags: pkgsrc-2022Q3-base,
pkgsrc-2022Q3,
pkgsrc-2022Q2-base,
pkgsrc-2022Q2,
pkgsrc-2022Q1-base,
pkgsrc-2022Q1,
pkgsrc-2021Q4-base,
pkgsrc-2021Q4,
pkgsrc-2021Q3-base,
pkgsrc-2021Q3,
pkgsrc-2021Q2-base,
pkgsrc-2021Q2,
pkgsrc-2021Q1-base,
pkgsrc-2021Q1,
pkgsrc-2020Q4-base,
pkgsrc-2020Q4,
pkgsrc-2020Q3-base,
pkgsrc-2020Q3,
pkgsrc-2020Q2-base,
pkgsrc-2020Q2
Diff to: previous 1.13: preferred, colored
Changes since revision 1.13: +4 -4
lines
mk/tools: don't create empty symlink for wrong tool definition
This case can only happen in the following special case:
TOOLS_CREATE+= asdf
TOOLS_PATH.asdf= # empty
If there is a lonely TOOLS_CREATE without a corresponding TOOLS_PATH, it
defaults to ${FALSE} and thus doesn't trigger this code.
Revision 1.13: download - view: text, markup, annotated - select for diffs
Sat May 9 21:08:05 2020 UTC (6 years, 6 months ago) by rillig
Branches: MAIN
Diff to: previous 1.12: preferred, colored
Changes since revision 1.12: +2 -2
lines
mk/tools/create.mk: make tool wrappers smaller
There is no need to include the comments from the shquote function.
Revision 1.12: download - view: text, markup, annotated - select for diffs
Sat May 9 20:50:20 2020 UTC (6 years, 6 months ago) by rillig
Branches: MAIN
Diff to: previous 1.11: preferred, colored
Changes since revision 1.11: +10 -2
lines
mk/tools/create.mk: add new variable TOOLS_ALWAYS_WRAP for debugging
Revision 1.11: download - view: text, markup, annotated - select for diffs
Sun Mar 24 11:29:19 2019 UTC (7 years, 7 months ago) by rillig
Branches: MAIN
CVS tags: pkgsrc-2020Q1-base,
pkgsrc-2020Q1,
pkgsrc-2019Q4-base,
pkgsrc-2019Q4,
pkgsrc-2019Q3-base,
pkgsrc-2019Q3,
pkgsrc-2019Q2-base,
pkgsrc-2019Q2,
pkgsrc-2019Q1-base,
pkgsrc-2019Q1
Diff to: previous 1.10: preferred, colored
Changes since revision 1.10: +11 -8
lines
mk/tools: correctly quote arguments in the tool wrapper log
Before, the tool arguments were written to the log as plain strings. Now
the arguments are properly quoted, which makes it possible to replay the
commands by copying them from the .work.log file.
This only affects tools that are shell builtins (echo, true, false), get
additional arguments (mkdir -p) or define a custom TOOLS_SCRIPT
(pkg-config, to set an environment variable; or autotools). Tools that
are symlinked to the real tool are not affected.
The calls to the compiler are already properly logged since cwrappers
takes care of that. This commit therefore makes the log entries for the
compilers and the other tools more similar.
Revision 1.10: download - view: text, markup, annotated - select for diffs
Sun Mar 24 08:40:07 2019 UTC (7 years, 7 months ago) by rillig
Branches: MAIN
Diff to: previous 1.9: preferred, colored
Changes since revision 1.9: +13 -7
lines
mk/tools: fix quoting when logging tool invocations
When a package or the infrastructure defined a tool with custom
TOOLS_ARGS or TOOLS_SCRIPT containing special characters, these could
lead to unintuitive interactions at the time when that tool invocation
was logged in the tool wrapper log. Some of the logging output ended up
on stdout, while some of the normal output ended up in the log, and parts
of the quoted arguments were even evaluated as shell commands.
The logging of the wrapped tool commands is not perfect yet, but at least
it's much more predictable now.
Revision 1.9: download - view: text, markup, annotated - select for diffs
Fri Mar 22 22:13:21 2019 UTC (7 years, 7 months ago) by rillig
Branches: MAIN
Diff to: previous 1.8: preferred, colored
Changes since revision 1.8: +8 -3
lines
mk/tools: fix unintended filename expansion in the tool wrapper log file
Revision 1.8: download - view: text, markup, annotated - select for diffs
Wed Aug 22 20:48:37 2018 UTC (8 years, 2 months ago) by maya
Branches: MAIN
CVS tags: pkgsrc-2018Q4-base,
pkgsrc-2018Q4,
pkgsrc-2018Q3-base,
pkgsrc-2018Q3
Diff to: previous 1.7: preferred, colored
Changes since revision 1.7: +1 -8
lines
Remove clauses 3,4 from TNF-only copyright blocks.
This is based on the decision The NetBSD Foundation made in 2008 to
do so, which was already applied to src.
This change has been applied to code which is likely not in other
repositories.
ok board@, reviewed by riastradh@
Revision 1.7: download - view: text, markup, annotated - select for diffs
Fri Apr 27 20:53:14 2018 UTC (8 years, 6 months ago) by rillig
Branches: MAIN
CVS tags: pkgsrc-2018Q2-base,
pkgsrc-2018Q2
Diff to: previous 1.6: preferred, colored
Changes since revision 1.6: +5 -2
lines
mk/tools/create.mk: revert filtering duplicate tool names
The "split" program is not managed by the tools framework. It just has a
wrapper that is placed into the same directory. This is confusing since
intuitively, "split" is a tool like many others.
The "duplicate script for target" warning from Make is therefore correct,
albeit obscure.
Currently, neither the pkgsrc infrastructure nor pkglint check for
allowed tool names.
Revision 1.6: download - view: text, markup, annotated - select for diffs
Fri Apr 27 20:16:36 2018 UTC (8 years, 6 months ago) by rillig
Branches: MAIN
Diff to: previous 1.5: preferred, colored
Changes since revision 1.5: +2 -2
lines
mk/tools/create.mk: sort tools before creating the wrapper targets
The TOOLS_CREATE variable is only ever appended to, without checking for
duplicates. In some rare cases, this produces warnings about
doubly-defined make targets. An example is adding USE_TOOLS+=strip to
pkgtools/pkglint:
".../mk/tools/create.mk" line 149: warning:
duplicate script for target ".../work/.tools/bin/strip" ignored
The above line number 149 is zero-based, which in reality means the
duplicate definition is in line 150.
Revision 1.5: download - view: text, markup, annotated - select for diffs
Wed Feb 27 12:09:39 2013 UTC (13 years, 8 months ago) by obache
Branches: MAIN
CVS tags: pkgsrc-2018Q1-base,
pkgsrc-2018Q1,
pkgsrc-2017Q4-base,
pkgsrc-2017Q4,
pkgsrc-2017Q3-base,
pkgsrc-2017Q3,
pkgsrc-2017Q2-base,
pkgsrc-2017Q2,
pkgsrc-2017Q1-base,
pkgsrc-2017Q1,
pkgsrc-2016Q4-base,
pkgsrc-2016Q4,
pkgsrc-2016Q3-base,
pkgsrc-2016Q3,
pkgsrc-2016Q2-base,
pkgsrc-2016Q2,
pkgsrc-2016Q1-base,
pkgsrc-2016Q1,
pkgsrc-2015Q4-base,
pkgsrc-2015Q4,
pkgsrc-2015Q3-base,
pkgsrc-2015Q3,
pkgsrc-2015Q2-base,
pkgsrc-2015Q2,
pkgsrc-2015Q1-base,
pkgsrc-2015Q1,
pkgsrc-2014Q4-base,
pkgsrc-2014Q4,
pkgsrc-2014Q3-base,
pkgsrc-2014Q3,
pkgsrc-2014Q2-base,
pkgsrc-2014Q2,
pkgsrc-2014Q1-base,
pkgsrc-2014Q1,
pkgsrc-2013Q4-base,
pkgsrc-2013Q4,
pkgsrc-2013Q3-base,
pkgsrc-2013Q3,
pkgsrc-2013Q2-base,
pkgsrc-2013Q2,
pkgsrc-2013Q1-base,
pkgsrc-2013Q1
Diff to: previous 1.4: preferred, colored
Changes since revision 1.4: +6 -1
lines
create tools' aliases additionally with _OPSYS_EXE_SUFFIX.
In some situations, tools will be invoked with platform specific executable
suffix (ex. Perl5's Configure).
Revision 1.4: download - view: text, markup, annotated - select for diffs
Tue Mar 17 22:13:36 2009 UTC (17 years, 8 months ago) by rillig
Branches: MAIN
CVS tags: pkgsrc-2012Q4-base,
pkgsrc-2012Q4,
pkgsrc-2012Q3-base,
pkgsrc-2012Q3,
pkgsrc-2012Q2-base,
pkgsrc-2012Q2,
pkgsrc-2012Q1-base,
pkgsrc-2012Q1,
pkgsrc-2011Q4-base,
pkgsrc-2011Q4,
pkgsrc-2011Q3-base,
pkgsrc-2011Q3,
pkgsrc-2011Q2-base,
pkgsrc-2011Q2,
pkgsrc-2011Q1-base,
pkgsrc-2011Q1,
pkgsrc-2010Q4-base,
pkgsrc-2010Q4,
pkgsrc-2010Q3-base,
pkgsrc-2010Q3,
pkgsrc-2010Q2-base,
pkgsrc-2010Q2,
pkgsrc-2010Q1-base,
pkgsrc-2010Q1,
pkgsrc-2009Q4-base,
pkgsrc-2009Q4,
pkgsrc-2009Q3-base,
pkgsrc-2009Q3,
pkgsrc-2009Q2-base,
pkgsrc-2009Q2,
pkgsrc-2009Q1-base,
pkgsrc-2009Q1
Diff to: previous 1.3: preferred, colored
Changes since revision 1.3: +4 -5
lines
Replaced _PKG_SILENT and _PKG_DEBUG with RUN.
Revision 1.3: download - view: text, markup, annotated - select for diffs
Wed Feb 13 09:11:01 2008 UTC (18 years, 9 months ago) by rillig
Branches: MAIN
CVS tags: pkgsrc-2008Q4-base,
pkgsrc-2008Q4,
pkgsrc-2008Q3-base,
pkgsrc-2008Q3,
pkgsrc-2008Q2-base,
pkgsrc-2008Q2,
pkgsrc-2008Q1-base,
pkgsrc-2008Q1,
cwrapper,
cube-native-xorg-base,
cube-native-xorg
Diff to: previous 1.2: preferred, colored
Changes since revision 1.2: +4 -2
lines
Whenever a tool from TOOLS_FAIL is executed, print a useful error
message. This is much better than failing silently.
Revision 1.2: download - view: text, markup, annotated - select for diffs
Mon Jul 10 08:13:37 2006 UTC (20 years, 4 months ago) by rillig
Branches: MAIN
CVS tags: pkgsrc-2007Q4-base,
pkgsrc-2007Q4,
pkgsrc-2007Q3-base,
pkgsrc-2007Q3,
pkgsrc-2007Q2-base,
pkgsrc-2007Q2,
pkgsrc-2007Q1-base,
pkgsrc-2007Q1,
pkgsrc-2006Q4-base,
pkgsrc-2006Q4,
pkgsrc-2006Q3-base,
pkgsrc-2006Q3,
jlam-pkgviews-base,
jlam-pkgviews
Diff to: previous 1.1: preferred, colored
Changes since revision 1.1: +9 -1
lines
The wrapper for perl silently failed, giving no hint that
USE_TOOLS+=perl was necessary. Therefore, added a new class of tools,
TOOLS_FAIL, which records the call in a .warnings file, which is later
printed to the user. At least when the tool is first called in the
"configure" phase; I didn't test other phases.
Revision 1.1: download - view: text, markup, annotated - select for diffs
Tue Jun 6 06:30:29 2006 UTC (20 years, 5 months ago) by jlam
Branches: MAIN
CVS tags: pkgsrc-2006Q2-base,
pkgsrc-2006Q2
Separate out the part of bsd.tools.mk that actually created the tools
into a new file pkgsrc/mk/tools/create.mk. This leaves bsd.tools.mk
as a file that pulls in all of the other ones. Also move the
tools-related targets from bsd.pkg.mk into bsd.tools.mk.
The tools cookie file has been removed, as well as hooks for
{pre,do,post}-tools. Instead, there is now only a single public target
"tools" which may be invoked. Invoking "tools" will always cause all
of the tools in ${TOOLS_DIR} to be created.
The "tools" step has been moved and is now just after the "depends"
step and before sources are extracted. This is the earliest place
where the "tools" step can be taken, and it allows the created tools
to be used in all steps/phases after it, starting with "extract". As
a consequence, we should just invoke tools by their bare names in
targets, e.g. awk, sed, patch, etc., instead of with the ${VARIABLE}
names, e.g. ${AWK}, ${SED}, ${PATCH}, etc.
CVSweb <webmaster@jp.NetBSD.org>