CVS log for src/usr.sbin/sup/source/Attic/supcmeat.c

Up to [cvs.NetBSD.org] / src / usr.sbin / sup / source

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Mostly merge changes from HEAD upto 20200411

remove sup

Sync with HEAD

add breaks for done() since it might not be __dead.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

resync from head

- add new ignore chown/chgrp flag
- bump strings space to 8K someone has 4K paths now.
- use snprintf where possible and detect long lines.

- don't allow multiple active connections from the same host
- prefix all messages with the local hostname
- more error checking

Add a canonicalize option to avoid disaster when one converts directories
to symlinks in the tree and back. This option is expensive, it could be
made better by cacheing, but not now.

NULL does not need a cast

improve error handling and logging.

change to strchr and strrchr

Make this compile again. I should have tried to compile the patches myself,
but ran out of time this morning.

constification from Paul Ripke to make it compile on OS/X

Fix one more build breakage ("warning: 'er' may be used uninitialized in
this function").

- remove errmsg; we all have strerror() these days.
- sanitize error printing. Try to print the system error or a reason for
  the message.

Fix symlink lossage:
- Use lstat instead of stat to find the destination path. we can make a symlink
  to a broken symlink this way.
- When calling process to create a link, check if the source is a symlink
  instead of trying to remove what the symlink points to!
- Don't create hard links to directories.

XXX: NB. Still sup is broken when used with the delete option. This is because
in the delete pass, it goes and tries to delete all files in the old list
that don't exist in the new list. This is a problem when a directory becomes
a symlink to a hierarchy that contains the same names. Then sup will cross
the symlink and start deleting files and directories from the destination.
This is not easily fixed. Don't use sup with symlink/rsymlink and the delete
option at the same time or *be careful*!

From Anon Ymous:
- add __unused
- fix volatile

rename salloc to estrdup.

add mode 0600 for open call with O_CREAT.

Pull up revision 1.28 via patch (requested by itojun in ticket #1391):
debian bug id "sup 1.8-8, bug #175327" - temporary file symlink race

Pull up rev. 1.28 via patch (requested by itojun in ticket #60):
 Fix debian bug id "sup 1.8-8, bug #175327" - temporary file symlink race

debian bug id "sup 1.8-8, bug #175327" - temporary file symlink race

use readlink with bufsize - 1; approved thorpej.

Don't omit third argument to open(2).
PR bin/17885 from mjl.

De-lint a bit.

Cleanup, part 2:
Remove 'register'. ANSIfy. indent(1). Static -> static.
Change some ``#include <header.h>'' to ``#include "header.h"'' for
local headers.
Fix function declaration mistakes uncovered by ANSIfication.

Cleanup, part 1:
Remove sysent.h, unneeded.
Remove __P().
unifdef __STDC__
Remove some #if 0 parts.
Start ANSIfication.

va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.

Replace the provided read_line function with calls to the fparseln function in libutil.  Maintain compatibility on machines without fparseln through the NEED_READ_LINE define.

Add -u flag, that prevents sup from attempting to restore a and m times
on the received files.

Pullup copyright text corrections.

Software_Distribution => Software.Distribution.

Before running "rm -rf" on a directory chmod the directory and its parent
to u+rwx to make our chances of success better.  The modes for directories
are reset at the end of a sup run, so we don't need to worry about that.

This possibly might mess up the mode of the parent of the top-level dir,
if the top-level changed to a non-directory.  This is probably rare enough
not to care too much about.

XXX: Should probably chmod the containing directory for each non-directory
removal as well, so there wouldn't be complaints about them.  Please feel
free to send in your opinions on that...

Before running "rm -rf" on a directory try to turn on the S_IRWXU bits.

{} fixes from Erik Bertelsen <erik@erik-be.uni-c.dk> (PR 6047) to shut up egcs.

Use S_IS*(), not S_IF*.

If a directory gets deleted in the master tree, but the client has it in
his last.<collection> list, this directory did not get removed in the client
since the code just tried rmdir(foo) and gave up when that failed. This
has been changed to be more agressive and do an rm -fr when rmdir fails.

When in compress mode, don't overwrite the destination file directly,
write a temp file and use rename when it is done. (From James Mathiesen
<james@deshaw.com>)

avoid last.temp filename collision by using rel-suffix;
  from Scott Stevens <s.k.stevens@ic.ac.uk>

When creating directories, make sure you remove previous non-directories
before doing so, otherwise sup fails.

- add $NetBSD$
- remove all $Log$ instances and the extra logs caused by our local changes.

64 bit patches (mostly long -> time_t) from Matthew Jacob (?)
sup now works on the alpha!

- add missing prototypes.
- fix function call inconsistencies
- fix int <-> long and pointer conversions
It should run now on 64 bit machines...

- for portability make sure that we never use "" as a pathname, always convert
  it to "."
- include sockio.h if needed to define SIOCGIFCONF (for svr4)
- use POSIX signals and wait macros
- add -S silent flag, so that the client does not print messages unless there
  is something wrong
- use flock or lockf as appropriate
- use fstatfs or fstatvfs to find out if a filesystem is mounted over nfs,
  don't depend on the major() = 255 hack; it only works on legacy systems.
- use gzip -cf to make sure that gzip compresses the file even when the file
  would expand.
- punt on defining vsnprintf if _IOSTRG is not defined; use sprintf...

To compile sup on systems other than NetBSD, you'll need a copy of daemon.c,
vis.c, vis.h and sys/cdefs.h. Maybe we should keep those in the distribution?

- runio fails when result != 0 not only < 0
- print vis-encoded file in the scanner.

- Don't use system(3) to fork processes. It is a big security hole.
- Encode the filenames in the scan files using strvis(3), so filenames
  that contain newlines or other weird characters don't break the scanner.

Changes to write ascii timestamps in the when files.
Looked into making it 64 bit clean, but it is hopeless.
Added little program to convert from the old timestamp files
into the new ones.

Changes from nate for gzip'ed sup

Use /var/tmp for NetBSD

initial import of CMU's SUP to NetBSD

Initial revision