CVS log for src/usr.sbin/rtadvd/config.c

Up to [cvs.NetBSD.org] / src / usr.sbin / rtadvd

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

usr.sbin: remove unnecessary CONSTCOND, lint no longer needs it

Since 2021-01-31, lint no longer requires a CONSTCOND comment in a
do-while-0 statement since this is a common code pattern, especially in
statement-like macros.

sed -i -E 's,} while \(/\* ?CONSTCOND ?\*/ ?0\),} while (0),' */*.[ch]

print function names as %s: not <%s> everywhere for consistency.

- remove extra \n from stderr logging
- add string message types
- sprinkle const

Sync with HEAD

rtadvd: Remove disabled use of SIOCGIFPREFIX_IN6

It's not been enabled since the functionality was added to ifconfig(8)
many many years ago.

Mostly merge changes from HEAD upto 20200411

Pull up following revision(s) (requested by roy in ticket #417):

	usr.sbin/rtadvd/rtadvd.c: revision 1.70
	usr.sbin/rtadvd/rtadvd.c: revision 1.71
	usr.sbin/rtadvd/rtadvd.h: revision 1.20
	usr.sbin/rtadvd/config.c: revision 1.42
	usr.sbin/rtadvd/config.c: revision 1.43
	usr.sbin/rtadvd/rtadvd.8: revision 1.27

rtadvd: Fix reloading configuration killing interface timers

rtadvd: remove support for SIOCSIFINFO_IN6
It's been broken since we enabled dropping privs.
It's also probably the wrong place to do this, and support for
SIOCSIFINFO_IN6 will be in the next dhcpcd import.

rtadvd: Add C flag to control the zeroing of the leaving configuration
This is only intended to assist the testing of clients which consume
Router Advertisement messages, such as dhcpcd(8).

rtadvd: Add C flag to control the zeroing of the leaving configuration

This is only intended to assist the testing of clients which consume
Router Advertisement messages, such as dhcpcd(8).

rtadvd: remove support for SIOCSIFINFO_IN6

It's been broken since we enabled dropping privs.
It's also probably the wrong place to do this, and support for
SIOCSIFINFO_IN6 will be in the next dhcpcd import.

rtadvd: fix rdnss and dnssl lifetime assignment

Treat it the same as a prefix valid time as per the RFC.
This allows to set a zero value to remove the assignment from the node.

Sync with HEAD

Unicast solicited RA's as per RFC 7772.

This is done by having a secondary timer against rainfo so we
can delay unicasting by the required randomised amount of time
without affecting the unsolicited RA timer.

Ensure that the soliciter list is initialised and freed correctly, even if it's not used yet.

White space police.

Pull up following revision(s) (requested by ozaki-r in ticket #358):
	usr.sbin/rtadvd/rtadvd.c: revision 1.54-1.58
	usr.sbin/rtadvd/config.c: revision 1.37
	usr.sbin/rtadvd/if.c: revision 1.25
	usr.sbin/rtadvd/dump.c: revision 1.15
	usr.sbin/rtadvd/rrenum.c: revision 1.20
	usr.sbin/rtadvd/logit.h: revision 1.1
	usr.sbin/rtadvd/rtadvd.8: revision 1.26
	tests/net/ndp/t_ra.sh: revision 1.30
	usr.sbin/rtadvd/timer.c: revision 1.14
	tests/net/ndp/t_ra.sh: revision 1.31
	usr.sbin/rtadvd/advcap.c: revision 1.17

KNF, fix time printing formats.

Don't start another copy of rtadvd if one is running.

PR/52618: Shinichi Doyashiki: Don't exit if adding interface to multicast
group fails. This happens with empty vlan interfaces
- make syscalls checks against -1
- fix errors to print %s: instead of <%s>
XXX: if_vlan is the only pseudo interface in net/ that returns such an
error..

Kill rtadvd surely even if the tests fail in the middle
It may help PR bin/52701.

Change the meaning of the D flag to print errors to stderr instead of
syslog(3) and exit if poll(2) fails (intended to be used with unit-tests).

Mark expandm as preserving format strings.

Let rtadvd not use syslog for logging
Thanks to christos@ now rtadvd can log via stderr instead of syslog
by -D option.
Address PR bin/52701

Change the meaning of the 'D' flag to print errors to stderr instead of
syslog(3) and exit if poll(2) fails (intended to be used with unit-tests).

Pull up following revision(s) (requested by ozaki-r in ticket #1440):
	usr.sbin/rtadvd/rtadvd.h: revision 1.15
	usr.sbin/rtadvd/config.c: revision 1.36
Fix the default value of rltime
According to rtadvd.conf(5), the default value of rltime is 1800 seconds.
PR bin/51994

Pull up following revision(s) (requested by ozaki-r in ticket #1440):
	usr.sbin/rtadvd/rtadvd.h: revision 1.15
	usr.sbin/rtadvd/config.c: revision 1.36
Fix the default value of rltime
According to rtadvd.conf(5), the default value of rltime is 1800 seconds.
PR bin/51994

Pull up following revision(s) (requested by ozaki-r in ticket #1440):
	usr.sbin/rtadvd/rtadvd.h: revision 1.15
	usr.sbin/rtadvd/config.c: revision 1.36
Fix the default value of rltime
According to rtadvd.conf(5), the default value of rltime is 1800 seconds.
PR bin/51994

Pull up following revision(s) (requested by ozaki-r in ticket #1373):
	usr.sbin/rtadvd/config.c: revision 1.36
	usr.sbin/rtadvd/rtadvd.h: revision 1.15
Fix the default value of rltime
According to rtadvd.conf(5), the default value of rltime is 1800 seconds.
PR bin/51994

Pull up following revision(s) (requested by ozaki-r in ticket #1373):
	usr.sbin/rtadvd/config.c: revision 1.36
	usr.sbin/rtadvd/rtadvd.h: revision 1.15
Fix the default value of rltime
According to rtadvd.conf(5), the default value of rltime is 1800 seconds.
PR bin/51994

Pull up following revision(s) (requested by ozaki-r in ticket #1373):
	usr.sbin/rtadvd/config.c: revision 1.36
	usr.sbin/rtadvd/rtadvd.h: revision 1.15
Fix the default value of rltime
According to rtadvd.conf(5), the default value of rltime is 1800 seconds.
PR bin/51994

Sync with HEAD

Sync with HEAD

Fix the default value of rltime

According to rtadvd.conf(5), the default value of rltime is 1800 seconds.

PR bin/51994

Introduce rump.rtadvd

It is used to write ATF tests for RA.

From s-yamaguchi@IIJ.

Use clock_gettime(2) instead of gettimeofday(2) so we can use a monotonic
clock rather than the wall clock.
Use timespec rather than timeval structs to make this transition easier.
Kill custom timeval comparison functions in favor of timespeccmp(3).

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

resync with head

fix previous.

make it static const

sync with head

sync with (a bit old) head

Intsead of forcing out each RA at shutdown and sleeping we now use
the existing timer model and wait for each RA to expire itself after
sending the required number of transmissions.

This allows for a faster and saner shutdown.

Remove the iflist array and store ifflags in rainfo.

Add support for SIGHUP to re-read the configuration for each interface.
If an invalid configuration is found, we continue to use the old one;
otherwise we expire the current one and then start advertising the new one.

Specififed interfaces don't have to exist at startup.
If specified interfaces arrive, load their config and start advertising.
If they depart, remove their rainfo structure and continue.

Fixes PR/43881 and PR/47311

Add support for the noifprefix keyword which stops rtadvd(8) gathing prefix
information from the interface if no addrs are present in rtadvd.conf(5).

sync with head

Pull up following revision(s) (requested by msaitoh in ticket #465):
	usr.sbin/rtadvd/config.c: revision 1.28
Fix a bug that incorrect RA packet is sent if rtadvd.conf exists.
Fixes PR#46580 reported by Takahiro HAYASHI.

Fix a bug that incorrect RA packet is sent if rtadvd.conf exists.
Fixes PR#46580 reported by Takahiro HAYASHI.

sync with head

- sprinkle const
- malloc + memset -> calloc
- free + malloc -> realloc
- syslog("%s", strerror(errno)) -> syslog("%m")

Add RDNSS and DNSSL support, RFC6106.
Replace custom lists with TAILQ lists.
Clean up plently of signed vs unsigned warnings and set WARNS=4.

Adapted from FreeBSD.

imported Mobile IPv6 code developed by the SHISA project
(http://www.mobileip.jp/).

u_char -> char for several things:
- inet_ntop()
- if_indextoname()
- variable assignment matching
char -> u_char in one place for variable assignment matching

PR 33462: default maxinterval was not being initialized properly.
From Matthias Scheller.

From KAME sources.

avoid heap overrun.  thanks goes to Susan Lan of zyxel.

NDP-related improvements:
        RFC4191
	- supports host-side router-preference

	RFC3542
	- if DAD fails on a interface, disables IPv6 operation on the
          interface
	- don't advertise MLD report before DAD finishes

	Others
	- fixes integer overflow for valid and preferred lifetimes
	- improves timer granularity for MLD, using callout-timer.
	- reflects rtadvd's IPv6 host variable information into kernel
	  (router only)
	- adds a sysctl option to enable/disable pMTUd for multicast
          packets
	- performs NUD on PPP/GRE interface by default
	- Redirect works regardless of ip6_accept_rtadv
	- removes RFC1885-related code

From the KAME project via SUZUKI Shinsuke.
Reviewed by core.

relax addrs#x config parameter.  should address PR 21872

strncpy -> strlcpy

test malloc failure.  From: Chad Loder <cloder@acm.org>.  sync w/kame

byebye __FUNCTIION__.  sync w/kame

Remove extra/redundant argument to syslog.

use strchr

do not use deprecated ioctls

KNF, strlcpy, memory leak fix, random other cleanups.  sync w/kame

prevent overflow of lifetime value.  sync with kame

typo.  ntohl -> htonl.

avoid infinite loop when -s is specified (select loop mistake).
make agetent() 32bit clean.  KAME PR 127.
disable -R (router renumbering receiver).  sync with kame.

make sure to initialize prefix information struct before use.  sync with kame

sync with latest kame.
- make icmp6.h spec conformant to 2292bis-02, regarding to router reumbering
  flag bit.
- latest rtadvd.

sync with latest kame tree.
- reduce chances for signal handler rae condition
- decrease chances for misconfiguration
- feedbacks from router renumbering protocol bakeoff

sync with latest kame.
- decrease warning level on missing rtadvd.conf (actually, the file
  can be omitted)
- strict prototype
- gather stats better, emit stats on SIGUSR1 to /var/run

bring in latest kame tree.  this fixes unclosed file descdriptor
in router renumbering case.

fix include file path (IPv6 related).

add -R (accept router renumbering packet).  now router renumbering is disabled
by default for ipsec config twists.
dies gracefully on SIGTERM.

fix for 64bit arch, where sizeof(size_t) != sizeof(int).
add NetBSD RCS ID.

more careful signed-ness handling in parsing config file.

rtadvd: advertise IPv6 prefix info via router advertisement.
(to be run on routers)