CVS log for src/usr.bin/xlint/lint1/ckgetopt.c

Up to [cvs.NetBSD.org] / src / usr.bin / xlint / lint1

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

lint: keep invalid arguments in function calls

Previously, arguments of incomplete type or 'void' cleared all arguments
of the function call expression, requiring extra checks in later checks.

Invalid function calls are now exported to the .ln files, but that's
irrelevant in practice as these invalid function calls make lint1 fail,
after which xlint removes the .ln file.

lint: inline accessor macros for tnode_t

lint: clean up string parsing and snprintb check

lint: fix misleading initializer for string iterator

The field 'start' marks the start of the previous matching character,
not the current iterator position.

No binary change.

lint: make function call arguments directly accessible

Previously, the arguments of a function call expression were arranged in
a linear tree structure, from right to left.  To allow easier access to
the arguments, store them in an array instead.

lint: keep strings in their source representation

This allows further analysis depending on whether individual characters are
escaped as octal, hexadecimal or not at all.

lint: clean up comments, reduce scope of variables

lint: use standard buffer for storing string values

No functional change.

lint: do not remember content of wide string literals

The plain char literals are needed for checking printf/scanf format
strings; lint has no similar check for wide strings. These format
strings are checked by modern compilers, making this check less
relevant.

lint: check getopt call more strictly

Previously, '(c = getopt(...)) != -2' would match as well.

lint: re-wrap comments

No functional change.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: merge duplicate code for handling plain and wide strings

No functional change.  As before, the string literals "1" "2" "3" are
not concatenated from left to right, instead concatenation starts with
"23" and then proceeds to "123".

lint: enter full C90 compatibility mode

The C99 comment in tree.c:3468 has been there since 2017-03-06, without
anyone complaining that their compiler would not handle it.

Strangely, running GCC 10.3.0 in '-std=c90' mode does not complain about
declarations after statements, '-Wdeclaration-after-statement' is needed
separately.

No functional change.

lint: move all declarations above statements

All code that is used by src/tools is supposed to be compatible with C90.

No functional change.

lint: warn if a getopt switch tries to handle unreachable ':'

lint: fix wrong warning about '?' in getopt

sync with head

lint: fix function name in check for getopt

No functional change.

lint: pass pos_t via const pointer

Thanks for the suggestion, christos@.

lint: migrate the getopt check to warning_at

lint: reduce visibility of global variable for getopt check

No functional change.

lint: reduce duplicate code in check for getopt

This also changes the conditions to their positive form, which is easier
to read.

No functional change.  The resulting binary would have been the same as
before, were it not for the changed line numbers in the lint_assert
calls further down in the code.

lint: clean up check for getopt

The original options string is not needed during the check.  Having only
the unhandled options suffices.

No functional change.

lint: fix crash from ckgetopt.c 1.2 and document the data structures

Prevent crashing when options are NULL in libc while linting
    src/lib/libc/posix1e/acl_from_text.c

lint: fix build in tools mode

lint: warn about mismatch in getopt handling