CVS log for src/usr.bin/telnet/commands.c

Up to [cvs.NetBSD.org] / src / usr.bin / telnet

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Prevent crashes as shown in PR 56918.

preserve errno because we are doing system calls between error printing
and error setting.

restore perror -> warn (reported by Havard Eidnes)

Mostly merge changes from HEAD upto 20200411

use memmove() instead of strncpy() for overlapping strings.
ensure nul termination.

Sync with HEAD

Synch with HEAD

Match the function prototype of encrypthandler instead of casting to it.
Make GCC 9 snapshot happier with the code

While here, remove unnecessary braces around return (KNF).

unifdef compatibility for old BSD servers. This has been
disabled, so no binary change. from openbsd.

Avoid unnecessary casts, from openbsd. No binary change.

Sync with HEAD, resolve a few conflicts

minor cleanup:
- more const
- prevent overflow of the argument vector
- change a lot of unsigned to signed to eliminate casts

G/C In3270 - always false

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

Sync with HEAD

GC header left from earlier diagnostic test.

Remove source routing support.

sync with head

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- Minimal diffs to separate MKCRYPTO from USE_KERBEROS

volatile fixes from Anon Ymous

end the argument list to exec*(3) with a NULL instead of a bare '0', as
the latter isn't a pointer context in these varargs functions.

Add support for RFC 3542 Adv. Socket API for IPv6 (which obsoletes 2292).
* RFC 3542 isn't binary compatible with RFC 2292.
* RFC 2292 support is on by default but can be disabled.
* update ping6, telnet and traceroute6 to the new API.

From the KAME project (www.kame.net).
Reviewed by core.

Turn if/then/elif into a switch

Rename debug to telnet_debug, to allow static linking with libssh.a.

fix compilation after changes to telopts. I will revisit this and constify
it later.

Pull up revision 1.61 (requested by atatat in ticket #87):
charaters -> characters

charaters -> characters

NI_WITHSCOPEID was not picked up by IETF standardization process.

- deal with a dead tty in ttyflush() by cleaning-up and exiting instead of
  returning a failure code and processing that all the way up the stack.
- deal with a dead peer similarly and do it without setjmp/longjmp() (at
  christos' request).

These fix bin/20304 and my own observations when the remote abruptly closes
the connection.

Homogenize usage messages: make the 'usage' word all lowercase, as this seems
to be the most common practice in our tree.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

more unifdef

more unifdef

remove unneeded #ifdef.  (confirmed that same *.o is generated)

use bounded copy ops

strlcpy

Ansify.

one <sys/cdefs.h> include is enough
fixes PR misc/21340 by Igor Sobrado

- Support -4 and -6.  Approved by itojun.

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

Make telnet escape work in tn3270

PR: 1816

just to be sure, set telnetport to 0.
From: Pekka Savola <pekkas@netcore.fi>

comment or delete text after CPP directives.

Fix possible buffer overruns. From OpenBSD, but without breaking stuff.

Update from trunk:
Bring the telnet situation back into better shape.  Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
  module.
- Add connection encryption support to the Heimdal Kerberos 5
  module.  Hints on this can be taken from the MIT Kerberos 5
  module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

Bring the telnet situation back into better shape.  Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
  module.
- Add connection encryption support to the Heimdal Kerberos 5
  module.  Hints on this can be taken from the MIT Kerberos 5
  module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

add missing #ifdef INET6, to compile without -DINET6.
From: Mason Loring Bliss <mason@acheron.middleboro.ma.us>

Convert telnet and top to the new termcap interface.  This stops some
buffer overflows in top from ever happening.

recover old error message on unknown service ("telnet localhost foo"
when foo is not valid).  gai_strerror may be too generic.
fix suggested in openbsd camp.

sync comment for sourceroute() to reality

use getnameinfo for "Trying ::1..." message, to enable printing of
IPv6 scopeid.

sync with latest libipsec/kernel.

clarify reverse lookup and -N.
getaddrinfo(AI_CANONNAME) does not imply reverse lookup.

Pull up to last week's -current.

remove setuid(getuid()).  they are unnecessary as noone is going to
setuid telnet(1).

i'm not sure why it is here (maybe someone reused this code from
other setuid'ed program, or someone cut-and-pasted the code from
somewhere else?), it was from revision 1.1 (= 4.4BSD).

briefly discussed in: tech-net?

clarify getaddrinfo() loop.  try to contact all possible addresses
unless we experience fatal error.
XXX changed location of setuid(getuid()), may need someone's review.

clarify reverse address lookup (-N).  AI_NUMERICHOST is for forward lookup.

XXX RFC2553 does not say that AI_CANONNAME means reverse lookup.
we need to check if getaddrinfo(3) implementation is correct.

Remove extraneous colons and newlines from perror(3) arguments.

Add -N option (numeric host address) - idea taken from FreeBSD.
Fix bug where -E8 would still pick up 0xFF as escape (again from FreeBSD)

fix handling of port number preceded by minus sign to restore documented behavior

clarify socket-connect trial loop.  fix freeaddrinfo().
adjust indentation (commands.c uses sw=4 ts=8).

Whitespace cleanup.

bark if mismatched address families are found on source route.

IPv6-ready telnet.
source route (telnet @localhost@localhost) works for IPv6 as well.

- synchronize with the domestic version
- setupterm -> setup_term
- char -> unsigned char

const poisoning.

Declare ints, too, don't default them.

Fix pasto in previous.

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

use static int instead of static

Avoid GCC warning on m68k.

Adjust for tn3270 cleanup.

Add a cast to make the compiler happy on the Alpha.

Fix compile error of tn3270/tn3270; getpgrp() takes no argument.

WARNSify and fix problems passing int * -> long *

sync up with domestic fixes

RCS id cosmetics.

restore last of the lost local changes.

replace another lost change: "help" is a valid hostname.

update to 95.10.23 version of telnet
also, RCS ID police

contrary to unpopular opinion, 'help' is a perfectly valid hostname.

Squish #581.

headers, and use INADDR_NONE appropriately.

020 -> IPTOS_LOWDELAY

new telnet from ftp.cray.com.  Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

fix sending simple commands, from Jonathan Stone <jonathan@CS.Stanford.EDU>

Cleanup for GCC 2.

initial import of 386bsd-0.1 sources

Initial revision