The NetBSD Project

CVS log for src/usr.bin/make/unit-tests/varparse-errors.exp

[BACK] Up to [cvs.NetBSD.org] / src / usr.bin / make / unit-tests

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.10 / (download) - annotate - [select for diffs], Sun Nov 19 22:06:15 2023 UTC (3 months, 2 weeks ago) by rillig
Branch: MAIN
CVS Tags: triaxx-drm, HEAD
Changes since 1.9: +14 -14 lines
Diff to previous 1.9 (colored)

make: replace 'variable expression' with 'expression' in diagnostics

Revision 1.9 / (download) - annotate - [select for diffs], Thu Jun 1 20:56:35 2023 UTC (9 months ago) by rillig
Branch: MAIN
Changes since 1.8: +4 -4 lines
Diff to previous 1.8 (colored)

tests/make: force line-based diagnostics to be listed in the tests

This way, contradictions between the intended output and the actual
output are closer together and have a better chance of being spotted.

Revision 1.8 / (download) - annotate - [select for diffs], Tue Feb 14 21:56:48 2023 UTC (12 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.7: +4 -4 lines
Diff to previous 1.7 (colored)

make: remove redundant type VarParseResult

No functional change.

Revision 1.7 / (download) - annotate - [select for diffs], Wed Aug 24 22:09:41 2022 UTC (18 months, 1 week ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10-0-RC5, netbsd-10-0-RC4, netbsd-10-0-RC3, netbsd-10-0-RC2, netbsd-10-0-RC1, netbsd-10
Changes since 1.6: +10 -33 lines
Diff to previous 1.6 (colored)

make: prevent future out-of-bounds errors when parsing expressions

A modifier in an expression ends not only at the next ':' or at the
closing '}' or ')', but also at the end of the string.

Previously, testing for the end of the string had been done separately,
which was error-prone since 2006-05-11, when indirect modifiers were
introduced.  Since then, it was possible that the string terminator '\0'
was accidentally skipped in cases where the loop condition only tested
for the ending character.  When parsing indirect modifiers, the ending
character is indeed '\0', but when parsing direct modifiers, it is '}'
or ')'.

A welcome side effect is that in the case of unclosed expressions such
as '${VAR:Modifier', the amount of error messages is reduced from 2 or 3
to only 1.  The removed error messages were wrong and thus confusing
anyway.

Revision 1.6 / (download) - annotate - [select for diffs], Wed Aug 24 21:38:06 2022 UTC (18 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.5: +37 -0 lines
Diff to previous 1.5 (colored)

tests/make: test misleading error messages on unclosed expressions

The error messages say 'Unknown modifier' or 'Bad modifier', which is
not entirely correct.  The modifier in itself is valid, it's just that
make doesn't expect the end of the string after the modifier.

Revision 1.5 / (download) - annotate - [select for diffs], Mon Jan 24 22:59:49 2022 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.4: +6 -0 lines
Diff to previous 1.4 (colored)

tests/make: demonstrate that the 'static' in Var_Parse has an effect

Revision 1.4 / (download) - annotate - [select for diffs], Tue Feb 23 15:19:41 2021 UTC (3 years ago) by rillig
Branch: MAIN
CVS Tags: cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.3: +2 -2 lines
Diff to previous 1.3 (colored)

make: improve error message for unknown modifier

Back in 1995, the modifiers were all single-character, and it made sense
to print only the first character.  Nowadays, with ':S', ':@var@...@',
'::=' and several others, a little more context is useful to see where
the exact error is.  The actual modifier is still guessed, and the guess
may be wrong as soon as backslashes get involved, but it is still better
than before.

Revision 1.3 / (download) - annotate - [select for diffs], Sun Dec 20 19:47:34 2020 UTC (3 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.2: +5 -3 lines
Diff to previous 1.2 (colored)

make(1): error out on unknown variable modifiers at parse time

Before, make printed an "error message" that did not include the word
error and thus was not easily identified as such.  This "error message"
also did not influence the exit status in the default mode but only in
-dL mode.  The error message also didn't include any line number
information and was thus rude.

Revision 1.2 / (download) - annotate - [select for diffs], Tue Dec 1 20:15:23 2020 UTC (3 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.1: +2 -0 lines
Diff to previous 1.1 (colored)

make(1): add test for parse errors in variable name in Var_SetWithFlags

Revision 1.1 / (download) - annotate - [select for diffs], Sun Nov 8 16:44:47 2020 UTC (3 years, 3 months ago) by rillig
Branch: MAIN

make(1): add test for expanding variable expressions

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>