The NetBSD Project

CVS log for src/usr.bin/make/unit-tests/varname-dot-shell.exp

[BACK] Up to [cvs.NetBSD.org] / src / usr.bin / make / unit-tests

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.16 / (download) - annotate - [select for diffs], Sat Mar 26 14:34:07 2022 UTC (10 months, 1 week ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10, HEAD
Changes since 1.15: +1 -1 lines
Diff to previous 1.15 (colored)

make: avoid trailing whitespace in debug log for variables

Since trailing whitespace is invisible, describe the variable value in
words to make it visible.

Revision 1.15 / (download) - annotate - [select for diffs], Sat Mar 26 14:17:46 2022 UTC (10 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

make: add space after colon in debug logging for variables

These log messages are intended for human interpretation, so don't make
them unnecessarily hard to read.

Revision 1.14 / (download) - annotate - [select for diffs], Thu Mar 3 19:36:35 2022 UTC (10 months, 4 weeks ago) by rillig
Branch: MAIN
Changes since 1.13: +3 -3 lines
Diff to previous 1.13 (colored)

make: make debug logging for comparisons less technical

Revision 1.13 / (download) - annotate - [select for diffs], Tue Dec 28 15:49:00 2021 UTC (13 months ago) by rillig
Branch: MAIN
Changes since 1.12: +6 -6 lines
Diff to previous 1.12 (colored)

make: make debug logging a bit more human-friendly

The previous log format "ParseReadLine (%d): '%s'" focused on the
implementation, it was not immediately obvious to a casual reader that
the number in parentheses was the line number.  Additionally, having
both a colon and quotes in a log message is uncommon.  The quotes have
been added in parse.c 1.127 from 2007-01-01.

The new log format "Parsing line %d: %s" is meant to be easier readable
by humans.  The quotes are not needed since ParseReadLine always strips
trailing whitespace, leaving no room for ambiguities.  The other log
messages follow common punctuation rules, which makes the beginning of
the line equally unambiguous.  Before var.c 1.911 from 2021-04-05,
variable assignments were logged with the format "%s:%s = %s", without a
space after the colon.

Revision 1.12 / (download) - annotate - [select for diffs], Mon Apr 5 13:35:41 2021 UTC (21 months, 3 weeks ago) by rillig
Branch: MAIN
CVS Tags: cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.11: +7 -7 lines
Diff to previous 1.11 (colored)

make: in debug log, add space between scope and variable name

Without this space, the debug log looked more like line noise, even
though the only punctuation was a single innocent ':'.  From a make
user's perspective, the variable name is a word of its own and should
not be visually glued to its namespace.

Revision 1.11 / (download) - annotate - [select for diffs], Sun Apr 4 10:13:09 2021 UTC (21 months, 4 weeks ago) by rillig
Branch: MAIN
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

make: remove filler word 'Do' from function names for parsing

No functional change, except for debug logging.

Revision 1.10 / (download) - annotate - [select for diffs], Mon Mar 15 15:39:13 2021 UTC (22 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.9: +7 -7 lines
Diff to previous 1.9 (colored)

make: change debug log for variable evaluation flags to lowercase

This makes them easier distinguishable from variable names since the
latter are usually uppercase.

No functional change outside debug mode.

Revision 1.9 / (download) - annotate - [select for diffs], Mon Dec 28 00:46:24 2020 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.8: +1 -1 lines
Diff to previous 1.8 (colored)

make(1): replace global preserveUndefined with VARE_KEEP_UNDEF

Controlling the expansion of variable expressions using a global
variable and a VARE flag was inconsistent.

Converting the global variable into a flag had to prerequisites:

1.  The unintended duplicate variable assignment had to be fixed, as
done in parse.c 1.520 from 2020-12-27.  Without this fix, it would have
been necessary to add more flags to Var_Exists and Var_SetWithFlags, and
this would have become too complex.

2.  There had to be a unit test demonstrating that VARE_KEEP_DOLLAR only
applies to the top-level expression and is not passed to the
subexpressions, while VARE_KEEP_UNDEF applies to all subexpressions as
well.  This test is in var-op-expand.mk 1.10 from 2020-12-28, at least
for the ':@word@' modifier.  In ParseModifierPartSubst, VARE_KEEP_UNDEF
is not passed down either, in the same way.

Revision 1.8 / (download) - annotate - [select for diffs], Sun Nov 8 16:58:34 2020 UTC (2 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.7: +1 -1 lines
Diff to previous 1.7 (colored)

make(1): rename VARE_ASSIGN to VARE_KEEP_DOLLAR

The other flags in VarEvalFlags already describe their effects, not the
place where they are used.  It's more important to know the effect.

Only a single unit test had to be adjusted.  This probably means that
there are too few tests where the special effects of VARE_KEEP_DOLLAR
come into play.  It could also mean that the effects are so simple and
obvious that they don't need any debug log, but that's not the case.

Revision 1.7 / (download) - annotate - [select for diffs], Fri Oct 30 16:09:56 2020 UTC (2 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.6: +9 -9 lines
Diff to previous 1.6 (colored)

make(1): prevent appending to read-only variables

Revision 1.6 / (download) - annotate - [select for diffs], Fri Oct 30 15:09:13 2020 UTC (2 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.5: +14 -7 lines
Diff to previous 1.5 (colored)

make(1): demonstrate how to append to a read-only variable

Revision 1.5 / (download) - annotate - [select for diffs], Fri Oct 30 15:03:58 2020 UTC (2 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.4: +16 -10 lines
Diff to previous 1.4 (colored)

make(1): move test flags for varname-dot-shell to the test itself

Revision 1.4 / (download) - annotate - [select for diffs], Tue Sep 22 06:13:39 2020 UTC (2 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.3: +2 -2 lines
Diff to previous 1.3 (colored)

make(1): move VAR_JUNK and VAR_KEEP away from VarFlags

These two flags have nothing to do with a variable.  They are only used
while evaluating a variable expression.

While here, rename the flags and make their documentation more precise.

Revision 1.3 / (download) - annotate - [select for diffs], Sun Sep 13 16:47:24 2020 UTC (2 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.2: +2 -2 lines
Diff to previous 1.2 (colored)

make(1): shorten debug output of ApplyModifiers

Having the words "eflags" and "vflags" in the debug output was too
repetitive.  That they are flags is made obvious by the '|' separator,
and the flags have clearly distinguishable names (VARE_* vs. VAR_*),
which lowers the chance for confusion.

Revision 1.2 / (download) - annotate - [select for diffs], Sun Aug 23 09:28:52 2020 UTC (2 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.1: +5 -0 lines
Diff to previous 1.1 (colored)

make(1): fix assertion failure in debug output for read-only variables

Revision 1.1 / (download) - annotate - [select for diffs], Sun Aug 23 09:18:25 2020 UTC (2 years, 5 months ago) by rillig
Branch: MAIN

make(1): add test for the newly added .SHELL variable

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>