The NetBSD Project

CVS log for src/usr.bin/make/unit-tests/varmod-remember.mk

[BACK] Up to [cvs.NetBSD.org] / src / usr.bin / make / unit-tests

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.9 / (download) - annotate - [select for diffs], Thu Feb 9 22:21:57 2023 UTC (12 months, 2 weeks ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.8: +1 -3 lines
Diff to previous 1.8 (colored)

tests/make: remove debugging directive from test for ':_'

Revision 1.8 / (download) - annotate - [select for diffs], Thu Feb 9 08:22:10 2023 UTC (12 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.7: +54 -21 lines
Diff to previous 1.7 (colored)

tests/make: extend and explain test for the ':_' modifier

Revision 1.7 / (download) - annotate - [select for diffs], Thu Feb 9 07:34:15 2023 UTC (12 months, 2 weeks ago) by sjg
Branch: MAIN
Changes since 1.6: +13 -1 lines
Diff to previous 1.6 (colored)

make: ApplyModifier_Remember always use SCOPE_GLOBAL

Conditionals evaluate vars with SCOPE_CMDLINE, if :_
is used within a conditional expression and is thus
set in SCOPE_CMDLINE, it breaks any use of :_ in SCOPE_GLOBAL.

The simplest solution is for :_ to always use SCOPE_GLOBAL

Reviewed by: rillig

Revision 1.6 / (download) - annotate - [select for diffs], Sun Mar 14 17:27:27 2021 UTC (2 years, 11 months ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10-0-RC4, netbsd-10-0-RC3, netbsd-10-0-RC2, netbsd-10-0-RC1, netbsd-10, cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.5: +5 -2 lines
Diff to previous 1.5 (colored)

make: do not expand the variable name in the ':_' modifier

This edge case had been so obscure that even discovering this takes
quite some time and requires reading the source code of make.

The manual page doesn't document whether the variable name is expanded
or not, it doesn't even give an example.  When this obscure modifier was
initially added in var.c 1.210 from 2017-01-30, Var_Set always expanded
the variable name once, and there was no way around it.  Therefore this
expansion has probably been unintentional.

Revision 1.5 / (download) - annotate - [select for diffs], Sun Mar 14 17:14:15 2021 UTC (2 years, 11 months ago) by rillig
Branch: MAIN
Changes since 1.4: +13 -1 lines
Diff to previous 1.4 (colored)

tests/make: demonstrate unintended edge case for the ':_' modifier

Revision 1.4 / (download) - annotate - [select for diffs], Sun Mar 14 17:07:11 2021 UTC (2 years, 11 months ago) by rillig
Branch: MAIN
Changes since 1.3: +11 -3 lines
Diff to previous 1.3 (colored)

tests/make: convert test for ':_' modifier to parse time

Revision 1.3 / (download) - annotate - [select for diffs], Sun Aug 23 15:18:43 2020 UTC (3 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.2: +7 -4 lines
Diff to previous 1.2 (colored)

make(1): move tests for the :tu and :_ modifiers into separate files

Revision 1.2 / (download) - annotate - [select for diffs], Sun Aug 16 14:25:16 2020 UTC (3 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.1: +3 -2 lines
Diff to previous 1.1 (colored)

make(1): describe the purpose of each newly added unit test dummy

Revision 1.1 / (download) - annotate - [select for diffs], Sun Aug 16 12:07:51 2020 UTC (3 years, 6 months ago) by rillig
Branch: MAIN

make(1): add dummies for fine-grained tests, one per single feature

The test names have been derived from the current manual page.

All these tests are dummies right now, and the code from the existing
tests will be moved into the new tests step by step.

This is done to prevent modmisc, escape, varmod-edge and varmisc from
growing without any bounds, and to reduce the side-effects of one test
to the others.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>