The NetBSD Project

CVS log for src/usr.bin/make/unit-tests/varmod-indirect.mk

[BACK] Up to [cvs.NetBSD.org] / src / usr.bin / make / unit-tests

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.18 / (download) - annotate - [select for diffs], Sun Feb 4 10:03:10 2024 UTC (3 weeks, 3 days ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.17: +5 -12 lines
Diff to previous 1.17 (colored)

make: do not evaluate indirect modifiers in parse-only mode

Discovered by sjg.

Revision 1.17 / (download) - annotate - [select for diffs], Sun Feb 4 09:56:24 2024 UTC (3 weeks, 3 days ago) by rillig
Branch: MAIN
Changes since 1.16: +4 -3 lines
Diff to previous 1.16 (colored)

make: in parse-only mode, don't evaluate modifiers

Previously, the ':S', ':ts', ':tA' and ':from=to' modifiers were
evaluated in parse-only mode, unnecessarily.  This is only noticeable
when an indirect modifier is evaluated in parse-only mode, which is
another bug that will be fixed in a follow-up commit.

Revision 1.16 / (download) - annotate - [select for diffs], Sun Feb 4 09:29:50 2024 UTC (3 weeks, 3 days ago) by rillig
Branch: MAIN
Changes since 1.15: +16 -3 lines
Diff to previous 1.15 (colored)

tests/make: extend test for wrong evaluation in parse-only mode

Revision 1.15 / (download) - annotate - [select for diffs], Sun Feb 4 08:51:57 2024 UTC (3 weeks, 3 days ago) by rillig
Branch: MAIN
Changes since 1.14: +19 -2 lines
Diff to previous 1.14 (colored)

tests/make: indirect modifiers are evaluated in parse-only mode

Found by sjg@.

Revision 1.14 / (download) - annotate - [select for diffs], Sun Nov 19 22:32:44 2023 UTC (3 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)

tests/make: replace 'variable expressions' with 'expressions'

Revision 1.13 / (download) - annotate - [select for diffs], Sun Nov 19 21:47:52 2023 UTC (3 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.12: +11 -11 lines
Diff to previous 1.12 (colored)

tests/make: replace 'variable expression' with 'expression'

Each expression is based on a variable, there's no need for the
verbosity.  The wording in make's diagnostics will be changed in a
follow-up commit.

Revision 1.12 / (download) - annotate - [select for diffs], Thu Jun 1 20:56:35 2023 UTC (8 months, 4 weeks ago) by rillig
Branch: MAIN
Changes since 1.11: +12 -1 lines
Diff to previous 1.11 (colored)

tests/make: force line-based diagnostics to be listed in the tests

This way, contradictions between the intended output and the actual
output are closer together and have a better chance of being spotted.

Revision 1.11 / (download) - annotate - [select for diffs], Sat Jan 15 12:35:18 2022 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10-0-RC5, netbsd-10-0-RC4, netbsd-10-0-RC3, netbsd-10-0-RC2, netbsd-10-0-RC1, netbsd-10
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

tests/make: ensure that the 'expect' comments in tests are correct

Based on tests/usr.bin/xlint/check-expect.lua.

For now, this extra check needs to be run manually.

Revision 1.10 / (download) - annotate - [select for diffs], Sat Jan 8 20:21:34 2022 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.9: +2 -2 lines
Diff to previous 1.9 (colored)

make: fix reported line numbers of continuation lines (since 2002)

Previously, multi-line directives like '.info' or '.error' reported the
line number of their last line instead of their first line, which is
more usual.  This also affected the debug log from '-dp'.

Revision 1.9 / (download) - annotate - [select for diffs], Mon Mar 15 20:00:50 2021 UTC (2 years, 11 months ago) by rillig
Branch: MAIN
CVS Tags: cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

make: rename ApplyModifiersState to ModChain

The new name accurately describes the structural element that holds such
properties as the separator character and whether the expression value
is considered a single word.  The old name ApplyModifiersState was too
long and was meant as a placeholder anyway, when I introduced it in
var.c 1.236 from 2020-07-03.

Revision 1.8 / (download) - annotate - [select for diffs], Sun Feb 14 17:47:33 2021 UTC (3 years ago) by rillig
Branch: MAIN
Changes since 1.7: +24 -3 lines
Diff to previous 1.7 (colored)

make: add test for indirect ':U' modifier

Unlike ':ts' and ':tW', the effects of ':U' are visible even after the
modifiers from the nested expression have been applied.  These subtle
details, like many others, are not documented in the manual page.

Revision 1.7 / (download) - annotate - [select for diffs], Sun Feb 14 17:22:37 2021 UTC (3 years ago) by rillig
Branch: MAIN
Changes since 1.6: +5 -3 lines
Diff to previous 1.6 (colored)

make: document since when indirect modifiers are supported

Revision 1.6 / (download) - annotate - [select for diffs], Sun Feb 14 16:12:46 2021 UTC (3 years ago) by rillig
Branch: MAIN
Changes since 1.5: +71 -4 lines
Diff to previous 1.5 (colored)

make: add more tests for edge cases in evaluating variable expressions

As a preparation for refactoring the code around variable expressions,
there need to be a few tests for indirect variable modifiers since these
were not covered before.

Indirect modifiers may include ':ts' and ':tW', which change the
interpretation of the variable expression in small details.  The scope
of these changes is limited to the indirect modifier, any evaluations
outside this indirect modifier are unaffected.

The changes to the .exp file are mostly line number changes, plus a
demonstration of a newly found bug, where an expression is evaluated
successfully despite producing a parse error.

Revision 1.5 / (download) - annotate - [select for diffs], Sun Dec 27 17:32:25 2020 UTC (3 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.4: +8 -2 lines
Diff to previous 1.4 (colored)

make(1): split test for indirect modifiers into paragraphs

Revision 1.4 / (download) - annotate - [select for diffs], Sun Dec 27 17:17:46 2020 UTC (3 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.3: +39 -3 lines
Diff to previous 1.3 (colored)

make(1): add tests for parsing indirect modifiers in nested expressions

Revision 1.3 / (download) - annotate - [select for diffs], Sun Dec 27 16:31:58 2020 UTC (3 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.2: +14 -1 lines
Diff to previous 1.2 (colored)

make(1): remove dead code from ApplyModifiersIndirect

At that point, the expression can never be varUndefined.  At the
beginning of ParseVarnameLong, the expression is initialized to a simple
empty string, and that string is only ever converted to varUndefined at
the very end of Var_Parse.

Revision 1.2 / (download) - annotate - [select for diffs], Sun Dec 20 19:29:06 2020 UTC (3 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.1: +31 -1 lines
Diff to previous 1.1 (colored)

make(1): move tests for indirect modifiers around

The next commit will error out on unknown modifiers and influence the
exit status.  The test modmisc.mk contains both parse time tests and run
time tests.  To prevent the latter from being run, the parse error is
moved to varmod-indirect.mk, which only contains parse time tests.

Revision 1.1 / (download) - annotate - [select for diffs], Tue Dec 1 22:16:36 2020 UTC (3 years, 2 months ago) by rillig
Branch: MAIN

make(1): add test and tutorial for indirect modifiers

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>