The NetBSD Project

CVS log for src/usr.bin/make/unit-tests/varmod-defined.exp

[BACK] Up to [cvs.NetBSD.org] / src / usr.bin / make / unit-tests

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.13 / (download) - annotate - [select for diffs], Tue Aug 23 19:22:01 2022 UTC (5 months, 1 week ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10, HEAD
Changes since 1.12: +0 -1 lines
Diff to previous 1.12 (colored)

make: revert parsing of modifier parts (since 2022-08-08)

The modifier ':@var@body@' parses the body in parse-only mode and later
uses Var_Subst on it, in which each literal '$' must be written as '$$'.

Trying to parse the loop body using Var_Parse treated the text
'$${var:-0}' as a single '$' followed by the expression '${var:-0}',
wrongly complaining about the 'Unknown modifier "-0"'.

Found by sjg.

Revision 1.12 / (download) - annotate - [select for diffs], Mon Aug 8 18:23:30 2022 UTC (5 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.11: +1 -0 lines
Diff to previous 1.11 (colored)

make: fix parsing of modifiers containing unbalanced subexpressions

Revision 1.11 / (download) - annotate - [select for diffs], Sat Mar 26 14:34:07 2022 UTC (10 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.10: +1 -1 lines
Diff to previous 1.10 (colored)

make: avoid trailing whitespace in debug log for variables

Since trailing whitespace is invisible, describe the variable value in
words to make it visible.

Revision 1.10 / (download) - annotate - [select for diffs], Sat Mar 26 14:17:46 2022 UTC (10 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.9: +1 -1 lines
Diff to previous 1.9 (colored)

make: add space after colon in debug logging for variables

These log messages are intended for human interpretation, so don't make
them unnecessarily hard to read.

Revision 1.9 / (download) - annotate - [select for diffs], Sat Nov 20 17:51:48 2021 UTC (14 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.8: +1 -1 lines
Diff to previous 1.8 (colored)

make: use correct plural form in debug message

Revision 1.8 / (download) - annotate - [select for diffs], Mon Apr 5 13:35:41 2021 UTC (21 months, 4 weeks ago) by rillig
Branch: MAIN
CVS Tags: cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.7: +8 -8 lines
Diff to previous 1.7 (colored)

make: in debug log, add space between scope and variable name

Without this space, the debug log looked more like line noise, even
though the only punctuation was a single innocent ':'.  From a make
user's perspective, the variable name is a word of its own and should
not be visually glued to its namespace.

Revision 1.7 / (download) - annotate - [select for diffs], Mon Apr 5 13:14:55 2021 UTC (21 months, 4 weeks ago) by rillig
Branch: MAIN
Changes since 1.6: +2 -2 lines
Diff to previous 1.6 (colored)

make: be more verbose in -dv debug logging

The previous log output was too brief to be understandable.  Give more
hints by describing each part of the expression when evaluating a
modifier.  Distinguish between parse-only mode and eval mode since in
parse-only mode most of the details are irrelevant.

Revision 1.6 / (download) - annotate - [select for diffs], Sat Apr 3 22:02:59 2021 UTC (22 months ago) by rillig
Branch: MAIN
Changes since 1.5: +4 -4 lines
Diff to previous 1.5 (colored)

make: remove VarFlags from debug logging

Before the introduction of ExprDefined, VarFlags contained whether the
expression was defined or not, which was useful to know since the final
value of the expression depends on this information.  The other VarFlags
do not influence the evaluation, so there is no point logging them.

Revision 1.5 / (download) - annotate - [select for diffs], Mon Mar 15 15:39:13 2021 UTC (22 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.4: +9 -9 lines
Diff to previous 1.4 (colored)

make: change debug log for variable evaluation flags to lowercase

This makes them easier distinguishable from variable names since the
latter are usually uppercase.

No functional change outside debug mode.

Revision 1.4 / (download) - annotate - [select for diffs], Mon Feb 15 18:23:32 2021 UTC (23 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.3: +4 -4 lines
Diff to previous 1.3 (colored)

make: rename ExprDefined constants for debug logging

Revision 1.3 / (download) - annotate - [select for diffs], Mon Dec 28 00:46:24 2020 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.2: +9 -9 lines
Diff to previous 1.2 (colored)

make(1): replace global preserveUndefined with VARE_KEEP_UNDEF

Controlling the expansion of variable expressions using a global
variable and a VARE flag was inconsistent.

Converting the global variable into a flag had to prerequisites:

1.  The unintended duplicate variable assignment had to be fixed, as
done in parse.c 1.520 from 2020-12-27.  Without this fix, it would have
been necessary to add more flags to Var_Exists and Var_SetWithFlags, and
this would have become too complex.

2.  There had to be a unit test demonstrating that VARE_KEEP_DOLLAR only
applies to the top-level expression and is not passed to the
subexpressions, while VARE_KEEP_UNDEF applies to all subexpressions as
well.  This test is in var-op-expand.mk 1.10 from 2020-12-28, at least
for the ':@word@' modifier.  In ParseModifierPartSubst, VARE_KEEP_UNDEF
is not passed down either, in the same way.

Revision 1.2 / (download) - annotate - [select for diffs], Sun Nov 8 20:29:13 2020 UTC (2 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.1: +22 -0 lines
Diff to previous 1.1 (colored)

make(1): add test demonstrating the :D modifier with := assignments

Revision 1.1 / (download) - annotate - [select for diffs], Sun Aug 16 12:07:51 2020 UTC (2 years, 5 months ago) by rillig
Branch: MAIN

make(1): add dummies for fine-grained tests, one per single feature

The test names have been derived from the current manual page.

All these tests are dummies right now, and the code from the existing
tests will be moved into the new tests step by step.

This is done to prevent modmisc, escape, varmod-edge and varmisc from
growing without any bounds, and to reduce the side-effects of one test
to the others.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>