The NetBSD Project

CVS log for src/usr.bin/make/unit-tests/suff-main-several.exp

[BACK] Up to [] / src / usr.bin / make / unit-tests

Request diff between arbitrary revisions

Default branch: MAIN

Revision 1.10 / (download) - annotate - [select for diffs], Sat Sep 9 16:41:04 2023 UTC (5 months, 2 weeks ago) by sjg
Branch: MAIN
Changes since 1.9: +1 -0 lines
Diff to previous 1.9 (colored)

Add .MAKE.JOBS.C to indicate wether -jC is supported

Revision 1.9 / (download) - annotate - [select for diffs], Tue Jan 24 00:24:02 2023 UTC (13 months ago) by sjg
Branch: MAIN
Changes since 1.8: +1 -1 lines
Diff to previous 1.8 (colored)

make: .SYSPATH: to add dirs to sysIncPath

.SYSPATH: with no sources will clear sysIncPath
otherwise sources are added

Reviewed by: rillig

Revision 1.8 / (download) - annotate - [select for diffs], Sat Mar 26 14:34:07 2022 UTC (23 months ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10-0-RC4, netbsd-10-0-RC3, netbsd-10-0-RC2, netbsd-10-0-RC1, netbsd-10
Changes since 1.7: +5 -5 lines
Diff to previous 1.7 (colored)

make: avoid trailing whitespace in debug log for variables

Since trailing whitespace is invisible, describe the variable value in
words to make it visible.

Revision 1.7 / (download) - annotate - [select for diffs], Tue Dec 28 15:49:00 2021 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.6: +15 -15 lines
Diff to previous 1.6 (colored)

make: make debug logging a bit more human-friendly

The previous log format "ParseReadLine (%d): '%s'" focused on the
implementation, it was not immediately obvious to a casual reader that
the number in parentheses was the line number.  Additionally, having
both a colon and quotes in a log message is uncommon.  The quotes have
been added in parse.c 1.127 from 2007-01-01.

The new log format "Parsing line %d: %s" is meant to be easier readable
by humans.  The quotes are not needed since ParseReadLine always strips
trailing whitespace, leaving no room for ambiguities.  The other log
messages follow common punctuation rules, which makes the beginning of
the line equally unambiguous.  Before var.c 1.911 from 2021-04-05,
variable assignments were logged with the format "%s:%s = %s", without a
space after the colon.

Revision 1.6 / (download) - annotate - [select for diffs], Sun Apr 4 10:13:09 2021 UTC (2 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.5: +12 -12 lines
Diff to previous 1.5 (colored)

make: remove filler word 'Do' from function names for parsing

No functional change, except for debug logging.

Revision 1.5 / (download) - annotate - [select for diffs], Tue Feb 2 17:56:31 2021 UTC (3 years ago) by rillig
Branch: MAIN
Changes since 1.4: +8 -8 lines
Diff to previous 1.4 (colored)

make: remove overengineered Enum_ValueToString

For printing the status of a GNode, there was already made_name (now
renamed to GNodeMade_Name), which prints user-friendly text instead of
the bare enum constant names.

To do this change confidently, I first had to demonstrate that the
output really affects something other than just the word "UNMADE". There
had not been a test for that case before, and the test immediately
discovered a bug in the -dg2 and -dg3 options.  This bug is one of the
oldest in make, dating back to at least 1993.

Revision 1.4 / (download) - annotate - [select for diffs], Mon Dec 7 00:53:30 2020 UTC (3 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.3: +4 -1 lines
Diff to previous 1.3 (colored)

make(1): fix exit status in -k mode if a dependency fails

Whether in -k mode or not, the exit status tells whether all requested
targets were made or not.  If a dependency could not be made, the main
target was not made as well, therefore the exit status must be nonzero
in such a case.

This part of the code lacked proper unit tests until today.  The unit
test is compatible with make>=2003 at least, allowing
to compare the output over time.

In 2003, in the ok-ok-ok-ok case, "Making all from all-dep." was printed
twice in a row, for whatever reason  ... (40 minutes later) ... If I had
just made the two commands for 'all' and '.END' more distinguishable.
Back in 2003, the local variables for .END had not been initialized,
instead the .END node was run with the local variables of the last
preceding node.  In this case, that node was 'all', therefore ${.TARGET}
had obviously expanded to 'all'.

Somewhere in 2004, the shell commands were no longer run with the -e
flag, which resulted in the "exit status $?" line to be printed in cases
that had stopped early before.

Somewhere in 2005, the local variables for the .END node had been fixed.
The variable ${.TARGET} now had the value '.END', just as expected.  In
addition, the dependencies for the .END node were made, although without
getting their proper local variables.  This resulted in the output
"Making  out of nothing" instead of the expected "Making end-dep out of

Still in 2005, in the test case "all=ok all-dep=ok end=ok end-dep=ERR",
the error code of the failed 'end-dep' was first reported as "*** Error
code 1 (continuing)".  To compensate for this improvement, a new bug had
been introduced.  The test case "all=ok all-dep=ok end=ERR end-dep=ERR"
had properly exited with status 1 on 2005-01-01, but on 2006-01-01 it
exited with status 0, thereby ignoring errors in the .END node.

Somewhere in 2008, some of the error messages (but not all) were
directed to stderr instead of stdout.  The actual output stayed the same

Somewhere in 2011, the dependency of the .END node got its own local
variables, and ${.TARGET} now expanded to 'end-dep', as expected.

Somewhere in 2016, the two empty lines between the "*** Error code 1
(continuing)" and the "Stop." got compressed into a single empty line.

On 2020-12-07 (that is, today), the exit status 1 has been restored in
the error cases, after it had been wrong for at least 14 years.

Revision 1.3 / (download) - annotate - [select for diffs], Fri Dec 4 14:28:50 2020 UTC (3 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.2: +7 -0 lines
Diff to previous 1.2 (colored)

make(1): use fixed format for debug output of the directory cache

The previous output format had a %-20s conversion specifier.  This
produced different output depending on the length of the pathname, which
was too difficult to normalize.  By moving the directory name to the
end, it is no longer necessary to fill up any space, and the numbers are
always aligned properly.

As a result, 3 of the unit tests no longer need any special
postprocessing of their output.

Revision 1.2 / (download) - annotate - [select for diffs], Wed Nov 25 00:50:44 2020 UTC (3 years, 3 months ago) by sjg
Branch: MAIN
Changes since 1.1: +2 -0 lines
Diff to previous 1.1 (colored)


Revision 1.1 / (download) - annotate - [select for diffs], Sun Nov 22 20:36:17 2020 UTC (3 years, 3 months ago) by rillig
Branch: MAIN

make(1): add another unit test for suffix handling

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.

CVSweb <>