The NetBSD Project

CVS log for src/usr.bin/make/unit-tests/opt-debug-loud.mk

[BACK] Up to [cvs.NetBSD.org] / src / usr.bin / make / unit-tests

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.5 / (download) - annotate - [select for diffs], Tue Dec 19 19:33:40 2023 UTC (3 months, 3 weeks ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.4: +3 -3 lines
Diff to previous 1.4 (colored)

make: clean up comments

No binary change, except for line numbers in assertions.

Revision 1.4 / (download) - annotate - [select for diffs], Mon Oct 5 19:27:48 2020 UTC (3 years, 6 months ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10-0-RELEASE, netbsd-10-0-RC6, netbsd-10-0-RC5, netbsd-10-0-RC4, netbsd-10-0-RC3, netbsd-10-0-RC2, netbsd-10-0-RC1, netbsd-10, cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.3: +14 -5 lines
Diff to previous 1.3 (colored)

make(1): revert previous commit

It had accidentally reverted all the work from the past few days.

Revision 1.3 / (download) - annotate - [select for diffs], Mon Oct 5 19:24:29 2020 UTC (3 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.2: +4 -13 lines
Diff to previous 1.2 (colored)

make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)

The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25.  In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.

Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath.  Dir_ClearPath takes full ownership of the given list and
empties it.  This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.

With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table.  This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes.  This by itself
was not a problem since the hash table would be freed afterwards.  But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again.  Boom.

Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.

Revision 1.2 / (download) - annotate - [select for diffs], Sat Oct 3 07:52:30 2020 UTC (3 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.1: +14 -5 lines
Diff to previous 1.1 (colored)

make(1): add test for the -dl command line option

Revision 1.1 / (download) - annotate - [select for diffs], Sat Sep 5 06:20:51 2020 UTC (3 years, 7 months ago) by rillig
Branch: MAIN

make(1): add tests for each debug option

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>