CVS log for src/usr.bin/make/unit-tests/cond-token-plain.mk

Up to [cvs.NetBSD.org] / src / usr.bin / make / unit-tests

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

make: in error message about conditionals, use single quotes

Single quotes are used less often in the conditionals themselves, which
leads to fewer confusions.

tests/make: replace 'variable expression' with 'expression'

Each expression is based on a variable, there's no need for the
verbosity.  The wording in make's diagnostics will be changed in a
follow-up commit.

tests/make: force line-based diagnostics to be listed in the tests

This way, contradictions between the intended output and the actual
output are closer together and have a better chance of being spotted.

make: don't interpret the return value of Var_Parse

The return value of Var_Parse is largely redundant to the returned
string.  The idea behind the type VarParseResult was to migrate all call
sites to checking this return value instead of the returned string, but
that hasn't happened.  Instead, the additional type only added more
complexity.

There was a single place where that return value was actually used, when
parsing conditions.  And even in that case, ignoring the VarParseResult
added back an error message that previously hid bugs, in the test
cond-token-plain.mk.

Even though these error messages are redundant in the other tests, they
don't hurt as they don't happen often.

tests/make: reduce trailing whitespace

tests/make: demonstrate edge case that evaluates an expression twice

tests/make: refine comments for parsing and evaluating conditions

make: rename ParseFuncArg to ParseWord, update comments

No functional change.

make: do not allow unquoted 'left == right' after modifier ':?'

Having a static variable for state that clearly belongs in the parser
looked suspicious, and indeed it was wrong.

When the distinction between .if conditions and expressions of the form
${condition:?:} was added in cond.c 1.68 from 2015-05-05, a new unit
test was added, but it didn't cover this edge case.  At that time, the
state of the condition parser consisted of a few global variables
instead of a separate data type, as would have been appropriate for
parsing nested conditions.

tests/make: demonstrate unintended unquoted string in conditions

make(1): demonstrate parse error without error message in conditional

make(1): add test case for bare word containing quotes

make(1): add more tests for edge cases in conditionals

make(1): add more tests for tokens in conditionals

make(1): add remarks to the tests about conditions

make(1): document handling of '#' and '\n' in conditionals

make(1): add tests for comparison tokens without whitespace

make(1): add tests for really strange edge cases in conditions

make(1): describe the purpose of each newly added unit test dummy

make(1): add dummies for fine-grained tests, one per single feature

The test names have been derived from the current manual page.

All these tests are dummies right now, and the code from the existing
tests will be moved into the new tests step by step.

This is done to prevent modmisc, escape, varmod-edge and varmisc from
growing without any bounds, and to reduce the side-effects of one test
to the others.