The NetBSD Project

CVS log for src/usr.bin/make/unit-tests/cond-func-empty.mk

[BACK] Up to [cvs.NetBSD.org] / src / usr.bin / make / unit-tests

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.24 / (download) - annotate - [select for diffs], Tue Dec 19 19:33:40 2023 UTC (2 months, 1 week ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.23: +2 -2 lines
Diff to previous 1.23 (colored)

make: clean up comments

No binary change, except for line numbers in assertions.

Revision 1.23 / (download) - annotate - [select for diffs], Sun Nov 19 21:47:52 2023 UTC (3 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.22: +8 -8 lines
Diff to previous 1.22 (colored)

tests/make: replace 'variable expression' with 'expression'

Each expression is based on a variable, there's no need for the
verbosity.  The wording in make's diagnostics will be changed in a
follow-up commit.

Revision 1.22 / (download) - annotate - [select for diffs], Fri Aug 11 05:01:12 2023 UTC (6 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.21: +2 -2 lines
Diff to previous 1.21 (colored)

tests/make: fix grammar in a test comment

Revision 1.21 / (download) - annotate - [select for diffs], Wed Jun 28 06:15:42 2023 UTC (8 months ago) by rillig
Branch: MAIN
Changes since 1.20: +25 -11 lines
Diff to previous 1.20 (colored)

tests/make: extend test for the 'empty' function in conditions

Revision 1.20 / (download) - annotate - [select for diffs], Thu Jun 1 20:56:35 2023 UTC (8 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.19: +3 -2 lines
Diff to previous 1.19 (colored)

tests/make: force line-based diagnostics to be listed in the tests

This way, contradictions between the intended output and the actual
output are closer together and have a better chance of being spotted.

Revision 1.19 / (download) - annotate - [select for diffs], Thu Jun 1 07:27:30 2023 UTC (8 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)

tests/make: clean up comments, extend a few tests

Revision 1.18 / (download) - annotate - [select for diffs], Sat Mar 4 21:15:30 2023 UTC (11 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.17: +25 -22 lines
Diff to previous 1.17 (colored)

tests/make: improve explanations in test for 'empty' function

Revision 1.17 / (download) - annotate - [select for diffs], Tue Dec 28 22:13:56 2021 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10-0-RC4, netbsd-10-0-RC3, netbsd-10-0-RC2, netbsd-10-0-RC1, netbsd-10
Changes since 1.16: +14 -3 lines
Diff to previous 1.16 (colored)

tests/make: test function names without following '('

Revision 1.16 / (download) - annotate - [select for diffs], Sat Dec 11 10:41:31 2021 UTC (2 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.15: +6 -6 lines
Diff to previous 1.15 (colored)

make: inline ParseEmptyArg into CondParser_FuncCallEmpty

No functional change.

Revision 1.15 / (download) - annotate - [select for diffs], Sat Dec 11 09:53:53 2021 UTC (2 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.14: +42 -33 lines
Diff to previous 1.14 (colored)

tests/make: proofread and clean up comments for function 'empty'

This prepares a refactoring for handling the function 'empty' in
conditionals like '.if'.

The function 'empty' is fundamentally different from all other functions
since it is parsed differently and passes its result on different path
than the other functions.  Splitting up these code paths will untangle
the control flow of parsing a condition like 'empty(VARNAME)'.  It will
also remove several ARGSUSED and MAKE_ATTR_UNUSED that make the current
code smell.

Revision 1.14 / (download) - annotate - [select for diffs], Sun Apr 11 13:35:56 2021 UTC (2 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.13: +4 -4 lines
Diff to previous 1.13 (colored)

make: clean up remaining references to VarEvalFlags

VarEvalFlags has been replaced with VarEvalMode.  There were some
comments and tests that still referred to the old names.

No functional change.

Revision 1.13 / (download) - annotate - [select for diffs], Mon Mar 15 12:15:03 2021 UTC (2 years, 11 months ago) by rillig
Branch: MAIN
Changes since 1.12: +5 -5 lines
Diff to previous 1.12 (colored)

make: replace enum bit-field with struct bit-field for VarEvalFlags

This makes the code easier to read, especially in var.c.  It also makes
debugging sessions easier since some debuggers don't show enum
bit-fields symbolically as soon as more than one bit is set.

The code outside var.c is basically unchanged, except that instead of
passing the individual flags, there are 4 predefined evaluation modes.
These suffice for all practical use cases.  Only in the implementation
deep inside var.c, the value of the flags keepDollar and keepUndef
differs.

There is no way of passing the struct to EnumFlags_ToString, which means
the ToString function has to be spelled out explicitly.  This allows for
fine-tuning the representation in the debug log, to reduce the amount of
uppercae letters.

No functional change.

Revision 1.12 / (download) - annotate - [select for diffs], Mon Feb 22 20:38:55 2021 UTC (3 years ago) by rillig
Branch: MAIN
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

make: update constant names in comments

No functional change.

Revision 1.11 / (download) - annotate - [select for diffs], Sat Nov 28 14:08:37 2020 UTC (3 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.10: +26 -1 lines
Diff to previous 1.10 (colored)

make(1): move test for recursive variable to cond-func-empty

Previously, the documentation of that test was much too short to explain
all the effects that happened in the bug situation from 2020-06-28 until
2020-07-02.

Revision 1.10 / (download) - annotate - [select for diffs], Sun Nov 15 14:07:53 2020 UTC (3 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.9: +19 -17 lines
Diff to previous 1.9 (colored)

make(1): clean up some tests

Fix some mistakes in comments.

Improve some comments to be easier understandable.

Inline variables that are irrelevant for the test at hand (RUN,
MAKE_CMD).

Remove references to functions and constants that have since been removed
or renamed.

Revision 1.9 / (download) - annotate - [select for diffs], Sat Nov 7 14:37:31 2020 UTC (3 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.8: +8 -1 lines
Diff to previous 1.8 (colored)

make(1): add test for parse error in condition using empty()

Revision 1.8 / (download) - annotate - [select for diffs], Wed Sep 23 08:11:28 2020 UTC (3 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.7: +14 -1 lines
Diff to previous 1.7 (colored)

make(1): add tests for spaces in condition functions

Revision 1.7 / (download) - annotate - [select for diffs], Wed Sep 23 07:50:58 2020 UTC (3 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.6: +2 -2 lines
Diff to previous 1.6 (colored)

make(1): fix unexpected behavior in ::= variable modifier

Previously, the ::= modifier had returned an error value, which caused
the variable expression to be preserved.  This behavior was not useful
in this case; it had only been intended to be used for undefined
variables.

To fix it, distinguish between parse errors, undefined variables and
regular empty strings.

Revision 1.6 / (download) - annotate - [select for diffs], Fri Sep 4 21:08:44 2020 UTC (3 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

make(1): rename local functions for parsing conditions

The word "get" implies a cheap operation without side effects.  Parsing
instead has lots of side effects, even if it's only that the parsing
position is updated.

Revision 1.5 / (download) - annotate - [select for diffs], Fri Sep 4 20:51:01 2020 UTC (3 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.4: +13 -1 lines
Diff to previous 1.4 (colored)

make(1): migrate get_mpt_arg to Var_ParsePP

This part is covered well by the unit tests.  When I forgot to decrement
the linePtr, several of them failed reliably.

Revision 1.4 / (download) - annotate - [select for diffs], Fri Sep 4 20:28:16 2020 UTC (3 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.3: +4 -1 lines
Diff to previous 1.3 (colored)

make(1): add more explanation for undefined variable expressions

Revision 1.3 / (download) - annotate - [select for diffs], Thu Sep 3 17:13:42 2020 UTC (3 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.2: +117 -3 lines
Diff to previous 1.2 (colored)

make(1): add test for the empty function in conditionals

Revision 1.2 / (download) - annotate - [select for diffs], Sun Aug 16 14:25:16 2020 UTC (3 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

make(1): describe the purpose of each newly added unit test dummy

Revision 1.1 / (download) - annotate - [select for diffs], Sun Aug 16 12:07:51 2020 UTC (3 years, 6 months ago) by rillig
Branch: MAIN

make(1): add dummies for fine-grained tests, one per single feature

The test names have been derived from the current manual page.

All these tests are dummies right now, and the code from the existing
tests will be moved into the new tests step by step.

This is done to prevent modmisc, escape, varmod-edge and varmisc from
growing without any bounds, and to reduce the side-effects of one test
to the others.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>