CVS log for src/usr.bin/login/login_pam.c

Up to [cvs.NetBSD.org] / src / usr.bin / login

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

s/begining/beginning/ in comments and messages.

usr.bin: remove unnecessary lint comment CONSTCOND

Since 2021-01-31, lint no longer warns about 'do ... while (0)'.

No functional change.

Merge changes from current as of 20200406

Avoid use-after-free bug in PAM environment

Traditional BSD putenv(3) was creating an internal copy of the passed
argument. Unfortunately this was causing memory leaks and was changed by
POSIX to not allocate.

Adapt the putenv(3) usage to modern POSIX (and NetBSD) semantics.

- Added error checks for initgroups(3) and setgroups(2).
- Reorder functions in privilege regain - setgroups(2) should be called after
  seteuid(2).

OK christos@

Pull up following revision(s) (requested by aymeric in ticket #506):
	usr.bin/login/login.c: revision 1.105
	usr.bin/login/login_pam.c: revision 1.24
Remove the syslogging of a dial out login warning based on the tty name, because
the test is sloppy and doesn't correspond to the current naming anyway.
OK gdt@
PR#377 can remain closed.

Remove the syslogging of a dial out login warning based on the tty name, because
the test is sloppy and doesn't correspond to the current naming anyway.
OK gdt@
PR#377 can remain closed.

Rebase to HEAD as of a few days ago.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

fix unused variable warnings

sync with head.

Pull up the following revisions(s) (requested by martin in ticket #215):
	usr.bin/login/login_pam.c:	revision 1.22

Fix build.
trimusername (which does not exist) should be trimloginname.

Pull up following revision(s) (requested by christos in ticket #215):
	usr.bin/login/login.c: revision 1.100
	usr.bin/login/login.c: revision 1.101
	usr.bin/login/login.c: revision 1.102
	usr.bin/login/common.c: revision 1.4
	usr.bin/login/common.h: revision 1.2
	usr.bin/login/k5login.c: revision 1.28
	usr.bin/login/k5login.c: revision 1.29
	usr.bin/login/login.c: revision 1.99
	usr.bin/login/login_pam.c: revision 1.21
	usr.bin/login/Makefile: revision 1.53
	usr.bin/login/Makefile: revision 1.54
	usr.bin/login/Makefile: revision 1.55
	usr.bin/login/k5login.c: revision 1.30
	usr.bin/login/k5login.c: revision 1.31
	usr.bin/login/k5login.c: revision 1.32
	usr.bin/login/k5login.c: revision 1.33
make krb5 compile again. XXX: one function left that is deprecated, what's
the new equivalent?
centralize error function processing.
fix the USE_KERBEROS=no USE_PAM=no build.
remove obsolete comment.
make kerberos work again:
1. make notickets external
2. don't use the tty as part of the credential cache, since pts/1 will not work.
3. Attempt to use the newer functions, but punt for now since it does not work
yet.
don't abuse the instance variable
move more of the compat code in the compat block.
last commit before I nuke the old code.
no more KRB5_DEPRECATED

trimusername (which does not exist) probably was meant to be called
trimloginname (which does exist, at least)

make krb5 compile again. XXX: one function left that is deprecated, what's
the new equivalent?

PR/42540: Ed Ravin: /usr/bin/login does not log normal logins, and does not
log ip addresses.
- Factor out the common code in login.c and login_pam.c into common.c
- Always log a login event
- Check passed in sockaddr against the one from getpeername(2).

Sync with wrstuden-revivesa-base-2.

Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

PR/36294: De Zeurkous: login(1) -- inconsistent exit behavior on EOF
- Always EXIT_FAILURE when login fails.
- Cleanup fork code in krb5 (old login).

GC old signal handling and merge it in 4 places:
    1. Immediately ignore all the signals we want to ignore and set the alarm.
    2. Before we exit on error, restore all signals we modified
    3. Before we exec a shell, restore all signals we modified and ignore TSTP.
       Job control aware shells know how to deal with this.
    4. Temporarily handle SIGINT while we read motd.

PR/33128: Martin Husemann: When login in on the console, SIGABRT is ignored
Both SIGINT and SIGABRT should be restored before executing the shell.

Fix Coverity run 5, issue 1931 -- memory leak.  This was noted as being a
bug by cgilbert.
Approved by christos@.

Pull up following revision(s) (requested by jnemeth in ticket #1201):
	usr.bin/login/login_pam.c: revision 1.14
PR/23616: Christian Biere: login might not back-off as expected

Pull up following revision(s) (requested by jnemeth in ticket #1201):
	usr.bin/login/login_pam.c: revision 1.14
PR/23616: Christian Biere: login might not back-off as expected

Pull up following revision(s) (requested by jnemeth in ticket #1199):
	usr.bin/login/login_pam.c: revision 1.13
PR/30923: Zafer Aydogan: pam too verbose
Don't display a different message for root logins on insecure terminals.
Approved by christos@.

Pull up following revision(s) (requested by jnemeth in ticket #1199):
	usr.bin/login/login_pam.c: revision 1.13
PR/30923: Zafer Aydogan: pam too verbose
Don't display a different message for root logins on insecure terminals.
Approved by christos@.

PR/23616: Christian Biere: login might not back-off as expected

PR/30923: Zafer Aydogan: pam too verbose

Don't display a different message for root logins on insecure terminals.

Approved by christos@.

Propagate change from login.c where if getpeername succeeded, then we have
the sockaddr from the remote peer.

PR/32870: Johan Veenhuizen: login(1) does not obey .hushlogin

Update documentation for pam, and don't accept flags that we don't support
anymore.

use getgrnam_r; from Jon Nemeth

Pull up revision 1.8 (requested by lukem in ticket #531):
Terminate variable argument list with NULL, not 0.

Pull up revision 1.7 (requested by lukem in ticket #531):
Safety boots: don't depend upon getpwnam_r() to set pwd to NULL on all
failures, especially as we're ignoring the return result.

Pull up revision 1.6 (requested by lukem in ticket #531):
Don't report that we don't know the username. We don't want to give out
more information that we need to.

Pull up revision 1.5 (requested by lukem in ticket #531):
- use getpwnam_r
- KNF

Terminate variable argument list with NULL, not 0.

Safety boots: don't depend upon getpwnam_r() to set pwd to NULL on all
failures, especially as we're ignoring the return result.

Don't report that we don't know the username. We don't want to give out
more information that we need to.

- use getpwnam_r
- KNF

1. Restore missing tty action.
2. Pass the nested user name to pam.
3. always try to fill in sockaddr.

- deal with ptyfs pty names.
- put back chown pty code.
- use setproctitle(NULL) to kill our argument display.
- don't wait for any pid, just the one we forked.

Add setting of PAM_SOCKADDR.

Add PAM support to login(8)