CVS log for src/usr.bin/cdplay/cdplay.c

Up to [cvs.NetBSD.org] / src / usr.bin / cdplay

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

usr.bin: remove unnecessary CONSTCOND, lint no longer needs it

Since 2021-01-31, lint no longer requires a CONSTCOND comment in a
do-while-0 statement since this is a common code pattern, especially in
statement-like macros.

cdplay: remove redundant parentheses around return value

Purely cosmetic change.  The generated code stays exactly the same.

more stray \n

Rebase to HEAD as of a few days ago.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

fix the rest of the lint warnings [pass 1]

Merge some of the cleanup from PR 21894. Do a bit more of my own.
lint still squawks quite a bit, and it woudl probably be worthwhile
for someone to go through and make all the signedness consistent, but
I think I've got the valuable bits.

sync with head

-make digital mode work in non-interactive mode (init sighandler
 earlier, sleep(3) until playing finished)
-also switch to digital mode if an audio device is given on the
 cmd line, or the (new) "CDPLAY_DIGITAL" env var is set

(The latter can be used to make digital mode default per system.
As I see it, analog mode is not dead yet - two of three external
DVD drives I looked at have a speaker output.)

kill unnecessary srandom() call which crept in in rev. 1.33

If the ioctl to play tracks returned EINVAL, switch to digital mode and
try again.
XXX: Should we do this for the other ioctls? Should we default to digital mode?
Definitely the error message is completely unfriendly and should be fixed.

ANSIfy + static + __dead

Sync with HEAD.

Third (and last) commit. See http://mail-index.netbsd.org/source-changes/2009/05/13/msg221222.html

fix -W sign-compare issues.

fix a dud indent

handle 64 bit time_t

Sync with wrstuden-revivesa-base-2.

some improvements to digital play mode:
-use AUMODE_PLAY_ALL, from Sergey Svishchev -- this might cause
 stuttering if the write to audio can't keep up, but it avoids pauses
 if the audio buffer drains out on stop/resume
-The timeout for the raw SCSI command to read audio data
 was too small, causing complete failure for me.
-Since the itimer can't do faster than HZ, a too small buffer doesn't
 work. Try to calculate a sensible buffer size.
-While it makes sense to deliver data a bit faster than necessary,
 it should be not that much that the blocking in the signal handler
 hurts interactive response. Allow for 50ms.
-Comment out a sched_yield() in the signal handler - this doesn't
 look right.
This is far from being perfect, but it makes digital mode usable for me.
And for Jeremy C. Reed, the author of PR bin/38493.

if ioctl(fd, CDIOCPLAYMSF,...) fails, do not warn("ioctl(CDIOREADTOCENTRYS)");

arg might be improperly initialized; fix that.
(also, since we check arg == NULL, s/arg = 0/arg = NULL/.)

CID-4199: move the test (line != NULL) one line up to check the
return value of strdup()

ok christos@

Pull up following revision(s) (requested by chuck in ticket #276):
	usr.bin/cdplay/cdplay.c: revision 1.35
take into account the 150 frame start offset time when computing the
duration of a track.  call lba2msf like this:
        lba2msf(len - 150, &m, &s, &f);
                    ^^^^^
from rev 1.41 of FreeBSD usr.sbin/cdcontrol/cdcontrol.c, Dmitry Afanasiev.
XXX: note that this is a mis-use of lba2msf() because 'len' is the length
     of the track in frames, not a logical block address (lba).

take into account the 150 frame start offset time when computing the
duration of a track.  call lba2msf like this:
	lba2msf(len - 150, &m, &s, &f);
                    ^^^^^
from rev 1.41 of FreeBSD usr.sbin/cdcontrol/cdcontrol.c, Dmitry Afanasiev.

XXX: note that this is a mis-use of lba2msf() because 'len' is the length
     of the track in frames, not a logical block address (lba).

remove bogus assertion.

Apply patch from PR bin/34545 sent by Sergey Svishchev to add support
for digital transfer mode, not enabled by default.

To use it: $ cdplay -a /dev/audio (otherwise /dev/sound will be used)
and type "digital" on the interactive mode.

Thank you very much Sergey, it's very useful.

Reviewed and ok by christos@.

Applied patch from PR bin/14505  Tested on i386-current.  Fixes inability of
cdplay to properly play a cd immediately following an eject command in
interactive mode.  Patch supplied by Sergey Svishchev.

Add repeat mode to cdplay(1) per PR bin/13970
Applied the second patch in the PR, with minor tweaking, and adjusted
manpage for change.

appease gcc -Wuninitialized

Add (unsigned char) cast to ctype functions

use arc4random

eliminate unneeded use of sigcontext.

use bounded string op

use bounded string op as much as possible

Pull up revision 1.22 (requested by is in ticket #1172):
Fix PR 18444 and a few other corner cases in cdplay.c.

Remove unused printf argument.

Show the last "track" as the start of the lead-out area instead of a
bogus track number.  Remove a magic number and (slightly) simplify the
TOC entry display function a little.

Fix PR 18444 and a few other corner cases in cdplay.c.

Pull up revision 1.21 (requested by is in ticket #872):
0 is a valid value for the absolute minute to stop playing. Initialize
to UINT_MAX before scanning, and check for UINT_MAX to detect whether it
was set.
Without this, it is not possible to play the first less than a minute of
a CD using absolute msf addresses.

0 is a valid value for the absolute minute to stop playing. Initialize
to UINT_MAX before scanning, and check for UINT_MAX to detect whether it
was set.
Without this, it is not possible to play the first less than a minute of
a CD using absolute msf addresses.

err/errx/warn/warnx do not need \n at the end

Need <sys/types.h> early on.

Fix typo.

warn() -> warnx() in one place.

- Implement shuffle play and some other goodies. Mostly from a patch
  submitted by Sergey Svishchev <svs@ropnet.ru> in PR 13682.
- More tidying.

Cleanup.

Use getrawpartition().

Add support for skipping to the previous and next tracks.

convert to use getprogname()

replace guts of opencd() with call to opendisk(). prevents coredump
when a device with a leading / (e.g, `/dev/cd0') is given, as well as
promotes code reuse ;-)

Pullup usr.bin string format fixes [is].
See "cvs log" for explicit revision numbers per file, from sommerfeld.

More format string cleanup by sommerfeld.

Allow a single argument to volume to set both left and right channels
Fix incorrect use of Ar in manpage (noted by jhawk)
Pullup (approved by jhawk)
usr.bin/cdplay/cdplay.1         1.7,1.8
usr.bin/cdplay/cdplay.c         1.9

Allow a single argument to 'volume' to set both channels.

Sync w/ netbsd-1-5-base.

use play_track() instead of play_blocks() when play whole disk
(because the xfer length field of the PLAY command (0x45) is 2 bytes.
It's too short to play whole disk)

Apply patch supplied in PR 8561 from URA Hiroshi: fixes LBA mode display on
little endian machines.

Use my proper name.

- ntohl() -> be32toh().
- Dispence with some of the idiocy in run().
- Couple of nits.

Pull up to last week's -current.

cdplay now uses libedit!

Some cleanup [Fixes to follow as soon as I get a CD-ROM drive at home]

KNF

'cdplay', a simple utility for playing compact disks with both a command line
and an interactive mode.