The NetBSD Project

CVS log for src/tests/usr.bin/xlint/lint1/msg_324.c

[BACK] Up to [] / src / tests / usr.bin / xlint / lint1

Request diff between arbitrary revisions

Default branch: MAIN

Revision 1.10 / (download) - annotate - [select for diffs], Sun Jan 28 08:17:27 2024 UTC (4 weeks, 5 days ago) by rillig
Branch: MAIN
Changes since 1.9: +5 -5 lines
Diff to previous 1.9 (colored)

tests/lint: sort multiple diagnostics per line chronologically

For now, the chronologic order is not enforced but has to be established
manually, for example by removing all 'expect' comment lines and
regenerating them with ' -u'.

While here, clean up a few instances that came up when regenerating the
'expect' comments, such as wrong indentation or needless deviation from
the 'expect+1' form.

Revision 1.9 / (download) - annotate - [select for diffs], Fri Jul 7 19:45:22 2023 UTC (7 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

lint: warn about function definitions without header declaration

The existing warning was only issued for function declarations, not for
function definitions.

The interesting change in the tests is in msg_351.c.  Many other tests
use non-static functions due to their syntactic brevity.  In these
tests, the warning is disabled individually, to allow new functions to
be added without generating warning 351.

Revision 1.8 / (download) - annotate - [select for diffs], Fri Jul 7 06:03:31 2023 UTC (7 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.7: +3 -1 lines
Diff to previous 1.7 (colored)

lint: only skip 'unused' warnings after errors, not other warnings

Previously, in -w mode, any warning suppressed further 'unused'
warnings, even though there was no need to do that.  This can be seen in
the test gcc_attribute_var.c, where only the last unused variable from a
function was marked as unused, the others slipped through.

Fixed by counting the errors and the warnings separately and only
combining them if actually desired.

Revision 1.7 / (download) - annotate - [select for diffs], Wed Jun 22 19:23:18 2022 UTC (20 months, 1 week ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10-0-RC5, netbsd-10-0-RC4, netbsd-10-0-RC3, netbsd-10-0-RC2, netbsd-10-0-RC1, netbsd-10
Changes since 1.6: +9 -9 lines
Diff to previous 1.6 (colored)

lint: add quotes around placeholders for the remaining messages

Reword some of the messages slightly, exchanging brevity for clarity.

Message 138 is kept as-is, as it is not yet covered by any tests.

Message 240 is kep as-is, as it is unreachable.

Revision 1.6 / (download) - annotate - [select for diffs], Fri Jun 17 06:59:16 2022 UTC (20 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.5: +15 -8 lines
Diff to previous 1.5 (colored)

tests/lint: add more details to tests from msg_300 until msg_343

Revision 1.5 / (download) - annotate - [select for diffs], Sun Jan 31 11:12:07 2021 UTC (3 years ago) by rillig
Branch: MAIN
CVS Tags: cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.4: +8 -8 lines
Diff to previous 1.4 (colored)

lint: add expections to tests

msg_098: fix suffix for floating point constant
msg_127: remove prototype
msg_146: fix return type

Revision 1.4 / (download) - annotate - [select for diffs], Wed Jan 6 09:23:04 2021 UTC (3 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.3: +18 -18 lines
Diff to previous 1.3 (colored)

lint: fix test for message 324 on i386

i386 is an ILP32 platform (arch/i386/targparam.h).  On these platforms,
int and long have the same size, and even with the -p option for
portability checks, INT_RSIZE in inittyp.c is defined to 4, not 3.

Because of this, in check_integer_conversion, psize(nt) was not greater
than psize(ot), and the warning was not issued.

To make the test behave the same on all platforms, changed the long
variables to long long, since long long is 64-bit on all platforms, and
int is 32-bit.

Revision 1.3 / (download) - annotate - [select for diffs], Tue Jan 5 23:20:53 2021 UTC (3 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.2: +13 -1 lines
Diff to previous 1.2 (colored)

lint: remove redundant symbolic operator names

These symbolic names for INCBEF, INCAFT, DECBEF and DECAFT were
non-standard and thus confusing.  All other operators were as expected.
Now that the operator names from ops.def are very similar, there is no
need to keep to almost identical lists around.

No change to the user-visible messages since the only place where these
operator names were used was in 324, and that message was restricted to

Revision 1.2 / (download) - annotate - [select for diffs], Tue Jan 5 22:38:51 2021 UTC (3 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.1: +36 -3 lines
Diff to previous 1.1 (colored)

lint: add test for "suggest cast" [324]

This warning is the only one that calls print_tnode, which in turn uses
the redundant operator names in str_op_t.

There is another list of operator names in ops.c, but those names
include more clutter, for example "p + p" instead of a simple "+".
Using those operator names would therefore rather be confusing. These
two lists should be merged, to remove unnecessary redundancy.

Revision 1.1 / (download) - annotate - [select for diffs], Sat Jan 2 10:22:44 2021 UTC (3 years, 1 month ago) by rillig
Branch: MAIN

lint: add a test for each message produced by lint1

Having a test for each message ensures that upcoming refactorings don't
break the basic functionality.  Adding the tests will also discover
previously unknown bugs in lint.

The tests ensure that every lint message can actually be triggered, and
they demonstrate how to do so.  Having a separate file for each test
leaves enough space for documenting historical anecdotes, rationale or
edge cases, keeping them away from the source code.

The interesting details of this commit are in Makefile and  All other files are just auto-generated.

When running the tests as part of ATF, they are packed together as a
single test case.  Conceptually, it would have been better to have each
test as a separate test case, but ATF quickly becomes very slow as soon
as a test program defines too many test cases, and 50 is already too
many.  The time complexity is O(n^2), not O(n) as one would expect.
It's the same problem as in tests/usr.bin/make, which has over 300 test
cases as well.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.

CVSweb <>