The NetBSD Project

CVS log for src/tests/usr.bin/xlint/lint1/msg_249.c

[BACK] Up to [cvs.NetBSD.org] / src / tests / usr.bin / xlint / lint1

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.15 / (download) - annotate - [select for diffs], Sun Jan 28 08:17:27 2024 UTC (4 weeks, 5 days ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.14: +6 -6 lines
Diff to previous 1.14 (colored)

tests/lint: sort multiple diagnostics per line chronologically

For now, the chronologic order is not enforced but has to be established
manually, for example by removing all 'expect' comment lines and
regenerating them with 'accept.sh -u'.

While here, clean up a few instances that came up when regenerating the
'expect' comments, such as wrong indentation or needless deviation from
the 'expect+1' form.

Revision 1.14 / (download) - annotate - [select for diffs], Tue Mar 28 14:44:35 2023 UTC (11 months ago) by rillig
Branch: MAIN
Changes since 1.13: +3 -1 lines
Diff to previous 1.13 (colored)

lint: warn about extern declarations outside headers

https://mail-index.netbsd.org/tech-userlevel/2023/03/15/msg013727.html

Revision 1.13 / (download) - annotate - [select for diffs], Sun Jan 29 18:37:20 2023 UTC (13 months ago) by rillig
Branch: MAIN
Changes since 1.12: +3 -3 lines
Diff to previous 1.12 (colored)

lint: properly clean up when leaving a function definition

Revision 1.12 / (download) - annotate - [select for diffs], Fri Jun 17 18:54:53 2022 UTC (20 months, 2 weeks ago) by rillig
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10-0-RC5, netbsd-10-0-RC4, netbsd-10-0-RC3, netbsd-10-0-RC2, netbsd-10-0-RC1, netbsd-10
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

tests/lint: make 'expect+-' comments stricter

Previously, the expectations from these comments were already satisfied
if the expectation occurred somewhere in the actual message from lint.
This meant that the prefix 'error:' or 'warning:' could be omitted from
the 'expect' comment.  These omissions were hard to see in a manual
review.  Now any omissions must be visually marked with '...'.

The test msg_342 now reports its messages properly as being in the file
msg_342.c, rather than msg_341.c.  This had been a copy-and-paste
mistake.

Revision 1.11 / (download) - annotate - [select for diffs], Thu Jun 16 21:24:41 2022 UTC (20 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.10: +3 -2 lines
Diff to previous 1.10 (colored)

tests/lint: add more details to messages in msg_200 until msg_299

Add some tests that were previously empty.  Some other tests are still
empty.

Revision 1.10 / (download) - annotate - [select for diffs], Tue May 31 00:35:18 2022 UTC (21 months ago) by rillig
Branch: MAIN
Changes since 1.9: +28 -1 lines
Diff to previous 1.9 (colored)

lint: fix null pointer dereference after syntax error

Found by afl, starting with the malformed input '/**/f=({;/**/};}' that
no longer crashes.  This input led to 'f=({L:;}', which is at least a
syntactically valid prefix of a translation unit, containing a GCC
statement expression with an unused label.  The error message for this
unused label assumed that it would always be inside a function
definition.

While here, document incomplete recovery after syntax errors, in
msg_249.c.

Revision 1.9 / (download) - annotate - [select for diffs], Sat Jan 15 23:21:34 2022 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.8: +2 -1 lines
Diff to previous 1.8 (colored)

lint: warn about unreachable null statements

This warning flags the second semicolon of 'return;;' as being
unreachable.  It does not warn about these superfluous semicolons in
general though.

Seen in usr.bin/make/bmake_malloc.c.

Revision 1.8 / (download) - annotate - [select for diffs], Sat Jul 10 17:35:54 2021 UTC (2 years, 7 months ago) by rillig
Branch: MAIN
Changes since 1.7: +2 -2 lines
Diff to previous 1.7 (colored)

lint: rename clrtyp/deftyp to begin_type/end_type

The abbreviations clr/def did not make it obvious that these two
functions or grammar rules form pairs.

No functional change.

Revision 1.7 / (download) - annotate - [select for diffs], Sat Jul 10 11:22:19 2021 UTC (2 years, 7 months ago) by rillig
Branch: MAIN
Changes since 1.6: +2 -2 lines
Diff to previous 1.6 (colored)

lint: do not allow struct{const;}

In traditional C, a struct member was defined syntactically as
'type-specifier struct-declarator-list', the concept of a type-qualifier
was not known back then.

C90 invented the type-qualifier 'const' and relaxed the syntactic
requirement for struct member declarations by allowing 'const x'. Having
only a type-qualifier without an actual type may be regarded as an
"incomplete type", which would be forbidden by C90 and later.

Anyway, this doesn't occur in practice anyway, so there is no need for
lint to try to parse it.  This removes a bit of dead code, since a
type-qualifier-list can never have type struct or union.

Revision 1.6 / (download) - annotate - [select for diffs], Sat Jul 10 10:30:26 2021 UTC (2 years, 7 months ago) by rillig
Branch: MAIN
Changes since 1.5: +13 -1 lines
Diff to previous 1.5 (colored)

lint: fix assertion failure for malformed member declaration

Revision 1.5 / (download) - annotate - [select for diffs], Thu Jul 8 20:11:15 2021 UTC (2 years, 7 months ago) by rillig
Branch: MAIN
Changes since 1.4: +12 -2 lines
Diff to previous 1.4 (colored)

tests/lint: test error recovery of the parser

Revision 1.4 / (download) - annotate - [select for diffs], Thu Jul 8 18:02:22 2021 UTC (2 years, 7 months ago) by rillig
Branch: MAIN
Changes since 1.3: +22 -1 lines
Diff to previous 1.3 (colored)

tests/lint: add test coverage for some parse errors

Revision 1.3 / (download) - annotate - [select for diffs], Sat Jun 19 16:05:07 2021 UTC (2 years, 8 months ago) by rillig
Branch: MAIN
Changes since 1.2: +12 -3 lines
Diff to previous 1.2 (colored)

lint: fix assertion failure after malformed statement

Found using afl.

Revision 1.2 / (download) - annotate - [select for diffs], Sun Feb 21 09:07:58 2021 UTC (3 years ago) by rillig
Branch: MAIN
CVS Tags: cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

lint: force each test to declare the expected diagnostics

By listing the expected diagnostics directly at the code that triggers
the diagnostics, it is easier to cross-check whether the diagnostics
make sense.

No functional change to lint itself.

Revision 1.1 / (download) - annotate - [select for diffs], Sat Jan 2 10:22:44 2021 UTC (3 years, 1 month ago) by rillig
Branch: MAIN

lint: add a test for each message produced by lint1

Having a test for each message ensures that upcoming refactorings don't
break the basic functionality.  Adding the tests will also discover
previously unknown bugs in lint.

The tests ensure that every lint message can actually be triggered, and
they demonstrate how to do so.  Having a separate file for each test
leaves enough space for documenting historical anecdotes, rationale or
edge cases, keeping them away from the source code.

The interesting details of this commit are in Makefile and
t_integration.sh.  All other files are just auto-generated.

When running the tests as part of ATF, they are packed together as a
single test case.  Conceptually, it would have been better to have each
test as a separate test case, but ATF quickly becomes very slow as soon
as a test program defines too many test cases, and 50 is already too
many.  The time complexity is O(n^2), not O(n) as one would expect.
It's the same problem as in tests/usr.bin/make, which has over 300 test
cases as well.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>