![[BACK]](/icons/back.gif){kind=icon}
Up to [cvs.NetBSD.org] / src / sys / netipsec
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.38 / (download) - annotate - [select for diffs], Thu Dec 8 08:05:03 2022 UTC (3 months, 2 weeks ago) by knakahara
Branch: MAIN
CVS Tags: netbsd-10-base,
netbsd-10,
HEAD
Changes since 1.37: +2 -1
lines
Diff to previous 1.37 (colored)
Fix: update lastused of ipsecif(4) IPv6 out SP.
Revision 1.37 / (download) - annotate - [select for diffs], Mon Aug 9 20:49:10 2021 UTC (19 months, 2 weeks ago) by andvar
Branch: MAIN
CVS Tags: bouyer-sunxi-drm-base,
bouyer-sunxi-drm
Changes since 1.36: +2 -2
lines
Diff to previous 1.36 (colored)
fix various typos in compatibility, mainly in comments.
Revision 1.34.2.1 / (download) - annotate - [select for diffs], Sun Apr 22 07:20:28 2018 UTC (4 years, 11 months ago) by pgoyette
Branch: pgoyette-compat
CVS Tags: pgoyette-compat-merge-20190127
Changes since 1.34: +23 -27
lines
Diff to previous 1.34 (colored) next main 1.35 (colored)
Sync with HEAD
Revision 1.36 / (download) - annotate - [select for diffs], Thu Apr 19 08:27:38 2018 UTC (4 years, 11 months ago) by maxv
Branch: MAIN
CVS Tags: thorpej-i2c-spi-conf2-base,
thorpej-i2c-spi-conf2,
thorpej-i2c-spi-conf-base,
thorpej-i2c-spi-conf,
thorpej-futex2-base,
thorpej-futex2,
thorpej-futex-base,
thorpej-futex,
thorpej-cfargs2-base,
thorpej-cfargs2,
thorpej-cfargs-base,
thorpej-cfargs,
phil-wifi-base,
phil-wifi-20200421,
phil-wifi-20200411,
phil-wifi-20200406,
phil-wifi-20191119,
phil-wifi-20190609,
phil-wifi,
pgoyette-compat-20190127,
pgoyette-compat-20190118,
pgoyette-compat-1226,
pgoyette-compat-1126,
pgoyette-compat-1020,
pgoyette-compat-0930,
pgoyette-compat-0906,
pgoyette-compat-0728,
pgoyette-compat-0625,
pgoyette-compat-0521,
pgoyette-compat-0502,
pgoyette-compat-0422,
netbsd-9-base,
netbsd-9-3-RELEASE,
netbsd-9-2-RELEASE,
netbsd-9-1-RELEASE,
netbsd-9-0-RELEASE,
netbsd-9-0-RC2,
netbsd-9-0-RC1,
netbsd-9,
isaki-audio2-base,
isaki-audio2,
is-mlppp-base,
is-mlppp,
cjep_sun2x-base1,
cjep_sun2x-base,
cjep_sun2x,
cjep_staticlib_x-base1,
cjep_staticlib_x-base,
cjep_staticlib_x,
bouyer-xenpvh-base2,
bouyer-xenpvh-base1,
bouyer-xenpvh-base,
bouyer-xenpvh,
ad-namecache-base3,
ad-namecache-base2,
ad-namecache-base1,
ad-namecache-base,
ad-namecache
Changes since 1.35: +2 -2
lines
Diff to previous 1.35 (colored)
Remove extra long file paths from the headers.
Revision 1.35 / (download) - annotate - [select for diffs], Wed Apr 18 07:32:44 2018 UTC (4 years, 11 months ago) by maxv
Branch: MAIN
Changes since 1.34: +22 -26
lines
Diff to previous 1.34 (colored)
Style, and remove unused MALLOC_DECLARE.
Revision 1.19.2.3 / (download) - annotate - [select for diffs], Sun Feb 11 21:17:35 2018 UTC (5 years, 1 month ago) by snj
Branch: netbsd-8
CVS Tags: netbsd-8-2-RELEASE,
netbsd-8-1-RELEASE,
netbsd-8-1-RC1,
netbsd-8-0-RELEASE,
netbsd-8-0-RC2,
netbsd-8-0-RC1
Changes since 1.19.2.2: +14 -4
lines
Diff to previous 1.19.2.2 (colored) to branchpoint 1.19 (colored) next main 1.20 (colored)
Pull up following revision(s) (requested by ozaki-r in ticket #536):
distrib/sets/lists/base/shl.mi: 1.825
distrib/sets/lists/comp/mi: 1.2168-1.2169
distrib/sets/lists/comp/shl.mi: 1.310
distrib/sets/lists/debug/mi: 1.234
distrib/sets/lists/debug/shl.mi: 1.188
distrib/sets/lists/man/mi: 1.1570
distrib/sets/lists/tests/mi: 1.772
etc/mtree/NetBSD.dist.tests: 1.150
share/man/man4/Makefile: 1.650
share/man/man4/ipsec.4: 1.42-1.43
share/man/man4/ipsecif.4: 1.1-1.5
sys/arch/amd64/conf/ALL: 1.77
sys/arch/amd64/conf/GENERIC: 1.480
sys/conf/files: 1.1191
sys/net/Makefile: 1.34
sys/net/files.net: 1.14
sys/net/if.c: 1.404
sys/net/if.h: 1.248
sys/net/if_gif.c: 1.135
sys/net/if_ipsec.c: 1.1-1.3
sys/net/if_ipsec.h: 1.1
sys/net/if_l2tp.c: 1.16
sys/net/if_types.h: 1.28
sys/netinet/in.c: 1.214
sys/netinet/in.h: 1.103
sys/netinet/in_gif.c: 1.92
sys/netinet/ip_var.h: 1.122
sys/netinet6/in6.c: 1.257
sys/netinet6/in6.h: 1.88
sys/netinet6/in6_gif.c: 1.90
sys/netinet6/ip6_var.h: 1.75
sys/netipsec/Makefile: 1.6
sys/netipsec/files.netipsec: 1.13
sys/netipsec/ipsec.h: 1.62
sys/netipsec/ipsecif.c: 1.1
sys/netipsec/ipsecif.h: 1.1
sys/netipsec/key.c: 1.246-1.247
sys/netipsec/key.h: 1.34
sys/rump/net/Makefile.rumpnetcomp: 1.20
sys/rump/net/lib/libipsec/IPSEC.ioconf: 1.1
sys/rump/net/lib/libipsec/Makefile: 1.1
sys/rump/net/lib/libipsec/ipsec_component.c: 1.1
tests/net/Makefile: 1.34
tests/net/if_ipsec/Makefile: 1.1
tests/net/if_ipsec/t_ipsec.sh: 1.1-1.2
Don't touch an SP without a reference to it
unify processing to check nesting count for some tunnel protocols.
add ipsec(4) interface, which is used for route-based VPN.
man and ATF are added later, please see man for details.
reviewed by christos@n.o, joerg@n.o and ozaki-r@n.o, thanks.
https://mail-index.netbsd.org/tech-net/2017/12/18/msg006557.html
ipsec(4) interface supports rump now.
add ipsec(4) interface ATF.
add ipsec(4) interface man as ipsecif.4.
add ipsec(4) interface to amd64/GENERIC and amd64/ALL configs.
apply in{,6}_tunnel_validate() to gif(4).
Spell IPsec that way. Simplify macro usage. Sort SEE ALSO. Bump
date for previous.
Improve wording and macro use.
Some parts are not clear to me, so someone with knowledge of ipsecif(4)
should improve this some more.
Improve ipsecif.4. Default port ipsec(4) NAT-T is tested now.
pointed out by wiz@n.o and suggested by ozaki-r@n.o, thanks.
Change the prefix of test names to ipsecif_ to distinguish from tests for ipsec(4)
New sentence, new line. Remove empty macro.
Fix PR kern/52920. Pointed out by David Binderman, thanks.
Improve wording, and put a new drawing, from me and Kengo Nakahara.
apply a little more #ifdef INET/INET6. fixes !INET6 builds.
Revision 1.34 / (download) - annotate - [select for diffs], Wed Jan 10 10:56:31 2018 UTC (5 years, 2 months ago) by knakahara
Branch: MAIN
CVS Tags: pgoyette-compat-base,
pgoyette-compat-0415,
pgoyette-compat-0407,
pgoyette-compat-0330,
pgoyette-compat-0322,
pgoyette-compat-0315
Branch point for: pgoyette-compat
Changes since 1.33: +14 -4
lines
Diff to previous 1.33 (colored)
add ipsec(4) interface, which is used for route-based VPN. man and ATF are added later, please see man for details. reviewed by christos@n.o, joerg@n.o and ozaki-r@n.o, thanks. https://mail-index.netbsd.org/tech-net/2017/12/18/msg006557.html
Revision 1.11.12.3 / (download) - annotate - [select for diffs], Sun Dec 3 11:39:05 2017 UTC (5 years, 3 months ago) by jdolecek
Branch: tls-maxphys
Changes since 1.11.12.2: +30 -25
lines
Diff to previous 1.11.12.2 (colored) to branchpoint 1.11 (colored) next main 1.12 (colored)
update from HEAD
Revision 1.19.2.2 / (download) - annotate - [select for diffs], Thu Nov 30 14:57:34 2017 UTC (5 years, 3 months ago) by martin
Branch: netbsd-8
Changes since 1.19.2.1: +2 -2
lines
Diff to previous 1.19.2.1 (colored) to branchpoint 1.19 (colored)
Pull up following revision(s) (requested by ozaki-r in ticket #406): sys/netipsec/key.c: revision 1.239 sys/netipsec/key.c: revision 1.240 sys/netipsec/key.c: revision 1.241 sys/netipsec/key.c: revision 1.242 sys/netipsec/key.h: revision 1.33 sys/netipsec/ipsec.c: revision 1.123 sys/netipsec/key.c: revision 1.236 sys/netipsec/key.c: revision 1.237 sys/netipsec/key.c: revision 1.238 Provide a function to call MGETHDR and MCLGET The change fixes two usages of MGETHDR that don't check whether a mbuf is really allocated before passing it to MCLGET. Fix error handling of MCLGET in key_alloc_mbuf Add missing splx to key_spdexpire Use M_WAITOK to allocate mbufs wherever sleepable Further changes will get rid of unnecessary NULL checks then. Get rid of unnecessary NULL checks that are obsoleted by M_WAITOK Simply the code by avoiding unnecessary error checks - Remove unnecessary m_pullup for self-allocated mbufs - Replace some if-fails-return sanity checks with KASSERT Call key_sendup_mbuf immediately unless key_acquire is called in softint We need to defer it only if it's called in softint to avoid deadlock.
Revision 1.33 / (download) - annotate - [select for diffs], Tue Nov 21 07:03:08 2017 UTC (5 years, 4 months ago) by ozaki-r
Branch: MAIN
CVS Tags: tls-maxphys-base-20171202
Changes since 1.32: +2 -2
lines
Diff to previous 1.32 (colored)
Use M_WAITOK to allocate mbufs wherever sleepable Further changes will get rid of unnecessary NULL checks then.
Revision 1.19.2.1 / (download) - annotate - [select for diffs], Sat Oct 21 19:43:54 2017 UTC (5 years, 5 months ago) by snj
Branch: netbsd-8
CVS Tags: matt-nb8-mediatek-base,
matt-nb8-mediatek
Changes since 1.19: +25 -17
lines
Diff to previous 1.19 (colored)
Pull up following revision(s) (requested by ozaki-r in ticket #300): crypto/dist/ipsec-tools/src/setkey/parse.y: 1.19 crypto/dist/ipsec-tools/src/setkey/token.l: 1.20 distrib/sets/lists/tests/mi: 1.754, 1.757, 1.759 doc/TODO.smpnet: 1.12-1.13 sys/net/pfkeyv2.h: 1.32 sys/net/raw_cb.c: 1.23-1.24, 1.28 sys/net/raw_cb.h: 1.28 sys/net/raw_usrreq.c: 1.57-1.58 sys/net/rtsock.c: 1.228-1.229 sys/netinet/in_proto.c: 1.125 sys/netinet/ip_input.c: 1.359-1.361 sys/netinet/tcp_input.c: 1.359-1.360 sys/netinet/tcp_output.c: 1.197 sys/netinet/tcp_var.h: 1.178 sys/netinet6/icmp6.c: 1.213 sys/netinet6/in6_proto.c: 1.119 sys/netinet6/ip6_forward.c: 1.88 sys/netinet6/ip6_input.c: 1.181-1.182 sys/netinet6/ip6_output.c: 1.193 sys/netinet6/ip6protosw.h: 1.26 sys/netipsec/ipsec.c: 1.100-1.122 sys/netipsec/ipsec.h: 1.51-1.61 sys/netipsec/ipsec6.h: 1.18-1.20 sys/netipsec/ipsec_input.c: 1.44-1.51 sys/netipsec/ipsec_netbsd.c: 1.41-1.45 sys/netipsec/ipsec_output.c: 1.49-1.64 sys/netipsec/ipsec_private.h: 1.5 sys/netipsec/key.c: 1.164-1.234 sys/netipsec/key.h: 1.20-1.32 sys/netipsec/key_debug.c: 1.18-1.21 sys/netipsec/key_debug.h: 1.9 sys/netipsec/keydb.h: 1.16-1.20 sys/netipsec/keysock.c: 1.59-1.62 sys/netipsec/keysock.h: 1.10 sys/netipsec/xform.h: 1.9-1.12 sys/netipsec/xform_ah.c: 1.55-1.74 sys/netipsec/xform_esp.c: 1.56-1.72 sys/netipsec/xform_ipcomp.c: 1.39-1.53 sys/netipsec/xform_ipip.c: 1.50-1.54 sys/netipsec/xform_tcp.c: 1.12-1.16 sys/rump/librump/rumpkern/Makefile.rumpkern: 1.170 sys/rump/librump/rumpnet/net_stub.c: 1.27 sys/sys/protosw.h: 1.67-1.68 tests/net/carp/t_basic.sh: 1.7 tests/net/if_gif/t_gif.sh: 1.11 tests/net/if_l2tp/t_l2tp.sh: 1.3 tests/net/ipsec/Makefile: 1.7-1.9 tests/net/ipsec/algorithms.sh: 1.5 tests/net/ipsec/common.sh: 1.4-1.6 tests/net/ipsec/t_ipsec_ah_keys.sh: 1.2 tests/net/ipsec/t_ipsec_esp_keys.sh: 1.2 tests/net/ipsec/t_ipsec_gif.sh: 1.6-1.7 tests/net/ipsec/t_ipsec_l2tp.sh: 1.6-1.7 tests/net/ipsec/t_ipsec_misc.sh: 1.8-1.18 tests/net/ipsec/t_ipsec_sockopt.sh: 1.1-1.2 tests/net/ipsec/t_ipsec_tcp.sh: 1.1-1.2 tests/net/ipsec/t_ipsec_transport.sh: 1.5-1.6 tests/net/ipsec/t_ipsec_tunnel.sh: 1.9 tests/net/ipsec/t_ipsec_tunnel_ipcomp.sh: 1.1-1.2 tests/net/ipsec/t_ipsec_tunnel_odd.sh: 1.3 tests/net/mcast/t_mcast.sh: 1.6 tests/net/net/t_ipaddress.sh: 1.11 tests/net/net_common.sh: 1.20 tests/net/npf/t_npf.sh: 1.3 tests/net/route/t_flags.sh: 1.20 tests/net/route/t_flags6.sh: 1.16 usr.bin/netstat/fast_ipsec.c: 1.22 Do m_pullup before mtod It may fix panicks of some tests on anita/sparc and anita/GuruPlug. --- KNF --- Enable DEBUG for babylon5 --- Apply C99-style struct initialization to xformsw --- Tweak outputs of netstat -s for IPsec - Get rid of "Fast" - Use ipsec and ipsec6 for titles to clarify protocol - Indent outputs of sub protocols Original outputs were organized like this: (Fast) IPsec: IPsec ah: IPsec esp: IPsec ipip: IPsec ipcomp: (Fast) IPsec: IPsec ah: IPsec esp: IPsec ipip: IPsec ipcomp: New outputs are organized like this: ipsec: ah: esp: ipip: ipcomp: ipsec6: ah: esp: ipip: ipcomp: --- Add test cases for IPComp --- Simplify IPSEC_OSTAT macro (NFC) --- KNF; replace leading whitespaces with hard tabs --- Introduce and use SADB_SASTATE_USABLE_P --- KNF --- Add update command for testing Updating an SA (SADB_UPDATE) requires that a process issuing SADB_UPDATE is the same as a process issued SADB_ADD (or SADB_GETSPI). This means that update command must be used with add command in a configuration of setkey. This usage is normally meaningless but useful for testing (and debugging) purposes. --- Add test cases for updating SA/SP The tests require newly-added udpate command of setkey. --- PR/52346: Frank Kardel: Fix checksumming for NAT-T See XXX for improvements. --- Remove codes for PACKET_TAG_IPSEC_IN_CRYPTO_DONE It seems that PACKET_TAG_IPSEC_IN_CRYPTO_DONE is for network adapters that have IPsec accelerators; a driver sets the mtag to a packet when its device has already encrypted the packet. Unfortunately no driver implements such offload features for long years and seems unlikely to implement them soon. (Note that neither FreeBSD nor Linux doesn't have such drivers.) Let's remove related (unused) codes and simplify the IPsec code. --- Fix usages of sadb_msg_errno --- Avoid updating sav directly On SADB_UPDATE a target sav was updated directly, which was unsafe. Instead allocate another sav, copy variables of the old sav to the new one and replace the old one with the new one. --- Simplify; we can assume sav->tdb_xform cannot be NULL while it's valid --- Rename key_alloc* functions (NFC) We shouldn't use the term "alloc" for functions that just look up data and actually don't allocate memory. --- Use explicit_memset to surely zero-clear key_auth and key_enc --- Make sure to clear keys on error paths of key_setsaval --- Add missing KEY_FREESAV --- Make sure a sav is inserted to a sah list after its initialization completes --- Remove unnecessary zero-clearing codes from key_setsaval key_setsaval is now used only for a newly-allocated sav. (It was used to reset variables of an existing sav.) --- Correct wrong assumption of sav->refcnt in key_delsah A sav in a list is basically not to be sav->refcnt == 0. And also KEY_FREESAV assumes sav->refcnt > 0. --- Let key_getsavbyspi take a reference of a returning sav --- Use time_mono_to_wall (NFC) --- Separate sending message routine (NFC) --- Simplify; remove unnecessary zero-clears key_freesaval is used only when a target sav is being destroyed. --- Omit NULL checks for sav->lft_c sav->lft_c can be NULL only when initializing or destroying sav. --- Omit unnecessary NULL checks for sav->sah --- Omit unnecessary check of sav->state key_allocsa_policy picks a sav of either MATURE or DYING so we don't need to check its state again. --- Simplify; omit unnecessary saidx passing - ipsec_nextisr returns a saidx but no caller uses it - key_checkrequest is passed a saidx but it can be gotton by another argument (isr) --- Fix splx isn't called on some error paths --- Fix header size calculation of esp where sav is NULL --- Fix header size calculation of ah in the case sav is NULL This fix was also needed for esp. --- Pass sav directly to opencrypto callback In a callback, use a passed sav as-is by default and look up a sav only if the passed sav is dead. --- Avoid examining freshness of sav on packet processing If a sav list is sorted (by lft_c->sadb_lifetime_addtime) in advance, we don't need to examine each sav and also don't need to delete one on the fly and send up a message. Fortunately every sav lists are sorted as we need. Added key_validate_savlist validates that each sav list is surely sorted (run only if DEBUG because it's not cheap). --- Add test cases for SAs with different SPIs --- Prepare to stop using isr->sav isr is a shared resource and using isr->sav as a temporal storage for each packet processing is racy. And also having a reference from isr to sav makes the lifetime of sav non-deterministic; such a reference is removed when a packet is processed and isr->sav is overwritten by new one. Let's have a sav locally for each packet processing instead of using shared isr->sav. However this change doesn't stop using isr->sav yet because there are some users of isr->sav. isr->sav will be removed after the users find a way to not use isr->sav. --- Fix wrong argument handling --- fix printf format. --- Don't validate sav lists of LARVAL or DEAD states We don't sort the lists so the validation will always fail. Fix PR kern/52405 --- Make sure to sort the list when changing the state by key_sa_chgstate --- Rename key_allocsa_policy to key_lookup_sa_bysaidx --- Separate test files --- Calculate ah_max_authsize on initialization as well as esp_max_ivlen --- Remove m_tag_find(PACKET_TAG_IPSEC_PENDING_TDB) because nobody sets the tag --- Restore a comment removed in previous The comment is valid for the below code. --- Make tests more stable sleep command seems to wait longer than expected on anita so use polling to wait for a state change. --- Add tests that explicitly delete SAs instead of waiting for expirations --- Remove invalid M_AUTHIPDGM check on ESP isr->sav M_AUTHIPDGM flag is set to a mbuf in ah_input_cb. An sav of ESP can have AH authentication as sav->tdb_authalgxform. However, in that case esp_input and esp_input_cb are used to do ESP decryption and AH authentication and M_AUTHIPDGM never be set to a mbuf. So checking M_AUTHIPDGM of a mbuf on isr->sav of ESP is meaningless. --- Look up sav instead of relying on unstable sp->req->sav This code is executed only in an error path so an additional lookup doesn't matter. --- Correct a comment --- Don't release sav if calling crypto_dispatch again --- Remove extra KEY_FREESAV from ipsec_process_done It should be done by the caller. --- Don't bother the case of crp->crp_buf == NULL in callbacks --- Hold a reference to an SP during opencrypto processing An SP has a list of isr (ipsecrequest) that represents a sequence of IPsec encryption/authentication processing. One isr corresponds to one opencrypto processing. The lifetime of an isr follows its SP. We pass an isr to a callback function of opencrypto to continue to a next encryption/authentication processing. However nobody guaranteed that the isr wasn't freed, i.e., its SP wasn't destroyed. In order to avoid such unexpected destruction of isr, hold a reference to its SP during opencrypto processing. --- Don't make SAs expired on tests that delete SAs explicitly --- Fix a debug message --- Dedup error paths (NFC) --- Use pool to allocate tdb_crypto For ESP and AH, we need to allocate an extra variable space in addition to struct tdb_crypto. The fixed size of pool items may be larger than an actual requisite size of a buffer, but still the performance improvement by replacing malloc with pool wins. --- Don't use unstable isr->sav for header size calculations We may need to optimize to not look up sav here for users that don't need to know an exact size of headers (e.g., TCP segmemt size caclulation). --- Don't use sp->req->sav when handling NAT-T ESP fragmentation In order to do this we need to look up a sav however an additional look-up degrades performance. A sav is later looked up in ipsec4_process_packet so delay the fragmentation check until then to avoid an extra look-up. --- Don't use key_lookup_sp that depends on unstable sp->req->sav It provided a fast look-up of SP. We will provide an alternative method in the future (after basic MP-ification finishes). --- Stop setting isr->sav on looking up sav in key_checkrequest --- Remove ipsecrequest#sav --- Stop setting mtag of PACKET_TAG_IPSEC_IN_DONE because there is no users anymore --- Skip ipsec_spi_*_*_preferred_new_timeout when running on qemu Probably due to PR 43997 --- Add localcount to rump kernels --- Remove unused macro --- Fix key_getcomb_setlifetime The fix adjusts a soft limit to be 80% of a corresponding hard limit. I'm not sure the fix is really correct though, at least the original code is wrong. A passed comb is zero-cleared before calling key_getcomb_setlifetime, so comb->sadb_comb_soft_addtime = comb->sadb_comb_soft_addtime * 80 / 100; is meaningless. --- Provide and apply key_sp_refcnt (NFC) It simplifies further changes. --- Fix indentation Pointed out by knakahara@ --- Use pslist(9) for sptree --- Don't acquire global locks for IPsec if NET_MPSAFE Note that the change is just to make testing easy and IPsec isn't MP-safe yet. --- Let PF_KEY socks hold their own lock instead of softnet_lock Operations on SAD and SPD are executed via PF_KEY socks. The operations include deletions of SAs and SPs that will use synchronization mechanisms such as pserialize_perform to wait for references to SAs and SPs to be released. It is known that using such mechanisms with holding softnet_lock causes a dead lock. We should avoid the situation. --- Make IPsec SPD MP-safe We use localcount(9), not psref(9), to make the sptree and secpolicy (SP) entries MP-safe because SPs need to be referenced over opencrypto processing that executes a callback in a different context. SPs on sockets aren't managed by the sptree and can be destroyed in softint. localcount_drain cannot be used in softint so we delay the destruction of such SPs to a thread context. To do so, a list to manage such SPs is added (key_socksplist) and key_timehandler_spd deletes dead SPs in the list. For more details please read the locking notes in key.c. Proposed on tech-kern@ and tech-net@ --- Fix updating ipsec_used - key_update_used wasn't called in key_api_spddelete2 and key_api_spdflush - key_update_used wasn't called if an SP had been added/deleted but a reply to userland failed --- Fix updating ipsec_used; turn on when SPs on sockets are added --- Add missing IPsec policy checks to icmp6_rip6_input icmp6_rip6_input is quite similar to rip6_input and the same checks exist in rip6_input. --- Add test cases for setsockopt(IP_IPSEC_POLICY) --- Don't use KEY_NEWSP for dummy SP entries By the change KEY_NEWSP is now not called from softint anymore and we can use kmem_zalloc with KM_SLEEP for KEY_NEWSP. --- Comment out unused functions --- Add test cases that there are SPs but no relevant SAs --- Don't allow sav->lft_c to be NULL lft_c of an sav that was created by SADB_GETSPI could be NULL. --- Clean up clunky eval strings - Remove unnecessary \ at EOL - This allows to omit ; too - Remove unnecessary quotes for arguments of atf_set - Don't expand $DEBUG in eval - We expect it's expanded on execution Suggested by kre@ --- Remove unnecessary KEY_FREESAV in an error path sav should be freed (unreferenced) by the caller. --- Use pslist(9) for sahtree --- Use pslist(9) for sah->savtree --- Rename local variable newsah to sah It may not be new. --- MP-ify SAD slightly - Introduce key_sa_mtx and use it for some list operations - Use pserialize for some list iterations --- Introduce KEY_SA_UNREF and replace KEY_FREESAV with it where sav will never be actually freed in the future KEY_SA_UNREF is still key_freesav so no functional change for now. This change reduces diff of further changes. --- Remove out-of-date log output Pointed out by riastradh@ --- Use KDASSERT instead of KASSERT for mutex_ownable Because mutex_ownable is too heavy to run in a fast path even for DIAGNOSTIC + LOCKDEBUG. Suggested by riastradh@ --- Assemble global lists and related locks into cache lines (NFCI) Also rename variable names from *tree to *list because they are just lists, not trees. Suggested by riastradh@ --- Move locking notes --- Update the locking notes - Add locking order - Add locking notes for misc lists such as reglist - Mention pserialize, key_sp_ref and key_sp_unref on SP operations Requested by riastradh@ --- Describe constraints of key_sp_ref and key_sp_unref Requested by riastradh@ --- Hold key_sad.lock on SAVLIST_WRITER_INSERT_TAIL --- Add __read_mostly to key_psz Suggested by riastradh@ --- Tweak wording (pserialize critical section => pserialize read section) Suggested by riastradh@ --- Add missing mutex_exit --- Fix setkey -D -P outputs The outputs were tweaked (by me), but I forgot updating libipsec in my local ATF environment... --- MP-ify SAD (key_sad.sahlist and sah entries) localcount(9) is used to protect key_sad.sahlist and sah entries as well as SPD (and will be used for SAD sav). Please read the locking notes of SAD for more details. --- Introduce key_sa_refcnt and replace sav->refcnt with it (NFC) --- Destroy sav only in the loop for DEAD sav --- Fix KASSERT(solocked(sb->sb_so)) failure in sbappendaddr that is called eventually from key_sendup_mbuf If key_sendup_mbuf isn't passed a socket, the assertion fails. Originally in this case sb->sb_so was softnet_lock and callers held softnet_lock so the assertion was magically satisfied. Now sb->sb_so is key_so_mtx and also softnet_lock isn't always held by callers so the assertion can fail. Fix it by holding key_so_mtx if key_sendup_mbuf isn't passed a socket. Reported by knakahara@ Tested by knakahara@ and ozaki-r@ --- Fix locking notes of SAD --- Fix deadlock between key_sendup_mbuf called from key_acquire and localcount_drain If we call key_sendup_mbuf from key_acquire that is called on packet processing, a deadlock can happen like this: - At key_acquire, a reference to an SP (and an SA) is held - key_sendup_mbuf will try to take key_so_mtx - Some other thread may try to localcount_drain to the SP with holding key_so_mtx in say key_api_spdflush - In this case localcount_drain never return because key_sendup_mbuf that has stuck on key_so_mtx never release a reference to the SP Fix the deadlock by deferring key_sendup_mbuf to the timer (key_timehandler). --- Fix that prev isn't cleared on retry --- Limit the number of mbufs queued for deferred key_sendup_mbuf It's easy to be queued hundreds of mbufs on the list under heavy network load. --- MP-ify SAD (savlist) localcount(9) is used to protect savlist of sah. The basic design is similar to MP-ifications of SPD and SAD sahlist. Please read the locking notes of SAD for more details. --- Simplify ipsec_reinject_ipstack (NFC) --- Add per-CPU rtcache to ipsec_reinject_ipstack It reduces route lookups and also reduces rtcache lock contentions when NET_MPSAFE is enabled. --- Use pool_cache(9) instead of pool(9) for tdb_crypto objects The change improves network throughput especially on multi-core systems. --- Update ipsec(4), opencrypto(9) and vlan(4) are now MP-safe. --- Write known issues on scalability --- Share a global dummy SP between PCBs It's never be changed so it can be pre-allocated and shared safely between PCBs. --- Fix race condition on the rawcb list shared by rtsock and keysock keysock now protects itself by its own mutex, which means that the rawcb list is protected by two different mutexes (keysock's one and softnet_lock for rtsock), of course it's useless. Fix the situation by having a discrete rawcb list for each. --- Use a dedicated mutex for rt_rawcb instead of softnet_lock if NET_MPSAFE --- fix localcount leak in sav. fixed by ozaki-r@n.o. I commit on behalf of him. --- remove unnecessary comment. --- Fix deadlock between pserialize_perform and localcount_drain A typical ussage of localcount_drain looks like this: mutex_enter(&mtx); item = remove_from_list(); pserialize_perform(psz); localcount_drain(&item->localcount, &cv, &mtx); mutex_exit(&mtx); This sequence can cause a deadlock which happens for example on the following situation: - Thread A calls localcount_drain which calls xc_broadcast after releasing a specified mutex - Thread B enters the sequence and calls pserialize_perform with holding the mutex while pserialize_perform also calls xc_broadcast - Thread C (xc_thread) that calls an xcall callback of localcount_drain tries to hold the mutex xc_broadcast of thread B doesn't start until xc_broadcast of thread A finishes, which is a feature of xcall(9). This means that pserialize_perform never complete until xc_broadcast of thread A finishes. On the other hand, thread C that is a callee of xc_broadcast of thread A sticks on the mutex. Finally the threads block each other (A blocks B, B blocks C and C blocks A). A possible fix is to serialize executions of the above sequence by another mutex, but adding another mutex makes the code complex, so fix the deadlock by another way; the fix is to release the mutex before pserialize_perform and instead use a condvar to prevent pserialize_perform from being called simultaneously. Note that the deadlock has happened only if NET_MPSAFE is enabled. --- Add missing ifdef NET_MPSAFE --- Take softnet_lock on pr_input properly if NET_MPSAFE Currently softnet_lock is taken unnecessarily in some cases, e.g., icmp_input and encap4_input from ip_input, or not taken even if needed, e.g., udp_input and tcp_input from ipsec4_common_input_cb. Fix them. NFC if NET_MPSAFE is disabled (default). --- - sanitize key debugging so that we don't print extra newlines or unassociated debugging messages. - remove unused functions and make internal ones static - print information in one line per message --- humanize printing of ip addresses --- cast reduction, NFC. --- Fix typo in comment --- Pull out ipsec_fill_saidx_bymbuf (NFC) --- Don't abuse key_checkrequest just for looking up sav It does more than expected for example key_acquire. --- Fix SP is broken on transport mode isr->saidx was modified accidentally in ipsec_nextisr. Reported by christos@ Helped investigations by christos@ and knakahara@ --- Constify isr at many places (NFC) --- Include socketvar.h for softnet_lock --- Fix buffer length for ipsec_logsastr
Revision 1.32 / (download) - annotate - [select for diffs], Tue Oct 3 08:56:52 2017 UTC (5 years, 5 months ago) by ozaki-r
Branch: MAIN
Changes since 1.31: +2 -2
lines
Diff to previous 1.31 (colored)
Constify isr at many places (NFC)
Revision 1.31 / (download) - annotate - [select for diffs], Tue Oct 3 08:34:28 2017 UTC (5 years, 5 months ago) by ozaki-r
Branch: MAIN
Changes since 1.30: +3 -2
lines
Diff to previous 1.30 (colored)
Fix SP is broken on transport mode isr->saidx was modified accidentally in ipsec_nextisr. Reported by christos@ Helped investigations by christos@ and knakahara@
Revision 1.30 / (download) - annotate - [select for diffs], Tue Oct 3 08:25:21 2017 UTC (5 years, 5 months ago) by ozaki-r
Branch: MAIN
Changes since 1.29: +2 -1
lines
Diff to previous 1.29 (colored)
Don't abuse key_checkrequest just for looking up sav It does more than expected for example key_acquire.
Revision 1.13.4.2 / (download) - annotate - [select for diffs], Mon Aug 28 17:53:13 2017 UTC (5 years, 7 months ago) by skrll
Branch: nick-nhusb
Changes since 1.13.4.1: +28 -23
lines
Diff to previous 1.13.4.1 (colored) to branchpoint 1.13 (colored) next main 1.14 (colored)
Sync with HEAD
Revision 1.29 / (download) - annotate - [select for diffs], Wed Aug 9 09:48:11 2017 UTC (5 years, 7 months ago) by ozaki-r
Branch: MAIN
CVS Tags: nick-nhusb-base-20170825
Changes since 1.28: +3 -4
lines
Diff to previous 1.28 (colored)
MP-ify SAD (savlist) localcount(9) is used to protect savlist of sah. The basic design is similar to MP-ifications of SPD and SAD sahlist. Please read the locking notes of SAD for more details.
Revision 1.28 / (download) - annotate - [select for diffs], Tue Aug 8 08:23:10 2017 UTC (5 years, 7 months ago) by ozaki-r
Branch: MAIN
Changes since 1.27: +2 -1
lines
Diff to previous 1.27 (colored)
Introduce key_sa_refcnt and replace sav->refcnt with it (NFC)
Revision 1.27 / (download) - annotate - [select for diffs], Thu Aug 3 06:32:51 2017 UTC (5 years, 7 months ago) by ozaki-r
Branch: MAIN
Changes since 1.26: +3 -1
lines
Diff to previous 1.26 (colored)
Introduce KEY_SA_UNREF and replace KEY_FREESAV with it where sav will never be actually freed in the future KEY_SA_UNREF is still key_freesav so no functional change for now. This change reduces diff of further changes.
Revision 1.26 / (download) - annotate - [select for diffs], Wed Aug 2 01:28:03 2017 UTC (5 years, 7 months ago) by ozaki-r
Branch: MAIN
Changes since 1.25: +8 -4
lines
Diff to previous 1.25 (colored)
Make IPsec SPD MP-safe We use localcount(9), not psref(9), to make the sptree and secpolicy (SP) entries MP-safe because SPs need to be referenced over opencrypto processing that executes a callback in a different context. SPs on sockets aren't managed by the sptree and can be destroyed in softint. localcount_drain cannot be used in softint so we delay the destruction of such SPs to a thread context. To do so, a list to manage such SPs is added (key_socksplist) and key_timehandler_spd deletes dead SPs in the list. For more details please read the locking notes in key.c. Proposed on tech-kern@ and tech-net@
Revision 1.25 / (download) - annotate - [select for diffs], Wed Jul 26 03:59:59 2017 UTC (5 years, 8 months ago) by ozaki-r
Branch: MAIN
Changes since 1.24: +2 -1
lines
Diff to previous 1.24 (colored)
Provide and apply key_sp_refcnt (NFC) It simplifies further changes.
Revision 1.24 / (download) - annotate - [select for diffs], Fri Jul 21 04:39:08 2017 UTC (5 years, 8 months ago) by ozaki-r
Branch: MAIN
Changes since 1.23: +1 -5
lines
Diff to previous 1.23 (colored)
Don't use key_lookup_sp that depends on unstable sp->req->sav It provided a fast look-up of SP. We will provide an alternative method in the future (after basic MP-ification finishes).
Revision 1.23 / (download) - annotate - [select for diffs], Fri Jul 14 12:26:26 2017 UTC (5 years, 8 months ago) by ozaki-r
Branch: MAIN
CVS Tags: perseant-stdc-iso10646-base,
perseant-stdc-iso10646
Changes since 1.22: +2 -2
lines
Diff to previous 1.22 (colored)
Prepare to stop using isr->sav isr is a shared resource and using isr->sav as a temporal storage for each packet processing is racy. And also having a reference from isr to sav makes the lifetime of sav non-deterministic; such a reference is removed when a packet is processed and isr->sav is overwritten by new one. Let's have a sav locally for each packet processing instead of using shared isr->sav. However this change doesn't stop using isr->sav yet because there are some users of isr->sav. isr->sav will be removed after the users find a way to not use isr->sav.
Revision 1.22 / (download) - annotate - [select for diffs], Fri Jul 14 01:24:23 2017 UTC (5 years, 8 months ago) by ozaki-r
Branch: MAIN
Changes since 1.21: +4 -1
lines
Diff to previous 1.21 (colored)
Pass sav directly to opencrypto callback In a callback, use a passed sav as-is by default and look up a sav only if the passed sav is dead.
Revision 1.21 / (download) - annotate - [select for diffs], Thu Jul 13 01:22:44 2017 UTC (5 years, 8 months ago) by ozaki-r
Branch: MAIN
Changes since 1.20: +2 -2
lines
Diff to previous 1.20 (colored)
Simplify; omit unnecessary saidx passing - ipsec_nextisr returns a saidx but no caller uses it - key_checkrequest is passed a saidx but it can be gotton by another argument (isr)
Revision 1.20 / (download) - annotate - [select for diffs], Fri Jul 7 01:37:34 2017 UTC (5 years, 8 months ago) by ozaki-r
Branch: MAIN
Changes since 1.19: +10 -10
lines
Diff to previous 1.19 (colored)
Rename key_alloc* functions (NFC) We shouldn't use the term "alloc" for functions that just look up data and actually don't allocate memory.
Revision 1.19 / (download) - annotate - [select for diffs], Tue May 30 01:31:07 2017 UTC (5 years, 10 months ago) by ozaki-r
Branch: MAIN
CVS Tags: netbsd-8-base
Branch point for: netbsd-8
Changes since 1.18: +4 -1
lines
Diff to previous 1.18 (colored)
Make refcnt operations of SA and SP atomic Using atomic opeartions isn't optimal and should be optimized somehow in the future though, the change allows a kernel with NET_MPSAFE to run out a benchmark, which is useful to know performance improvement and degradation by code changes.
Revision 1.18 / (download) - annotate - [select for diffs], Fri May 26 08:10:46 2017 UTC (5 years, 10 months ago) by ozaki-r
Branch: MAIN
Changes since 1.17: +1 -3
lines
Diff to previous 1.17 (colored)
Make key_cmpspidx_exactly and key_cmpspidx_withmask static
Revision 1.17 / (download) - annotate - [select for diffs], Fri May 26 08:09:44 2017 UTC (5 years, 10 months ago) by ozaki-r
Branch: MAIN
Changes since 1.16: +1 -2
lines
Diff to previous 1.16 (colored)
Comment out unused key_freesp_so and key_freeso
Revision 1.14.8.1 / (download) - annotate - [select for diffs], Fri May 19 00:22:58 2017 UTC (5 years, 10 months ago) by pgoyette
Branch: prg-localcount2
Changes since 1.14: +8 -9
lines
Diff to previous 1.14 (colored) next main 1.15 (colored)
Resolve conflicts from previous merge (all resulting from $NetBSD keywork expansion)
Revision 1.16 / (download) - annotate - [select for diffs], Tue May 16 02:59:22 2017 UTC (5 years, 10 months ago) by ozaki-r
Branch: MAIN
CVS Tags: prg-localcount2-base3
Changes since 1.15: +1 -2
lines
Diff to previous 1.15 (colored)
Run key_timehandler in thread context (workqueue) The handler involves object deallocations so we want to not run it in softint.
Revision 1.15 / (download) - annotate - [select for diffs], Mon May 15 09:55:29 2017 UTC (5 years, 10 months ago) by ozaki-r
Branch: MAIN
Changes since 1.14: +8 -8
lines
Diff to previous 1.14 (colored)
Show __func__ instead of __FILE__ in debug log messages __func__ is shorter and more useful than __FILE__.
Revision 1.13.4.1 / (download) - annotate - [select for diffs], Mon Apr 6 15:18:23 2015 UTC (7 years, 11 months ago) by skrll
Branch: nick-nhusb
Changes since 1.13: +1 -3
lines
Diff to previous 1.13 (colored)
Sync with HEAD
Revision 1.14 / (download) - annotate - [select for diffs], Mon Mar 30 03:51:50 2015 UTC (8 years ago) by ozaki-r
Branch: MAIN
CVS Tags: prg-localcount2-base2,
prg-localcount2-base1,
prg-localcount2-base,
pgoyette-localcount-base,
pgoyette-localcount-20170426,
pgoyette-localcount-20170320,
pgoyette-localcount-20170107,
pgoyette-localcount-20161104,
pgoyette-localcount-20160806,
pgoyette-localcount-20160726,
pgoyette-localcount,
nick-nhusb-base-20170204,
nick-nhusb-base-20161204,
nick-nhusb-base-20161004,
nick-nhusb-base-20160907,
nick-nhusb-base-20160529,
nick-nhusb-base-20160422,
nick-nhusb-base-20160319,
nick-nhusb-base-20151226,
nick-nhusb-base-20150921,
nick-nhusb-base-20150606,
nick-nhusb-base-20150406,
localcount-20160914,
jdolecek-ncq-base,
jdolecek-ncq,
bouyer-socketcan-base1,
bouyer-socketcan-base,
bouyer-socketcan
Branch point for: prg-localcount2
Changes since 1.13: +1 -3
lines
Diff to previous 1.13 (colored)
Tidy up opt_ipsec.h inclusions Some inclusions of opt_ipsec.h were for IPSEC_NAT_T and are now unnecessary. Add inclusions to some C files for IPSEC_DEBUG.
Revision 1.11.12.2 / (download) - annotate - [select for diffs], Wed Aug 20 00:04:36 2014 UTC (8 years, 7 months ago) by tls
Branch: tls-maxphys
Changes since 1.11.12.1: +2 -0
lines
Diff to previous 1.11.12.1 (colored) to branchpoint 1.11 (colored)
Rebase to HEAD as of a few days ago.
Revision 1.12.6.1 / (download) - annotate - [select for diffs], Sun Aug 10 06:56:34 2014 UTC (8 years, 7 months ago) by tls
Branch: tls-earlyentropy
Changes since 1.12: +3 -1
lines
Diff to previous 1.12 (colored) next main 1.13 (colored)
Rebase.
Revision 1.13 / (download) - annotate - [select for diffs], Fri May 30 01:39:03 2014 UTC (8 years, 10 months ago) by christos
Branch: MAIN
CVS Tags: tls-maxphys-base,
tls-earlyentropy-base,
nick-nhusb-base,
netbsd-7-nhusb-base-20170116,
netbsd-7-nhusb-base,
netbsd-7-nhusb,
netbsd-7-base,
netbsd-7-2-RELEASE,
netbsd-7-1-RELEASE,
netbsd-7-1-RC2,
netbsd-7-1-RC1,
netbsd-7-1-2-RELEASE,
netbsd-7-1-1-RELEASE,
netbsd-7-1,
netbsd-7-0-RELEASE,
netbsd-7-0-RC3,
netbsd-7-0-RC2,
netbsd-7-0-RC1,
netbsd-7-0-2-RELEASE,
netbsd-7-0-1-RELEASE,
netbsd-7-0,
netbsd-7
Branch point for: nick-nhusb
Changes since 1.12: +3 -1
lines
Diff to previous 1.12 (colored)
Introduce 2 new variables: ipsec_enabled and ipsec_used. Ipsec enabled is controlled by sysctl and determines if is allowed. ipsec_used is set automatically based on ipsec being enabled, and rules existing.
Revision 1.11.2.1 / (download) - annotate - [select for diffs], Thu May 22 11:41:10 2014 UTC (8 years, 10 months ago) by yamt
Branch: yamt-pagecache
Changes since 1.11: +1 -3
lines
Diff to previous 1.11 (colored) next main 1.12 (colored)
sync with head.
for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.
this commit was splitted into small chunks to avoid
a limitation of cvs. ("Protocol error: too many arguments")
Revision 1.11.12.1 / (download) - annotate - [select for diffs], Sun Jun 23 06:20:26 2013 UTC (9 years, 9 months ago) by tls
Branch: tls-maxphys
Changes since 1.11: +1 -3
lines
Diff to previous 1.11 (colored)
resync from head
Revision 1.12 / (download) - annotate - [select for diffs], Tue Jun 4 22:47:37 2013 UTC (9 years, 9 months ago) by christos
Branch: MAIN
CVS Tags: yamt-pagecache-base9,
rmind-smpnet-nbase,
rmind-smpnet-base,
rmind-smpnet,
riastradh-xf86-video-intel-2-7-1-pre-2-21-15,
riastradh-drm2-base3,
riastradh-drm2-base2,
riastradh-drm2-base1,
riastradh-drm2-base,
riastradh-drm2
Branch point for: tls-earlyentropy
Changes since 1.11: +1 -3
lines
Diff to previous 1.11 (colored)
PR/47886: Dr. Wolfgang Stukenbrock: IPSEC_NAT_T enabled kernels may access outdated pointers and pass ESP data to UPD-sockets. While here, simplify the code and remove the IPSEC_NAT_T option; always compile nat-traversal in so that it does not bitrot.
Revision 1.11.10.1 / (download) - annotate - [select for diffs], Thu Nov 1 16:45:04 2012 UTC (10 years, 4 months ago) by matt
Branch: matt-nb6-plus
Changes since 1.11: +5 -1
lines
Diff to previous 1.11 (colored) next main 1.12 (colored)
sync with netbsd-6-0-RELEASE.
Revision 1.11.8.1 / (download) - annotate - [select for diffs], Mon Sep 3 19:19:55 2012 UTC (10 years, 6 months ago) by riz
Branch: netbsd-6
CVS Tags: netbsd-6-1-RELEASE,
netbsd-6-1-RC4,
netbsd-6-1-RC3,
netbsd-6-1-RC2,
netbsd-6-1-RC1,
netbsd-6-1-5-RELEASE,
netbsd-6-1-4-RELEASE,
netbsd-6-1-3-RELEASE,
netbsd-6-1-2-RELEASE,
netbsd-6-1-1-RELEASE,
netbsd-6-1,
netbsd-6-0-RELEASE,
netbsd-6-0-RC2,
netbsd-6-0-6-RELEASE,
netbsd-6-0-5-RELEASE,
netbsd-6-0-4-RELEASE,
netbsd-6-0-3-RELEASE,
netbsd-6-0-2-RELEASE,
netbsd-6-0-1-RELEASE,
netbsd-6-0,
matt-nb6-plus-nbase,
matt-nb6-plus-base
Changes since 1.11: +5 -1
lines
Diff to previous 1.11 (colored) next main 1.12 (colored)
Apply patch requested by msaitoh in pullup-6 ticket #538:
* add TAILQ satailq and sptailq
- these queues are referenced from kernfs/ipsecsa, kernfs/ipsecsp
as a weak_symbol.
- KAME netkey has the two queues, but FAST-IPsec netkey doen't.
This cause a panic. To prevent this panic, make a empty tailq.
- The tailq doen't work, because there are no implementation yet...
Revision 1.10.2.1 / (download) - annotate - [select for diffs], Thu Jun 23 14:20:27 2011 UTC (11 years, 9 months ago) by cherry
Branch: cherry-xenmp
Changes since 1.10: +2 -2
lines
Diff to previous 1.10 (colored) next main 1.11 (colored)
Catchup with rmind-uvmplock merge.
Revision 1.8.56.3 / (download) - annotate - [select for diffs], Sun Jun 12 00:24:31 2011 UTC (11 years, 9 months ago) by rmind
Branch: rmind-uvmplock
Changes since 1.8.56.2: +1 -1
lines
Diff to previous 1.8.56.2 (colored) to branchpoint 1.8 (colored) next main 1.9 (colored)
sync with head
Revision 1.11 / (download) - annotate - [select for diffs], Thu Jun 9 19:54:18 2011 UTC (11 years, 9 months ago) by drochner
Branch: MAIN
CVS Tags: yamt-pagecache-tag8,
yamt-pagecache-base8,
yamt-pagecache-base7,
yamt-pagecache-base6,
yamt-pagecache-base5,
yamt-pagecache-base4,
yamt-pagecache-base3,
yamt-pagecache-base2,
yamt-pagecache-base,
rmind-uvmplock-nbase,
rmind-uvmplock-base,
netbsd-6-base,
netbsd-6-0-RC1,
khorben-n900,
jmcneill-usbmp-pre-base2,
jmcneill-usbmp-base9,
jmcneill-usbmp-base8,
jmcneill-usbmp-base7,
jmcneill-usbmp-base6,
jmcneill-usbmp-base5,
jmcneill-usbmp-base4,
jmcneill-usbmp-base3,
jmcneill-usbmp-base2,
jmcneill-usbmp-base10,
jmcneill-usbmp-base,
jmcneill-usbmp,
jmcneill-audiomp3-base,
jmcneill-audiomp3,
agc-symver-base,
agc-symver
Branch point for: yamt-pagecache,
tls-maxphys,
netbsd-6,
matt-nb6-plus
Changes since 1.10: +2 -2
lines
Diff to previous 1.10 (colored)
more "const"
Revision 1.8.62.1 / (download) - annotate - [select for diffs], Mon Jun 6 09:10:01 2011 UTC (11 years, 9 months ago) by jruoho
Branch: jruoho-x86intr
Changes since 1.8: +8 -9
lines
Diff to previous 1.8 (colored) next main 1.9 (colored)
Sync with HEAD.
Revision 1.8.56.2 / (download) - annotate - [select for diffs], Tue May 31 03:05:10 2011 UTC (11 years, 10 months ago) by rmind
Branch: rmind-uvmplock
Changes since 1.8.56.1: +0 -1
lines
Diff to previous 1.8.56.1 (colored) to branchpoint 1.8 (colored)
sync with head
Revision 1.10 / (download) - annotate - [select for diffs], Mon May 23 15:17:25 2011 UTC (11 years, 10 months ago) by drochner
Branch: MAIN
CVS Tags: cherry-xenmp-base
Branch point for: cherry-xenmp
Changes since 1.9: +1 -2
lines
Diff to previous 1.9 (colored)
g/c remainders of IV handling in pfkey code -- this is done in opencrypto now
Revision 1.8.56.1 / (download) - annotate - [select for diffs], Sat Mar 5 20:56:00 2011 UTC (12 years ago) by rmind
Branch: rmind-uvmplock
Changes since 1.8: +8 -8
lines
Diff to previous 1.8 (colored)
sync with head
Revision 1.8.64.1 / (download) - annotate - [select for diffs], Sat Mar 5 15:10:48 2011 UTC (12 years ago) by bouyer
Branch: bouyer-quota2
Changes since 1.8: +8 -8
lines
Diff to previous 1.8 (colored) next main 1.9 (colored)
Sync with HEAD
Revision 1.9 / (download) - annotate - [select for diffs], Mon Feb 21 22:28:19 2011 UTC (12 years, 1 month ago) by drochner
Branch: MAIN
CVS Tags: bouyer-quota2-nbase
Changes since 1.8: +8 -8
lines
Diff to previous 1.8 (colored)
treat "struct secpolicyindex" and "struct secasindex" as "const" once they are initialized -- during lifetime, no changes are expected plus some constification of input to comparision functions etc mostly required by the former
Revision 1.3.4.3 / (download) - annotate - [select for diffs], Mon Sep 3 14:43:46 2007 UTC (15 years, 6 months ago) by yamt
Branch: yamt-lazymbuf
Changes since 1.3.4.2: +39 -36
lines
Diff to previous 1.3.4.2 (colored) to branchpoint 1.3 (colored) next main 1.4 (colored)
sync with head.
Revision 1.6.2.1 / (download) - annotate - [select for diffs], Sun Jul 15 13:28:03 2007 UTC (15 years, 8 months ago) by ad
Branch: vmlocking
Changes since 1.6: +39 -36
lines
Diff to previous 1.6 (colored) next main 1.7 (colored)
Sync with head.
Revision 1.6.4.1 / (download) - annotate - [select for diffs], Wed Jul 11 20:11:53 2007 UTC (15 years, 8 months ago) by mjf
Branch: mjf-ufs-trans
Changes since 1.6: +39 -36
lines
Diff to previous 1.6 (colored) next main 1.7 (colored)
Sync with head.
Revision 1.8 / (download) - annotate - [select for diffs], Sat Jul 7 18:38:23 2007 UTC (15 years, 8 months ago) by degroote
Branch: MAIN
CVS Tags: yamt-x86pmap-base4,
yamt-x86pmap-base3,
yamt-x86pmap-base2,
yamt-x86pmap-base,
yamt-x86pmap,
yamt-pf42-baseX,
yamt-pf42-base4,
yamt-pf42-base3,
yamt-pf42-base2,
yamt-pf42-base,
yamt-pf42,
yamt-nfs-mp-base9,
yamt-nfs-mp-base8,
yamt-nfs-mp-base7,
yamt-nfs-mp-base6,
yamt-nfs-mp-base5,
yamt-nfs-mp-base4,
yamt-nfs-mp-base3,
yamt-nfs-mp-base2,
yamt-nfs-mp-base11,
yamt-nfs-mp-base10,
yamt-nfs-mp-base,
yamt-nfs-mp,
yamt-lazymbuf-base15,
yamt-lazymbuf-base14,
yamt-kmem-base3,
yamt-kmem-base2,
yamt-kmem-base,
yamt-kmem,
wrstuden-revivesa-base-4,
wrstuden-revivesa-base-3,
wrstuden-revivesa-base-2,
wrstuden-revivesa-base-1,
wrstuden-revivesa-base,
wrstuden-revivesa,
vmlocking2-base3,
vmlocking2-base2,
vmlocking2-base1,
vmlocking2,
vmlocking-nbase,
vmlocking-base,
uebayasi-xip-base4,
uebayasi-xip-base3,
uebayasi-xip-base2,
uebayasi-xip-base1,
uebayasi-xip-base,
uebayasi-xip,
simonb-wapbl-nbase,
simonb-wapbl-base,
simonb-wapbl,
reinoud-bufcleanup-nbase,
reinoud-bufcleanup-base,
nick-net80211-sync-base,
nick-net80211-sync,
nick-hppapmap-base4,
nick-hppapmap-base3,
nick-hppapmap-base2,
nick-hppapmap-base,
nick-hppapmap,
nick-csl-alignment-base5,
nick-csl-alignment-base,
nick-csl-alignment,
netbsd-5-base,
netbsd-5-2-RELEASE,
netbsd-5-2-RC1,
netbsd-5-2-3-RELEASE,
netbsd-5-2-2-RELEASE,
netbsd-5-2-1-RELEASE,
netbsd-5-2,
netbsd-5-1-RELEASE,
netbsd-5-1-RC4,
netbsd-5-1-RC3,
netbsd-5-1-RC2,
netbsd-5-1-RC1,
netbsd-5-1-5-RELEASE,
netbsd-5-1-4-RELEASE,
netbsd-5-1-3-RELEASE,
netbsd-5-1-2-RELEASE,
netbsd-5-1-1-RELEASE,
netbsd-5-1,
netbsd-5-0-RELEASE,
netbsd-5-0-RC4,
netbsd-5-0-RC3,
netbsd-5-0-RC2,
netbsd-5-0-RC1,
netbsd-5-0-2-RELEASE,
netbsd-5-0-1-RELEASE,
netbsd-5-0,
netbsd-5,
mjf-ufs-trans-base,
mjf-devfs2-base,
mjf-devfs2,
mjf-devfs-base,
mjf-devfs,
matt-premerge-20091211,
matt-nb5-pq3-base,
matt-nb5-pq3,
matt-nb5-mips64-u2-k2-k4-k7-k8-k9,
matt-nb5-mips64-u1-k1-k5,
matt-nb5-mips64-premerge-20101231,
matt-nb5-mips64-premerge-20091211,
matt-nb5-mips64-k15,
matt-nb5-mips64,
matt-nb4-mips64-k7-u2a-k9b,
matt-mips64-premerge-20101231,
matt-mips64-base2,
matt-mips64-base,
matt-mips64,
matt-armv6-prevmlocking,
matt-armv6-nbase,
matt-armv6-base,
matt-armv6,
keiichi-mipv6-nbase,
keiichi-mipv6-base,
keiichi-mipv6,
jymxensuspend-base,
jym-xensuspend-nbase,
jym-xensuspend-base,
jym-xensuspend,
jruoho-x86intr-base,
jmcneill-pm-base,
jmcneill-pm,
jmcneill-base,
hpcarm-cleanup-nbase,
hpcarm-cleanup-base,
hpcarm-cleanup,
haad-nbase2,
haad-dm-base2,
haad-dm-base1,
haad-dm-base,
haad-dm,
cube-autoconf-base,
cube-autoconf,
bouyer-xeni386-nbase,
bouyer-xeni386-merge1,
bouyer-xeni386-base,
bouyer-xeni386,
bouyer-xenamd64-base2,
bouyer-xenamd64-base,
bouyer-xenamd64,
bouyer-quota2-base,
ad-socklock-base1,
ad-audiomp2-base,
ad-audiomp2
Branch point for: rmind-uvmplock,
jruoho-x86intr,
bouyer-quota2
Changes since 1.7: +29 -34
lines
Diff to previous 1.7 (colored)
Ansify Remove useless extern bzero -> memset, bcopy -> memcpy No functionnal changes
Revision 1.7 / (download) - annotate - [select for diffs], Wed Jun 27 20:38:33 2007 UTC (15 years, 9 months ago) by degroote
Branch: MAIN
Changes since 1.6: +12 -4
lines
Diff to previous 1.6 (colored)
Add support for options IPSEC_NAT_T (RFC 3947 and 3948) for fast_ipsec(4). No objection on tech-net@
Revision 1.4.26.2 / (download) - annotate - [select for diffs], Mon Mar 12 06:00:09 2007 UTC (16 years ago) by rmind
Branch: yamt-idlelwp
Changes since 1.4.26.1: +2 -2
lines
Diff to previous 1.4.26.1 (colored) to branchpoint 1.4 (colored) next main 1.5 (colored)
Sync with HEAD.
Revision 1.6 / (download) - annotate - [select for diffs], Sun Mar 4 06:03:29 2007 UTC (16 years ago) by christos
Branch: MAIN
CVS Tags: yamt-idlelwp-base8,
thorpej-atomic-base,
thorpej-atomic,
reinoud-bufcleanup
Branch point for: vmlocking,
mjf-ufs-trans
Changes since 1.5: +2 -2
lines
Diff to previous 1.5 (colored)
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
Revision 1.4.26.1 / (download) - annotate - [select for diffs], Tue Feb 27 16:55:07 2007 UTC (16 years, 1 month ago) by yamt
Branch: yamt-idlelwp
Changes since 1.4: +3 -3
lines
Diff to previous 1.4 (colored)
- sync with head. - move sched_changepri back to kern_synch.c as it doesn't know PPQ anymore.
Revision 1.3.4.2 / (download) - annotate - [select for diffs], Mon Feb 26 09:11:57 2007 UTC (16 years, 1 month ago) by yamt
Branch: yamt-lazymbuf
Changes since 1.3.4.1: +3 -3
lines
Diff to previous 1.3.4.1 (colored) to branchpoint 1.3 (colored)
sync with head.
Revision 1.5 / (download) - annotate - [select for diffs], Sun Feb 18 13:55:26 2007 UTC (16 years, 1 month ago) by degroote
Branch: MAIN
CVS Tags: ad-audiomp-base,
ad-audiomp
Changes since 1.4: +3 -3
lines
Diff to previous 1.4 (colored)
Constify the code following the dyoung change ( the "bug" was hidden by the extern declaration ). While here, remove a Kame ifdef which is useless in netipsec code
Revision 1.3.4.1 / (download) - annotate - [select for diffs], Wed Jun 21 15:11:24 2006 UTC (16 years, 9 months ago) by yamt
Branch: yamt-lazymbuf
Changes since 1.3: +2 -2
lines
Diff to previous 1.3 (colored)
sync with head.
Revision 1.2.4.6 / (download) - annotate - [select for diffs], Sun Dec 11 10:29:32 2005 UTC (17 years, 3 months ago) by christos
Branch: ktrace-lwp
Changes since 1.2.4.5: +2 -2
lines
Diff to previous 1.2.4.5 (colored) to branchpoint 1.2 (colored) next main 1.3 (colored)
Sync with head.
Revision 1.4 / (download) - annotate - [select for diffs], Sat Dec 10 23:44:08 2005 UTC (17 years, 3 months ago) by elad
Branch: MAIN
CVS Tags: yamt-uio_vmspace-base5,
yamt-uio_vmspace,
yamt-splraiseipl-base5,
yamt-splraiseipl-base4,
yamt-splraiseipl-base3,
yamt-splraiseipl-base2,
yamt-splraiseipl-base,
yamt-splraiseipl,
yamt-pdpolicy-base9,
yamt-pdpolicy-base8,
yamt-pdpolicy-base7,
yamt-pdpolicy-base6,
yamt-pdpolicy-base5,
yamt-pdpolicy-base4,
yamt-pdpolicy-base3,
yamt-pdpolicy-base2,
yamt-pdpolicy-base,
yamt-pdpolicy,
wrstuden-fixsa-newbase,
wrstuden-fixsa-base-1,
wrstuden-fixsa-base,
wrstuden-fixsa,
simonb-timecounters-base,
simonb-timecounters,
simonb-timcounters-final,
rpaulo-netinet-merge-pcb-base,
rpaulo-netinet-merge-pcb,
post-newlock2-merge,
peter-altq-base,
peter-altq,
newlock2-nbase,
newlock2-base,
newlock2,
netbsd-4-base,
netbsd-4-0-RELEASE,
netbsd-4-0-RC5,
netbsd-4-0-RC4,
netbsd-4-0-RC3,
netbsd-4-0-RC2,
netbsd-4-0-RC1,
netbsd-4-0-1-RELEASE,
netbsd-4-0,
netbsd-4,
matt-nb4-arm-base,
matt-nb4-arm,
ktrace-lwp-base,
gdamore-uart-base,
gdamore-uart,
elad-kernelauth-base,
elad-kernelauth,
chap-midi-nbase,
chap-midi-base,
chap-midi,
abandoned-netbsd-4-base,
abandoned-netbsd-4
Branch point for: yamt-idlelwp
Changes since 1.3: +2 -2
lines
Diff to previous 1.3 (colored)
Multiple inclusion protection, as suggested by christos@ on tech-kern@ few days ago.
Revision 1.2.10.1 / (download) - annotate - [select for diffs], Fri Apr 29 11:29:35 2005 UTC (17 years, 11 months ago) by kent
Branch: kent-audio2
Changes since 1.2: +2 -2
lines
Diff to previous 1.2 (colored) next main 1.3 (colored)
sync with -current
Revision 1.2.12.1 / (download) - annotate - [select for diffs], Sat Mar 19 08:36:41 2005 UTC (18 years ago) by yamt
Branch: yamt-km
Changes since 1.2: +2 -2
lines
Diff to previous 1.2 (colored) next main 1.3 (colored)
sync with head. xen and whitespace. xen part is not finished.
Revision 1.2.4.5 / (download) - annotate - [select for diffs], Fri Mar 4 16:53:44 2005 UTC (18 years ago) by skrll
Branch: ktrace-lwp
Changes since 1.2.4.4: +2 -2
lines
Diff to previous 1.2.4.4 (colored) to branchpoint 1.2 (colored)
Sync with HEAD. Hi Perry!
Revision 1.3 / (download) - annotate - [select for diffs], Sat Feb 26 22:45:13 2005 UTC (18 years, 1 month ago) by perry
Branch: MAIN
CVS Tags: yamt-vop-base3,
yamt-vop-base2,
yamt-vop-base,
yamt-vop,
yamt-readahead-pervnode,
yamt-readahead-perfile,
yamt-readahead-base3,
yamt-readahead-base2,
yamt-readahead-base,
yamt-readahead,
yamt-km-base4,
yamt-km-base3,
thorpej-vnode-attr-base,
thorpej-vnode-attr,
netbsd-3-base,
netbsd-3-1-RELEASE,
netbsd-3-1-RC4,
netbsd-3-1-RC3,
netbsd-3-1-RC2,
netbsd-3-1-RC1,
netbsd-3-1-1-RELEASE,
netbsd-3-1,
netbsd-3-0-RELEASE,
netbsd-3-0-RC6,
netbsd-3-0-RC5,
netbsd-3-0-RC4,
netbsd-3-0-RC3,
netbsd-3-0-RC2,
netbsd-3-0-RC1,
netbsd-3-0-3-RELEASE,
netbsd-3-0-2-RELEASE,
netbsd-3-0-1-RELEASE,
netbsd-3-0,
netbsd-3,
kent-audio2-base
Branch point for: yamt-lazymbuf
Changes since 1.2: +2 -2
lines
Diff to previous 1.2 (colored)
nuke trailing whitespace
Revision 1.2.4.4 / (download) - annotate - [select for diffs], Tue Sep 21 13:37:48 2004 UTC (18 years, 6 months ago) by skrll
Branch: ktrace-lwp
Changes since 1.2.4.3: +1 -1
lines
Diff to previous 1.2.4.3 (colored) to branchpoint 1.2 (colored)
Fix the sync with head I botched.
Revision 1.2.4.3 / (download) - annotate - [select for diffs], Sat Sep 18 14:55:32 2004 UTC (18 years, 6 months ago) by skrll
Branch: ktrace-lwp
Changes since 1.2.4.2: +1 -1
lines
Diff to previous 1.2.4.2 (colored) to branchpoint 1.2 (colored)
Sync with HEAD.
Revision 1.2.4.2 / (download) - annotate - [select for diffs], Tue Aug 3 10:55:29 2004 UTC (18 years, 7 months ago) by skrll
Branch: ktrace-lwp
Changes since 1.2.4.1: +119 -0
lines
Diff to previous 1.2.4.1 (colored) to branchpoint 1.2 (colored)
Sync with HEAD
Revision 1.2.4.1, Tue Mar 2 02:22:56 2004 UTC (19 years, 1 month ago) by skrll
Branch: ktrace-lwp
Changes since 1.2: +0 -119
lines
FILE REMOVED
file key.h was added on branch ktrace-lwp on 2004-08-03 10:55:29 +0000
Revision 1.2 / (download) - annotate - [select for diffs], Tue Mar 2 02:22:56 2004 UTC (19 years, 1 month ago) by thorpej
Branch: MAIN
CVS Tags: yamt-km-base2,
yamt-km-base,
netbsd-2-base,
netbsd-2-1-RELEASE,
netbsd-2-1-RC6,
netbsd-2-1-RC5,
netbsd-2-1-RC4,
netbsd-2-1-RC3,
netbsd-2-1-RC2,
netbsd-2-1-RC1,
netbsd-2-1,
netbsd-2-0-base,
netbsd-2-0-RELEASE,
netbsd-2-0-RC5,
netbsd-2-0-RC4,
netbsd-2-0-RC3,
netbsd-2-0-RC2,
netbsd-2-0-RC1,
netbsd-2-0-3-RELEASE,
netbsd-2-0-2-RELEASE,
netbsd-2-0-1-RELEASE,
netbsd-2-0,
netbsd-2,
kent-audio1-beforemerge,
kent-audio1-base,
kent-audio1
Branch point for: yamt-km,
ktrace-lwp,
kent-audio2
Changes since 1.1: +5 -1
lines
Diff to previous 1.1 (colored)
Bring the PCB policy cache over from KAME IPsec, including the "hint" used to short-circuit IPsec processing in other places. This is enabled only for NetBSD at the moment; in order for it to function correctly, ipsec_pcbconn() must be called as appropriate.
Revision 1.1 / (download) - annotate - [select for diffs], Wed Aug 13 20:06:51 2003 UTC (19 years, 7 months ago) by jonathan
Branch: MAIN
Initial import of Sam Leffler's `Fast-IPsec' from FreeBSD 4. Fast-IPsec is a rework of the OpenBSD and KAME IPsec code, using the OpenCryptoFramework (and thus hardware crypto accelerators) and numerous detailed performance improvements. This import is (aside from SPL-level names) the FreeBSD source, imported ``as-is'' as a historical snapshot, for future maintenance and comparison against the FreeBSD source. For now, several minor kernel-API differences are hidden by macros a shim file, ipsec_osdep.h, which (aside from SPL names) can be targeted at either NetBSD or FreeBSD.