Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. =================================================================== RCS file: /ftp/cvs/cvsroot/src/sys/netinet6/mld6.c,v rcsdiff: /ftp/cvs/cvsroot/src/sys/netinet6/mld6.c,v: warning: Unknown phrases like `commitid ...;' are present. retrieving revision 1.29.2.1 retrieving revision 1.39 diff -u -p -r1.29.2.1 -r1.39 --- src/sys/netinet6/mld6.c 2006/09/09 02:58:55 1.29.2.1 +++ src/sys/netinet6/mld6.c 2007/07/09 21:11:13 1.39 @@ -1,4 +1,4 @@ -/* $NetBSD: mld6.c,v 1.29.2.1 2006/09/09 02:58:55 rpaulo Exp $ */ +/* $NetBSD: mld6.c,v 1.39 2007/07/09 21:11:13 ad Exp $ */ /* $KAME: mld6.c,v 1.25 2001/01/16 14:14:18 itojun Exp $ */ /* @@ -102,7 +102,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: mld6.c,v 1.29.2.1 2006/09/09 02:58:55 rpaulo Exp $"); +__KERNEL_RCSID(0, "$NetBSD: mld6.c,v 1.39 2007/07/09 21:11:13 ad Exp $"); #include "opt_inet.h" @@ -181,7 +181,7 @@ mld_init() hbh_buf[3] = 0; hbh_buf[4] = IP6OPT_RTALERT; hbh_buf[5] = IP6OPT_RTALERT_LEN - 2; - bcopy((caddr_t)&rtalert_code, &hbh_buf[6], sizeof(u_int16_t)); + bcopy((void *)&rtalert_code, &hbh_buf[6], sizeof(u_int16_t)); ip6_opts.ip6po_hbh = hbh; /* We will specify the hoplimit by a multicast option. */ @@ -189,8 +189,7 @@ mld_init() } static void -mld_starttimer(in6m) - struct in6_multi *in6m; +mld_starttimer(struct in6_multi *in6m) { struct timeval now; @@ -209,8 +208,7 @@ mld_starttimer(in6m) } static void -mld_stoptimer(in6m) - struct in6_multi *in6m; +mld_stoptimer(struct in6_multi *in6m) { if (in6m->in6m_timer == IN6M_TIMER_UNDEF) return; @@ -221,8 +219,7 @@ mld_stoptimer(in6m) } static void -mld_timeo(in6m) - struct in6_multi *in6m; +mld_timeo(struct in6_multi *in6m) { int s = splsoftnet(); @@ -243,8 +240,7 @@ mld_timeo(in6m) } static u_long -mld_timerresid(in6m) - struct in6_multi *in6m; +mld_timerresid(struct in6_multi *in6m) { struct timeval now, diff; @@ -268,8 +264,7 @@ mld_timerresid(in6m) } static void -mld_start_listening(in6m) - struct in6_multi *in6m; +mld_start_listening(struct in6_multi *in6m) { struct in6_addr all_in6; @@ -301,8 +296,7 @@ mld_start_listening(in6m) } static void -mld_stop_listening(in6m) - struct in6_multi *in6m; +mld_stop_listening(struct in6_multi *in6m) { struct in6_addr allnode, allrouter; @@ -326,9 +320,7 @@ mld_stop_listening(in6m) } void -mld_input(m, off) - struct mbuf *m; - int off; +mld_input(struct mbuf *m, int off) { struct ip6_hdr *ip6 = mtod(m, struct ip6_hdr *); struct mld_hdr *mldh; @@ -428,10 +420,7 @@ mld_input(m, off) if (ia == NULL) break; - for (in6m = ia->ia6_multiaddrs.lh_first; - in6m; - in6m = in6m->in6m_entry.le_next) - { + LIST_FOREACH(in6m, &ia->ia6_multiaddrs, in6m_entry) { if (IN6_ARE_ADDR_EQUAL(&in6m->in6m_addr, &all_in6) || IPV6_ADDR_MC_SCOPE(&in6m->in6m_addr) < IPV6_ADDR_SCOPE_LINKLOCAL) @@ -500,10 +489,8 @@ mld_input(m, off) } static void -mld_sendpkt(in6m, type, dst) - struct in6_multi *in6m; - int type; - const struct in6_addr *dst; +mld_sendpkt(struct in6_multi *in6m, int type, + const struct in6_addr *dst) { struct mbuf *mh; struct mld_hdr *mldh; @@ -571,11 +558,8 @@ mld_sendpkt(in6m, type, dst) } static struct mld_hdr * -mld_allocbuf(mh, len, in6m, type) - struct mbuf **mh; - int len; - struct in6_multi *in6m; - int type; +mld_allocbuf(struct mbuf **mh, int len, struct in6_multi *in6m, + int type) { struct mbuf *md; struct mld_hdr *mldh; @@ -626,10 +610,8 @@ mld_allocbuf(mh, len, in6m, type) * Add an address to the list of IP6 multicast addresses for a given interface. */ struct in6_multi * -in6_addmulti(maddr6, ifp, errorp, timer) - struct in6_addr *maddr6; - struct ifnet *ifp; - int *errorp, timer; +in6_addmulti(struct in6_addr *maddr6, struct ifnet *ifp, + int *errorp, int timer) { struct in6_ifaddr *ia; struct in6_ifreq ifr; @@ -674,6 +656,7 @@ in6_addmulti(maddr6, ifp, errorp, timer) } IFP_TO_IA6(ifp, ia); if (ia == NULL) { + /* leaks in6m_timer_ch */ free(in6m, M_IPMADDR); splx(s); *errorp = EADDRNOTAVAIL; /* appropriate? */ @@ -695,16 +678,17 @@ in6_addmulti(maddr6, ifp, errorp, timer) *errorp = ENXIO; /* XXX: appropriate? */ else *errorp = (*ifp->if_ioctl)(ifp, SIOCADDMULTI, - (caddr_t)&ifr); + (void *)&ifr); if (*errorp) { LIST_REMOVE(in6m, in6m_entry); + /* leaks in6m_timer_ch */ free(in6m, M_IPMADDR); IFAFREE(&ia->ia_ifa); splx(s); return (NULL); } - callout_init(in6m->in6m_timer_ch); + callout_init(in6m->in6m_timer_ch, 0); in6m->in6m_timer = timer; if (in6m->in6m_timer > 0) { in6m->in6m_state = MLD_REPORTPENDING; @@ -728,8 +712,7 @@ in6_addmulti(maddr6, ifp, errorp, timer) * Delete a multicast address record. */ void -in6_delmulti(in6m) - struct in6_multi *in6m; +in6_delmulti(struct in6_multi *in6m) { struct in6_ifreq ifr; struct in6_ifaddr *ia; @@ -748,8 +731,9 @@ in6_delmulti(in6m) * Unlink from list. */ LIST_REMOVE(in6m, in6m_entry); - if (in6m->in6m_ia) { + if (in6m->in6m_ia != NULL) { IFAFREE(&in6m->in6m_ia->ia_ifa); /* release reference */ + in6m->in6m_ia = NULL; } /* @@ -758,8 +742,7 @@ in6_delmulti(in6m) */ for (ia = in6_ifaddr; ia; ia = ia->ia_next) { struct in6_multi_mship *imm; - LIST_FOREACH(imm, &ia->ia6_memberships, - i6mm_chain) { + LIST_FOREACH(imm, &ia->ia6_memberships, i6mm_chain) { if (imm->i6mm_maddr == in6m) imm->i6mm_maddr = NULL; } @@ -774,7 +757,7 @@ in6_delmulti(in6m) ifr.ifr_addr.sin6_len = sizeof(struct sockaddr_in6); ifr.ifr_addr.sin6_addr = in6m->in6m_addr; (*in6m->in6m_ifp->if_ioctl)(in6m->in6m_ifp, - SIOCDELMULTI, (caddr_t)&ifr); + SIOCDELMULTI, (void *)&ifr); free(in6m->in6m_timer_ch, M_IPMADDR); free(in6m, M_IPMADDR); } @@ -783,10 +766,8 @@ in6_delmulti(in6m) struct in6_multi_mship * -in6_joingroup(ifp, addr, errorp, timer) - struct ifnet *ifp; - struct in6_addr *addr; - int *errorp, timer; +in6_joingroup(struct ifnet *ifp, struct in6_addr *addr, + int *errorp, int timer) { struct in6_multi_mship *imm; @@ -799,7 +780,7 @@ in6_joingroup(ifp, addr, errorp, timer) memset(imm, 0, sizeof(*imm)); imm->i6mm_maddr = in6_addmulti(addr, ifp, errorp, timer); if (!imm->i6mm_maddr) { - /* *errorp is alrady set */ + /* *errorp is already set */ free(imm, M_IPMADDR); return NULL; } @@ -807,8 +788,7 @@ in6_joingroup(ifp, addr, errorp, timer) } int -in6_leavegroup(imm) - struct in6_multi_mship *imm; +in6_leavegroup(struct in6_multi_mship *imm) { if (imm->i6mm_maddr) { @@ -826,33 +806,33 @@ in6_leavegroup(imm) * such time as this interface is reconfigured for IPv6. */ void -in6_savemkludge(oia) - struct in6_ifaddr *oia; +in6_savemkludge(struct in6_ifaddr *oia) { struct in6_ifaddr *ia; - struct in6_multi *in6m, *next; + struct in6_multi *in6m; IFP_TO_IA6(oia->ia_ifp, ia); if (ia) { /* there is another address */ - for (in6m = oia->ia6_multiaddrs.lh_first; in6m; in6m = next) { - next = in6m->in6m_entry.le_next; - IFAFREE(&in6m->in6m_ia->ia_ifa); + KASSERT(ia != oia); + while ((in6m = LIST_FIRST(&oia->ia6_multiaddrs)) != NULL) { + LIST_REMOVE(in6m, in6m_entry); IFAREF(&ia->ia_ifa); + IFAFREE(&in6m->in6m_ia->ia_ifa); in6m->in6m_ia = ia; LIST_INSERT_HEAD(&ia->ia6_multiaddrs, in6m, in6m_entry); } } else { /* last address on this if deleted, save */ struct multi6_kludge *mk; - for (mk = in6_mk.lh_first; mk; mk = mk->mk_entry.le_next) { + LIST_FOREACH(mk, &in6_mk, mk_entry) { if (mk->mk_ifp == oia->ia_ifp) break; } if (mk == NULL) /* this should not happen! */ panic("in6_savemkludge: no kludge space"); - for (in6m = oia->ia6_multiaddrs.lh_first; in6m; in6m = next) { - next = in6m->in6m_entry.le_next; + while ((in6m = LIST_FIRST(&oia->ia6_multiaddrs)) != NULL) { + LIST_REMOVE(in6m, in6m_entry); IFAFREE(&in6m->in6m_ia->ia_ifa); /* release reference */ in6m->in6m_ia = NULL; LIST_INSERT_HEAD(&mk->mk_head, in6m, in6m_entry); @@ -866,26 +846,22 @@ in6_savemkludge(oia) * then we re-attach it to the first address configured on the i/f. */ void -in6_restoremkludge(ia, ifp) - struct in6_ifaddr *ia; - struct ifnet *ifp; +in6_restoremkludge(struct in6_ifaddr *ia, struct ifnet *ifp) { struct multi6_kludge *mk; + struct in6_multi *in6m; - for (mk = in6_mk.lh_first; mk; mk = mk->mk_entry.le_next) { - if (mk->mk_ifp == ifp) { - struct in6_multi *in6m, *next; - - for (in6m = mk->mk_head.lh_first; in6m; in6m = next) { - next = in6m->in6m_entry.le_next; - in6m->in6m_ia = ia; - IFAREF(&ia->ia_ifa); - LIST_INSERT_HEAD(&ia->ia6_multiaddrs, - in6m, in6m_entry); - } - LIST_INIT(&mk->mk_head); + LIST_FOREACH(mk, &in6_mk, mk_entry) { + if (mk->mk_ifp == ifp) break; - } + } + if (mk == NULL) + return; + while ((in6m = LIST_FIRST(&mk->mk_head)) != NULL) { + LIST_REMOVE(in6m, in6m_entry); + in6m->in6m_ia = ia; + IFAREF(&ia->ia_ifa); + LIST_INSERT_HEAD(&ia->ia6_multiaddrs, in6m, in6m_entry); } } @@ -901,12 +877,11 @@ in6_restoremkludge(ia, ifp) * it is a global function. */ void -in6_createmkludge(ifp) - struct ifnet *ifp; +in6_createmkludge(struct ifnet *ifp) { struct multi6_kludge *mk; - for (mk = in6_mk.lh_first; mk; mk = mk->mk_entry.le_next) { + LIST_FOREACH(mk, &in6_mk, mk_entry) { /* If we've already had one, do not allocate. */ if (mk->mk_ifp == ifp) return; @@ -921,22 +896,23 @@ in6_createmkludge(ifp) } void -in6_purgemkludge(ifp) - struct ifnet *ifp; +in6_purgemkludge(struct ifnet *ifp) { struct multi6_kludge *mk; - struct in6_multi *in6m; + struct in6_multi *in6m, *next; - for (mk = in6_mk.lh_first; mk; mk = mk->mk_entry.le_next) { - if (mk->mk_ifp != ifp) - continue; - - /* leave from all multicast groups joined */ - while ((in6m = LIST_FIRST(&mk->mk_head)) != NULL) { - in6_delmulti(in6m); - } - LIST_REMOVE(mk, mk_entry); - free(mk, M_IPMADDR); - break; + LIST_FOREACH(mk, &in6_mk, mk_entry) { + if (mk->mk_ifp == ifp) + break; + } + if (mk == NULL) + return; + + /* leave from all multicast groups joined */ + for (in6m = LIST_FIRST(&mk->mk_head); in6m != NULL; in6m = next) { + next = LIST_NEXT(in6m, in6m_entry); + in6_delmulti(in6m); } + LIST_REMOVE(mk, mk_entry); + free(mk, M_IPMADDR); }