CVS log for src/sys/netinet/sctp_usrreq.c

Up to [cvs.NetBSD.org] / src / sys / netinet

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

s/effect/affect/ in a few places

fix a/an grammar in obvious cases

sys: Drop redundant NULL check before m_freem(9)

m_freem(9) safely has accepted NULL argument at least since 4.2BSD:
https://www.tuhs.org/cgi-bin/utree.pl?file=4.2BSD/usr/src/sys/sys/uipc_mbuf.c

Compile-tested on amd64/ALL.

Suggested by knakahara@

fix spelling mistakes, mainly in comments and log messages.

inpcb: rename functions to inpcb_*

Inspired by rmind-smpnet patches.

s/blity/bility/ in various words, mainly in comments.

fix various typos in comments and log messages.

Do sctp_connectx() handling using ioctl() for IPv6 as well.

Mostly merge changes from HEAD upto 20200411

Split out the prototypes for add/delete address into a separate header file.

Sync with HEAD

RIP6, CAN, SCTP and SCTP6 lack a length check in their _send() functions.
Fix RIP6 and CAN, add a big XXX in the SCTP ones.

Found by KASAN, triggered by SyzKaller.

Reported-by: syzbot+0b9692ae0f49f93b7dc7@syzkaller.appspotmail.com

RIP, RIP6, DDP, SCTP and SCTP6 lack a length check in their _connect()
functions. Fix the first three, and add a big XXX in the SCTP ones.

Found by KASAN, triggered by SyzKaller.

Reported-by: syzbot+9eaf98dad6ca738c250d@syzkaller.appspotmail.com

This really was a missing break.

Spotted by Rin Okuyama.

Add some fallthrough annotations.

Pull up following revision(s) (requested by martin in ticket #1175):
sys/net/link_proto.c				1.37
sys/netatalk/ddp_usrreq.c			1.72
sys/netbt/hci_socket.c				1.46
sys/netbt/l2cap_socket.c			1.36
sys/netbt/rfcomm_socket.c			1.38
sys/netbt/sco_socket.c				1.38
sys/netinet/sctp_usrreq.c			1.14
sys/netinet/tcp_usrreq.c			1.223
sys/netinet6/raw_ip6.c				1.173
sys/netinet6/sctp6_usrreq.c			1.17
sys/netinet6/udp6_usrreq.c			1.146
sys/netmpls/mpls_proto.c			1.32
sys/netnatm/natm.c				patch

	Fix memory leaks pointed out by Ilja Van Sprundel: all
	sendoob() functions are expted to free both passed
	mbuf chains.

Fix memory leaks pointed out by Ilja Van Sprundel: all
sendoob() functions are expted to free both passed
mbuf chains.

Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int.  The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER!  Some subsystems have

	#define min(a, b)	((a) < (b) ? (a) : (b))
	#define max(a, b)	((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX.  Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate.  But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all.  (Who knows, maybe in some cases integer
truncation is actually intended!)

Enable SCTP sysctl nodes.

Rename auto asconf one to match FreeBSD.

Change implementation of sctp_connectx() to use ioctl(2).

Synch with HEAD

Remove now unused net_osdep.h includes, the other BSDs did the same.

Improve compliance to RFC 6458.

update from HEAD

file sctp_usrreq.c was added on branch tls-maxphys on 2017-12-03 11:39:04 +0000

Make SCTP work when IPSEC is also defined.

Set SPL level to match usage for TCP.

Sync with HEAD

Switch the address list of intefaces to pslist(9)

As usual, we leave the old list to avoid breaking kvm(3) users.

Sync with HEAD

Protect ifnet list with psz and psref

The change ensures that ifnet objects in the ifnet list aren't freed during
list iterations by using pserialize(9) and psref(9).

Note that the change adds a pslist(9) for ifnet but doesn't remove the
original ifnet list (ifnet_list) to avoid breaking kvm(3) users. We
shouldn't use the original list in the kernel anymore.

Fix build when IPSEC enabled.

Sync with HEAD

Replace generic queue macros with IFNET/IFADDR macros.

Sync with HEAD (as of 26th Dec)

file sctp_usrreq.c was added on branch nick-nhusb on 2015-12-27 12:10:07 +0000

PR/50529: David Binderman: Remove double sizeof

Add core networking support for SCTP.