CVS log for src/sys/netinet/sctp_output.c

Up to [cvs.NetBSD.org] / src / sys / netinet

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Pull up following revision(s) (requested by rin in ticket #863):

	sys/netinet/sctp_output.c: revision 1.34

handle EHOSTDOWN the same way as EHOSTUNREACH in sctp_med_chunk_output().

Compile-tested only (I don't have a sctp setup); proposed in
http://mail-index.netbsd.org/tech-net/2023/09/11/msg008611.html

LGTM from Greg Troxel and Robert Swindells

fix a/an grammar in obvious cases

sys: Drop redundant NULL check before m_freem(9)

m_freem(9) safely has accepted NULL argument at least since 4.2BSD:
https://www.tuhs.org/cgi-bin/utree.pl?file=4.2BSD/usr/src/sys/sys/uipc_mbuf.c

Compile-tested on amd64/ALL.

Suggested by knakahara@

fix spelling mistakes, mainly in comments and log messages.

handle EHOSTDOWN the same way as EHOSTUNREACH in sctp_med_chunk_output().
Compile-tested only (I don't have a sctp setup); proposed in
http://mail-index.netbsd.org/tech-net/2023/09/11/msg008611.html
LGTM from Greg Troxel and Robert Swindells

inpcb: rename functions to in6pcb_*

Adjust dccp and sctp for struct inpcb separation

fix various typos in comments, documentation and messages.

fix various typos, mainly in comments.

fix various typos, mainly in comments, but also log messages, docs, game text.

s/futher/further/ in comment.

s/measurment/measurement/ in comment.

fix various typos, mainly in comments, but also in man pages and log messages.

s/aquire/acquire/ in comments, also one typo fix acqure->acquire.

fix typos in comments, mainly s/extention/extension/ and s/sufficent/sufficient/

Sync with HEAD.

Fix all remaining typos, mainly in comments but also in few definitions and log messages, reported by me in PR kern/54889.
Also fixed some additional typos in comments, found on review of same files or typos.

SCTP: Use ifp->if_mtu rather than ND_IFINFO(ifp)->linkmtu

Mostly merge changes from HEAD upto 20200411

Merge changes from current as of 20200406

 Fix typo in comment.

 s/upate/update/ in comment.

Get rid of unnecessary NULL checks for rt_ifa and ifa_ifp

They are always non-NULL nowadays.

Sync with HEAD

Sync with HEAD, resolve a few conflicts

Replace M_ALIGN and MH_ALIGN by m_align.

Ssync with HEAD

interrupt has two 'r's

fix another typo while I'm here (flsah)

Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int.  The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER!  Some subsystems have

	#define min(a, b)	((a) < (b) ? (a) : (b))
	#define max(a, b)	((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX.  Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate.  But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all.  (Who knows, maybe in some cases integer
truncation is actually intended!)

Sync with HEAD

Remove m_copy completely.

Synch with HEAD

Remove now unused net_osdep.h includes, the other BSDs did the same.

Sync with HEAD.  77 conflicts resolved - all of them $NetBSD$

correct typo: and and -> and (comments only)

heads up on this being a common typo from chris28.

Improve compliance to RFC 6458.

update from HEAD

Sync with HEAD

file sctp_output.c was added on branch tls-maxphys on 2017-12-03 11:39:04 +0000

Use host byte order for a debug message.

Sync with HEAD

Sync with HEAD

Pass inpcb/in6pcb instead of socket to ip_output/ip6_output

- Passing a socket to Layer 3 is layer violation and even unnecessary
- The change makes codes of callers and IPsec a bit simple

Sync with HEAD

Sync with HEAD.  (Note that most of these changes are simply $NetBSD$
tag issues.)

Remove extraneous parentheses. no functional change

Appeases clang

Add rtcache_unref to release points of rtentry stemming from rtcache

In the MP-safe world, a rtentry stemming from a rtcache can be freed at any
points. So we need to protect rtentries somehow say by reference couting or
passive references. Regardless of the method, we need to call some release
function of a rtentry after using it.

The change adds a new function rtcache_unref to release a rtentry. At this
point, this function does nothing because for now we don't add a reference
to a rtentry when we get one from a rtcache. We will add something useful
in a further commit.

This change is a part of changes for MP-safe routing table. It is separated
to avoid one big change that makes difficult to debug by bisecting.

Sync with HEAD

Switch the address list of intefaces to pslist(9)

As usual, we leave the old list to avoid breaking kvm(3) users.

Avoid storing a pointer of an interface in a mbuf

Having a pointer of an interface in a mbuf isn't safe if we remove big
kernel locks; an interface object (ifnet) can be destroyed anytime in any
packet processing and accessing such object via a pointer is racy. Instead
we have to get an object from the interface collection (ifindex2ifnet) via
an interface index (if_index) that is stored to a mbuf instead of an
pointer.

The change provides two APIs: m_{get,put}_rcvif_psref that use psref(9)
for sleep-able critical sections and m_{get,put}_rcvif that use
pserialize(9) for other critical sections. The change also adds another
API called m_get_rcvif_NOMPSAFE, that is NOT MP-safe and for transition
moratorium, i.e., it is intended to be used for places where are not
planned to be MP-ified soon.

The change adds some overhead due to psref to performance sensitive paths,
however the overhead is not serious, 2% down at worst.

Proposed on tech-kern and tech-net.

Introduce m_set_rcvif and m_reset_rcvif

The API is used to set (or reset) a received interface of a mbuf.
They are counterpart of m_get_rcvif, which will come in another
commit, hide internal of rcvif operation, and reduce the diff of
the upcoming change.

No functional change.

Sync with HEAD

Protect ifnet list with psz and psref

The change ensures that ifnet objects in the ifnet list aren't freed during
list iterations by using pserialize(9) and psref(9).

Note that the change adds a pslist(9) for ifnet but doesn't remove the
original ifnet list (ifnet_list) to avoid breaking kvm(3) users. We
shouldn't use the original list in the kernel anymore.

Fix build when IPSEC enabled.

Sync with HEAD

Replace generic queue macros with IFNET/IFADDR macros.

Sync with HEAD (as of 26th Dec)

file sctp_output.c was added on branch nick-nhusb on 2015-12-27 12:10:07 +0000

Add core networking support for SCTP.