CVS log for src/sys/net/npf/lpm.c

Up to [cvs.NetBSD.org] / src / sys / net / npf

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Mostly merge changes from HEAD upto 20200411

Avoid LOCKDEBUG pserialize panic by implementing suggestion #1 from

    http://mail-index.netbsd.org/current-users/2019/02/24/msg035220.html:

Convert the mutex to spin-lock at IPL_NET (but it is excessive) and
convert the memory allocations in that code path to KM_NOSLEEP.

Sync with HEAD

Ssync with HEAD

NPF: Major rework -- migrate NPF to the libnv library.
- This conversion significantly simplifies the code and moves NPF to
  a binary serialisation format (replacing the XML-like format).
- Fix some memory/reference leaks and possibly use-after-free bugs.
- Bump NPF_VERSION as this change makes libnpf incompatible with the
  previous versions.  Also, different serialisation format means NPF
  connection/config saving and loading is not compatible with the
  previous versions either.

Thanks to christos@ for extra testing.

update from HEAD

Sync with HEAD

file lpm.c was added on branch tls-maxphys on 2017-12-03 11:39:03 +0000

remove checks for failure after memory allocation calls that cannot fail:

  kmem_alloc() with KM_SLEEP
  kmem_zalloc() with KM_SLEEP
  percpu_alloc()
  pserialize_create()
  psref_class_create()

all of these paths include an assertion that the allocation has not failed,
so callers should not assert that again.

Sync with HEAD

Sync with netbsd-5

Sync with HEAD.  (Note that most of these changes are simply $NetBSD$
tag issues.)

Pull up following revision(s) (requested by rmind in ticket #1340):
	sys/net/npf/lpm.c: revision 1.3
Fix kmem_free() in hashmap_remove().

file lpm.c was added on branch nick-nhusb on 2017-02-05 13:40:58 +0000

file lpm.c was added on branch netbsd-7-nhusb on 2017-01-18 08:46:46 +0000

file lpm.c was added on branch pgoyette-localcount on 2017-01-07 08:56:50 +0000

Fix kmem_free() in hashmap_remove().

Pull up following revision(s) (requested by rmind in ticket #1339):
	sys/net/npf/lpm.c: revision 1.2
Fix kmem_free() sizes in hashmap_rehash() and lpm_clear().

Fix kmem_free() sizes in hashmap_rehash() and lpm_clear().

Pull up following revision(s) (requested by rmind in ticket #1319):
	sys/modules/npf/Makefile: revision 1.19
	sys/net/npf/files.npf: revision 1.18
	sys/net/npf/lpm.c: revision 1.1
	sys/net/npf/lpm.h: revision 1.1
	sys/net/npf/npf_impl.h: revision 1.62
	sys/net/npf/npf_tableset.c: revision 1.24
	sys/net/npf/npf_tableset_ptree.c: file removal
	sys/rump/net/lib/libnpf/Makefile: revision 1.18
This patches ditches the ptree(3) library, because it is broken (you
can get missing entries!).  Instead, as a temporary solution, we switch
to a simple linear scan of the hash tables for the longest-prefix-match
(lpm.c lpm.h) algorithm. In fact, with few unique prefixes in the set,
on modern hardware this simple algorithm is pretty fast anyway!
--
ditch ptree and use lpm
--
remove ptree add lpm

file lpm.c was added on branch netbsd-7 on 2016-12-18 07:40:50 +0000

This patches ditches the ptree(3) library, because it is broken (you
can get missing entries!).  Instead, as a temporary solution, we switch
to a simple linear scan of the hash tables for the longest-prefix-match
(lpm.c lpm.h) algorithm. In fact, with few unique prefixes in the set,
on modern hardware this simple algorithm is pretty fast anyway!