CVS log for src/sys/net/if_ppp.c

Up to [cvs.NetBSD.org] / src / sys / net

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

sys: Drop redundant NULL check before m_freem(9)

m_freem(9) safely has accepted NULL argument at least since 4.2BSD:
https://www.tuhs.org/cgi-bin/utree.pl?file=4.2BSD/usr/src/sys/sys/uipc_mbuf.c

Compile-tested on amd64/ALL.

Suggested by knakahara@

IFQ_CLASSIFY() -> ifq_classify_packet().

Rename ifq_enqueue() -> if_enqueue(), ifq_enqueue2() -> if_enqueue2().

Garbage-collect the remaining vestiges of netisr.

Ensure that all queues passed to ifq_enqueue2() have a valid ifq_lock.

Consistently use IFQ_SET_MAXLEN(), rather than open-coding it.  NFC.

net/if_ppp.c: Avoid user-controlled overrun in PPPIOCSCOMPRESS.

Reported-by: syzbot+2c7bda7dc2b6c0d4f279@syzkaller.appspotmail.com

net/if_ppp.c: Sprinkle KNF.  No functional change intended.

Mostly merge changes from HEAD upto 20200411

Merge changes from current as of 20200406

Sync with head.

Adopt <net/if_stats.h>.

dedup

 Simplify "LIST_HEAD();" to make the code more understandable.
No functional change.

Sync with HEAD

Sync with HEAD

Add __cacheline_aligned to ppp softc list and its mutex just in case.

Synch with HEAD

Pull up following revision(s) (requested by knakahara in ticket #1162):

	sys/net/if_ppp.c: revision 1.162
	sys/net/if_ppp.c: revision 1.163

Fix missing mutex_exit in ppp_create().

Fix missing splx in ppp_inproc().

Fix missing splx in ppp_inproc().

Fix missing mutex_exit in ppp_create().

Sync with HEAD

Pull up following revision(s) (requested by msaitoh in ticket #938):
	sys/arch/acorn32/podulebus/if_ie.c: revision 1.41
	sys/arch/amiga/dev/if_es.c: revision 1.58
	sys/arch/amiga/dev/if_qn.c: revision 1.45
	sys/arch/arm/at91/at91emac.c: revision 1.20
	sys/arch/arm/ep93xx/epe.c: revision 1.37
	sys/arch/emips/ebus/if_le_ebus.c: revision 1.14
	sys/arch/emips/ebus/if_le_ebus.c: revision 1.15
	sys/arch/mac68k/dev/if_mc.c: revision 1.46
	sys/arch/macppc/dev/am79c950.c: revision 1.39
	sys/arch/newsmips/apbus/if_sn.c: revision 1.40
	sys/arch/next68k/dev/mb8795.c: revision 1.59
	sys/arch/playstation2/dev/if_smap.c: revision 1.25
	sys/arch/playstation2/dev/if_smap.c: revision 1.26
	sys/arch/sun2/dev/if_ec.c: revision 1.28
	sys/arch/sun3/dev/if_ie.c: revision 1.63
	sys/arch/x68k/dev/if_ne_intio.c: revision 1.19
	sys/arch/xen/xen/if_xennet_xenbus.c: revision 1.75
	sys/arch/xen/xen/xennetback_xenbus.c: revision 1.63
	sys/dev/bi/if_ni.c: revision 1.45
	sys/dev/cadence/if_cemac.c: revision 1.12
	sys/dev/ic/am7990.c: revision 1.78
	sys/dev/ic/am79900.c: revision 1.27
	sys/dev/ic/an.c: revision 1.67
	sys/dev/ic/cs89x0.c: revision 1.40
	sys/dev/ic/dm9000.c: revision 1.13
	sys/dev/ic/dm9000.c: revision 1.14
	sys/dev/ic/dp8390.c: revision 1.88
	sys/dev/ic/elink3.c: revision 1.141
	sys/dev/ic/elinkxl.c: revision 1.122
	sys/dev/ic/hme.c: revision 1.98
	sys/dev/ic/i82586.c: revision 1.77
	sys/dev/ic/lance.c: revision 1.53
	sys/dev/ic/mb86950.c: revision 1.27
	sys/dev/ic/mb86960.c: revision 1.86
	sys/dev/ic/mtd803.c: revision 1.34
	sys/dev/ic/pdq_ifsubr.c: revision 1.59
	sys/dev/ic/rrunner.c: revision 1.86
	sys/dev/ic/seeq8005.c: revision 1.58
	sys/dev/ic/sgec.c: revision 1.47
	sys/dev/ic/smc90cx6.c: revision 1.72
	sys/dev/ic/smc91cxx.c: revision 1.96
	sys/dev/ic/tropic.c: revision 1.49
	sys/dev/ic/wi.c: revision 1.245
	sys/dev/isa/if_eg.c: revision 1.93
	sys/dev/isa/if_el.c: revision 1.95
	sys/dev/isa/if_iy.c: revision 1.101
	sys/dev/ofw/ofnet.c: revision 1.58
	sys/dev/pci/if_alc.c: revision 1.27
	sys/dev/pci/if_de.c: revision 1.152
	sys/dev/pci/if_fpa.c: revision 1.61
	sys/dev/pci/if_jme.c: revision 1.34
	sys/dev/pci/if_tl.c: revision 1.108
	sys/dev/pci/if_vte.c: revision 1.19
	sys/dev/pci/ixgbe/ixgbe.h: revision 1.50
	sys/dev/pcmcia/if_cnw.c: revision 1.62
	sys/dev/pcmcia/if_malo_pcmcia.c: revision 1.17
	sys/dev/pcmcia/if_ray.c: revision 1.89
	sys/dev/pcmcia/if_xi.c: revision 1.81
	sys/dev/pcmcia/mhzc.c: revision 1.51
	sys/dev/pcmcia/xirc.c: revision 1.34
	sys/dev/qbus/if_de.c: revision 1.33
	sys/dev/qbus/if_qe.c: revision 1.78
	sys/dev/qbus/if_qt.c: revision 1.22
	sys/dev/sbus/be.c: revision 1.87
	sys/dev/sbus/qe.c: revision 1.68
	sys/dev/scsipi/if_se.c: revision 1.96
	sys/dev/usb/if_atu.c: revision 1.59
	sys/net/if_l2tp.c: revision 1.28 via patch
	sys/net/if_ppp.c: revision 1.160
It's not required to include net/bpfdesc.h. Remove it.
--
Simplify like other drivers. NULL check of ifp->if_bpf is done in
bpf_mtap(), so it's not required to do it here.
--
Remove duplicated inclusion of net/bpf.h.
--
Remove duplicated inclusion of net/bpf.h.
--
Simplify bpf_mtap() call. No functional change.

 Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

 This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

Sync with HEAD

 Remove duplicated inclusion of net/bpf.h.

update from HEAD

Add one more not supported error

Sync with HEAD

Sync with HEAD

MFREE -> m_free

modularize some more drivers and merge the module glue

Destroy the mutex when detaching ppp.  Otherwise on a re-attach (ie,
module reload) we can end up with a panic "lock already initialized"

make strip and slip modular, and cosmetic for ppp.

Change the internal name of the module to match its external (file
system) name.  Otherwise "bad things" can happen, such as modload(8)
being able to load a second copy!

Modularize the ppp driver, and adjust dependencies of the compressor
modules.

For now, this is still included as a built-in module in GENERIC kernels.

Sync with HEAD

Introduce m_set_rcvif and m_reset_rcvif

The API is used to set (or reset) a received interface of a mbuf.
They are counterpart of m_get_rcvif, which will come in another
commit, hide internal of rcvif operation, and reduce the diff of
the upcoming change.

No functional change.

Sync with HEAD

Constify rtentry of if_output

We no longer need to change rtentry below if_output.

The change makes it clear where rtentries are changed (or not)
and helps forthcoming locking (os psrefing) rtentries.

Sync with HEAD

IFQ_ENQUEUE refactor (3/3) : eliminate pktattr argument from IFQ_ENQUEUE caller

Sync with HEAD

sprinkle _KERNEL_OPT

Honor pseudo attach decl generated by config(1).

Sync with HEAD

Introduce p2p_rtrequest() so that IFF_POINTOPOINT interfaces can work
with RTF_LOCAL.
Fixes PR kern/49829.

Rebase to HEAD as of a few days ago.

Rebase.

KNF. No functional change.

Cleanup ppp_inproc

- Remove unnecessary variable isr
- Use pktq instead of rv to switch between inet/inet6 and other protocols

ok msaitoh@ and rmind@

- Implement pktqueue interface for lockless IP input queue.
- Replace ipintrq and ip6intrq with the pktqueue mechanism.
- Eliminate kernel-lock from ipintr() and ip6intr().
- Some preparation work to push softnet_lock out of ipintr().

Discussed on tech-net.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

sync with head

ppp_inproc: handle non-IP protocols correctly (hi msaitoh); PR/48813.

 Save a NETISR_* value in a variable and call schednetisr() after enqueue
a packet for readability and future modification.

Add bpf_filter_ext() to use with BPF COP, restore bpf_filter() as it was
originally to preserve compatibility.  Similarly, add bpf_validate_ext()
which takes bpf_ctx_t.

bpf_filter: add a custom argument which can be passed to coprocessor routine.

Implement BPF_COP/BPF_COPX instructions in the misc category (BPF_MISC)
which add a capability to call external functions in a predetermined way.

It can be thought as a BPF "coprocessor" -- a generic mechanism to offload
more complex packet inspection operations.  There is no default coprocessor
and this functionality is not targeted to the /dev/bpf.  This is primarily
targeted to the kernel subsystems, therefore there is no way to set a custom
coprocessor at the userlevel.

Discussed on: tech-net@
OK: core@

resync with head

sync with (a bit old) head

Don't check mp for NULL twice.  From Michael W. Bomardieri <mb@il.net>
via tech-net@NetBSD.org.  Thanks!

Resync to 2012-11-19 00:00:00 UTC

Pull up following revision(s) (requested by christos in ticket #638):
	sys/net/if_ppp.c: revision 1.137
	sys/netinet6/ip6_flow.c: revision 1.20
	sys/net/if_fddisubr.c: revision 1.82
	sys/net/if_ethersubr.c: revision 1.192
	sys/netinet6/in6_var.h: revision 1.66
	sys/net/if_atmsubr.c: revision 1.50
PR/47058: Antti Kantee: If the ipv6 flow code modifies the mbuf, pass the
change up to the caller.

sync with head

PR/47058: Antti Kantee: If the ipv6 flow code modifies the mbuf, pass the
change up to the caller.

For these interfaces, the implementation of SIOCSIFDSTADDR is identical
to SIOCINITIFADDR, and SIOCSIFDSTADDR callers always fall back to
SIOCINITIFADDR, so just get rid of the SIOCSIFDSTADDR case.

Don't kauth-orize SIOCSIFMTU in pppsioctl() and stf_ioctl(), ifioctl()
has already done that for us.

Convert ppp_list_lock to mutex(9).

Sync with HEAD.

sync with head

Fix misplaced parenthesis.  From henning.petersen@t-online.de, thanks.

sync with head

Sync with HEAD (-D20101022).

sync with head

Update the rest of the kernel to conform to the module subsystem's new
locking protocol.

sync with head.

sync with head

Sync with HEAD.

Push the bpf_ops usage back into bpf.h. Push the common ifp->if_bpf
check into the inline functions as well the fourth argument for
bpf_attach.

sync with head

Redefine bpf linkage through an always present op vector, i.e.
#if NBPFILTER is no longer required in the client.  This change
doesn't yet add support for loading bpf as a module, since drivers
can register before bpf is attached.  However, callers of bpf can
now be modularized.

Dynamically loadable bpf could probably be done fairly easily with
coordination from the stub driver and the real driver by registering
attachments in the stub before the real driver is loaded and doing
a handoff.  ... and I'm not going to ponder the depths of unload
here.

Tested with i386/MONOLITHIC, modified MONOLITHIC without bpf and rump.

Sync with HEAD.

Commit is split, to avoid a "too many arguments" protocol error.

sync with head.

Sync with HEAD.

Remove a few KAUTH_GENERIC_ISSUSER in favor of more descriptive
alternatives.

Discussed on tech-kern:

	http://mail-index.netbsd.org/tech-kern/2009/04/11/msg004798.html

Input from ad@, christos@, dyoung@, tsutsui@.

Okay ad@.

Sync with HEAD.

ppp_get_compressor: take module_lock when trying to load a module.  PR/40428

Sync with HEAD.

Sync with HEAD.

kill MALLOC and FREE macros.

Update haad-dm branch to haad-dm-base2.

Fix handling of ppp compressor modules, from Andrew Doran's input.
 - ref count each compressor
 - allow {un,}registration of several modules at once
 - une RUN_ONCE to make sure the mutex is initialised, because
   unfortunately built-in (and bootloader-loaded) modules init functions
   are run before pseudo-devices attach (reported by Nick Hudson).

Rework the way PPP compmressors are handled and allow them to be
automatically loaded when needed.

*** Summary ***

When a link-layer address changes (e.g., ifconfig ex0 link
02:de:ad:be:ef:02 active), send a gratuitous ARP and/or a Neighbor
Advertisement to update the network-/link-layer address bindings
on our LAN peers.

Refuse a change of ethernet address to the address 00:00:00:00:00:00
or to any multicast/broadcast address.  (Thanks matt@.)

Reorder ifnet ioctl operations so that driver ioctls may inherit
the functions of their "class"---ether_ioctl(), fddi_ioctl(), et
cetera---and the class ioctls may inherit from the generic ioctl,
ifioctl_common(), but both driver- and class-ioctls may override
the generic behavior.  Make network drivers share more code.

Distinguish a "factory" link-layer address from others for the
purposes of both protecting that address from deletion and computing
EUI64.

Return consistent, appropriate error codes from network drivers.

Improve readability.  KNF.

*** Details ***

In if_attach(), always initialize the interface ioctl routine,
ifnet->if_ioctl, if the driver has not already initialized it.
Delete if_ioctl == NULL tests everywhere else, because it cannot
happen.

In the ioctl routines of network interfaces, inherit common ioctl
behaviors by calling either ifioctl_common() or whichever ioctl
routine is appropriate for the class of interface---e.g., ether_ioctl()
for ethernets.

Stop (ab)using SIOCSIFADDR and start to use SIOCINITIFADDR.  In
the user->kernel interface, SIOCSIFADDR's argument was an ifreq,
but on the protocol->ifnet interface, SIOCSIFADDR's argument was
an ifaddr.  That was confusing, and it would work against me as I
make it possible for a network interface to overload most ioctls.
On the protocol->ifnet interface, replace SIOCSIFADDR with
SIOCINITIFADDR.  In ifioctl(), return EPERM if userland tries to
invoke SIOCINITIFADDR.

In ifioctl(), give the interface the first shot at handling most
interface ioctls, and give the protocol the second shot, instead
of the other way around. Finally, let compatibility code (COMPAT_OSOCK)
take a shot.

Pull device initialization out of switch statements under
SIOCINITIFADDR.  For example, pull ..._init() out of any switch
statement that looks like this:

        switch (...->sa_family) {
        case ...:
                ..._init();
                ...
                break;
        ...
        default:
                ..._init();
                ...
                break;
        }

Rewrite many if-else clauses that handle all permutations of IFF_UP
and IFF_RUNNING to use a switch statement,

        switch (x & (IFF_UP|IFF_RUNNING)) {
        case 0:
                ...
                break;
        case IFF_RUNNING:
                ...
                break;
        case IFF_UP:
                ...
                break;
        case IFF_UP|IFF_RUNNING:
                ...
                break;
        }

unifdef lots of code containing #ifdef FreeBSD, #ifdef NetBSD, and
#ifdef SIOCSIFMTU, especially in fwip(4) and in ndis(4).

In ipw(4), remove an if_set_sadl() call that is out of place.

In nfe(4), reuse the jumbo MTU logic in ether_ioctl().

Let ethernets register a callback for setting h/w state such as
promiscuous mode and the multicast filter in accord with a change
in the if_flags: ether_set_ifflags_cb() registers a callback that
returns ENETRESET if the caller should reset the ethernet by calling
if_init(), 0 on success, != 0 on failure.  Pull common code from
ex(4), gem(4), nfe(4), sip(4), tlp(4), vge(4) into ether_ioctl(),
and register if_flags callbacks for those drivers.

Return ENOTTY instead of EINVAL for inappropriate ioctls.  In
zyd(4), use ENXIO instead of ENOTTY to indicate that the device is
not any longer attached.

Add to if_set_sadl() a boolean 'factory' argument that indicates
whether a link-layer address was assigned by the factory or some
other source.  In a comment, recommend using the factory address
for generating an EUI64, and update in6_get_hw_ifid() to prefer a
factory address to any other link-layer address.

Add a routing message, RTM_LLINFO_UPD, that tells protocols to
update the binding of network-layer addresses to link-layer addresses.
Implement this message in IPv4 and IPv6 by sending a gratuitous
ARP or a neighbor advertisement, respectively.  Generate RTM_LLINFO_UPD
messages on a change of an interface's link-layer address.

In ether_ioctl(), do not let SIOCALIFADDR set a link-layer address
that is broadcast/multicast or equal to 00:00:00:00:00:00.

Make ether_ioctl() call ifioctl_common() to handle ioctls that it
does not understand.

In gif(4), initialize if_softc and use it, instead of assuming that
the gif_softc and ifp overlap.

Let ifioctl_common() handle SIOCGIFADDR.

Sprinkle rtcache_invariants(), which checks on DIAGNOSTIC kernels
that certain invariants on a struct route are satisfied.

In agr(4), rewrite agr_ioctl_filter() to be a bit more explicit
about the ioctls that we do not allow on an agr(4) member interface.

bzero -> memset.  Delete unnecessary casts to void *.  Use
sockaddr_in_init() and sockaddr_in6_init().  Compare pointers with
NULL instead of "testing truth".  Replace some instances of (type
*)0 with NULL.  Change some K&R prototypes to ANSI C, and join
lines.

Sync with HEAD.

Sync w/ -current. 34 merge conflicts to follow.

Sync with head.

sync with head.

- add if_alloc (ours just mallocs), and if_initname and use them (from FreeBSD)
- kill memsets where M_ZERO can be used.

Sync with HEAD.

sync with head.

Merge the socket locking patch:

- Socket layer becomes MP safe.
- Unix protocols become MP safe.
- Allows protocol processing interrupts to safely block on locks.
- Fixes a number of race conditions.

With much feedback from matt@ and plunky@.

sync with HEAD

Sync with HEAD.

sync with head.

Start patching up the kernel so that a network driver always has
the opportunity to handle an ioctl before generic ifioctl handling
occurs.  This will ease extending the kernel and sharing of code
between drivers.

First steps:  Make the signature of ifioctl_common() match struct
ifinet->if_ioctl.  Convert SIOCSIFCAP and SIOCSIFMTU to the new
ifioctl() regime, throughout the kernel.

sync with head

sync with HEAD

Sync with HEAD

Start detangling lock.h from intr.h. This is likely to cause short term
breakage, but the mess of dependencies has been regularly breaking the
build recently anyhow.

sync with HEAD

sync with head.

Sync with HEAD.

Follow the merge of pmap.c on i386 and amd64 and move
pmap_init_tmp_pgtbl into arch/x86/x86/pmap.c. Modify the ACPI wakeup
code to restore CR4 before jumping back into kernel space as the large
page option might cover that.

Sync with HEAD.

Sync with head.

machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

sync with head.

Sync with head.

Use the softint API.

Sync with HEAD.

sync with head.

Sync with HEAD.

Use ifreq_setaddr(), ifreq_getaddr(), sockaddr_in_init(), and
sockaddr_copy().  Constify.  Compare pointers with NULL, not 0.
Don't "test truth" of pointers, but compare with NULL.

Sync with head.

Sync with head.

Generic soft interrupts are mandatory.

Sync with head.

Merge some of the less invasive changes from the vmlocking branch:

- kthread, callout, devsw API changes
- select()/poll() improvements
- miscellaneous MT safety improvements

Adapt to callout API change.

- Increase the number of thread priorities from 128 to 256. How the space
  is set up is to be revisited.
- Implement soft interrupts as kernel threads. A generic implementation
  is provided, with hooks for fast-path MD code that can run the interrupt
  threads over the top of other threads executing in the kernel.
- Split vnode::v_flag into three fields, depending on how the flag is
  locked (by the interlock, by the vnode lock, by the file system).
- Miscellaneous locking fixes and improvements.

Sync with HEAD.

Add IPv6 Fast Forward - the IPv4 counterpart:

If ip6_forward successfully forwards a packet, a cache, in this case a
ip6flow struct entry, will be created. ether_input and friends will
then be able to call ip6flow_fastforward with the packet which will then
be passed to if_output (unless an issue is found - in that case the packet
is passed back to ip6_input).

ok matt@ christos@ dyoung@ and joerg@

Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

- sync with head.
- move sched_changepri back to kern_synch.c as it doesn't know PPQ anymore.

sync with head.

KNF: de-__P, bzero -> memset, bcmp -> memcmp.  Remove extraneous
   parentheses in return statements.

Cosmetic: don't open-code TAILQ_FOREACH().

Cosmetic: change types of variables to avoid oodles of casts: in
   in6_src.c, avoid casts by changing several route_in6 pointers
   to struct route pointers.  Remove unnecessary casts to caddr_t
   elsewhere.

Pave the way for eliminating address family-specific route caches:
   soon, struct route will not embed a sockaddr, but it will hold
   a reference to an external sockaddr, instead.  We will set the
   destination sockaddr using rtcache_setdst().  (I created a stub
   for it, but it isn't used anywhere, yet.)  rtcache_free() will
   free the sockaddr.  I have extracted from rtcache_free() a helper
   subroutine, rtcache_clear().  rtcache_clear() will "forget" a
   cached route, but it will not forget the destination by releasing
   the sockaddr.  I use rtcache_clear() instead of rtcache_free()
   in rtcache_update(), because rtcache_update() is not supposed
   to forget the destination.

Constify:

   1 Introduce const accessor for route->ro_dst, rtcache_getdst().

   2 Constify the 'dst' argument to ifnet->if_output().  This
     led me to constify a lot of code called by output routines.

   3 Constify the sockaddr argument to protosw->pr_ctlinput.  This
     led me to constify a lot of code called by ctlinput routines.

   4 Introduce const macros for converting from a generic sockaddr
     to family-specific sockaddrs, e.g., sockaddr_in: satocsin6,
     satocsin, et cetera.

sync with head.

sync with head.

Sync with head.

__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER uses.

sync with head

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

sync with head

sync with head

Use the LWP cached credentials where sane.

sync with head.

sync with head.

Sync with head.

merge FreeBSD timecounters from branch simonb-timecounters
- struct timeval time is gone
  time.tv_sec -> time_second
- struct timeval mono_time is gone
  mono_time.tv_sec -> time_uptime
- access to time via
	{get,}{micro,nano,bin}time()
	get* versions are fast but less precise
- support NTP nanokernel implementation (NTP API 4)
- further reading:
  Timecounter Paper: http://phk.freebsd.dk/pubs/timecounter.pdf
  NTP Nanokernel: http://www.eecis.udel.edu/~mills/ntp/html/kern.html

Sync with head.

Merge 2006-05-24 NetBSD-current into the "peter-altq" branch.

sync with head.

integrate kauth.

- Move kauth_cred_t declaration to <sys/types.h>
- Cleanup struct ucred; forward declarations that are unused.
- Don't include <sys/kauth.h> in any header, but include it in the c files
  that need it.

Approved by core.

generic_authorize() -> kauth_authorize_generic().

Adapt to kernel authorization KPI.

Adapt for timecounters: mostly use get*time(), use bintime's for timeout
calculations and use "time_second" instead of "time.tv_sec".

sync with head.

ppp_dequeue: fix a mbuf leak/packet loss introduced by rev.1.104.

PR/5901: Felix A. Croes: PPP fast queue blocks traffic at normal priority.
Applied fix, similar to the one suggested in the PR. We use a counter to
limit the number of consecutive packets accepted from the fast queue. This
number can be set via ioctl, but this has not been implemented. Since there
are only 2 queues other proposed solutions such as ALTQ are overkill and
they have not been implemented in the past 7 years. Now LCP echos can be
used to detect that the line is up.

ANSI function decls and application of static.

Sync with head.

sync with head.

Overhaul how TTY line disciplines are handled:
- Replace references to linesw[0] with a ttyldisc_default() function
  that returns the default ("termios") line discipline.
- The linesw[] array is gone, replaced by a linked list.
- ttyldisc_add() and ttyldisc_remove() have been replaced by
  ttyldisc_attach() and ttyldisc_detach().
- Things that provide line disciplines are now responsible for
  registering those disciplines with the system.  The linesw
  structures are no longer declared in tty_conf.c
- Line disciplines are now refcounted; a lookup causes a reference to
  be held.  ttyldisc_release() releases the reference.  Attempts to
  detach an in-use line discipline result in EBUSY.
- Fix function signature lossage in if_sl.c, if_strip.c, and tty_tb.c
  that was masked by the old tty_conf.c
- tty_init() is no longer necessary; delete it and its call from main().

Sync with HEAD. Here we go again...

- sprinkle const
- remove unneeded casts
- use more mem*() instead of b*() funcs.

Yes, it was a cool trick >20 years ago to use "0123456789abcdef"[a] to
implement, xtoa(), but I think defining the samestring 50 times is a bit
too much. Defined HEXDIGITS and hexdigits in subr_prf.c and use it...

sync with -current

Sync with HEAD.

no point in assigning to ifq twice.

Fix error with ifq not being set before use.  Explicitly set it to NULL just before it may be set to the fastq, since if this becomes a loop (and in one case already is) this will always work.  ifq_enqueue2() is designed to handle this case.

factor out the interface queueing code into two functions. One used by
the non point-to-point interfaces that has one queue, and one used by
the point to point interfaces that has two queues. No functional changes.
XXX: The ALTQ stuff makes the code ugly.
XXX: More cleanup to come

sync with head.  xen and whitespace.  xen part is not finished.

Sync with HEAD.

Hi Perry!

nuke trailing whitespace

Sync with HEAD.

pasto: simple_lock -> simple_unlock.

Don't forget to call bpfdetach in the clone destroy function.
While here, add a missing static and change some spaces to tabs.

Fix an obvious typo: scf -> sc.  Discovered while compiling for x68k.

void in arg prototype.

Make ppp a cloning device. Based on the work of Quentin Garnier.

Fix the sync with head I botched.

Sync with HEAD.

Sync with HEAD

I changed pppoutput to use M_PREPEND.  pppoutput was duplicating
the functionality of M_PREPEND, but with a bug: m_pkthdr.len was
not updated in pppoutput as it is in M_PREPEND.

Also, replace the loop that measures the length of the mbuf chain
with a call to m_length.

This fixes a PR from an anonymous bug reporter.  Thank you, anonymous
bug reporter.  Thanks, Itojun, for bringing the anonymous bug report
to my attention.

kill sprintf, use snprintf

Also, if we're going to bail, we should free the memory we just allocated...

Previous patch created a dead break.

Fix uninitialized variable warnings

Add a new ioctl PPPIOCGRAWIN to get the last characters we got from the
remote site.

KNF

PR/20844: Iain Hibbert: PPP Compressors cannot be loaded as LKM

Remove variable that is only assigned too but not referenced.

sync kqueue with -current; this includes merge of gehenna-devsw branch,
merge of i386 MP branch, and part of autoconf rototil work

backout previous two - if you use ppp* interface, kernel panics instantly.
it is apparent that the change was untested, and severety is high.

Remove unused variable so the file compiles again.

Keep m_pkthdr.len updated correctly and use it rather than a loop to find
out the total length of the packet.

sync kqueue branch with HEAD

Catch up to -current.

catch up with -current.

No longer need to pull in lwp.h; proc.h pulls it in for us.

new copyright boilerplate from CMU.  from openbsd

Curproc->curlwp renaming.

Change uses of "curproc->l_proc" back to "curproc", which is more like the
original use. Bare uses of "curproc" are now "curlwp".

"curproc" is now #defined in proc.h as ((curlwp) ? (curlwp)->l_proc) : NULL)
so that it is always safe to reference curproc (*de*referencing curproc
is another story, but that's always been true).

catch up with -current on kqueue branch

Catch up to -current.

Make ppp_softc[] extern and declare in if_ppp.c

Catch up to -current.
(CVS: It's not just a program. It's an adventure!)

Convert ioctl code to use EPASSTHROUGH instead of -1 or ENOTTY for
indicating an unhandled "command".  ERESTART is -1, which can lead to
confusion.  ERESTART has been moved to -3 and EPASSTHROUGH has been
placed at -4.  No ioctl code should now return -1 anywhere.  The
ioctl() system call is now properly restartable.

Catch up with -current.

bring in latest ALTQ from kjc.  ALTQify some of the drivers.

Catch up to -current.

Sync w/ -current.

Include <machine/intr.h> unconditionally, instead of only doing so if
__HAVE_GENERIC_SOFT_INTERRUPTS and relying on <sys/param.h> to provide it
otherwise; pointed out by Aymeric Vincent.

Sync kqueue branch with -current.

Catch up to -current.

remove unnecessary #if NFOO > 0    .... #endif  wrappers

add RCSIDs

Merge Aug 24 -current into the kqueue branch.

Catch up with -current.

Pullup [jdolecek]:

sys/arch/amiga/dev/grf_cl.c                     1.26
sys/arch/amiga/dev/grfioctl.h                   1.14
sys/arch/hpcmips/dev/plumvideo.c                1.20
sys/arch/macppc/dev/ofb.c                       1.25
sys/arch/sparc/dev/cgtwo.c                      1.35
sys/arch/sparc/include/fbio.h                   patch
sys/arch/sparc64/include/fbio.h                 patch
sys/arch/sun3/dev/cg2.c                         1.14
sys/arch/sun3/include/fbio.h                    patch
sys/dev/pci/tga.c                               1.35
sys/dev/tc/cfb.c                                1.28
sys/dev/tc/mfb.c                                1.27
sys/dev/tc/sfb.c                                1.46
sys/dev/tc/sfbplus.c                            1.10 via patch
sys/dev/tc/tfb.c                                1.30
sys/dev/tc/xcfb.c                               1.23
sys/net/if_ppp.c                                1.71

  Use unsigned variable types to make bounds checking more correct.

use unsigned variable types as appropriate

update to -current

bzero -> memset

Catch up to -current.

change the meaning of ifnet.if_lastchange to meet RFC1573 ifLastChange.
follows BSD/OS practice and ucd-snmp code (FreeBSD does it for specific
interfaces only).

was: if_lastchange get updated on every packet transmission/receipt.
now: if_lastchange get updated when IFF_UP is changed.

Sync with HEAD

Remove the use of splimp() from the NetBSD kernel.  splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

Initial commit of scheduler activations and lightweight process support.

Sync with head (for UBC+NFS fixes, mostly).

Fix a rather annoying problem where the sockaddr_dl which holds
the link level name for the interface (ifp->if_sadl) is allocated
before ifp->if_addrlen is initialized, which could lead to allocating
too little space for the link level address.

Do this by splitting allocation of the link level name out of
if_attach() and into if_alloc_sadl(), which is normally called
by functions like ether_ifattach().  Network interfaces which
don't have a link-specific attach routine must call if_alloc_sadl()
themselves (example: gif).

Link level names are freed by if_free_sadl(), which can be called
from e.g. ether_ifdetach().  Drivers never need call if_free_sadl()
themselves as if_detach() will do it if it is not already done.

While here, add the ability to pass an AF_LINK address to
SIOCSIFADDR in ether_ioctl() (this is what caused me to notice
the problem that the above fixes).

For SLIP/STRIP/PPP, use generic soft interrupts, if available.

Sync with HEAD

Fill in if_dlt.

Add ALTQ support.

Sync with HEAD (for UBC fixes).

Adapt to bpfattach() changes, and further centralize the bpfattach()
and bpfdetach() calls into link-type subroutines where possible.

Sync with HEAD.

Update thorpej_scsipi to -current as of a month ago

Fix typo (thinko?), which didn't allow MRU to be set below the default
value (instead of the minimum value). Patch supplied by Stephen Degler
in PR #9945, and reviewed by Ignatios Souvatzis.

unique #include opt_inet.h

need opt_inet.h for #ifdef INET

enable VJC only with INET

Kill some more register declarations.

New callout mechanism with two major improvements over the old
timeout()/untimeout() API:
- Clients supply callout handle storage, thus eliminating problems of
  resource allocation.
- Insertion and removal of callouts is constant time, important as
  this facility is used quite a lot in the kernel.

The old timeout()/untimeout() API has been removed from the kernel.

Pull up to last week's -current.

bring in latest KAME (as of 19991130, KAME/NetBSD141) into kame branch
just for reference purposes.
This commit includes 1.4 -> 1.4.1 sync for kame branch.

The branch does not compile at all (due to the lack of ALTQ and some other
source code).  Please do not try to modify the branch, this is just for
referenre purposes.

synchronization to latest KAME will take place on HEAD branch soon.

Fix typo introduced in rev. 1.55.
It caused IP6 packets to be sent as AF_UNSPEC instead of AF_INET6.

Update from trunk.

remove reference to in6_systm.h (file itself will be removed afterwords)

Sync w/ -current.

IPv6 kernel code, based on KAME/NetBSD 1.4, SNAP kit 19990628.
(Sorry for a big commit, I can't separate this into several pieces...)
Pls check sys/netinet6/TODO and sys/netinet6/IMPLEMENTATION for details.

- sys/kern: do not assume single mbuf, accept chained mbuf on passing
  data from userland to kernel (or other way round).
- "midway" ATM card: ATM PVC pseudo device support, like those done in ALTQ
  package (ftp://ftp.csl.sony.co.jp/pub/kjc/).
- sys/netinet/tcp*: IPv4/v6 dual stack tcp support.
- sys/netinet/{ip6,icmp6}.h, sys/net/pfkeyv2.h: IETF document assumes those
  file to be there so we patch it up.
- sys/netinet: IPsec additions are here and there.
- sys/netinet6/*: most of IPv6 code sits here.
- sys/netkey: IPsec key management code
- dev/pci/pcidevs: regen

In my understanding no code here is subject to export control so it
should be safe.

KAME/NetBSD 1.4 SNAP kit, dated 19990628.

NOTE: this branch (kame) is used just for refernce.  this may not compile
due to multiple reasons.

Sync w/ -current.

Fix compilation problem caused by recent changes to filtering code.

Decouple inbound and outbound filters.  Now instead of using "active-filter"
and "pass-filter" and "inbound" and "outbound" qualifiers in the filter
expression, use new "active-filter-in", "active-filter-out", "pass-filter-in",
and "pass-filter-out" without these qualifiers.

This is necessary due to the horrible, awful way "inbound" and "outbound"
were specified for the filter programs when a packet was passed through them.
Basically, the "address" byte in the serial PPP header was overwritten with
a value to indicate the direction.  However, the "address" byte doesn't even
exist on PPP headers for all other PPP encaps!  So, this old method worked
only for serial encaps, and corrupted packets for all others (PPPoE, ATM, etc.)

* Start out with a data link type of DLT_NULL.  When we change an interface
to serial encap, change its data link type to DLT_PPP_SERIAL.
* Work around some serious bogosity in the filtering code which utterly
breaks proper functioning of BPF.  The PPP code and pppd(8) WILL be changed
to fix this.

Use M_LINK{0,1} for our own mbuf flags, rather than arbitrarily picking
2 bits.

The beginnings of interface detach support.  Still some bugs, but mostly
works for me.

This work was originally by Bill Studenmund, and cleaned up by me.

Revert IPX changes that I committed accidentally.

defopt

PR/5414: Ronald Khoo: tcpdump ppp does not respect inbound/outbound qualifiers.

Fix PR5898: ppp delays last packet.

Glue in fast forwarding.

Only run pppasyncstart (sc->sc_start) from the netisr handler.
This allows pppoutput to be called from splimp (e.g., when ipflow is
in use.) without requiring pppasyncstart to run at splimp.
This is believed to fix PR5624.

use #ifdef INET so this compiles again

defopt INET, NETATALK.

Merge changes from pppd-2.3.4; adds ppp-deflate-draft stuff and updates
zlib. Maybe we can merge our other copy of zlib with this one now and
avoid having two copies?

From Paul Mackerras: use sl_compress_setup, not sl_compress_init

Update to ppp-2.3b5

Made pppoutput() public again on behalf of Martin Husemann (PR 3455).
Apparently, the BISDN package uses this function.

Update to ppp-2.3b4; from Paul Mackerras

Merge in changes from The Trunk

Use splimp() to block interrupts, not splhigh().

From trunk:
Eliminate SS_PRIV; instead, pass down a proc pointer to the usrreq methods
that need it.
Fix numerous memory leaks and bogus return values.

backout previous kprintf change

- printf -> kprintf, sprintf -> ksprintf

no need for a local implementation of SIOCGIFMTU; delete it.

Pass a proc pointer down to the usrreq and pcbbind functions for PRU_ATTACH, PRU_BIND and
PRU_CONTROL.  The usrreq interface really needs to be split up, but this will have to wait.
Remove SS_PRIV completely.

Changed struct ifnet to have a pointer to the softc of the underlying
device and a printable "external name" (name + unit number), thus eliminating
if_name and if_unit.  Updated interface to (*if_watchdog)() and (*if_reset)()
to take a struct ifnet *, rather than a unit number.

Make inclusion of the PPP BSD-Compress and Deflate compressors
dependent on the PPP_BSDCOMP and PPP_DEFLATE kernel configuration
options, respectively.

Added packet filtering, support for "PPP Deflate" packet compression,
trivial multicast support, and support for xon/xoff output flow
control to the PPP subsystem.  Fixed several bugs, including making
the accumulation and resetting of statistics more consistent.  State
for the VJ compressor is now dynamically allocated.

Net prototypes

wrt. previous change: can't compute `ilen' that early; just do computation
separately when logging.
Notes: consider using mbuf pkthdr length field in PPP code.
       condider doing packet log after de-compression.

Init variable before use (PRs 1646 & 2042).

Remove old workaround for a bug.

Add some missing statistics.  From Thorsten Lockert.

splnet --> splsoftnet

Latest version of PPP stuff, with packet compression and other
improvements.  The PPP kernel code is now split into if_ppp.c,
containing generic PPP support, and ppp_tty.c, which specifically
supports PPP on async tty devices (as a line discipline).  This is
so that other devices can be supported without making them look
like ttys.

fixed sized types, where appropriate.  when casting pointers to
integers to do math on them, cast to long.  ioctl commands are
u_longs.

be more careful with types, also pull in headers where necessary.

from trunk

bug 367. paulus says the fix is right & critical.

update from trunk, to fix serious ppp lossage.

The ppp interface now retries the mbuf allocation when it receives
a character and it doesn't already have enough space allocated.
It still needs cluster mbufs to be able to decompress VJ-compressed
packets.  It drops packets if it can't allocate mbufs rather than
taking the interface down.

Due to popular revulsion, the ppp interface now drops packets if

If we can't get mbuf clusters, take the ppp interface down instead
of writing beyond the end of ordinary mbufs.

bug #319. fix from <alasdair@wildcat.demon.co.uk>

New RCS ID's, take two.  they're more aesthecially pleasant, and use 'NetBSD'

Some restructuring of the PPP packet input procedure to make it easier
to implement PPP over sync lines and PPP compression protocols.

some minor splx-type bug fixes from christos@deshaw.com.

check for escaped char before checking for escape char
so if peer escapes 0x5d we interpret it correctly

MIN -> min, MAX -> max

Update to 4.4-Lite networking code, with a few local changes.

Version from ppp-2.1 release;
this version has been restructured to make more of the code usable
with sync serial drivers

PPP_HEADER_LEN -> PPP_HDRLEN

include <machine/cpu.h> rather than <machine/mtpr.h> -- if the latter
exists at all, it's supposed to be included by <machine/cpu.h>

Canonicalize all #includes.

Canonicalize all #includes.

Removed test (CCOUNT(&sc->sc_ttyp->t_outq) == 0) for whether
to call pppstart or not: now we call pppstart for every packet,
which should aid recovery from lost transmitter interrupts.
Also a fix for 386BSD/FreeBSD which doesn't affect NetBSD.

Call pppstart() redundantly.

Nuke references to machine/mtpr.h.

Make all files using spl*() #include cpu.h.  Changes from trunk.

Fixed bug in if_ppp.c so that received IP packets are passed correctly to BPF.

Modified if_ppp.c and if_ppp.h to add priority queueing for "interactive"
traffic (done in a similar fashion to if_sl.c), and BPF support.

ppp from paul mackerras