Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. =================================================================== RCS file: /ftp/cvs/cvsroot/src/sys/kern/uipc_socket.c,v retrieving revision 1.29.4.2 retrieving revision 1.30 diff -u -p -r1.29.4.2 -r1.30 --- src/sys/kern/uipc_socket.c 1999/01/25 05:49:42 1.29.4.2 +++ src/sys/kern/uipc_socket.c 1998/01/05 09:12:29 1.30 @@ -1,4 +1,4 @@ -/* $NetBSD: uipc_socket.c,v 1.29.4.2 1999/01/25 05:49:42 cgd Exp $ */ +/* $NetBSD: uipc_socket.c,v 1.30 1998/01/05 09:12:29 thorpej Exp $ */ /* * Copyright (c) 1982, 1986, 1988, 1990, 1993 @@ -79,8 +79,6 @@ socreate(dom, aso, type, proto) return (EPROTOTYPE); MALLOC(so, struct socket *, sizeof(*so), M_SOCKET, M_WAIT); bzero((caddr_t)so, sizeof(*so)); - TAILQ_INIT(&so->so_q0); - TAILQ_INIT(&so->so_q); so->so_type = type; so->so_proto = prp; error = (*prp->pr_usrreq)(so, PRU_ATTACH, (struct mbuf *)0, @@ -129,7 +127,7 @@ solisten(so, backlog) splx(s); return (error); } - if (so->so_q.tqh_first == NULL) + if (so->so_q == 0) so->so_options |= SO_ACCEPTCONN; if (backlog < 0) backlog = 0; @@ -146,13 +144,9 @@ sofree(so) if (so->so_pcb || (so->so_state & SS_NOFDREF) == 0) return; if (so->so_head) { - /* - * We must not decommission a socket that's on the accept(2) - * queue. If we do, then accept(2) may hang after select(2) - * indicated that the listening socket was ready. - */ - if (!soqremque(so, 0)) - return; + if (!soqremque(so, 0) && !soqremque(so, 1)) + panic("sofree dq"); + so->so_head = 0; } sbrelease(&so->so_snd); sorflush(so); @@ -168,19 +162,14 @@ int soclose(so) register struct socket *so; { - struct socket *so2; int s = splsoftnet(); /* conservative */ int error = 0; if (so->so_options & SO_ACCEPTCONN) { - while ((so2 = so->so_q0.tqh_first) != 0) { - (void) soqremque(so2, 0); - (void) soabort(so2); - } - while ((so2 = so->so_q.tqh_first) != 0) { - (void) soqremque(so2, 1); - (void) soabort(so2); - } + while (so->so_q0) + (void) soabort(so->so_q0); + while (so->so_q) + (void) soabort(so->so_q); } if (so->so_pcb == 0) goto discard; @@ -243,11 +232,8 @@ soaccept(so, nam) if ((so->so_state & SS_NOFDREF) == 0) panic("soaccept: !NOFDREF"); so->so_state &= ~SS_NOFDREF; - if ((so->so_state & SS_ISDISCONNECTED) == 0) - error = (*so->so_proto->pr_usrreq)(so, PRU_ACCEPT, - (struct mbuf *)0, nam, (struct mbuf *)0, (struct proc *)0); - else - error = 0; + error = (*so->so_proto->pr_usrreq)(so, PRU_ACCEPT, (struct mbuf *)0, + nam, (struct mbuf *)0, (struct proc *)0); splx(s); return (error); }