Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. =================================================================== RCS file: /ftp/cvs/cvsroot/src/sys/kern/uipc_socket.c,v rcsdiff: /ftp/cvs/cvsroot/src/sys/kern/uipc_socket.c,v: warning: Unknown phrases like `commitid ...;' are present. retrieving revision 1.29.4.1 retrieving revision 1.41 diff -u -p -r1.29.4.1 -r1.41 --- src/sys/kern/uipc_socket.c 1998/01/30 19:24:12 1.29.4.1 +++ src/sys/kern/uipc_socket.c 1999/01/20 09:15:41 1.41 @@ -1,4 +1,4 @@ -/* $NetBSD: uipc_socket.c,v 1.29.4.1 1998/01/30 19:24:12 mellon Exp $ */ +/* $NetBSD: uipc_socket.c,v 1.41 1999/01/20 09:15:41 mycroft Exp $ */ /* * Copyright (c) 1982, 1986, 1988, 1990, 1993 @@ -32,9 +32,11 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * @(#)uipc_socket.c 8.3 (Berkeley) 4/15/94 + * @(#)uipc_socket.c 8.6 (Berkeley) 5/2/95 */ +#include "opt_compat_sunos.h" + #include #include #include @@ -48,6 +50,17 @@ #include #include #include +#include + +struct pool socket_pool; + +void +soinit() +{ + + pool_init(&socket_pool, sizeof(struct socket), 0, 0, 0, + "sockpl", 0, NULL, NULL, M_SOCKET); +} /* * Socket operation routines. @@ -68,6 +81,7 @@ socreate(dom, aso, type, proto) register struct protosw *prp; register struct socket *so; register int error; + int s; if (proto) prp = pffindproto(dom, proto, type); @@ -77,17 +91,21 @@ socreate(dom, aso, type, proto) return (EPROTONOSUPPORT); if (prp->pr_type != type) return (EPROTOTYPE); - MALLOC(so, struct socket *, sizeof(*so), M_SOCKET, M_WAIT); - bzero((caddr_t)so, sizeof(*so)); + s = splsoftnet(); + so = pool_get(&socket_pool, PR_WAITOK); + memset((caddr_t)so, 0, sizeof(*so)); TAILQ_INIT(&so->so_q0); TAILQ_INIT(&so->so_q); so->so_type = type; so->so_proto = prp; + so->so_send = sosend; + so->so_receive = soreceive; error = (*prp->pr_usrreq)(so, PRU_ATTACH, (struct mbuf *)0, (struct mbuf *)(long)proto, (struct mbuf *)0, p); if (error) { so->so_state |= SS_NOFDREF; sofree(so); + splx(s); return (error); } #ifdef COMPAT_SUNOS @@ -97,6 +115,7 @@ socreate(dom, aso, type, proto) so->so_options |= SO_BROADCAST; } #endif + splx(s); *aso = so; return (0); } @@ -143,16 +162,16 @@ sofree(so) register struct socket *so; { - if (so->so_pcb || (so->so_state & SS_NOFDREF) == 0) + /* + * We must not decommission a socket that's on the accept(2) queue. + * If we do, then accept(2) may hang even after select(2) indicated + * that the listening socket was ready. + */ + if (so->so_pcb || so->so_head || (so->so_state & SS_NOFDREF) == 0) return; - if (so->so_head) { - if (!soqremque(so, 0) && !soqremque(so, 1)) - panic("sofree dq"); - so->so_head = 0; - } sbrelease(&so->so_snd); sorflush(so); - FREE(so, M_SOCKET); + pool_put(&socket_pool, so); } /* @@ -164,14 +183,19 @@ int soclose(so) register struct socket *so; { + struct socket *so2; int s = splsoftnet(); /* conservative */ int error = 0; if (so->so_options & SO_ACCEPTCONN) { - while (so->so_q0.tqh_first) - (void) soabort(so->so_q0.tqh_first); - while (so->so_q.tqh_first) - (void) soabort(so->so_q.tqh_first); + while ((so2 = so->so_q0.tqh_first) != 0) { + so2->so_head = 0; + (void) soabort(so2); + } + while ((so2 = so->so_q.tqh_first) != 0) { + so2->so_head = 0; + (void) soabort(so2); + } } if (so->so_pcb == 0) goto discard; @@ -234,8 +258,11 @@ soaccept(so, nam) if ((so->so_state & SS_NOFDREF) == 0) panic("soaccept: !NOFDREF"); so->so_state &= ~SS_NOFDREF; - error = (*so->so_proto->pr_usrreq)(so, PRU_ACCEPT, (struct mbuf *)0, - nam, (struct mbuf *)0, (struct proc *)0); + if ((so->so_state & SS_ISDISCONNECTED) == 0) + error = (*so->so_proto->pr_usrreq)(so, PRU_ACCEPT, + (struct mbuf *)0, nam, (struct mbuf *)0, (struct proc *)0); + else + error = 0; splx(s); return (error); } @@ -461,6 +488,8 @@ nopages: } while (space > 0 && atomic); if (dontroute) so->so_options |= SO_DONTROUTE; + if (resid > 0) + so->so_state |= SS_MORETOCOME; s = splsoftnet(); /* XXX */ error = (*so->so_proto->pr_usrreq)(so, (flags & MSG_OOB) ? PRU_SENDOOB : PRU_SEND, @@ -468,6 +497,8 @@ nopages: splx(s); if (dontroute) so->so_options &= ~SO_DONTROUTE; + if (resid > 0) + so->so_state &= ~SS_MORETOCOME; clen = 0; control = 0; top = 0; @@ -807,15 +838,17 @@ release: int soshutdown(so, how) - register struct socket *so; - register int how; + struct socket *so; + int how; { - register struct protosw *pr = so->so_proto; + struct protosw *pr = so->so_proto; + + if (!(how == SHUT_RD || how == SHUT_WR || how == SHUT_RDWR)) + return (EINVAL); - how++; - if (how & FREAD) + if (how == SHUT_RD || how == SHUT_RDWR) sorflush(so); - if (how & FWRITE) + if (how == SHUT_WR || how == SHUT_RDWR) return (*pr->pr_usrreq)(so, PRU_SHUTDOWN, (struct mbuf *)0, (struct mbuf *)0, (struct mbuf *)0, (struct proc *)0); return (0); @@ -836,7 +869,7 @@ sorflush(so) socantrcvmore(so); sbunlock(sb); asb = *sb; - bzero((caddr_t)sb, sizeof (*sb)); + memset((caddr_t)sb, 0, sizeof(*sb)); splx(s); if (pr->pr_flags & PR_RIGHTS && pr->pr_domain->dom_dispose) (*pr->pr_domain->dom_dispose)(asb.sb_mb); @@ -861,7 +894,7 @@ sosetopt(so, level, optname, m0) switch (optname) { case SO_LINGER: - if (m == NULL || m->m_len != sizeof (struct linger)) { + if (m == NULL || m->m_len != sizeof(struct linger)) { error = EINVAL; goto bad; } @@ -877,7 +910,7 @@ sosetopt(so, level, optname, m0) case SO_REUSEPORT: case SO_OOBINLINE: case SO_TIMESTAMP: - if (m == NULL || m->m_len < sizeof (int)) { + if (m == NULL || m->m_len < sizeof(int)) { error = EINVAL; goto bad; } @@ -894,7 +927,7 @@ sosetopt(so, level, optname, m0) { int optval; - if (m == NULL || m->m_len < sizeof (int)) { + if (m == NULL || m->m_len < sizeof(int)) { error = EINVAL; goto bad; } @@ -945,7 +978,7 @@ sosetopt(so, level, optname, m0) struct timeval *tv; short val; - if (m == NULL || m->m_len < sizeof (*tv)) { + if (m == NULL || m->m_len < sizeof(*tv)) { error = EINVAL; goto bad; } @@ -1000,12 +1033,12 @@ sogetopt(so, level, optname, mp) return (ENOPROTOOPT); } else { m = m_get(M_WAIT, MT_SOOPTS); - m->m_len = sizeof (int); + m->m_len = sizeof(int); switch (optname) { case SO_LINGER: - m->m_len = sizeof (struct linger); + m->m_len = sizeof(struct linger); mtod(m, struct linger *)->l_onoff = so->so_options & SO_LINGER; mtod(m, struct linger *)->l_linger = so->so_linger;