The NetBSD Project

CVS log for src/sys/kern/uipc_mbufdebug.c

[BACK] Up to [cvs.NetBSD.org] / src / sys / kern

Request diff between arbitrary revisions


Default branch: MAIN
Current tag: MAIN


Revision 1.7 / (download) - annotate - [select for diffs], Thu Oct 18 05:44:19 2018 UTC (13 months ago) by msaitoh
Branch: MAIN
CVS Tags: phil-wifi-20191119, phil-wifi-20190609, pgoyette-compat-20190127, pgoyette-compat-20190118, pgoyette-compat-1226, pgoyette-compat-1126, pgoyette-compat-1020, netbsd-9-base, netbsd-9, isaki-audio2-base, isaki-audio2, HEAD
Branch point for: phil-wifi
Changes since 1.6: +12 -20 lines
Diff to previous 1.6 (colored)

 KNF. No functional change.

Revision 1.6 / (download) - annotate - [select for diffs], Fri Oct 12 05:49:38 2018 UTC (13 months, 1 week ago) by msaitoh
Branch: MAIN
Changes since 1.5: +123 -53 lines
Diff to previous 1.5 (colored)

- Print TCP options. Some of them are not decoded yet (e.g. SACK).
- Print IP checksum and TCP checksum.
- When a packet length is shorter than a required size of the protocol, print
  both sizes.
- Make m_examine_xxx() functions global.
- Use bool instead of boolean_t.
- s/TRUE/true/, s/FALSE/false/
- KNF

Revision 1.5 / (download) - annotate - [select for diffs], Thu Oct 11 11:17:07 2018 UTC (13 months, 1 week ago) by msaitoh
Branch: MAIN
Changes since 1.4: +3 -3 lines
Diff to previous 1.4 (colored)

Fix m_examine_ip6() to print IPv6 payload length (ip6_plen) correctly.

Revision 1.4 / (download) - annotate - [select for diffs], Wed Oct 10 10:54:30 2018 UTC (13 months, 1 week ago) by msaitoh
Branch: MAIN
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)

 Fix m_examine_tcp() to print TCP header length (th_off) correctly.

Revision 1.3 / (download) - annotate - [select for diffs], Mon Sep 3 16:29:35 2018 UTC (14 months, 2 weeks ago) by riastradh
Branch: MAIN
CVS Tags: pgoyette-compat-0930, pgoyette-compat-0906
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int.  The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER!  Some subsystems have

	#define min(a, b)	((a) < (b) ? (a) : (b))
	#define max(a, b)	((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX.  Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate.  But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all.  (Who knows, maybe in some cases integer
truncation is actually intended!)

Revision 1.2 / (download) - annotate - [select for diffs], Wed Jul 18 07:06:40 2018 UTC (16 months ago) by msaitoh
Branch: MAIN
CVS Tags: pgoyette-compat-0728
Branch point for: pgoyette-compat
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

- Fix compile error for kernel configuration file which has no any Ethernet
  device driver.
- Add missing default label.
- Fix NetBSD RCS Id.

Revision 1.1 / (download) - annotate - [select for diffs], Tue Jul 17 05:52:07 2018 UTC (16 months ago) by msaitoh
Branch: MAIN

 Add /d(dump) and /v(verbose) modifiers to DDB's "show mbuf" command. Mainly
written by Hiroki SUENAGA. Currently, /v supports Ethernet, PPP, PPPoE, ARP,
IPv4, ICMP, IPv6, ICMPv6, TCP and UDP.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>