CVS log for src/sys/dev/video.c

Up to [cvs.NetBSD.org] / src / sys / dev

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

video(9): Make softc argument mandatory for video_attach_mi.

No separate video_attach_mi_softc function any more.

video(4): Allow drivers to pass the softc explicitly.

This way one device driver can have multiple video0, video1, &c.,
interfaces attached, using independent state and a common parent.

fix various typos in comments and log messages.

s/fist/first/

Merge thorpej-cfargs2.

Adapt to CFARGS().

Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
  actually needed.
- Don't be explicit about what interface attribute is attaching if
  the device only has one.  (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
  situations, making is visibly easier to see when indirect config is
  in play, and allowing for future change in semantics.  (As of now,
  this is just a wrapper around config_match(), but that is an
  implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance.  This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

config_found_ia() -> config_found() w/ CFARG_IATTR.

Nix trailing whitespace.

Add some extra V4L ioctl() requests to latest V4L userland to work.

Import sys/videoio.h from OpenBSD, this is just the Linux headers
concatenated together.

Support VIDIOC_G_PARM/VIDIOC_S_PARM

Merge changes from current as of 20200406

s/transfered/transferred/

Sync with HEAD

Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int.  The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER!  Some subsystems have

	#define min(a, b)	((a) < (b) ? (a) : (b))
	#define max(a, b)	((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX.  Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate.  But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all.  (Who knows, maybe in some cases integer
truncation is actually intended!)

update from HEAD

Kill some more extern cfdriver xyz_cd in favour of #include "ioconf.h".

Sync with HEAD

remove checks for failure after memory allocation calls that cannot fail:

  kmem_alloc() with KM_SLEEP
  kmem_zalloc() with KM_SLEEP
  percpu_alloc()
  pserialize_create()
  psref_class_create()

all of these paths include an assertion that the allocation has not failed,
so callers should not assert that again.

Restore all work from the former pgoyette-localcount branch (which is
now abandoned doe to cvs merge botch).

The branch now builds, and installs via anita.  There are still some
problems (cgd is non-functional and all atf tests time-out) but they
will get resolved soon.

Typo

Sync with HEAD

Rebase to HEAD as of a few days ago.

Rebase.

Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

sync with head

Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.

- remove unused variables
- moved debugging variable into debugging ifdef

resync with head

sync with head

Allow USB memory allocation by multiple segments in scatter/gather lists
rather than in a single contiguous block which causes problems with
large USB video frames.
Based on a patch by Jeremy Morse in the thread
http://mail-index.netbsd.org/current-users/2011/01/26/msg015532.html
Tested by developing http://code.opencv.org/issues/2360
OK jmcneill@

sync with head

merge to -current.

fill in timestamps in outgoing data buffers

Restore binary compatibility with NetBSD 5 binaries that utilize video(4).

sync with head

don't try to set frequencies lower or higher than the tuner's allowed
range -- the v4l2 spec says "when the requested frequency is not possible
the driver assumes the closest possible value".

VIDIOC_QUERYCAP changes:
 - use driver name instead of device instance name in 'driver' field
 - add 'get_businfo' callback to fill in 'bus_info' field instead of
   hard-coding "USB"
 - use the kernel version for the 'version' field instead of 1
 - adapt pseye and uvideo drivers to changes in struct video_hw_if

video(4) changes to support analog tv capture devices:
 - support interlacing with VIDIOC_G_FMT
 - set V4L2_CAP_TUNER if driver implements the set_tuner/get_tuner
   callbacks
 - set V4L2_CAP_AUDIO if driver implements the set_audio/get_audio/enum_audio
   callbacks
 - add support for the following ioctls: VIDIOC_ENUMSTD, VIDIOC_G_STD,
   VIDIOC_S_STD, VIDIOC_ENUMINPUT, VIDIOC_G_INPUT, VIDIOC_S_INPUT,
   VIDIOC_ENUMAUDIO, VIDIOC_G_AUDIO, VIDIOC_S_AUDIO, VIDIOC_G_TUNER,
   VIDIOC_S_TUNER, VIDIOC_G_FREQUENCY, VIDIOC_S_FREQUENCY
 - in video_submit_payload(), fix support for signaling sample complete
   using frame numbers
 - new optional callbacks for drivers: enum_standard, get_standard,
   set_standard, enum_input, get_input, set_input, enum_audio, get_audio,
   set_audio, get_tuner, set_tuner, get_frequency, set_frequency

for drivers that don't provide enum_standard, get_standard, set_standard,
enum_input, get_input and set_input, the original stub implementations are
provided

sync with head

Simplify these device-activation hooks using the following semantic
patch.

XXX sc_dying must die.

@@
type device_t;

identifier act, midi_softc, midiactivate, sc, self;
@@

int
midiactivate(device_t self, enum devact act)
{
(
	struct midi_softc *sc = device_private(self);
|
-	struct midi_softc *sc;
+	struct midi_softc *sc = device_private(self);
...
-	sc = device_private(self);
)
...
	switch (act) {
-	case DVACT_ACTIVATE:
-		return (EOPNOTSUPP);
-
	case DVACT_DEACTIVATE:
(
	sc->dying
|
	sc->sc_dying
)
		=
(
	1
|
	true
)
		;
-		break;
+		return 0;
+	default:
+		return EOPNOTSUPP;
	}
-	return (0);
}

sync with head.

1. some of the video24linux structs are not as machine independent as their
   authors want them to be. For the buffer ioctls, define new ioctls with
   the 32 bit buffer sizes. For the format struct, define it as packed
   so it is the same on 32 and 64 bit. (I might need to version this)
2. the mmapped buffers need to be page aligned, otherwise mmap(2) does
   not work. Make it so.
All this makes my ricoh camera work with emul-linux and skype running on
amd64. Next is sound!

Sync with HEAD.

sync with head.

Fix amd64 build with VIDEO_DEBUG.

Sync with HEAD.

Commit is split, to avoid a "too many arguments" protocol error.

sync with head.

Sync with HEAD.

Pull up following revision(s) (requested by jmcneill in ticket #576):
	sys/dev/video.c: revision 1.20
PR# kern/41008: possible simple mistake of field check in video(9)
video_set_format() requires hw->set_format to be set, not get_format,
from fukumoto@imasy.or.jp

file video.c was added on branch yamt-nfs-mp on 2009-05-04 08:12:33 +0000

PR# kern/41008: possible simple mistake of field check in video(9)

video_set_format() requires hw->set_format to be set, not get_format,
from fukumoto@imasy.or.jp

Sync with HEAD.

Pull up following revision(s) (requested by drochner in ticket #305):
	sys/dev/video.c: revision 1.19
-avoid eternal block if device is not streaming
-apply locking to avoid race in poll()
-fix an obviously wrong flag check

-avoid eternal block if device is not streaming
-apply locking to avoid race in poll()
-fix an obviously wrong flag check

Sync with HEAD.

Sync with HEAD.

Pull up following revision(s) (requested by jmorse in ticket #204):
	sys/dev/video.c: revision 1.18
	sys/dev/usb/uvideo.c: revision 1.24
Fix UVC webcam output by:
- Storing updated video format after user changes format
- Round up number of xfers queued to multiple of 8, due to ehci inefficiencies
- Remove random debugging line I slipped in earlier

Fix UVC webcam output by:
- Storing updated video format after user changes format
- Round up number of xfers queued to multiple of 8, due to ehci inefficiencies
- Remove random debugging line I slipped in earlier

Sync with HEAD.

Sync with HEAD.

Sync with HEAD.

file video.c was added on branch haad-dm on 2008-10-19 22:16:18 +0000

file video.c was added on branch mjf-devfs2 on 2008-09-28 10:40:18 +0000

Register with pmf

Add RGB555, RGB565, UYVY support

Sync with wrstuden-revivesa-base-2.

file video.c was added on branch wrstuden-revivesa on 2008-09-18 04:35:01 +0000

Use get_format instead of set_format in videoopen

Add VIDEO_FORMAT_YUV420 support

Allow VIDIOC_ENUM_FORMAT to return more than one result.

Revert previous double-free hack, needs revisiting.

Add RGB24 support, and prevent a double-free on videoclose

VIDIOC_QUERYCAP: device_xname on device_t, not softc

More pixelformat mapping typo fixes

Map VIDEO_FORMAT_MJPEG to V4L2_PIX_FMT_MJPEG, not V4L2_PIX_FMT_JPEG

Fix "select timeout" and low framerate issues with mplayer, from drochner@

Limit VIDEO_MAX_BUFS to 32 instead of 255

Missing aprint newline in video_attach

Actually, EINVAL is correct for an unimplemented ioctl. ENOTTY is only
needed for the VIDIOC_*_FMT ioctls.

Return ENOTTY instead of EINVAL if a driver doesn't implement one of the
set, try, get, or enum format ioctls.

Unbreak build when VIDEO_DEBUG is not defined.

Add MI video4linux2 layer, part of Patrick Mahoney's Google Summer
of Code 2008 project.