CVS log for src/sys/dev/pci/piixpm.c

Up to [cvs.NetBSD.org] / src / sys / dev / pci

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Pull up following revision(s) (requested by msaitoh in ticket #55):

	sys/dev/pci/piixpm.c: revision 1.68
	sys/dev/pci/piixpm.c: revision 1.69
	sys/dev/pci/piixpmreg.h: revision 1.13
	sys/dev/pci/piixpm.c: revision 1.70
	sys/dev/pci/piixpm.c: revision 1.71
	sys/dev/pci/piixpm.c: revision 1.72

Modify comment. Whitespace. No functional change.

Simplify and modify for following MMIO support. No functional change.
Modify for following MMIO support. No functional change.

Use MMIO for PM register access on newer revision's devices.
 Newer revision's device only support memory mapped access. At least,
X670E's SMBus device that the revision ID is 0x71 doesn't support I/O
access. Use MMIO access for newer devices. Linux uses >= 0x51 for the
check, so we do the same check. Note that X570's SMBus(rev. 0x61) supports
I/O access...

Modify error message to match the current behavior.

Pull up the following revisions, requested by msaitoh in ticket #1790:

	sys/dev/pci/piixpm.c				1.66,1.68-1.72 via patch
	sys/dev/pci/piixpmreg.h 			1.13

Add support new AMD chipsets that do not have indirect access
I/O ports.

Pull up the following revisions, requested by msaitoh in ticket #1573:

	sys/dev/pci/piixpm.c				1.66,1.68-1.72 via patch
	sys/dev/pci/piixpmreg.h 			1.13

Add support new AMD chipsets that do not have indirect access
I/O ports.

Modify error message to match the current behavior.

Use MMIO for PM register access on newer revision's devices.

 Newer revision's device only support memory mapped access. At least,
X670E's SMBus device that the revision ID is 0x71 doesn't support I/O
access. Use MMIO access for newer devices. Linux uses >= 0x51 for the
check, so we do the same check. Note that X570's SMBus(rev. 0x61) supports
I/O access...

Modify for following MMIO support. No functional change.

Simplify and modify for following MMIO support. No functional change.

Modify comment. Whitespace. No functional change.

Call iic_fini_tag() when the tag is no longer needed.

Without this, a LOCKDEBUG kernel can panic when trying to re-init the tag.

Apply patch, requested by msaitoh in ticket #1709:

	sys/dev/pci/piixpm.c					patch

Fix a bug that I2C access panics on old AMD chipset (e.g SB600).
Fixes PR kern/56525.

Apply patch, requested by msaitoh in ticket #1378:

	sys/dev/pci/piixpm.c				patch

Fix a bug that I2C access panics on old AMD chipset (e.g SB600).
Fixes PR kern/56525.

fix various typos, mainly in comments.

Merge thorpej-cfargs2.

Adapt to CFARGS().

Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
  actually needed.
- Don't be explicit about what interface attribute is attaching if
  the device only has one.  (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
  situations, making is visibly easier to see when indirect config is
  in play, and allowing for future change in semantics.  (As of now,
  this is just a wrapper around config_match(), but that is an
  implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance.  This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

Don't filter interface attributes in rescan functions for devices that
carry only a single interface attribute.  The autoconfiguration machinery
already considers interface attributes when searching for possible parents.

Pull up the following revisions, requested by msaitoh in ticket #1591:

	sys/dev/pci/piixpm.c				1.57-1.59,
							1.61-1.63 via patch
	sys/dev/pci/piixpmreg.h				1.9-1.12

- Fix number of port for Hudson rev. 0x1f and newer.
- Read SB800_SMB_HOSTC correctly. This register is not in the PCI
  config space but in the I/O space.
- The bit 0 of SB800_SMB_HOSTC is 0 on SMI or 1 on IRQ, so invert the
  check.
- Don't force using SMBUS0SEL register.
- Acquire/release host semaphore to share SMBus between the host and
  the embedded controller (IMC). Without this change, "shutdown -r"
  does power off and not boot on some machines.
- Save/restore port number before selecting port.
- Modify comment.
- Whitespace fix.

Pull up the following revisions, requested by msaitoh in ticket #1017:

	sys/dev/pci/piixpm.c			1.57-1.59, 1.61-1.63 via patch
	sys/dev/pci/piixpmreg.h			1.9-1.12

- Fix number of port for Hudson rev. 0x1f and newer.
- Read SB800_SMB_HOSTC correctly. This register is not in the PCI
  config space but in the I/O space.
- The bit 0 of SB800_SMB_HOSTC is 0 on SMI and 1 on IRQ, so invert the
  check.
- Don't force using SMBUS0SEL register.
- Acquire/release host semaphore to share SMBus between the host and
  the embedded controller (IMC). Without this change, "shutdown -r"
  does power off and not boot on some machines.
- Save/restore port number before selecting port.
- Modify comment.
- Whitespace fix.

Mostly merge changes from HEAD upto 20200411

Sync with head.

Save/restore port number before selecting port. Linux driver says it must
be required on some systems.

 Simplify. No functional change.

 Acquire/release host semaphore to share SMBus between the host and
the embedded controller (IMC).

 Without this change, "shutdown -r" does power off and not boot on ECS HDC-I2.
This change fixes the problem.

Make ichsmb and piixpm MP-safe:
- Synchronize with the interrupt handler using a mutex.
- Use a condvar to wait for completion, rather than tsleep().
- Mark our interrupt handler as such.

Also, other general correctness fixes:
- Loop around testing the completion condition to protect aginst
  spurious wakes.
- The "i2c exec" function returns an error code, so actually do so.

Don't force using SMBUS0SEL register.

- Use it depending on USE_SMBUS0SEL bit.
- If we use SMBUS0EN_LO register to select the port, update the port
  select bits only.

- Read SB800_SMB_HOSTC correctly. This register is not in the PCI config space
  but in the I/O space.
- The bit 0 of SB800_SMB_HOSTC is 0 on SMI or 1 on IRQ, so invert the check.
- Modify comment.
- Whitespace fix.

 Fix number of port for Hudson rev. 0x1f and newer. Same as OpenBSD and Linux.

piixpm_i2c_exec(): No need to check 'cold' to force I2C_F_POLL; the i2c
upper layer does it for us.

Cleanup i2c bus acquire / release, centralizing all of the logic into
iic_acquire_bus() / iic_release_bus().  "acquire" and "release" hooks
no longer need to be provided by back-end controller drivers (only if
they need special handling, e.g. powering on the i2c controller).
This results in the removal of a bunch of rendundant code from each
back-end controller driver.

Assert that we are not in hard interrupt context in iic_acquire_bus(),
iic_exec(), and iic_release_bus().

Pull up following revision(s) (requested by msaitoh in ticket #1327):

	sys/dev/pci/piixpmreg.h: revision 1.8
	sys/dev/pci/piixpm.c: revision 1.53
	sys/dev/pci/piixpm.c: revision 1.54

Sync with OpenBSD's piixpm.c up to rev. 1.35:
- Print "polling" correctly when in the attach function. Same as OpenBSD
 rev. 1.22-23.
- Improve debug printf()'s. Part of OpenBSD 1.24.
- Do not bus_space_map devices which are at address 0 (it's uninitialized).
  Same as OpenBSD rev. 1.25.
- Add ServerWorks HT1100 device from OpenBSD. Same as OpenBSD rev. 1.32
- Use unique wait channel. From OpenBSD rev. 1.35


Improve SB800 and newer chipsets support:
- Add newer chipset (e.g. X370/X399 and newer) support that the PCI device id
  is 0x790b. The register definitions are mainly taken from FreeBSD.
- Rename PIIXPM_INDIRECTIO_* to SB800_INDIRECTIO_* because those are only
  for SB800 and newer chipsets.
- SB800 also support 4 ports.
- SB800's interrupt configuration bit is different from others.
  Use SB800_SMB_HOSTC's bit 0.
- Do not bus_space_map devices which are at address 0 (it's uninitialized)
  in piixpm_attach().
- Add the port number to the dmesg output.
- Avoid uninitiliazed use of ctl and corresponding warnings. From OpenBSD rev.
  1.38

Improve SB800 and newer chipsets support:
- Add newer chipset (e.g. X370/X399 and newer) support that the PCI device id
  is 0x790b. The register definitions are mainly taken from FreeBSD.
- Rename PIIXPM_INDIRECTIO_* to SB800_INDIRECTIO_* because those are only
  for SB800 and newer chipsets.
- SB800 also support 4 ports.
- SB800's interrupt configuration bit is different from others.
  Use SB800_SMB_HOSTC's bit 0.
- Do not bus_space_map devices which are at address 0 (it's uninitialized)
  in piixpm_attach().
- Add the port number to the dmesg output.
- Avoid uninitiliazed use of ctl and corresponding warnings. From OpenBSD rev.
  1.38

Sync with OpenBSD's piixpm.c up to rev. 1.35:
- Print "polling" correctly when in the attach function. Same as OpenBSD
 rev. 1.22-23.
- Improve debug printf()'s. Part of OpenBSD 1.24.
- Do not bus_space_map devices which are at address 0 (it's uninitialized).
  Same as OpenBSD rev. 1.25.
- Add ServerWorks HT1100 device from OpenBSD. Same as OpenBSD rev. 1.32
- Use unique wait channel. From OpenBSD rev. 1.35

update from HEAD

Sync with HEAD

Resolve a couple of conflicts

Sync with HEAD

Sync with HEAD

 Fix 0x%d and 0x%u.

Sync with HEAD

Sync with HEAD

provide intr xname

Sync with HEAD

Sync with HEAD

Insert missing 'break;' statements.

CID 1364142

KNF. No functional change.

The piixpm(4) driver also supports AMD's HUDSON chipset's SMBus function.

From OpenBSD, verified.

Sync with HEAD (as of 26th Dec)

Initialize the mutex before calling xxx_rescan().  Otherwise if we
load/attach an i2cbus at a later time (ie, load the iic module),
we'll end-up re-initializing the mutex.

(Caught with a LOCKDEBUG kernel)

Sync with HEAD

Teach a couple of i2cbus controllers how to rescan.  This enables
{,un}loading and {at,de}taching of the iic(4) driver/module at a
later time. Tested piixpm on QEMU, and ichsmb on my live server.

Rebase to HEAD as of a few days ago.

Rebase.

Pull up following revision(s) (requested by hannken in ticket #1096):
	sys/dev/pci/piixpm.c: revision 1.45
Consistently pass a "struct piixpm_softc" to piixpm_intr.
Prevents a crash on hardware interrupts.

Consistently pass a "struct piixpm_softc" to piixpm_intr.
Prevents a crash on hardware interrupts.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

sync with head

make pci_intr_string and eisa_intr_string take a buffer and a length
instead of relying in local static storage.

Merge riastradh-drm2 to HEAD.

Pull up following revision(s) (requested by fair in ticket #936):
	sys/dev/pci/piixpmreg.h: revision 1.6
	sys/dev/pci/piixpm.c: revision 1.42
The SB800 SMBus controller has four selectable SDA lines.
Expose them as four iic busses.

sync with head

sync with HEAD

The SB800 SMBus controller has four selectable SDA lines.
Expose them as four iic busses.

Clear errors before beginning a transfer.

Closes PR port-i386/46792.

sync with head

merge to -current.

Replace the xxx_acquire()/xxx_release() rwlocks with mutexes.  There are
only RW_WRITERs for these, and no RW_READERs, so no need to incur the
extra overhead of allowing for both.  As discussed on tech-kern.

For piixpm and ichsmb, the acquire/release protocol needs to be used,
even if the request is I2C_F_POLL'd (or if the device supports only
polled mode).  Otherwise multiple requests can be running at the same
time, and they stomp on each other and create anomolous results.

Part 2 addresses my PR kern/45889

3 ACKs from releng

Use pci_aprint_devinfo(9) instead of pci_devinfo+aprint_{normal,naive}
where it looks straightforward, and pci_aprint_devinfo_fancy in a few
others where drivers want to supply their own device names instead
of the pcidevs generated one. More complicated cases, where names
are composed at runtime, are left alone for now. It certainly makes
sense to simplify the drivers here rather than inventing a catch-all API.
This should serve as as example for new drivers, and also ensure
consistent output in the AB_QUIET ("boot -q") case. Also, it avoids
excessive stack usage where drivers attach child devices because the
buffer for the device name is not kept on the local stack anymore.

Modify the attach message for consistency with most other pci devices.

avoid printing an empty line in the sb800 case

Newer ATI SB800 SMBus controllers don't report the base address in PCI
config space. According to the SB800-Series Southbridges Register Reference
Guide, we can still read this value from PM config space using indirect I/O.

Sync with HEAD.

sync with head

Sync with HEAD

The ServerWorks CSB5 smbus controller often times out and hangs until reboot.

Increase the delay between setting the command register and reading the
status register.  Reset the smbus controller if it has timed out.

Tested on an IBM eServer x335.

Make the SMbus Send/Receive functions work.

If cmdlen = 0 and len = 1 use the XXX_HC_CMD_BYTE protocol, send
data through XXX_SMB_HCMD or receive data from XXX_SMB_HD0.

Ok: Paul Goyette

Pull up following revision(s) (requested by martin in ticket #1391):
	sys/dev/pci/piixpm.c: revision 1.28
Fix dmesg output:
Old:
piixpm0 at pci0 dev 20 function 0
piixpm0: ATI Technologies SB600/SB700/SB800 SMBus Controller (rev. 0x13)
piixpm0: interrupting at SMIpiixpm0: polling
New:
piixpm0 at pci0 dev 20 function 0
piixpm0: ATI Technologies SB600/SB700/SB800 SMBus Controller (rev. 0x13)
piixpm0: interrupting at SMI, polling
Cosmetic change only, no functional changes intended.

Sync with HEAD.

sync with head.

Make PIIXPM_DEBUG work with 64-bit size_t.

Sync with HEAD.

sync with head

A pointer typedef entails trading too much flexibility to declare const
and non-const types, and the kernel uses both const and non-const
PMF qualifiers and device suspensors, so change the pmf_qual_t and
device_suspensor_t typedefs from "pointers to const" to non-pointer,
non-const types.

Expand PMF_FN_* macros.

Set iba_type properly.  The only thing that ever looks at this is the
'options I2C_SCAN' code in dev/i2c/i2c.c which is disabled by default.

Sync with HEAD.

Commit is split, to avoid a "too many arguments" protocol error.

sync with head.

Sync with HEAD.

bzero -> memset

Sync with HEAD.

Fix dmesg output:

Old:
piixpm0 at pci0 dev 20 function 0
piixpm0: ATI Technologies SB600/SB700/SB800 SMBus Controller (rev. 0x13)
piixpm0: interrupting at SMIpiixpm0: polling

New:
piixpm0 at pci0 dev 20 function 0
piixpm0: ATI Technologies SB600/SB700/SB800 SMBus Controller (rev. 0x13)
piixpm0: interrupting at SMI, polling

Cosmetic change only, no functional changes intended.

Update the i2c_exec() functions to handle quick_read/quick_write protocol.

Although interface routines i2c_smbus_*() exist, nothing in NetBSD actually
uses them yet.

Sync with HEAD.

Sync with HEAD.

Move printing of the "polling" message at attach time out of the wrong if
scope, so that it is actually printed even in non-error cases.
Suggested by jmcneill.

Sync with HEAD.

Sync with wrstuden-revivesa-base-2.

Sync with head.

- device/softc split
- reduce namespace pollution

Sync with HEAD.

use aprint_*_dev and device_xname

Sync with HEAD.

PR#38301: Add support for SMBus controllers for ATI SB600, SB700, SB800
chipsets, from Christoph Egger.

sync with head.

sync with HEAD

sync with head.

Fix console output.

Use PMF_FN_ARGS, PMF_FN_PROTO.

Sync with HEAD.

sync with head.

Remove an extra \n from an attach message.  Get's rid of a blank
line during boot.

sync with head

sync with HEAD

Sync with head.

Sync with HEAD

sync with head.

use __KERNEL_RCSID()

Merge jmcneill-pm branch.

Rename pnp(9) -> pmf(9), as requested by many.

sync with HEAD

Refactor PNP API:
- Make suspend/resume directly a device functionality. It consists of
  three layers (class logic, device logic, bus logic), all of them being
  optional. This replaces D0/D3 transitions.
- device_is_active returns true if the device was not disabled and was
  not suspended (even partially), device_is_enabled returns true if the
  device was enabled.
- Change pnp_global_transition into pnp_system_suspend and
  pnp_system_resume. Before running any suspend/resume handlers, check
  that all currently attached devices support power management and bail
  out otherwise. The latter is not done for the shutdown/panic case.
- Make the former bus-specific generic network handlers a class handler.
- Make PNP message like volume up/down/toogle PNP events. Each device
  can register what events they are interested in and whether the handler
  should be global or not.
- Introduce device_active API for devices to mark themselve in use from
  either the system or the device. Use this to implement the idle handling
  for audio and input devices. This is intended to replace most ad-hoc
  watchdogs as well.
- Fix somes situations in which audio resume would lose mixer settings.
- Make USB host controllers better deal with suspend in the light of
  shared interrupts.
- Flush filesystem cache on suspend.
- Flush disk caches on suspend. Put ATA disks into standby on suspend as
  well.
- Adopt drivers to use the new PNP API.
- Fix a critical bug in the generic cardbus layer that made D0->D3
  break.
- Fix ral(4) to set if_stop.
- Convert cbb(4) to the new PNP API.
- Apply the PCI Express SCI fix on resume again.

sync with head.

Sync with HEAD.

Follow the merge of pmap.c on i386 and amd64 and move
pmap_init_tmp_pgtbl into arch/x86/x86/pmap.c. Modify the ACPI wakeup
code to restore CR4 before jumping back into kernel space as the large
page option might cover that.

Sync with HEAD.

Sync with head.

machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

Sync with head.

Convert piixpm(4) to PNP power management.

Sync with HEAD.

sync with head.

Sync with HEAD.

Use rwlock(9) rather than lockmgr(9).

There's no need to add timecounter code inside of __HAVE_TIMECOUNTER
ifdefs.

Sync with HEAD.

Sync with HEAD.

Sync with HEAD.

Some serverworks mainboards use this power management too

file piixpm.c was added on branch matt-mips64 on 2007-08-06 22:41:23 +0000

Some serverworks mainboards use this power management too

Sync with HEAD.

Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

Sync with head.

sync with head.

sync with head.

Print pci device info instead of "Power Management Controller".

Sync with head.

__unused removal on arguments; approved by core.

Match ATI SB[34]00 smbus controllers.

sync with head

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

Add "name" parameter to powerhook_establish, to aid debugging. No objections
on tech-kern@

sync with head

sync with head.

file piixpm.c was added on branch rpaulo-netinet-merge-pcb on 2006-09-09 02:52:19 +0000

Fix all the -D*DEBUG* code that it was rotting away and did not even compile.
Mostly from Arnaud Lacombe, many thanks!

sync with head

Merge from HEAD.

use the "i2cbus" interface attribute rather than putting a string name
into the i2cbus attach args

-make sure it is a PIIX4 before accessing counter stuff
 (there might be usable registers on 440mx and that ATI thing too,
  but that needs to be checked/tested)
-make sure the I/O access to the power management stuff was enabled
 by the BIOS before trying to map/access stuff
-most PIIX4s have a bug in the timer latch which causes jitter or worse
 if it is read naively - check the revision
-use common code in dev/ic/acpipmtimer.c

sync with head.

Add timecounter support for Intel PIIX Power Management Controllers.

Ok kardel@.

sync with head.

Sync with head.

file piixpm.c was added on branch yamt-lazymbuf on 2006-06-21 15:05:06 +0000

Restore the device activity PCI configuration registers on resume.

Sync with head.

Merge 2006-05-24 NetBSD-current into the "peter-altq" branch.

sync with head.

sync with head

file piixpm.c was added on branch simonb-timecounters on 2006-06-01 22:36:49 +0000

file piixpm.c was added on branch peter-altq on 2006-05-24 15:50:28 +0000

file piixpm.c was added on branch yamt-pdpolicy on 2006-05-24 10:58:01 +0000

file piixpm.c was added on branch elad-kernelauth on 2006-05-11 23:28:48 +0000

Add __KERNEL_RCSID.

Add support for the Intel PIIX4 power management controller, from OpenBSD.