The NetBSD Project

CVS log for src/sys/dev/pci/if_iavf.c

[BACK] Up to [cvs.NetBSD.org] / src / sys / dev / pci

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.16 / (download) - annotate - [select for diffs], Fri Jun 17 06:18:09 2022 UTC (7 months, 3 weeks ago) by yamaguchi
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10, bouyer-sunxi-drm-base, bouyer-sunxi-drm, HEAD
Changes since 1.15: +8 -6 lines
Diff to previous 1.15 (colored)

ixl(4), iavf(4): fix endian bug in vlan tag

Revision 1.15 / (download) - annotate - [select for diffs], Sat Nov 6 22:11:39 2021 UTC (15 months ago) by andvar
Branch: MAIN
Changes since 1.14: +4 -4 lines
Diff to previous 1.14 (colored)

s/invlaid/invalid/

Revision 1.13.4.1 / (download) - annotate - [select for diffs], Thu Jun 17 04:46:29 2021 UTC (19 months, 3 weeks ago) by thorpej
Branch: thorpej-i2c-spi-conf
Changes since 1.13: +3 -7 lines
Diff to previous 1.13 (colored) next main 1.14 (colored)

Sync w/ HEAD.

Revision 1.14 / (download) - annotate - [select for diffs], Wed Jun 16 00:21:18 2021 UTC (19 months, 3 weeks ago) by riastradh
Branch: MAIN
CVS Tags: thorpej-i2c-spi-conf2-base, thorpej-i2c-spi-conf2, thorpej-i2c-spi-conf-base, thorpej-futex2-base, thorpej-futex2, thorpej-cfargs2-base, thorpej-cfargs2
Changes since 1.13: +3 -7 lines
Diff to previous 1.13 (colored)

if_attach and if_initialize cannot fail, don't test return value

These were originally made failable back in 2017 when if_initialize
allocated a softint in every interface for link state changes, so
that it could fail gracefully instead of panicking:

https://mail-index.NetBSD.org/source-changes/2017/10/23/msg089053.html

However, this spawned many seldom- or never-tested error branches,
which are risky to have around.  And that softint in every interface
has since been replaced by a single global workqueue, because link
state changes require thread context but not low latency or high
throughput:

https://mail-index.NetBSD.org/source-changes/2020/02/06/msg113759.html

So there is no longer any reason for if_initialize to fail.  (The
subroutine if_stats_init can't fail because percpu_alloc can't fail
either.)

There is a snag: the softint_establish in if_percpuq_create could
fail, potentially leading to bad consequences later on trying to use
the softint.  This change doesn't introduce any new bugs because of
the snag -- if_percpuq_attach was already broken.  However, the snag
can be better addressed without spawning error branches, either by
using a single softint or making softints less scarce.

(Separate commit will change the signatures of if_attach and
if_initialize to return void, scheduled to ride whatever is the next
convenient kernel bump.)

Patch and testing on amd64 and evbmips64-eb by maya@; commit message
soliloquy, and compile-testing on evbppc/i386/earmv7hf, by me.

Revision 1.6.2.2 / (download) - annotate - [select for diffs], Sat Apr 3 22:28:46 2021 UTC (22 months ago) by thorpej
Branch: thorpej-futex
Changes since 1.6.2.1: +4 -3 lines
Diff to previous 1.6.2.1 (colored) next main 1.7 (colored)

Sync with HEAD.

Revision 1.13 / (download) - annotate - [select for diffs], Fri Mar 5 13:21:07 2021 UTC (23 months ago) by yamaguchi
Branch: MAIN
CVS Tags: thorpej-futex-base, thorpej-cfargs-base, thorpej-cfargs, cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Branch point for: thorpej-i2c-spi-conf
Changes since 1.12: +3 -2 lines
Diff to previous 1.12 (colored)

Fix missing IFM_FDX

Revision 1.12 / (download) - annotate - [select for diffs], Tue Feb 9 15:05:49 2021 UTC (23 months, 4 weeks ago) by jakllsch
Branch: MAIN
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

Zero interrupt handles upon allocation.

Might prevent detach-time bugs.

Revision 1.6.2.1 / (download) - annotate - [select for diffs], Mon Dec 14 14:38:06 2020 UTC (2 years, 1 month ago) by thorpej
Branch: thorpej-futex
Changes since 1.6: +34 -16 lines
Diff to previous 1.6 (colored)

Sync w/ HEAD.

Revision 1.11 / (download) - annotate - [select for diffs], Thu Dec 10 04:03:00 2020 UTC (2 years, 1 month ago) by yamaguchi
Branch: MAIN
Changes since 1.10: +4 -2 lines
Diff to previous 1.10 (colored)

Add a string literal for IAVF_VC_OP_CONFIG_RSS_LUT

Revision 1.10 / (download) - annotate - [select for diffs], Thu Dec 10 04:00:11 2020 UTC (2 years, 1 month ago) by yamaguchi
Branch: MAIN
Changes since 1.9: +2 -5 lines
Diff to previous 1.9 (colored)

remove unnecessary lock acquire and release

Revision 1.9 / (download) - annotate - [select for diffs], Thu Dec 10 03:58:35 2020 UTC (2 years, 1 month ago) by yamaguchi
Branch: MAIN
Changes since 1.8: +4 -4 lines
Diff to previous 1.8 (colored)

Fix a wrong value about HENA configuration

Revision 1.8 / (download) - annotate - [select for diffs], Tue Dec 8 07:53:20 2020 UTC (2 years, 2 months ago) by yamaguchi
Branch: MAIN
Changes since 1.7: +18 -3 lines
Diff to previous 1.7 (colored)

Change the default interrupt-affinity of iavf(4)

Revision 1.7 / (download) - annotate - [select for diffs], Tue Dec 1 04:39:03 2020 UTC (2 years, 2 months ago) by yamaguchi
Branch: MAIN
Changes since 1.6: +14 -10 lines
Diff to previous 1.6 (colored)

Dequeue aqb from sc_atq_live even when the last command is failed

iavf(4) didn't dequeue aqb from sc_atq_live that is a list for
buffer in use when a command is failed by ETIMEDOUT.

This causes a panic in the following sequence:

 1. enqueue an aqb to sc_atq_live at iavf_aqb_post()
 2. the last command is failed by ETIMEDOUT
 3. enqueue the aqb used in the failed command to sc_atq_idle
    at an error handling in iavf_attach()
 4. dequeue the same aqb from sc_atq_live and enqueue sc_atq_idle
    again at iavf_cleanup_admin_queue()
   - sc_atq_idle is broken at that time
 5. free the aqb in sc_atq_idle more than once

Fix PR/55822

reviewed by knakahara@n.o.

Revision 1.6 / (download) - annotate - [select for diffs], Thu Sep 17 06:34:43 2020 UTC (2 years, 4 months ago) by yamaguchi
Branch: MAIN
Branch point for: thorpej-futex
Changes since 1.5: +25 -15 lines
Diff to previous 1.5 (colored)

Fix a panic caused while detaching iavf(4)

The sequence of the panic is follow:
  1. failed to disable queues in iavf_stop()
  2. release ec->ec_lock in ether_ifdetach()
  3. do reset scheduled at iavf_stop()
  4. acquire ec->ec_lock in iavf_reset_finish()
    - panic

reviewed by knakahara@n.o, thanks.

Revision 1.5 / (download) - annotate - [select for diffs], Thu Sep 10 03:20:08 2020 UTC (2 years, 4 months ago) by yamaguchi
Branch: MAIN
Changes since 1.4: +10 -4 lines
Diff to previous 1.4 (colored)

Fix a possible deadlock in iavf(4)

Revision 1.4 / (download) - annotate - [select for diffs], Wed Sep 9 00:56:17 2020 UTC (2 years, 4 months ago) by yamaguchi
Branch: MAIN
Changes since 1.3: +8 -2 lines
Diff to previous 1.3 (colored)

Added the explain about locking order in iavf(4)

Revision 1.3 / (download) - annotate - [select for diffs], Wed Sep 9 00:35:36 2020 UTC (2 years, 4 months ago) by jakllsch
Branch: MAIN
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

fix bad conditional in iavf_parse_modprop()

found by clang

Revision 1.2 / (download) - annotate - [select for diffs], Tue Sep 8 13:28:51 2020 UTC (2 years, 5 months ago) by jakllsch
Branch: MAIN
Changes since 1.1: +5 -5 lines
Diff to previous 1.1 (colored)

iaq_datalen is 16-bit, always use htole16

fixes build failure on big endian

Revision 1.1 / (download) - annotate - [select for diffs], Tue Sep 8 10:05:47 2020 UTC (2 years, 5 months ago) by yamaguchi
Branch: MAIN

Added iavf(4) that is based on OpenBSD's iavf(4) implementation

reviewed by msaitoh@n.o and knakahara@n.o

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>