The NetBSD Project

CVS log for src/sys/dev/pci/if_bwfm_pci.c

[BACK] Up to [] / src / sys / dev / pci

Request diff between arbitrary revisions

Default branch: MAIN
Current tag: MAIN

Revision 1.6 / (download) - annotate - [select for diffs], Sun Dec 9 11:14:02 2018 UTC (10 months ago) by jdolecek
Branch: MAIN
CVS Tags: phil-wifi-20190609, pgoyette-compat-20190127, pgoyette-compat-20190118, pgoyette-compat-1226, netbsd-9-base, netbsd-9, isaki-audio2-base, isaki-audio2, HEAD
Changes since 1.5: +3 -3 lines
Diff to previous 1.5 (colored)

use pci_intr_establish_xname() everywhere

Revision 1.5 / (download) - annotate - [select for diffs], Thu Nov 1 13:09:35 2018 UTC (11 months, 2 weeks ago) by martin
Branch: MAIN
CVS Tags: pgoyette-compat-1126
Changes since 1.4: +14 -9 lines
Diff to previous 1.4 (colored)

Make this compilable with 32bit paddr_t.

Revision 1.4 / (download) - annotate - [select for diffs], Mon Oct 15 16:29:10 2018 UTC (12 months ago) by maya
Branch: MAIN
CVS Tags: pgoyette-compat-1020
Branch point for: netbsd-8
Changes since 1.3: +25 -2 lines
Diff to previous 1.3 (colored)

Apply OpenBSD if_bwfm_pci.c:1.25 by patrick:

Add bus_dmamap_sync(9) calls to bwfm(4) so that we make sure the data
is synced properly before the CPU or the WiFi chip access the supplied
memory.  Makes PCIe-connected bwfm(4) work on ARM-based machines.

Revision 1.3 / (download) - annotate - [select for diffs], Mon Sep 3 16:29:32 2018 UTC (13 months, 1 week ago) by riastradh
Branch: MAIN
CVS Tags: pgoyette-compat-0930, pgoyette-compat-0906
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int.  The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER!  Some subsystems have

	#define min(a, b)	((a) < (b) ? (a) : (b))
	#define max(a, b)	((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX.  Although these
may invite multiple evaluation bugs, these do _not_ cause integer

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate.  But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all.  (Who knows, maybe in some cases integer
truncation is actually intended!)

Revision 1.2 / (download) - annotate - [select for diffs], Sat Sep 1 22:01:03 2018 UTC (13 months, 2 weeks ago) by riastradh
Branch: MAIN
Changes since 1.1: +36 -19 lines
Diff to previous 1.1 (colored)

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:

Diagnosed and tested by maya.

Revision 1.1 / (download) - annotate - [select for diffs], Fri May 11 07:42:22 2018 UTC (17 months ago) by maya
Branch: MAIN
CVS Tags: phil-wifi-base, pgoyette-compat-0728, pgoyette-compat-0625, pgoyette-compat-0521, jdolecek-ncqfixes-base, jdolecek-ncqfixes
Branch point for: phil-wifi, pgoyette-compat

add bwfm pci support, from openbsd

Tested on BCM43602.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.

CVSweb <>