The NetBSD Project

CVS log for src/sys/dev/pci/if_bwfm_pci.c

[BACK] Up to [cvs.NetBSD.org] / src / sys / dev / pci

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.13 / (download) - annotate - [select for diffs], Mon May 23 13:53:37 2022 UTC (8 months, 1 week ago) by rin
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10, bouyer-sunxi-drm-base, bouyer-sunxi-drm, HEAD
Changes since 1.12: +3 -2 lines
Diff to previous 1.12 (colored)

Audit unload/unmap v.s. free against DMA buffer for sys/dev/pci;
make sure that bus_dmamap_unload(9) [or bus_dmamap_destroy(9)] or
bus_dmamem_unmap(9) are preceding to freeing DMA buffer, if it is
loaded or mapped, respectively.

This is mandatory for some archs. See, e.g.:

http://www.nerv.org/netbsd/?q=id:20210511T013030Z.013443cc790088147e4beed43f53dedabeaf9312
http://www.nerv.org/netbsd/?q=id:20220511T172220Z.561179f0b6fcc5b9cd73e274f69d74e2ce9e4c93

XXX XXX XXX
Compile test only (for amd64/ALL).

Thanks riastradh@ for double check.

Revision 1.12 / (download) - annotate - [select for diffs], Sun Apr 24 07:11:31 2022 UTC (9 months, 1 week ago) by skrll
Branch: MAIN
Changes since 1.11: +11 -11 lines
Diff to previous 1.11 (colored)

Trailing whitespace

Revision 1.11 / (download) - annotate - [select for diffs], Thu Aug 26 21:33:36 2021 UTC (17 months ago) by andvar
Branch: MAIN
Changes since 1.10: +4 -1 lines
Diff to previous 1.10 (colored)

Add missing RCSID in header files and one __KERNEL_RCSID().

Revision 1.9.6.1 / (download) - annotate - [select for diffs], Thu May 13 00:47:31 2021 UTC (20 months, 2 weeks ago) by thorpej
Branch: thorpej-i2c-spi-conf
Changes since 1.9: +10 -15 lines
Diff to previous 1.9 (colored) next main 1.10 (colored)

Sync with HEAD.

Revision 1.10 / (download) - annotate - [select for diffs], Sat May 8 00:27:02 2021 UTC (20 months, 3 weeks ago) by thorpej
Branch: MAIN
CVS Tags: thorpej-i2c-spi-conf2-base, thorpej-i2c-spi-conf2, thorpej-i2c-spi-conf-base, thorpej-futex2-base, thorpej-futex2, thorpej-cfargs2-base, thorpej-cfargs2, cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.9: +10 -15 lines
Diff to previous 1.9 (colored)

Use pci_compatible_match().

Revision 1.9 / (download) - annotate - [select for diffs], Sat May 30 15:55:47 2020 UTC (2 years, 8 months ago) by jdolecek
Branch: MAIN
CVS Tags: thorpej-futex-base, thorpej-futex, thorpej-cfargs-base, thorpej-cfargs
Branch point for: thorpej-i2c-spi-conf
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

Revision 1.8 / (download) - annotate - [select for diffs], Sat May 30 13:41:58 2020 UTC (2 years, 8 months ago) by jdolecek
Branch: MAIN
Changes since 1.7: +4 -4 lines
Diff to previous 1.7 (colored)

constify, and make static where possible

Revision 1.1.4.2 / (download) - annotate - [select for diffs], Wed Apr 8 14:08:09 2020 UTC (2 years, 9 months ago) by martin
Branch: phil-wifi
Changes since 1.1.4.1: +75 -55 lines
Diff to previous 1.1.4.1 (colored) to branchpoint 1.1 (colored) next main 1.2 (colored)

Merge changes from current as of 20200406

Revision 1.7 / (download) - annotate - [select for diffs], Wed Mar 25 03:44:45 2020 UTC (2 years, 10 months ago) by thorpej
Branch: MAIN
CVS Tags: phil-wifi-20200421, phil-wifi-20200411, phil-wifi-20200406, bouyer-xenpvh-base2, bouyer-xenpvh-base1, bouyer-xenpvh-base, bouyer-xenpvh
Changes since 1.6: +75 -55 lines
Diff to previous 1.6 (colored)

- Refactor the firmware loading code into a set of common routines in the
  core driver that understand how to find model-specific files before the
  generic files.  This greatly simplifies the firmware loading procedure
  in each of the bus front ends.  Adding additional firmware file types
  (such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
  and if() statements.
- Add several additional firmware image entries.

Revision 1.1.4.1 / (download) - annotate - [select for diffs], Mon Jun 10 22:07:16 2019 UTC (3 years, 7 months ago) by christos
Branch: phil-wifi
Changes since 1.1: +79 -34 lines
Diff to previous 1.1 (colored)

Sync with HEAD

Revision 1.1.2.6 / (download) - annotate - [select for diffs], Wed Dec 26 14:01:50 2018 UTC (4 years, 1 month ago) by pgoyette
Branch: pgoyette-compat
CVS Tags: pgoyette-compat-merge-20190127
Changes since 1.1.2.5: +3 -3 lines
Diff to previous 1.1.2.5 (colored) to branchpoint 1.1 (colored) next main 1.2 (colored)

Sync with HEAD, resolve a few conflicts

Revision 1.6 / (download) - annotate - [select for diffs], Sun Dec 9 11:14:02 2018 UTC (4 years, 1 month ago) by jdolecek
Branch: MAIN
CVS Tags: phil-wifi-20191119, phil-wifi-20190609, pgoyette-compat-20190127, pgoyette-compat-20190118, pgoyette-compat-1226, netbsd-9-base, netbsd-9-3-RELEASE, netbsd-9-2-RELEASE, netbsd-9-1-RELEASE, netbsd-9-0-RELEASE, netbsd-9-0-RC2, netbsd-9-0-RC1, netbsd-9, isaki-audio2-base, isaki-audio2, is-mlppp-base, is-mlppp, ad-namecache-base3, ad-namecache-base2, ad-namecache-base1, ad-namecache-base, ad-namecache
Changes since 1.5: +3 -3 lines
Diff to previous 1.5 (colored)

use pci_intr_establish_xname() everywhere

Revision 1.1.2.5 / (download) - annotate - [select for diffs], Mon Nov 26 01:52:32 2018 UTC (4 years, 2 months ago) by pgoyette
Branch: pgoyette-compat
Changes since 1.1.2.4: +14 -9 lines
Diff to previous 1.1.2.4 (colored) to branchpoint 1.1 (colored)

Sync with HEAD, resolve a couple of conflicts

Revision 1.4.2.3 / (download) - annotate - [select for diffs], Fri Nov 2 07:55:06 2018 UTC (4 years, 2 months ago) by martin
Branch: netbsd-8
CVS Tags: netbsd-8-2-RELEASE, netbsd-8-1-RELEASE, netbsd-8-1-RC1
Changes since 1.4.2.2: +14 -9 lines
Diff to previous 1.4.2.2 (colored) to branchpoint 1.4 (colored) next main 1.5 (colored)

Additional pullup for ticket #1072:

	sys/dev/pci/if_bwfm_pci.c	1.5

Make this compilable with 32bit paddr_t.

Revision 1.5 / (download) - annotate - [select for diffs], Thu Nov 1 13:09:35 2018 UTC (4 years, 3 months ago) by martin
Branch: MAIN
CVS Tags: pgoyette-compat-1126
Changes since 1.4: +14 -9 lines
Diff to previous 1.4 (colored)

Make this compilable with 32bit paddr_t.

Revision 1.4.2.2 / (download) - annotate - [select for diffs], Wed Oct 31 09:23:00 2018 UTC (4 years, 3 months ago) by martin
Branch: netbsd-8
Changes since 1.4.2.1: +2102 -0 lines
Diff to previous 1.4.2.1 (colored) to branchpoint 1.4 (colored)

Backport of bfwm code, requested by maya in ticket #1072:

	sys/dev/ic/bwfm.c			1.14
	sys/dev/ic/bwfmreg.h			1.3
	sys/dev/ic/bwfmvar.h			1.3
	sys/dev/pci/if_bwfm_pci.c 		1.4
	sys/dev/pci/if_bwfm_pci.h		1.8
	sys/dev/usb/if_bwfm_usb.c 		1.8

via patch.

Revision 1.1.2.4 / (download) - annotate - [select for diffs], Sat Oct 20 06:58:31 2018 UTC (4 years, 3 months ago) by pgoyette
Branch: pgoyette-compat
Changes since 1.1.2.3: +25 -2 lines
Diff to previous 1.1.2.3 (colored) to branchpoint 1.1 (colored)

Sync with head

Revision 1.4.2.1, Mon Oct 15 16:29:10 2018 UTC (4 years, 3 months ago) by martin
Branch: netbsd-8
Changes since 1.4: +0 -2102 lines
FILE REMOVED

file if_bwfm_pci.c was added on branch netbsd-8 on 2018-10-31 09:23:00 +0000

Revision 1.4 / (download) - annotate - [select for diffs], Mon Oct 15 16:29:10 2018 UTC (4 years, 3 months ago) by maya
Branch: MAIN
CVS Tags: pgoyette-compat-1020
Branch point for: netbsd-8
Changes since 1.3: +25 -2 lines
Diff to previous 1.3 (colored)

Apply OpenBSD if_bwfm_pci.c:1.25 by patrick:

Add bus_dmamap_sync(9) calls to bwfm(4) so that we make sure the data
is synced properly before the CPU or the WiFi chip access the supplied
memory.  Makes PCIe-connected bwfm(4) work on ARM-based machines.

Revision 1.1.2.3 / (download) - annotate - [select for diffs], Thu Sep 6 06:55:51 2018 UTC (4 years, 4 months ago) by pgoyette
Branch: pgoyette-compat
Changes since 1.1.2.2: +40 -23 lines
Diff to previous 1.1.2.2 (colored) to branchpoint 1.1 (colored)

Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)

Revision 1.3 / (download) - annotate - [select for diffs], Mon Sep 3 16:29:32 2018 UTC (4 years, 4 months ago) by riastradh
Branch: MAIN
CVS Tags: pgoyette-compat-0930, pgoyette-compat-0906
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int.  The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER!  Some subsystems have

	#define min(a, b)	((a) < (b) ? (a) : (b))
	#define max(a, b)	((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX.  Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate.  But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all.  (Who knows, maybe in some cases integer
truncation is actually intended!)

Revision 1.2 / (download) - annotate - [select for diffs], Sat Sep 1 22:01:03 2018 UTC (4 years, 4 months ago) by riastradh
Branch: MAIN
Changes since 1.1: +36 -19 lines
Diff to previous 1.1 (colored)

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

Revision 1.1.2.2 / (download) - annotate - [select for diffs], Mon May 21 04:36:06 2018 UTC (4 years, 8 months ago) by pgoyette
Branch: pgoyette-compat
Changes since 1.1.2.1: +2062 -0 lines
Diff to previous 1.1.2.1 (colored) to branchpoint 1.1 (colored)

Sync with HEAD

Revision 1.1.2.1, Fri May 11 07:42:22 2018 UTC (4 years, 8 months ago) by pgoyette
Branch: pgoyette-compat
Changes since 1.1: +0 -2062 lines
FILE REMOVED

file if_bwfm_pci.c was added on branch pgoyette-compat on 2018-05-21 04:36:06 +0000

Revision 1.1 / (download) - annotate - [select for diffs], Fri May 11 07:42:22 2018 UTC (4 years, 8 months ago) by maya
Branch: MAIN
CVS Tags: phil-wifi-base, pgoyette-compat-0728, pgoyette-compat-0625, pgoyette-compat-0521, jdolecek-ncqfixes-base, jdolecek-ncqfixes
Branch point for: phil-wifi, pgoyette-compat

add bwfm pci support, from openbsd

Tested on BCM43602.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>