CVS log for src/sys/dev/iscsi/iscsi_send.c

Up to [cvs.NetBSD.org] / src / sys / dev / iscsi

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Pull up following revision(s) (requested by rin in ticket #997):

	sys/dev/iscsi/iscsi_ioctl.c: revision 1.35
	sys/dev/iscsi/iscsi_main.c: revision 1.42
	sys/dev/iscsi/iscsi_send.c: revision 1.41

Use correct status value SCSI_BUSY (0x08) instead of XS_BUSY (7) when
running out of sessions. The bug had no impact as scsipi was only comparing
against SCSI_CHECK (0x02) and SCSI_QUEUE_FULL (0x28).

Avoid race in timeout handling.

Don't try to wake up CCB without connection (which led to a NULL pointer
deref).

Avoid race in timeout handling.
Don't try to wake up CCB without connection (which led to a NULL pointer deref).

Pull up following revision(s) (requested by mlelstv in ticket #505):

	sys/dev/iscsi/iscsi_utils.c: revision 1.29
	sys/dev/iscsi/iscsi.h: revision 1.5
	sys/dev/iscsi/iscsi_ioctl.c: revision 1.34
	sys/dev/iscsi/iscsi_globals.h: revision 1.28
	sys/dev/iscsi/iscsi_text.c: revision 1.14
	sys/dev/iscsi/iscsi_send.c: revision 1.40

Adapt to bignum representation of target.

Fix negotiation for mutual authentication.

Prepare for more CHAP types.

Fix crashes for invalid socket descriptors passed to kernel.

Protect usecount with connection mutex, avoids race on connection close.

Minor cosmetics.

Adapt to bignum representation of target.
Fix negotiation for mutual authentication.
Prepare for more CHAP types.
Fix crashes for invalid socket descriptors passed to kernel.
Protect usecount with connection mutex, avoids race on connection close.
Minor cosmetics.

kill_session now uses the session id to avoid stale session pointers.
protect network socket with rwlock to handle recconnects.
always take over socket from iscsid to prevent leaks.
keep a good connection alive.
don't forget child device when config_detach fails.
fix locking when reassigning CCBs.
pducount is protected by lock, no need for atomic.
some code rework, refined debug messages.

Sync w/ HEAD.

sync with head

Schedule command timeout without connection lock being held to prevent
a deadlock.

Pull up following revision(s) (requested by mlelstv in ticket #709):
	sys/dev/iscsi/iscsi_send.c: revision 1.37 via patch
	sys/dev/iscsi/iscsi_rcv.c: revision 1.25 via patch
Return temporary errors when the session is trying to recover the last
connection. The scsipi layer will retry.
Add sanity check.

Return temporary errors when the session is trying to recover the last
connection. The scsipi layer will retry.

Pull up following revision(s) (requested by mlelstv in ticket #437):
	sys/dev/iscsi/iscsi_ioctl.c: 1.26-1.27
	sys/dev/iscsi/iscsi_main.c: 1.26
	sys/dev/iscsi/iscsi_send.c: 1.35
Fix session cleanup.
--
add debug messages
-
use same lock for ref/deref.
--
unreference session only for responses to SCSI commands.

- add a prefix to struct members (but not the ioctl ones because they affect
  the API)
- use consistent variable names.

update from HEAD

add debug messages

Sync with HEAD

Sync with HEAD

Sync with HEAD

Use correct lock for session wakeup.

Sync with HEAD

Destroy callouts when cleaning up.

Sync with HEAD.  (Note that most of these changes are simply $NetBSD$
tag issues.)

Lock correctly around CV calls.
Fix handling of session termination.
Enable MPSAFE processing for scsipi.

Sync with HEAD

Remove throttling code, instead signal scsipi layer to reduce the openings
and retry the command. Start with a small openings number and let scsipi
request to grow it up to the current send window.

Adjust ccb and pdu counts to avoid ressource shortages. These are still
very ad-hoc numbers, but seem to be sufficient for a Gigabit link.

Use separate condvar for PDU pool and add counter to help debugging.

Revert setting PDU disposition to UNUSED before freeing. free_pdu
uses this as a flag to detect already returned PDUs.

Add reference counter for open commands to defer unmapping a session
that would lead to crashes in scsipi.

Move session cleanup to cleanup thread.

Use get_sernum to retrieve current serial number where possible and
make it check for immediate commands itself.

Adjust debug output.

Handle freeing of PDU when referencing CCB is freed.

wrong assertion.

Need session mutex to read serial number.

Add missing mutex_exit().

Whitespace, braces.

Replace the simple tag counter with the command tag coming down from scsipi.
Also set attributes according to tag types.

No need to acquire KERNEL_LOCK when entering network code.
Also use the socket callbacks.

Make PDU init routines record serial number in CCB too.

Fix locking for pdu flags here, in particular PDUF_INQUEUE.

More debugging output, changed debug levels for some.

fix debug message

don't sleep in run_xfer path.

refactor callouts
remove timed out ccbs and connections from cleanup queue when stopping timeout.

factor out sernum handling.
make incrementing sernum atomic.
declare variables for atomic operations as volatile.

Several improvements to the ISCSI driver.

- Enable debug messages but set log level to be quiet. Provide a
  system (hw.iscsi.debug) to set the log level at run time.
- Replace old tsleep/wakeup synchronization with mutexes and condvars.
- Defer actions from callouts (basically timeouts) to the cleanup thread.
- Protect lists and unique ids with mutexes. protect connection usecount
  by using atomic operations.
- Assert kernel lock when calling into scsipi and network code.
- Use this to make send/receive/cleanup threads MPSAFE.

- Fix handling of out-of-CCB/out-of-PDU conditions against the scsipi layer.
- Bump number of PDUs to 128 to avoid virtually all out-of-PDU conditions

- Make use of softc structure for attach/detach operations.
- Track open file handles to prevent detach when busy.

- Move some global variables to make them static.

- Fix 'Overlapping Commands Attempted' error by marking commands as
  simply ordered (ATTR_SIMPLE) like FreeBSD.

Sync with HEAD (as of 26th Dec)

fix amd64/conf/ALL build failure

Sync with HEAD

Inline SET_CCB_TIMEOUT and SET_CONN_TIMEOUT

Remove ISCSI_PERFTEST.

Remove ISCSI_TEST_MODE and corresponding dev/iscsi_test.h header.

Remove conditionals for NetBSD before 4.0.

Pull up following revision(s) (requested by tls in ticket #119):
	sys/dev/iscsi/iscsi_send.c: revision 1.10
The "throttling" code in the in-kernel iSCSI initiator is very questionable;
it sleeps on a ccb that appears highly unlikely to wake up, since it seems
to be waiting to _submit_ that very ccb!  This is doubtless why someone tried
to disable it in the default case via several #defines.
Unfortunately one of those #defines is later tested backwards.  Fix that.
The in-kernel initiator now seems to survive a system build without hanging.

The "throttling" code in the in-kernel iSCSI initiator is very questionable;
it sleeps on a ccb that appears highly unlikely to wake up, since it seems
to be waiting to _submit_ that very ccb!  This is doubtless why someone tried
to disable it in the default case via several #defines.

Unfortunately one of those #defines is later tested backwards.  Fix that.
The in-kernel initiator now seems to survive a system build without hanging.

Try not to use f_data, use f_{vnode,socket,pipe,mqueue,kqueue,ksem} to get
a correctly typed pointer.

resync with head

sync with head

- defer session cleanup to not force detachments
- use more and explicit locking
- improve connection recovery
- use larger timeouts
- handle ccb buffer underflow correctly
- simplify throttling code

Sessions can now temporarily exist without a valid
connection, you also need to update iscsid(8).

sync with head

Remove an erroneous change that crept in.  It was part of an earlier,
incorrect fix I had done for writing > 64K bytes.  It was still in the
set of changes mlelstv had committed.  I noticed it at the time, but did
not think it was problematic - until now.  This fixes the ccb corruption
I was seeing and fixes PR kern/46896.

Don't use common variables, also prefix global variables to avoid
namespace pollution.

Pull up revisions:
  src/sys/dev/iscsi/iscsi_globals.h revisions 1.3,1.4
  src/sys/dev/iscsi/iscsi_main.c revisions 1.4,1.5
  src/sys/dev/iscsi/iscsi_text.c revisions 1.4,1.5
  src/sys/dev/iscsi/iscsi_ioctl.c revisions 1.3,1.4
  src/sys/dev/iscsi/iscsi_send.c revisions 1.3,1.4,1.5
  src/sys/dev/iscsi/iscsi_utils.c revisions 1.2,1.3,1.4
  src/sbin/iscsid/iscsid_discover.c revision 1.4
  src/sys/dev/iscsi/iscsi_rcv.c revision 1.3
  src/sbin/iscsictl/iscsic_driverif.c revisions 1.5,1.6
(requested by martin in ticket #357, with updates from mhitch and mlelstv).

avoid namespace pollution when debugging
don't panic when printing data for a dead (NULL) connection

Close file descriptor passed into the kernel on success.
Fix locking of file handle. More cleanup on error paths.
Keep track of CCBs, so they cannot be used after a session ends.
Handle CCB timeouts even when the connection is terminated.
Compute firstdata, firstimmed correctly.

assemble_login_parameters() has a strange error reporting convention:
errors are positive numbers, so <= 0 is good, not >= ...
This makes CHAP authenticated iscsi logins work.

use first successful connection to a ISNS server

Add more debugging, fix filehandle usage, login negotiation and session
shutdown.
Add #ifdef'd code to send negotiation parameters in hex instead of base64,
so it works against older Linux targets.

report luns returns a 32bit list length.

Make digests work also on big endian machines.

it's really 32bit

Add more debugging, fix filehandle usage, login negotiation and session
shutdown.
Add #ifdef'd code to send negotiation parameters in hex instead of base64,
so it works against older Linux targets.

assemble_login_parameters() has a strange error reporting convention:
errors are positive numbers, so <= 0 is good, not >= ...
This makes CHAP authenticated iscsi logins work.

Pull up following revision(s) (requested by mhitch in ticket #323):
	sys/dev/iscsi/iscsi_send.c: revision 1.2
	sys/dev/iscsi/iscsi_rcv.c: revision 1.2
Fix system freeze when trying to write to a raw iSCSI device with MAXPHYS
bytes.  Newfs does large writes when initializing the filesystem.
First, don't copy the head of a TAILQ to make a copy - the first entry will
still point back to the original head.  This caused the ccb list to link to
itself, resulting in a continous loop processing the same ccb and blocked
interrupts.  Use TAILQ_CONCAT() to copy the list.
Next, the ccb disposition was not set in the ccb when the ccb was throttled,
losing the CCBDISP_SCSIPI, so when a throttled ccb was resent, it failed to
call scscipi_done(), and left that I/O hanging.
I am now able to newfs an iSCSI device, was well as issued large writes
using dd.

Close file descriptor passed into the kernel on success.
Fix locking of file handle. More cleanup on error paths.
Keep track of CCBs, so they cannot be used after a session ends.
Handle CCB timeouts even when the connection is terminated.
Compute firstdata, firstimmed correctly.

Fix system freeze when trying to write to a raw iSCSI device with MAXPHYS
bytes.  Newfs does large writes when initializing the filesystem.
First, don't copy the head of a TAILQ to make a copy - the first entry will
still point back to the original head.  This caused the ccb list to link to
itself, resulting in a continous loop processing the same ccb and blocked
interrupts.  Use TAILQ_CONCAT() to copy the list.
Next, the ccb disposition was not set in the ccb when the ccb was throttled,
losing the CCBDISP_SCSIPI, so when a throttled ccb was resent, it failed to
call scscipi_done(), and left that I/O hanging.
I am now able to newfs an iSCSI device, was well as issued large writes
using dd.

Start to move the in-kernel iSCSI initiator, kindly contributed to the
NetBSD Foundation by Wasabi Systems, from

        othersrc/external/bsd/iscsi/sys/dev/iscsi

to

        src/sys/dev/iscsi