CVS log for src/sys/dev/iscsi/iscsi_ioctl.c

Up to [cvs.NetBSD.org] / src / sys / dev / iscsi

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Release cleanup mutex before calling kill_connection.

Take lock when updating conn state.

Pull up following revision(s) (requested by rin in ticket #997):

	sys/dev/iscsi/iscsi_ioctl.c: revision 1.35
	sys/dev/iscsi/iscsi_main.c: revision 1.42
	sys/dev/iscsi/iscsi_send.c: revision 1.41

Use correct status value SCSI_BUSY (0x08) instead of XS_BUSY (7) when
running out of sessions. The bug had no impact as scsipi was only comparing
against SCSI_CHECK (0x02) and SCSI_QUEUE_FULL (0x28).

Avoid race in timeout handling.

Don't try to wake up CCB without connection (which led to a NULL pointer
deref).

Avoid race in timeout handling.
Don't try to wake up CCB without connection (which led to a NULL pointer deref).

Pull up following revision(s) (requested by mlelstv in ticket #505):

	sys/dev/iscsi/iscsi_utils.c: revision 1.29
	sys/dev/iscsi/iscsi.h: revision 1.5
	sys/dev/iscsi/iscsi_ioctl.c: revision 1.34
	sys/dev/iscsi/iscsi_globals.h: revision 1.28
	sys/dev/iscsi/iscsi_text.c: revision 1.14
	sys/dev/iscsi/iscsi_send.c: revision 1.40

Adapt to bignum representation of target.

Fix negotiation for mutual authentication.

Prepare for more CHAP types.

Fix crashes for invalid socket descriptors passed to kernel.

Protect usecount with connection mutex, avoids race on connection close.

Minor cosmetics.

Adapt to bignum representation of target.
Fix negotiation for mutual authentication.
Prepare for more CHAP types.
Fix crashes for invalid socket descriptors passed to kernel.
Protect usecount with connection mutex, avoids race on connection close.
Minor cosmetics.

kill_session now uses the session id to avoid stale session pointers.
protect network socket with rwlock to handle recconnects.
always take over socket from iscsid to prevent leaks.
keep a good connection alive.
don't forget child device when config_detach fails.
fix locking when reassigning CCBs.
pducount is protected by lock, no need for atomic.
some code rework, refined debug messages.

avoid the use of UVM internals in the iscsi ioctl code.
copyin/out are fine in this context.

Catch up with the usage of struct vmspace::vm_refcnt

Use the dedicated reference counting routines.

Change the type of struct vmspace::vm_refcnt and struct vm_map::ref_count
to volatile.

Remove the unnecessary vm->vm_map.misc_lock locking in process_domem().

Reviewed by <ad>

Sync with HEAD

Sync with HEAD, resolve a few conflicts

interlock isn't taken when cleaning up.

Pull up following revision(s) (requested by mlelstv in ticket #437):
	sys/dev/iscsi/iscsi_ioctl.c: 1.26-1.27
	sys/dev/iscsi/iscsi_main.c: 1.26
	sys/dev/iscsi/iscsi_send.c: 1.35
Fix session cleanup.
--
add debug messages
-
use same lock for ref/deref.
--
unreference session only for responses to SCSI commands.

Fix typo

- add a prefix to struct members (but not the ioctl ones because they affect
  the API)
- use consistent variable names.

update from HEAD

use same lock for ref/deref.

Sync with HEAD

Fix session cleanup.

Sync with HEAD

Sync with HEAD

Use correct lock for session wakeup.

Sync with HEAD

Destroy callouts when cleaning up.

Sync with HEAD.  (Note that most of these changes are simply $NetBSD$
tag issues.)

Lock correctly around CV calls.
Fix handling of session termination.
Enable MPSAFE processing for scsipi.

Sync with HEAD

Remove throttling code, instead signal scsipi layer to reduce the openings
and retry the command. Start with a small openings number and let scsipi
request to grow it up to the current send window.

Adjust ccb and pdu counts to avoid ressource shortages. These are still
very ad-hoc numbers, but seem to be sufficient for a Gigabit link.

Use separate condvar for PDU pool and add counter to help debugging.

Revert setting PDU disposition to UNUSED before freeing. free_pdu
uses this as a flag to detect already returned PDUs.

Add reference counter for open commands to defer unmapping a session
that would lead to crashes in scsipi.

Move session cleanup to cleanup thread.

Use get_sernum to retrieve current serial number where possible and
make it check for immediate commands itself.

Adjust debug output.

use correct comparison of serial numbers

More debug output. Dump pending CCBs when cleaning up.

appease compiler

When stopping a callout, wait until the cleanup thread has processed them.

use sernum handling function

refactor callouts
remove timed out ccbs and connections from cleanup queue when stopping timeout.

close session when last connection is removed.

Several improvements to the ISCSI driver.

- Enable debug messages but set log level to be quiet. Provide a
  system (hw.iscsi.debug) to set the log level at run time.
- Replace old tsleep/wakeup synchronization with mutexes and condvars.
- Defer actions from callouts (basically timeouts) to the cleanup thread.
- Protect lists and unique ids with mutexes. protect connection usecount
  by using atomic operations.
- Assert kernel lock when calling into scsipi and network code.
- Use this to make send/receive/cleanup threads MPSAFE.

- Fix handling of out-of-CCB/out-of-PDU conditions against the scsipi layer.
- Bump number of PDUs to 128 to avoid virtually all out-of-PDU conditions

- Make use of softc structure for attach/detach operations.
- Track open file handles to prevent detach when busy.

- Move some global variables to make them static.

- Fix 'Overlapping Commands Attempted' error by marking commands as
  simply ordered (ATTR_SIMPLE) like FreeBSD.

Sync with HEAD

Use value *before* freeing it. Found by brainy, reported by maxv.

Sync with HEAD

Create a per-device state for iscsi(4), effectively making it a cloning
device.

Inline SET_CCB_TIMEOUT and SET_CONN_TIMEOUT

Remove ISCSI_PERFTEST.

Remove ISCSI_TEST_MODE and corresponding dev/iscsi_test.h header.

Remove conditionals for NetBSD before 4.0.

Make sure callout is halted, not just stopped, before freeing memory.

resync with head

sync with head

- defer session cleanup to not force detachments
- use more and explicit locking
- improve connection recovery
- use larger timeouts
- handle ccb buffer underflow correctly
- simplify throttling code

Sessions can now temporarily exist without a valid
connection, you also need to update iscsid(8).

sync with head

Don't use common variables, also prefix global variables to avoid
namespace pollution.

Pull up revisions:
  src/sys/dev/iscsi/iscsi_globals.h revisions 1.3,1.4
  src/sys/dev/iscsi/iscsi_main.c revisions 1.4,1.5
  src/sys/dev/iscsi/iscsi_text.c revisions 1.4,1.5
  src/sys/dev/iscsi/iscsi_ioctl.c revisions 1.3,1.4
  src/sys/dev/iscsi/iscsi_send.c revisions 1.3,1.4,1.5
  src/sys/dev/iscsi/iscsi_utils.c revisions 1.2,1.3,1.4
  src/sbin/iscsid/iscsid_discover.c revision 1.4
  src/sys/dev/iscsi/iscsi_rcv.c revision 1.3
  src/sbin/iscsictl/iscsic_driverif.c revisions 1.5,1.6
(requested by martin in ticket #357, with updates from mhitch and mlelstv).

avoid namespace pollution when debugging
don't panic when printing data for a dead (NULL) connection

Close file descriptor passed into the kernel on success.
Fix locking of file handle. More cleanup on error paths.
Keep track of CCBs, so they cannot be used after a session ends.
Handle CCB timeouts even when the connection is terminated.
Compute firstdata, firstimmed correctly.

assemble_login_parameters() has a strange error reporting convention:
errors are positive numbers, so <= 0 is good, not >= ...
This makes CHAP authenticated iscsi logins work.

use first successful connection to a ISNS server

Add more debugging, fix filehandle usage, login negotiation and session
shutdown.
Add #ifdef'd code to send negotiation parameters in hex instead of base64,
so it works against older Linux targets.

report luns returns a 32bit list length.

Make digests work also on big endian machines.

it's really 32bit

Add more debugging, fix filehandle usage, login negotiation and session
shutdown.
Add #ifdef'd code to send negotiation parameters in hex instead of base64,
so it works against older Linux targets.

Close file descriptor passed into the kernel on success.
Fix locking of file handle. More cleanup on error paths.
Keep track of CCBs, so they cannot be used after a session ends.
Handle CCB timeouts even when the connection is terminated.
Compute firstdata, firstimmed correctly.

sync with head

merge to -current.

extending vmem(9) to be able to allocated resources for it's own needs.
simplifying uvm_map handling (no special kernel entries anymore no relocking)
make malloc(9) a thin wrapper around kmem(9)
(with private interface for interrupt safety reasons)

releng@ acknowledged

Start to move the in-kernel iSCSI initiator, kindly contributed to the
NetBSD Foundation by Wasabi Systems, from

        othersrc/external/bsd/iscsi/sys/dev/iscsi

to

        src/sys/dev/iscsi