CVS log for src/sys/dev/ir/irframe_tty.c

Up to [cvs.NetBSD.org] / src / sys / dev / ir

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

irframetty(4): Convert to ttylock/ttyunlock.

fix various typos in comment, documentation and log messages.

Change the kqueue filterops::f_isfd field to filterops::f_flags, and
define a flag FILTEROP_ISFD that has the meaning of the prior f_isfd.
Field and flag name aligned with OpenBSD.

This does not constitute a functional or ABI change, as the field location
and size, and the value placed in that field, are the same as the previous
code, but we're bumping __NetBSD_Version__ so 3rd-party module source code
can adapt, as needed.

NetBSD 9.99.89

Sync w/ HEAD.

Use sel{record,remove}_knote().

Sync with HEAD

Sync with HEAD

Add comments about D_MPSAFE to functions called as struct linesw.l_ioctl.

update from HEAD

Use C99 initializer for filterops

Mostly done with spatch with touchups for indentation

@@
expression a;
identifier b,c,d;
identifier p;
@@
const struct filterops p =
- 	{ a, b, c, d
+ 	{
+ 	.f_isfd = a,
+ 	.f_attach = b,
+ 	.f_detach = c,
+ 	.f_event = d,
};

At suggestion of chuq@, modify config_attach_pseudo() to return with a
reference held on the device.

Adapt callers to expect the reference to exist, and to ensure that the
reference is released.

Restore all work from the former pgoyette-localcount branch (which is
now abandoned doe to cvs merge botch).

The branch now builds, and installs via anita.  There are still some
problems (cgd is non-functional and all atf tests time-out) but they
will get resolved soon.

Adapt machine-independant code to the new {b,c}devsw reference-counting
(using localcount(9)).  All callers of {b,c}devsw_lookup() now call
{b,c}devsw_lookup_acquire() which retains a reference on the 'struct
{b,c}devsw'.  This reference must be released by the caller once it is
finished with the structure's content (or other data that would disappear
if the 'struct {b,c}devsw' were to disappear).

Sync with HEAD

include "ioconf.h" to get the 'void <driver>attach(int count);' prototype.

Pull up following revision(s) (requested by ozaki-r in ticket #1201):
	sys/kern/kern_ktrace.c: revision 1.166
	sys/dev/isa/aps.c: revision 1.16
	sys/dev/sysmon/sysmonvar.h: revision 1.45
	sys/dev/ir/irframe_tty.c: revision 1.60
	sys/dev/sysmon/sysmon_envsys_events.c: revision 1.111-1.112 (patch)
	sys/dev/pci/pccbb.c: revision 1.207
	sys/dev/wscons/wskbd.c: revision 1.135
	sys/dev/usb/ohci.c: revision 1.254
	sys/net/if_ecosubr.c: revision 1.41
	sys/dev/pcmcia/btbc.c: revision 1.17
	sys/arch/x86/x86/via_padlock.c: revision 1.23
	sys/dev/sdmmc/sdmmc.c: revision 1.23 (patch)
	sys/dev/bluetooth/btkbd.c: revision 1.17
	sys/dev/bluetooth/bcsp.c: revision 1.25
	sys/arch/x86/pci/fwhrng.c: revision 1.8
	sys/dev/ic/nslm7x.c: revision 1.61
	share/man/man9/callout.9: revision 1.28 (patch)

Replace callout_stop with callout_halt and ensure the callout
is not running before destroying it.

Pull up following revision(s) (requested by ozaki-r in ticket #279):
	sys/kern/kern_ktrace.c: revision 1.166
	sys/dev/isa/aps.c: revision 1.16
	sys/dev/sysmon/sysmonvar.h: revision 1.45
	sys/dev/ir/irframe_tty.c: revision 1.60
	sys/dev/sysmon/sysmon_envsys_events.c: revision 1.111
	sys/dev/sysmon/sysmon_envsys_events.c: revision 1.112
	sys/dev/pci/pccbb.c: revision 1.207
	sys/dev/wscons/wskbd.c: revision 1.135
	sys/dev/usb/ohci.c: revision 1.254
	sys/net/if_ecosubr.c: revision 1.41
	sys/dev/pcmcia/btbc.c: revision 1.17
	sys/arch/x86/x86/via_padlock.c: revision 1.23
	sys/dev/sdmmc/sdmmc.c: revision 1.23
	sys/dev/bluetooth/btkbd.c: revision 1.17
	sys/dev/bluetooth/bcsp.c: revision 1.25
	sys/arch/x86/pci/fwhrng.c: revision 1.8
	sys/dev/ic/nslm7x.c: revision 1.61
	share/man/man9/callout.9: revision 1.28
Replace callout_stop with callout_halt
In order to call callout_destroy for a callout safely, we have to ensure
the function of the callout is not running and pending. To do so, we should
use callout_halt, not callout_stop.
Discussed with martin@ and riastradh@.
Make it clear that we should use not callout_stop but callout_halt
before callout_destroy
Replace callout_stop with callout_halt
In order to call callout_destroy for a callout safely, we have to ensure
the function of the callout is not running and pending. To do so, we should
use callout_halt, not callout_stop.
In this case, we need to pass an interlock to callout_halt to wait for
the callout complete.
Reviewed by riastradh@.
Kill sme_callout_mtx and use sme_mtx instead
We can use sme_mtx for the callout as well. Actually we should do so
because sme_events_list and some other data that are touched in the
callout should be protected by sme_mtx, not sme_callout_mtx.
Discussed with riastradh@ in
http://mail-index.netbsd.org/tech-kern/2014/11/11/msg017956.html
Replace callout_stop with callout_halt
In order to call callout_destroy for a callout safely, we have to ensure
the function of the callout is not running and pending. To do so, we should
use callout_halt, not callout_stop.
In this case, we need to pass an interlock to callout_halt to wait for
the callout complete. And also we make sure that SME_CALLOUT_INITIALIZED
is unset before calling callout_halt to prevent the callout from calling
callout_schedule. This is the same as what we did in sys/netinet6/mld6.c@1.61.
Reviewed by riastradh@.

Replace callout_stop with callout_halt

In order to call callout_destroy for a callout safely, we have to ensure
the function of the callout is not running and pending. To do so, we should
use callout_halt, not callout_stop.

Discussed with martin@ and riastradh@.

Rebase to HEAD as of a few days ago.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

sync with head

apply __diagused where appropriate.

sync with head

Sync with HEAD.

Commit is split, to avoid a "too many arguments" protocol error.

struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

sync with head.

Pull up following revision(s) (requested by mlelstv in ticket #684):
	sys/dev/ir/irframe_tty.c: revision 1.56
Avoid crash under LOCKDEBUG by destroying a mutex correctly.
Also: move mutex init/destroy into attach/detach functions and
handle case where line discipline is closed before the irframe
device. Fixes PR kern/40271.

Sync with HEAD.

Sync with HEAD.

Avoid crash under LOCKDEBUG by destroying a mutex correctly.
Also: move mutex init/destroy into attach/detach functions and
handle case where line discipline is closed before the irframe
device. Fixes PR kern/40271.

merge christos-time_t

account for major and minor being unsigned long long

Sync w/ -current. 34 merge conflicts to follow.

sync with head

Sync with HEAD.

file irframe_tty.c was added on branch christos-time_t on 2008-11-09 02:05:20 +0000

Properly fix the "hanging in tty" bug that was worked around with cv_wakeup()
some time again.

sync with head.

sync with head.

Remove clause 3 and 4 from TNF licenses

Sync with HEAD.

sync with head.

sync with HEAD

sync with head.

Split device_t and softc for irframe(4).

Welcome to 4.99.55:

- Add a lot of missing selinit() and seldestroy() calls.

- Merge selwakeup() and selnotify() calls into a single selnotify().

- Add an additional 'events' argument to selnotify() call.  It will
  indicate which event (POLL_IN, POLL_OUT, etc) happen.  If unknown,
  zero may be used.

Note: please pass appropriate value of 'events' where possible.
Proposed on: <tech-kern>

sync with head

sync with HEAD

Sync with HEAD

Sync with HEAD.

Sync with head.

__FUNCTION__ -> __func__

Sync with HEAD.

Sync with HEAD.

Sync with head.

sync with head

Do not "return 1" from kqfilter for errors.  That value is passed
directly to the userland caller and results in a mysterious EPERM.
Instead, return EINVAL or something else sensible depending on the
case.

lockmgr -> mutex

Sync with HEAD.

Sync with HEAD

- Factor out too many copies of the same bit of tty code.
- Fix another tty signalling/wakeup problem.

Sync with HEAD.

sync with head.

Sync with HEAD

Sync with HEAD.

Call ttyflush() with tty_lock held.

sync with -HEAD

Merge tty changes from the vmlocking branch.

Replace the tty locks with a global tty_lock.

sync with head.

Sync with head.

Merge some of the less invasive changes from the vmlocking branch:

- kthread, callout, devsw API changes
- select()/poll() improvements
- miscellaneous MT safety improvements

Adapt to callout API change.

Compile fixes.

Sync with HEAD.

In the pseudo-dev attach function, also try to register the struct cfdriver
of the backend irframe device with autoconf. This might fail or not,
depending on whether another frontend was configured. It helps if
irframetty is the only frontend.
This is a workaround for some inconsistencies in the interaction of
pseudo-devices with the autoconf framework. A fix will require changes
to config(8) which needs more consideration and testing.
Should fix a crash reported by Dieter Baron per PM.

clean up and fix irframe attachment as a line discipline:
make it a regular "bus frontend" in terms of configuration attachment
(this is something new: a device which can be real or pseudo device),
and use only autoconf functions considered exported.
This suffers a bit from the fact that pseudo-devices don't get "aux"
context data passed to the xxx_attach() function. This can be changed
easily; the differences between real and pseudo devices are diminishing...

Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

sync with head.

sync with head.

Sync with head.

__unused removal on arguments; approved by core.

sync with head

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

Fix compilation with IRFRAMET_DEBUG (use %zu/%zd for sizes).

Adapt MD code to KAUTH_DEVICE_TTY_OPEN, batch #2 from Matt Fleming, thanks!

Also, add forgotten splx() calls in some places.

sync with head

sync with head

- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

sync with head.

sync with head.

Sync with head.

stack police: Fix the biggest offender with ~4K stack, by allocating the
buffer in the softc.

Sync with head.

Merge 2006-05-24 NetBSD-current into the "peter-altq" branch.

sync with head.

integrate kauth.

Sync with head.

sync with head.

sync with head.

Merge 2006-03-31 NetBSD-current into the "peter-altq" branch.

Use device_unit().

sync with head.

generic_authorize() -> kauth_authorize_generic().

Adapt to kernel authorization KPI.

cleanup more SET/CLR/ISSET lossage

merge ktrace-lwp.

Sync with head.

sync with head.

Overhaul how TTY line disciplines are handled:
- Replace references to linesw[0] with a ttyldisc_default() function
  that returns the default ("termios") line discipline.
- The linesw[] array is gone, replaced by a linked list.
- ttyldisc_add() and ttyldisc_remove() have been replaced by
  ttyldisc_attach() and ttyldisc_detach().
- Things that provide line disciplines are now responsible for
  registering those disciplines with the system.  The linesw
  structures are no longer declared in tty_conf.c
- Line disciplines are now refcounted; a lookup causes a reference to
  be held.  ttyldisc_release() releases the reference.  Attempts to
  detach an in-use line discipline result in EBUSY.
- Fix function signature lossage in if_sl.c, if_strip.c, and tty_tb.c
  that was masked by the old tty_conf.c
- tty_init() is no longer necessary; delete it and its call from main().

Sync with HEAD. Here we go again...

- remove Static define
- avoid variable shadowing.

sync with -current

sync with head.  xen and whitespace.  xen part is not finished.

Sync with HEAD.

Hi Perry!

nuke trailing whitespace

Fix the sync with head I botched.

Sync with HEAD.

Sync with HEAD

add missing __KERNEL_RCSID()

Apply the aborted ktrace-lwp changes to a specific branch.  This is just for
others to review, I'm concerned that patch fuziness may have resulted in some
errant code being generated but I'll look at that later by comparing the diff
from the base to the branch with the file I attempt to apply to it.  This will,
at the very least, put the changes in a better context for others to review
them and attempt to tinker with removing passing of 'struct lwp' through
the kernel.

Back out the lwp/ktrace changes. They contained a lot of colateral damage,
and need to be examined and discussed more.

Pass lwp pointers throughtout the kernel, as required, so that the lwpid can
be inserted into ktrace records.  The general change has been to replace
"struct proc *" with "struct lwp *" in various function prototypes, pass
the lwp through and use l_proc to get the process pointer when needed.

Bump the kernel rev up to 1.6V

Rename struct frame to irt_frame to avoid name clash with struct frame
in <arm/arm32/frame.h>.

Sync with HEAD.

si_ -> sel_

Catch up to -current

merge kqueue branch into -current

kqueue provides a stateful and efficient event notification framework
currently supported events include socket, file, directory, fifo,
pipe, tty and device changes, and monitoring of processes and signals

kqueue is supported by all writable filesystems in NetBSD tree
(with exception of Coda) and all device drivers supporting poll(2)

based on work done by Jonathan Lemon for FreeBSD
initial NetBSD port done by Luke Mewburn and Jason Thorpe

sync kqueue with -current; this includes merge of gehenna-devsw branch,
merge of i386 MP branch, and part of autoconf rototil work

do not need the (void *) cast for kn_hook anymore

Catch up to -current.

Merge the gehenna-devsw branch into the trunk.

This merge changes the device switch tables from static array to
dynamically generated by config(8).

- All device switches is defined as a constant structure in device drivers.

- The new grammer ``device-major'' is introduced to ``files''.

	device-major <prefix> char <num> [block <num>] [<rules>]

- All device major numbers must be listed up in port dependent majors.<arch>
  by using this grammer.

- Added the new naming convention.
  The name of the device switch must be <prefix>_[bc]devsw for auto-generation
  of device switch tables.

- The backward compatibility of loading block/character device
  switch by LKM framework is broken. This is necessary to convert
  from block/character device major to device name in runtime and vice versa.

- The restriction to assign device major by LKM is completely removed.
  We don't need to reserve LKM entries for dynamic loading of device switch.

- In compile time, device major numbers list is packed into the kernel and
  the LKM framework will refer it to assign device major number dynamically.

No longer need to pull in lwp.h; proc.h pulls it in for us.

Curproc->curlwp renaming.

Change uses of "curproc->l_proc" back to "curproc", which is more like the
original use. Bare uses of "curproc" are now "curlwp".

"curproc" is now #defined in proc.h as ((curlwp) ? (curlwp)->l_proc) : NULL)
so that it is always safe to reference curproc (*de*referencing curproc
is another story, but that's always been true).

catch up with -current on kqueue branch

Use devsw API instead of accessing to devsw table.

Catch up to -current.
(CVS: It's not just a program. It's an adventure!)

Convert ioctl code to use EPASSTHROUGH instead of -1 or ENOTTY for
indicating an unhandled "command".  ERESTART is -1, which can lead to
confusion.  ERESTART has been moved to -3 and EPASSTHROUGH has been
placed at -4.  No ioctl code should now return -1 anywhere.  The
ioctl() system call is now properly restartable.

Add kqueue support to the IrDA framework.

LWPify.

Catch up to -current.
(hate cvs. hate hate hate.)

file irframe_tty.c was added on branch kqueue on 2002-01-10 18:29:12 +0000

file irframe_tty.c was added on branch nathanw_sa on 2002-01-08 17:26:01 +0000

Be a little more paranoid.

Don't forget to call start routine in dongle manipulation.

Rearrange code that wiggles modem control lines so it actually reaches
the com port driver.

Rearrage softc a little.

Fix TODO comment.

Move parameter checks to a common place.

Add missing delay for the tekram dongle.

Don't use timeout 0 to tsleep() when the time is short.

Don't crash on early calls to get the speeds.

Add dongle specific code.

Break out SIR framing to its own file.

Put bytes on right q.

Fix some minor bug.
Add more debugging.

Mention that much of the code was stolen from Tommy Bohlin.

Add some dongle support ioctl()s.

Change speed setting a little.

Implement speed setting.

Implement input processing (untested).

Add irframetty driver for IrDA frames over serial lines.
THIS MOST DEFINITELY DOES NOT WORK.  IT'S VERY INCOMPLETE.