CVS log for src/sys/dev/ic/ncr5380sbc.c

Up to [cvs.NetBSD.org] / src / sys / dev / ic

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

A simpler fix for handling aborted requests.

From riastradh@.

Revert to previous - scsipi_done_once is not necessary.

A follow up commit will contain a simpler change (from riastradh@) to
ncr5380sbc.

Introduce scsipi_done_once.

This allows for transfers to be sucessfully aborted on the ncr5380sbc(4).

This may be usefull in future for other scsi controllers.

Callers of scsipi_done are not affected by this change.

Part of kern/58452.

As posted to tech-kern:
https://mail-index.netbsd.org/tech-kern/2024/08/02/msg029652.html

Ok thorpej@.

Avoid spamming console with abort messages.

This is common when using a device such as dse(4) and is a harmless message.

Part of kern/58452.

As posted to tech-kern:
https://mail-index.netbsd.org/tech-kern/2024/08/02/msg029652.html

Ok thorpej@.

Abort current request upon reset.

Part of kern/58452.

As posted to tech-kern:
https://mail-index.netbsd.org/tech-kern/2024/08/02/msg029652.html

Ok thorpej@.

Merge thorpej-cfargs2.

Adapt to CFARGS().

Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
  actually needed.
- Don't be explicit about what interface attribute is attaching if
  the device only has one.  (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
  situations, making is visibly easier to see when indirect config is
  in play, and allowing for future change in semantics.  (As of now,
  this is just a wrapper around config_match(), but that is an
  implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance.  This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

Give config_found() the same variadic arguments treatment as
config_search().  This commit only adds the CFARG_EOL sentinel
to the existing config_found() calls.  Conversion of config_found_sm_loc()
and config_found_ia() call sites will be in subsequent commits.

update from HEAD

Sync with HEAD

Sync with HEAD

adatper -> adapter

sync with head

Fix -fno-common found by building i386/conf/ALL

sync with head

Sync with HEAD.

sync with head.

Make debugging code compile on LP64.

sync with head

Remove some unecessary includes sys/user.h header.

Sync with HEAD.

Split devict_t/softc for ncr5380sbc SCSI, and misc cosmetic changes.

Sync with head.

sync with head.

sync with head.

fix spelling of accommodate; from Zapher.

Sync with head.

__unused removal on arguments; approved by core.

sync with head

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

sync with head

sync with head.

Fix all the -D*DEBUG* code that it was rotting away and did not even compile.
Mostly from Arnaud Lacombe, many thanks!

sync with head.

Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

Sync with HEAD. Here we go again...

Add a const. Fixes part of PR kern/30403.

sync with -current

sync with head.  xen and whitespace.  xen part is not finished.

Sync with HEAD.

Hi Perry!

nuke trailing whitespace

sync with head.

Sync with HEAD.

de-__P

Fix the sync with head I botched.

Sync with HEAD.

Enclose initialization of NCR_VARIANT_NCR53C400 in an ifdef on
NCR5380_USE_BUS_SPACE, to make this build again on acorn32, mac68k,
pc532, and sun3.  This is done under the assumption that it's
somewhat doubtful that any of those machines will encounter that
chip variant.

The acorn32 and mac68k parent drivers (csa and sbc) are listed in
ncr5380var.h as "easy to convert", but it's evident that noone have
stepped up to that challenge yet.  Sun3 and pc532 needs bus.h first,
which they apparently don't have at the moment.

Sync with HEAD.

For the c400, set 5380 compatibility mode on every pass through the reset
routine.  The PCMCIA attachment, at least, needs this.

Sync with HEAD

Fix gcc332 uninitialised bogon.

Fix some typos. From Tom Cosgrove via jmc@openbsd.

DMA, not dma nor Dma.

catch up with -current on kqueue branch

Catch up to -current.

Implement mstohz() as discussed on tech-kern, and use it in SCSI drivers
to convert xs->timeout to callout() parameter.

Sync kqueue branch with -current.

Catch up to -current.

Use bus_space on sun2.
Update the comment to match list of bus_space-using ports.
Removed some old unused asm() labels.

don't need <sys/types.h> when including <sys/param.h>

Catch up to -current.

add/cleanup RCSID

Sync the thorpej-mips-cache branch with -current.

Use common macro to check message length.

Catch up with -current.

Correct various misspellings of 'transfer' and inflected forms.

bzero -> memset

Catch up to -current.

Use the new generic mechanism for forcing polling on a SCSI interface, rather
than doing it ourselves.

Pull up the thorpej_scsipi branch to main branch.
This is a completely rewritten scsipi_xfer execution engine, and the
associated changes to HBA drivers. Overview of changes & features:
- All xfers are queued in the mid-layer, rather than doing so in an
  ad-hoc fashion in individual adapter drivers.
- Adapter/channel resource management in the mid-layer, avoids even trying
  to start running an xfer if the adapter/channel doesn't have the resources.
- Better communication between the mid-layer and the adapters.
- Asynchronous event notification mechanism from adapter to mid-layer and
  peripherals.
- Better peripheral queue management: freeze/thaw, sorted requeueing during
  recovery, etc.
- Clean separation of peripherals, adapters, and adapter channels (no more
  scsipi_link).
- Kernel thread for each scsipi_channel makes error recovery much easier
  (no more dealing with interrupt context when recovering from an error).
- Mid-layer support for tagged queueing: commands can have the tag type
  set explicitly, tag IDs are allocated in the mid-layer (thus eliminating
  the need to use buggy tag ID allocation schemes in many adapter drivers).
- support for QUEUE FULL and CHECK CONDITION status in mid-layer; the command
  will be requeued, or a REQUEST SENSE will be sent as appropriate.

Just before the merge syssrc has been tagged with thorpej_scsipi_beforemerge

Sync with HEAD

Remove the use of splimp() from the NetBSD kernel.  splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

Leave handling of SCSI_CHECK to middle-layer.

make it compile

req_sense_length is dead.

Update thorpej_scsipi to -current as of a month ago
A i386 GENERIC kernel compiles without the siop, ahc and bha drivers
(will be updated later). i386 IDE/ATAPI and ncr work, as well as
sparc/esp_sbus. alpha should work as well (untested yet).
siop, ahc and bha will be updated once I've updated the branch to current
-current, as well as machine-dependant code.

Sync w/ netbsd-1-5-base.

sun3 always defines Debugger(), so don't redefine it.

Fix for a driver bug provided by Jon W Grubbs (jgrubbs@megsinet.net).

This bug is only visible on some disks, and I have verified that it works
correctly on VAX. However, du to the author, it is a problem on other
machines/disks as well. Here's the author's comments:

> The MI code for the NCR5380 has a small bug in it  The RZ56 wants to
> negotiate for Synchronous Data Transfers and when it does, the current code
> looks like it will send a REJECT message as the spec calls for when we cant
> handle the request.  However, a couple of lines of code in the
> ncr5380_msg_in routine are missing wrt the PARITY message and anything that
> wants to send a REJECT message.  The ATN setup that is done in
> ncr_sched_msgout is immediately negated by the final byte ACK sequence in
> this routine.  This causes bad things to happen to an RZ56.

Remove "register" declaration.

Add a "sc_rev" member to ncr5380_softc and handle CXD1180 quirk
in MI ncr5380sbc.

New callout mechanism with two major improvements over the old
timeout()/untimeout() API:
- Clients supply callout handle storage, thus eliminating problems of
  resource allocation.
- Insertion and removal of callouts is constant time, important as
  this facility is used quite a lot in the kernel.

The old timeout()/untimeout() API has been removed from the kernel.

Change footprint of ncr5380_intr() to match normal interrupt handler usage.

Add a ncr5380_attach() routine which does part of the initialization, attaches
the scsibus, and does the addref/delref dance.

Fixup the SC_DEBUG() stuff for the new world order.

Update for:

  Deal a little more gracefully with the fact that xfer mode parameters
  are for the I_T Nexus, and make all xfer mode updates `async events'.

Adapt to scsipi API changes.

Update for SCSPI changes.

Update HBAs to incorporate the new max_lun property.

Update for changes to NCR5380_READ() and NCR5380_WRITE().

PR/6274: John Ruschmeyer: Add support for the ncr53c80 driver on the i386.

Revert the last change:  returning COMPLETE is clearly the wrong thing to do
if we weren't polling to begin with.

Correct a serious problem that affects at least front ends that can only
use PIO (or equivalent) code to do asynchronous transfers:  In
ncr5380_scsi_cmd(), test to see if the request has been completed after
the call to ncr5380_sched(), and return COMPLETE if so.  This avoids
going into an infinite loop in scsipi_execute_xs() while waiting for an
interrupt to trigger completion of the transfer... which, of course,
never happens, since it's already done.

defopt DDB.

Fix typo in a trace message expression.

Update marc-pcmcia branch from trunk.

Fix a couple of field references missed during the scsipi merge.

Update marc-pcmcia branch from trunk.

Merge scsipi branch in the mainline. This add support for ATAPI devices
(currently only CD-ROM drives on i386). The sys/dev/scsipi system provides 2
busses to which devices can attach (scsibus and atapibus). This needed to
change some include files and structure names in the low level scsi drivers.

Updates for new scsipi subsystem. Actally known to work on i386 and sparc.

Fix a debugging printf() format.

Work around an ambiguity in the SCSI spec.  Some implementations,
particularly older ones, don't do a SAVE DATA POINTER before disconnecting.
When the driver reconnects, it does an implicit RESTORE POINTERS, and
restores the data pointer from *before* the last transfer.  If the driver
calculates the residual using the data pointer and doesn't account for
this, the residual will be wrong.

What we do is test for the SDEV_AUTOSAVE quirk when we see a disconnect
message, falling through to do a SAVE DATA POINTER if the quirk applies
to this target.

The workaround was suggested by Mycroft, who also provided the explanation
of the problem.  Actual code was (mostly) ripped off from the 53C9x driver.

No longer need the hack that forced SCSI_POLL when cold.

Merge in changes from Trunk

Fix a couple of splhigh()s that should be splbio().

Use sc_no_disconnect (per-target) instead of NCR5380_PERMIT_RESELECT.

Integrate fix for rude targets that transfer more data than requested.
(From Matthias Pfaller).

Make this compile #ifdef DDB:

 - Prototype debugging functions
 - Replace %x and %lx with %p as appropriate

Fill in sc_link.max_target

backout kprintf changes

- printf -> kprintf, sprintf -> ksprintf

Fix printf() statement argument order

Add a new member to the softc (sc_parity_disable) with per-target
bits that tell the driver not to expect parity from those targets.
XXX: For now, it is up to MD code to set this mask.  Eventually,
XXX: we should identify targets first (without demanding parity)
XXX: and then use a new "SCSI quirk" to set the right bit.

Deal with devices that are slow to get off the bus.

prototypes for ccd audio and ncr5380

Replace DEBUG with NCR5380_DEBUG and do not define it by default.

Kill two mis-matched and unnecessary declarations.

fix a trace message

Do not mark target/LUN busy until we commit to working with it,
after the check for reselections.  (From Matthias Pfaller, PR 2105)
Also improve the selection code WRT concurrent reselection.

vnd.c: Typo (disk_deta{t,}ch) It was detach in the header file and
       detatch everywhere else. Reverted to the english spelling.
       Also fixed the rest of the prototype warnings while I was at it.
ic/ncr5380sbc.c: Don't declare Debugger()... I have to clean this
		 everywhere :-(

Use the function pointers sc_pio_in, sc_pio_out to call the PIO functions
for transfers in data phase so those functions may be MD implementations
that do "pseudo-DMA" if desired.  Also correct some comments.

Switch to David Jones' new machine-independent NCR5380 driver.  It's been
in use by the sun3 port for some time, and is now used by the sparc port.