CVS log for src/sys/dev/i2c/dbcool.c

Up to [cvs.NetBSD.org] / src / sys / dev / i2c

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Remove unnecessary include of <sys/malloc.h>.

These modules need to depend on iic, not just on i2cexec.  (They will
still recursively get i2cexec since the iic depends on it.)

Partial fix for kern/56772

Remove unnecessary references to i2c_attach_args::ia_prop and mark the ones
that remain as XXX.

fix various typos in compatibility, mainly in comments.

Sync with HEAD.

fix proplib deprecation

Sync w/ HEAD.

avoid double-free

Sync with HEAD.

If we're going to keep a reference on the "props" dictionary from
the i2c_attach_args, we should retain it.

Use DEVICE_COMPAT_EOL.

Since we're using designated initialisers for compat data, we should
use a completely empty initializer for the sentinel.

Use designated initializers and a consistent termination style in
compat_data[].

in sysctl_dbcool_behavior() - actually use the array index when translating
text from sysctl -w *.behavior=<whatever>
now this actually works on my sb2500's two adm1030s

get sensor names from device properties if possible

Sync with HEAD

Change a aprint_verbose into aprint_debug - the message does not add
real value to the dmesg(8) output.

- dbcool_pmf_suspend() set the wrong bit out of the suspended data as
  it is stored as a bool and thus when bit 2 was wanted, bit 1 was
  restored.  found by GCC7's "don't use ~ on bool" checker.
- consolidate the dbcool_pmf_suspend()/dbcool_pmf_resume() guts in to
  a shared function dbcool_do_pmf() as they are identical except for
  1 vs 2 lines.

Sync with HEAD

In my quest to make device_compatible_entry (and associated goo)
super-general, it turns out I also made it a little to cumbersome
to use (if my tired fingers are any indication).  So, this is a
course-correction -- one string per entry (like of_compat_data,
which it will soon replace), and remove the over-verbose macros.

Sync with HEAD

Add a kernel panic when we matched but can not handle a string - better
die explicitly instead of crashing a few lines later with strange NULL
derefs.

- Rename iic_compat_match() to iic_compatible_match() and change it
  to use the new device_compatible_match() routine.  A pointer to
  the matching device_compatible_entry is returned if a match is
  found.
- Adjust iic_use_direct_match() accordingly.
- i2c drivers now provide device_compatible_entry tables when performing
  direct-config matching.
- In the dsrtc driver, take advantage of this new capability to greatly
  simplify model selection.

(I'm coming for you next, of_compat_data...)

More cleanup to i2c autoconfiguration:

- Get all of the drivers onto the new match quality constants.
- Introduce a new helper function, iic_use_direct_match(), that has
  all of the logic for direct-config matching.  If it returns true,
  the driver returns the match result (which may be 0).  If it returns
  false, the driver does indirect-config matching.
- iic_compat_match() now returns a weighted match quality; matches to
  lower-indexed "compatible" device property are more-specific matches,
  and return a better match quality accordingly.

dbcool_read_volt() has a missing {} issue.

update from HEAD

add more names for direct config

Sync with HEAD

Fix compile error.

KNF. No functional change.

Sync with HEAD (as of 26th Dec)

Add direct configuration support via compatible names.

Sync with HEAD

Update module dependencies for all the existing modules that depend on sysmon components.

Sync with HEAD

Pull up following revision(s) (requested by jmcneill in ticket #634):
	distrib/sets/lists/modules/md.amd64: revision 1.51
	distrib/sets/lists/modules/md.evbppc.powerpc: revision 1.5
	distrib/sets/lists/modules/md.i386: revision 1.55
	distrib/sets/lists/modules/mi: revision 1.71
	sys/dev/i2c/au8522.c: revision 1.7
	sys/dev/i2c/cx24227.c: revision 1.7
	sys/dev/i2c/dbcool.c: revision 1.42
	sys/dev/i2c/hytp14.c: revision 1.3
	sys/dev/i2c/i2c_exec.c: revision 1.10
	sys/dev/i2c/lg3303.c: revision 1.9
	sys/dev/i2c/mt2131.c: revision 1.5
	sys/dev/i2c/nxt2k.c: revision 1.4
	sys/dev/i2c/sdtemp.c: revision 1.24
	sys/dev/i2c/spdmem_i2c.c: revision 1.10
	sys/dev/i2c/tvpll.c: revision 1.6
	sys/dev/i2c/xc3028.c: revision 1.7
	sys/dev/i2c/xc5k.c: revision 1.6
	sys/dev/i2c/zl10353.c: revision 1.4
	sys/modules/Makefile: revision 1.143
	sys/modules/i2cexec/Makefile: revision 1.1
i2c devices don't actually have a dependency on "iic" (the bus driver)
but on "i2cexec". Create an i2cexec module (i2c_exec.c) to mirror the
dependencies in files.i2c and switch device drivers to depend on "i2cexec"
module instead.
A kernel with a USB stack and no I2C controller / bus attachment would spit
out a bunch of "WARNING: module error: can't find builtin dependency `iic'"
messages at boot. This change solves that problem.

i2c devices don't actually have a dependency on "iic" (the bus driver)
but on "i2cexec". Create an i2cexec module (i2c_exec.c) to mirror the
dependencies in files.i2c and switch device drivers to depend on "i2cexec"
module instead.

A kernel with a USB stack and no I2C controller / bus attachment would spit
out a bunch of "WARNING: module error: can't find builtin dependency `iic'"
messages at boot. This change solves that problem.

Rebase to HEAD as of a few days ago.

Merge tls-earlyentropy branch into HEAD.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

sync with head

Be a little more clear and consistent about harvesting entropy from devices:

1) deprecate RND_FLAG_NO_ESTIMATE

2) define RND_FLAG_COLLECT_TIME, RND_FLAG_COLLECT_VALUE

3) define RND_FLAG_ESTIMATE_TIME, RND_FLAG_ESTIMATE_VALUE

4) define RND_FLAG_DEFAULT: RND_FLAG_COLLECT_TIME|
   RND_FLAG_COLLECT_VALUE|RND_FLAG_ESTIMATE_TIME

5) Make entropy harvesting from environmental sensors a little more generic
   and remove it from individual sensor drivers.

6) Remove individual open-coded delta-estimators for values from a few
   places in the tree (uvm, environmental drivers).

7) 0 -> RND_FLAG_DEFAULT, actually gather entropy from various drivers
   that had stubbed out code, other minor cleanups.

Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.

Remove unused variables

sync with head

Add some pre-processor magic to verify that the type of the data item
  passed to sysctl_createv() actually matches the declared type for
  the item itself.
In the places where the caller specifies a function and a structure
  address (typically the 'softc') an explicit (void *) cast is now needed.
Fixes bugs in sys/dev/acpi/asus_acpi.c sys/dev/bluetooth/bcsp.c
  sys/kern/vfs_bio.c sys/miscfs/syncfs/sync_subr.c and setting
  AcpiGbl_EnableAmlDebugObject.
(mostly passing the address of a uint64_t when typed as CTLTYPE_INT).
I've test built quite a few kernels, but there may be some unfixed MD
  fallout. Most likely passing &char[] to char *.
Also add CTLFLAG_UNSIGNED for unsiged decimals - not set yet.

sync to latest -current.

Update handling of sysctl stuff when built as modules

sync with head.

sync to latest -current.

Fix logical errors (&& instead of & in a few places).

now that iic is a module, add "iic" dependency to iic drivers

fix gcc-4.5 warnings

When detaching the device, tear down its sysctl tree.

appease gcc 4.5

modularize

Catchup with rmind-uvmplock merge.

Initialize sensor state before registering.

XXX Still need to fix i2c/ibmhawk.c

Sync with HEAD.

sync with head

Fix another instance of the same typo in the same comment!  dosn't -->
doesn't

Thanks again, Jukka!

Fix typo in previous - dosn't --> doesn't

Thanks, Jukka!

Add support for SMSC EMC6D103S

From jasper@pointless.net in PR kern/44685

sync with head

Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants.  These are provided by sys/param.h now.

Sync with HEAD (-D20101022).

sync with head

Use SYSCTL_DESCR()

sync with head.

sync with head

Sync with HEAD.

Save initial, boot-time limit values, and restore them upon request
from sysmon_envsys(9).

don't divide by zero. ever.

add some more ADM1031 support:
- additional temperature and fan speed sensors work now
- limits on should work on all temperature sensors
Controlling fan behaviour doesn't work yet, the ADM1031 uses the same
register for both fans which doesn't quite fit with the way the dbcool
driver works.

Add preliminary support for the ADM1031 found in the Sun Blade 2500 and similar
machines. For now we treat it like an ADM1030 - the only difference is the
device ID and a few previously reserved registers.

Use correct format directive in aprint_debug_dev()

Thanks to Kurt Schreiner for reporting this on current-users@

Fix the dbcool_{get,set}_limits() routines to properly deal with min/max
values on temp limits.  The actual ranges for temp limits varies if the
chip is running in "extended temperature" mode, so we need to handle this
difference, too.

Verified on my home machine which runs in extended-temp mode and by
njoly@ on a machine which does runs in the older 2s-complement mode.

sync with head

Now that sysmon_envsys(8) has learned how to retrieve and update sensor
limit values from the device driver, remove the high_limit and low_limit
entries from the hw.dbcool<#>.<sensor> sysctl(8) tree.  These limits are
now directly accessible via envstat(8).  Simplify the remaining code
somewhat.

No objections raised on either tech-kern@ or current-users@

XXX The fan controllers's parameters (including those that are tied to
XXX temperature sensors) are still in sysctl, since there isn't any clean
XXX way to implement the fan controllers in sysmon_envsys yet.  It is on
XXX my To-Do list...

Disable DBCOOL_DEBUG by default, and make it compile that way.

Fix handling of 6bit VID register (6th bit takes place of 12VIn sensor).

Move VID out of sysctl tree - make it a separate sensor of type INTEGER.

Clean-up some of the chip-descriptors.

A pointer typedef entails trading too much flexibility to declare const
and non-const types, and the kernel uses both const and non-const
PMF qualifiers and device suspensors, so change the pmf_qual_t and
device_suspensor_t typedefs from "pointers to const" to non-pointer,
non-const types.

Expand PMF_FN_* macros.

don't pull a 1.5K softc on the stack to do a chip ident. Idea from mrg.

Sync with HEAD.

sync with head

Since we no longer have individual events for each sensor value limit,
we don't need individual flag bits.  Clean up extra bit definitions.
Bump kernel version - welcome to 5.99.13

Sync with HEAD.

Commit is split, to avoid a "too many arguments" protocol error.

sync with head.

Sync with HEAD.

file dbcool.c was added on branch yamt-nfs-mp on 2009-05-04 08:12:38 +0000

Previous check for ADM1027 caused a kernel panic, since the read routine
can be called _before_ we've identified the chip.  Ensure that sc_chip
is initialized to NULL before chip is identified, and if it is NULL or
ADM1027, use the less-efficient send_byte/receive_byte.

While here, don't attempt to release the i2c bus if we failed to acquire
it.  This would cause a panic on a LOCKDEBUG kernel.

Thanks to Nicholas Joly for pointing out both of these bugs.

The ADM1027 chip doesn't support i2c read_byte protocol, so in this
case we use send_byte followed by receive_byte.

Use pre-scripted i2c protocols rather than re-inventing our own.  No
functional change intended.

While here, change some indentation to use tabs vs spaces.

Sync with HEAD.

Sync with HEAD.

Pull up following revision(s) (requested by pgoyette in ticket #269):
	sys/dev/i2c/dbcool.c: revision 1.8
Include ADT7460 in chip table (it's identical to the ADT7463, except for
physical packaging).

Include ADT7460 in chip table (it's identical to the ADT7463, except for
physical packaging).

Pull up following revision(s) (requested by pgoyette in ticket #195):
	sys/dev/i2c/dbcool.c: revision 1.7
	sys/dev/i2c/dbcool_reg.h: revision 1.3
Add i2c bus address checking for these chips.  All supported chips live
at predefined addresses 0x2c, 0x2d, or 0x2e.

Add i2c bus address checking for these chips.  All supported chips live
at predefined addresses 0x2c, 0x2d, or 0x2e.

Update haad-dm branch to haad-dm-base2.

Pull up following revision(s) (requested by jnemeth in ticket #82):
	sys/dev/i2c/dbcool.c: revision 1.6
PR/39947 - Juan RP -- dbcool_detach implicitly called
sysmon_envsys_destroy() twice

PR/39947 - Juan RP -- dbcool_detach implicitly called
  sysmon_envsys_destroy() twice

Sync with HEAD.

file dbcool.c was added on branch haad-dm on 2008-10-19 22:16:24 +0000

Move the {read,write}reg() routine addresses into the dbcool_softc so
that we can use different routines for macppc's ki2c attachment.  Fixes
problems reported by Robert Fritzsche on current-users@ list.

Sync with HEAD.

file dbcool.c was added on branch wrstuden-revivesa on 2008-10-10 22:30:58 +0000

sysctl doesn't like names that start with digits, nor does it like names
with embedded '.' so change the names to be better-conforming.  Reported
by njoly

Increase accuracy in nominal voltage table.

Various clean-ups:
  1. Trange sysctl's belong to the temp sensors, not to the fan controllers
  2. Trange really describes a slope on many chips, so modify the description
  3. Most of the sysctl's are read/write even if the chip's config is
     locked;  reflect that in the CTLFLAGs
  4. Apply correct 'nominal' values for voltage sensors/limits, specify
     them in microVolts, and calculate once rather than each time needed
  5. Be more consistent in register names - for example, use VCC instead of
     SUPPLY_VOLTAGE, to match VCC_LOWLIM & VCC_HIGHLIM
  6. Type of dbcool_islocked() should be bool, not int
  7. Reduce some unnecessary code indentation
  8. Define Vtt and Imon, and add ADT7490 support (excluding PECI sensors)
  9. Split the huge (250+ lines) dbcool_setup() function into a few smaller
     routines for better readability
 10. Update sensor tables for ADT7476 and ADT7468 - these chips have five
     voltage sensors, not two
 11. Adjust flags for ADT7463 and ADM1027 - these chips can monitor CPU
     VID data bits
 12. Update man page

Sync with HEAD.

file dbcool.c was added on branch mjf-devfs2 on 2008-10-05 20:11:29 +0000

Add new driver for dbCool(tm) family of Thermal Monitor and Fan Controller.
Supported chips: ADM1027, ADM1030, ADT7463, ADT7466, ADT7467, ADT7468,
ADT7473, ADT7475, and ADT7476.  Notably missing is the ADT7490, and fan
controller support on the ADT7466 is still on the to-do list.

Tested by myself and njoly@
Reviewed by garbled@
Commit approved by christos@, bouyer@, cube@, and matt@