CVS log for src/sys/dev/acpi/acpi_display.c

Up to [cvs.NetBSD.org] / src / sys / dev / acpi

Request diff between arbitrary revisions

Default branch: MAIN

Revision 1.22 / (download) - annotate - [select for diffs], Sun Feb 27 21:21:51 2022 UTC (11 months ago) by riastradh
Branch: MAIN
CVS Tags: netbsd-10-base, netbsd-10, bouyer-sunxi-drm-base, bouyer-sunxi-drm, HEAD
Changes since 1.21: +73 -3 lines
Diff to previous 1.21 (colored)

acpivga(4): Provide hooks for ACPI display notifications.

The Intel i915 graphics driver needs to receive ACPI VGA 0x80
notifications, but with NetBSD's ACPI API, each ACPI node -- such as
the VGA node -- can only have one notifier attached, and acpivga(4)
already uses it.

Revision 1.16.16.3 / (download) - annotate - [select for diffs], Thu Jan 20 11:42:22 2022 UTC (12 months, 2 weeks ago) by martin
Branch: netbsd-9
CVS Tags: netbsd-9-3-RELEASE
Changes since 1.16.16.2: +36 -24 lines
Diff to previous 1.16.16.2 (colored) to branchpoint 1.16 (colored) next main 1.17 (colored)

Pull up following revision(s) (requested by riastradh in ticket #1399):

	sys/dev/acpi/acpi_display.c: revision 1.21

acpiout(4): Work around firmware that doesn't like some brightnesses.

Instead of just asking for cur - 5 or cur + 5, repeatedly ask for
that increment, check whether we actually made progress in that
direction, and if not keep going with another increment, until we hit
the bounds of brightness levels.

I can't find anything in the ACPI spec about this, but my laptop
seems to have trouble with certain levels: 15, 75, 85, 95.  It goes
in all other increments of 5 from 5 to 100, just not those ones --
acts as if the change just never happened, so with the old logic the
brightness up/down would get stuck unable to move in either
direction.

This should have no impact on machines where the first increment
actually takes.

Revision 1.21 / (download) - annotate - [select for diffs], Thu Dec 30 14:40:06 2021 UTC (13 months ago) by riastradh
Branch: MAIN
Changes since 1.20: +36 -24 lines
Diff to previous 1.20 (colored)

acpiout(4): Work around firmware that doesn't like some brightnesses.

Instead of just asking for cur - 5 or cur + 5, repeatedly ask for
that increment, check whether we actually made progress in that
direction, and if not keep going with another increment, until we hit
the bounds of brightness levels.

I can't find anything in the ACPI spec about this, but my laptop
seems to have trouble with certain levels: 15, 75, 85, 95.  It goes
in all other increments of 5 from 5 to 100, just not those ones --
acts as if the change just never happened, so with the old logic the
brightness up/down would get stuck unable to move in either
direction.

This should have no impact on machines where the first increment
actually takes.

Revision 1.20 / (download) - annotate - [select for diffs], Sat Aug 7 16:19:09 2021 UTC (17 months, 4 weeks ago) by thorpej
Branch: MAIN
CVS Tags: thorpej-i2c-spi-conf2-base, thorpej-i2c-spi-conf2
Changes since 1.19: +3 -3 lines
Diff to previous 1.19 (colored)

Merge thorpej-cfargs2.

Revision 1.19.8.1 / (download) - annotate - [select for diffs], Wed Aug 4 17:24:17 2021 UTC (18 months ago) by thorpej
Branch: thorpej-cfargs2
Changes since 1.19: +3 -3 lines
Diff to previous 1.19 (colored) next main 1.20 (colored)

Adapt to CFARGS().

Revision 1.19 / (download) - annotate - [select for diffs], Sat Apr 24 23:36:52 2021 UTC (21 months, 1 week ago) by thorpej
Branch: MAIN
CVS Tags: thorpej-i2c-spi-conf-base, thorpej-i2c-spi-conf, thorpej-futex2-base, thorpej-futex2, thorpej-cfargs2-base, cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Branch point for: thorpej-cfargs2
Changes since 1.18: +4 -4 lines
Diff to previous 1.18 (colored)

Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
  actually needed.
- Don't be explicit about what interface attribute is attaching if
  the device only has one.  (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
  situations, making is visibly easier to see when indirect config is
  in play, and allowing for future change in semantics.  (As of now,
  this is just a wrapper around config_match(), but that is an
  implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance.  This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

Revision 1.18.4.1 / (download) - annotate - [select for diffs], Tue Mar 23 07:14:52 2021 UTC (22 months, 1 week ago) by thorpej
Branch: thorpej-cfargs
Changes since 1.18: +4 -4 lines
Diff to previous 1.18 (colored) next main 1.19 (colored)

Convert config_found_ia() call sites where the device only carries
a single interface attribute to bare config_found() calls.

Revision 1.16.16.2 / (download) - annotate - [select for diffs], Tue Jun 30 18:45:18 2020 UTC (2 years, 7 months ago) by martin
Branch: netbsd-9
CVS Tags: netbsd-9-2-RELEASE, netbsd-9-1-RELEASE
Changes since 1.16.16.1: +4 -4 lines
Diff to previous 1.16.16.1 (colored) to branchpoint 1.16 (colored)

Pull up following revision(s) (requested by sborrill in ticket #978):

	sys/dev/acpi/acpi_display.c: revision 1.18

Only need to set brightness if reading the initial state fails
to sync firmware and the driver. Avoids black screen at boot time.

Thanks to jmcneill@

Revision 1.16.2.1 / (download) - annotate - [select for diffs], Tue Jun 30 17:41:01 2020 UTC (2 years, 7 months ago) by martin
Branch: netbsd-8
Changes since 1.16: +4 -4 lines
Diff to previous 1.16 (colored) next main 1.17 (colored)

Pull up following revision(s) (requested by sborrill in ticket #1563):

	sys/dev/acpi/acpi_display.c: revision 1.18

Only need to set brightness if reading the initial state fails
to sync firmware and the driver. Avoids black screen at boot time.

Thanks to jmcneill@

Revision 1.18 / (download) - annotate - [select for diffs], Tue Jun 30 13:14:21 2020 UTC (2 years, 7 months ago) by sborrill
Branch: MAIN
CVS Tags: thorpej-futex-base, thorpej-futex, thorpej-cfargs-base
Branch point for: thorpej-cfargs
Changes since 1.17: +4 -4 lines
Diff to previous 1.17 (colored)

Only need to set brightness if reading the initial state fails
to sync firmware and the driver. Avoids black screen at boot time.
Thanks to jmcneill@

Revision 1.16.16.1 / (download) - annotate - [select for diffs], Wed Apr 29 13:36:57 2020 UTC (2 years, 9 months ago) by martin
Branch: netbsd-9
Changes since 1.16: +4 -4 lines
Diff to previous 1.16 (colored)

Pull up following revision(s) (requested by jmcneill in ticket #867):

	sys/dev/acpi/acpi_display.c: revision 1.17

Demote "unknown output device" message from error to debug, and change
the wording to reflect what is really happening -- the display output is
not connected.

Revision 1.17 / (download) - annotate - [select for diffs], Tue Apr 28 11:02:37 2020 UTC (2 years, 9 months ago) by jmcneill
Branch: MAIN
Changes since 1.16: +4 -4 lines
Diff to previous 1.16 (colored)

Demote "unknown output device" message from error to debug, and change
the wording to reflect what is really happening -- the display output is
not connected.

Revision 1.10.2.2 / (download) - annotate - [select for diffs], Sun Dec 3 11:36:58 2017 UTC (5 years, 2 months ago) by jdolecek
Branch: tls-maxphys
Changes since 1.10.2.1: +36 -35 lines
Diff to previous 1.10.2.1 (colored) to branchpoint 1.10 (colored) next main 1.11 (colored)

update from HEAD

Revision 1.12.2.3 / (download) - annotate - [select for diffs], Mon Aug 28 17:52:01 2017 UTC (5 years, 5 months ago) by skrll
Branch: nick-nhusb
Changes since 1.12.2.2: +2 -32 lines
Diff to previous 1.12.2.2 (colored) to branchpoint 1.12 (colored) next main 1.13 (colored)

Sync with HEAD

Revision 1.16 / (download) - annotate - [select for diffs], Thu Jun 1 02:45:09 2017 UTC (5 years, 8 months ago) by chs
Branch: MAIN
CVS Tags: tls-maxphys-base-20171202, phil-wifi-base, phil-wifi-20200421, phil-wifi-20200411, phil-wifi-20200406, phil-wifi-20191119, phil-wifi-20190609, phil-wifi, pgoyette-compat-merge-20190127, pgoyette-compat-base, pgoyette-compat-20190127, pgoyette-compat-20190118, pgoyette-compat-1226, pgoyette-compat-1126, pgoyette-compat-1020, pgoyette-compat-0930, pgoyette-compat-0906, pgoyette-compat-0728, pgoyette-compat-0625, pgoyette-compat-0521, pgoyette-compat-0502, pgoyette-compat-0422, pgoyette-compat-0415, pgoyette-compat-0407, pgoyette-compat-0330, pgoyette-compat-0322, pgoyette-compat-0315, pgoyette-compat, perseant-stdc-iso10646-base, perseant-stdc-iso10646, nick-nhusb-base-20170825, netbsd-9-base, netbsd-9-0-RELEASE, netbsd-9-0-RC2, netbsd-9-0-RC1, netbsd-8-base, netbsd-8-2-RELEASE, netbsd-8-1-RELEASE, netbsd-8-1-RC1, netbsd-8-0-RELEASE, netbsd-8-0-RC2, netbsd-8-0-RC1, matt-nb8-mediatek-base, matt-nb8-mediatek, jdolecek-ncqfixes-base, jdolecek-ncqfixes, isaki-audio2-base, isaki-audio2, is-mlppp-base, is-mlppp, bouyer-xenpvh-base2, bouyer-xenpvh-base1, bouyer-xenpvh-base, bouyer-xenpvh, ad-namecache-base3, ad-namecache-base2, ad-namecache-base1, ad-namecache-base, ad-namecache
Branch point for: netbsd-9, netbsd-8
Changes since 1.15: +2 -32 lines
Diff to previous 1.15 (colored)

remove checks for failure after memory allocation calls that cannot fail:

  kmem_alloc() with KM_SLEEP
  kmem_zalloc() with KM_SLEEP
  percpu_alloc()
  pserialize_create()
  psref_class_create()

all of these paths include an assertion that the allocation has not failed,
so callers should not assert that again.

Revision 1.12.2.2 / (download) - annotate - [select for diffs], Fri Apr 22 15:44:13 2016 UTC (6 years, 9 months ago) by skrll
Branch: nick-nhusb
Changes since 1.12.2.1: +9 -2 lines
Diff to previous 1.12.2.1 (colored) to branchpoint 1.12 (colored)

Sync with HEAD

Add comments.

Revision 1.12.2.1 / (download) - annotate - [select for diffs], Sat Mar 19 11:30:08 2016 UTC (6 years, 10 months ago) by skrll
Branch: nick-nhusb
Changes since 1.12: +4 -4 lines
Diff to previous 1.12 (colored)

Sync with HEAD

Revision 1.14 / (download) - annotate - [select for diffs], Thu Feb 18 15:42:44 2016 UTC (6 years, 11 months ago) by riastradh
Branch: MAIN
CVS Tags: nick-nhusb-base-20160319
Changes since 1.13: +3 -3 lines
Diff to previous 1.13 (colored)

Avoid reading one byte past end of array.

Fixes

   acpiout0: brightness levels: [20,25,30,35,40,45,50,55,60,65,70,75,80,85,90,uvm_fault(0xffffffff8133d200, 0xffff80000c1d8000, 1) -> e
   fatal page fault in supervisor mode
   trap type 6 code 0 rip ffffffff803b63d7 cs 8 rflags 10212 cr2 ffff80000c1d8000 ilevel 8 rsp ffffffff816a1b00

Revision 1.13 / (download) - annotate - [select for diffs], Wed Jan 6 01:37:17 2016 UTC (7 years, 1 month ago) by christos
Branch: MAIN
Changes since 1.12: +3 -3 lines
Diff to previous 1.12 (colored)

PR/50626: Vicente Chaves de Melo: acpi_display.c erroneously sends character
to console during boot

Revision 1.12 / (download) - annotate - [select for diffs], Tue Oct 14 19:50:57 2014 UTC (8 years, 3 months ago) by christos
Branch: MAIN
CVS Tags: nick-nhusb-base-20151226, nick-nhusb-base-20150921, nick-nhusb-base-20150606, nick-nhusb-base-20150406, nick-nhusb-base
Branch point for: nick-nhusb
Changes since 1.11: +31 -7 lines
Diff to previous 1.11 (colored)

summarize levels instead of printing dozens of them.

Revision 1.10.2.1 / (download) - annotate - [select for diffs], Wed Aug 20 00:03:35 2014 UTC (8 years, 5 months ago) by tls
Branch: tls-maxphys
Changes since 1.10: +4 -16 lines
Diff to previous 1.10 (colored)

Rebase to HEAD as of a few days ago.

Revision 1.9.6.2 / (download) - annotate - [select for diffs], Thu May 22 11:40:19 2014 UTC (8 years, 8 months ago) by yamt
Branch: yamt-pagecache
Changes since 1.9.6.1: +4 -16 lines
Diff to previous 1.9.6.1 (colored) to branchpoint 1.9 (colored) next main 1.10 (colored)

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

Revision 1.10.4.1 / (download) - annotate - [select for diffs], Sun May 18 17:45:35 2014 UTC (8 years, 8 months ago) by rmind
Branch: rmind-smpnet
Changes since 1.10: +4 -16 lines
Diff to previous 1.10 (colored) next main 1.11 (colored)

sync with head

Revision 1.11 / (download) - annotate - [select for diffs], Tue Feb 25 18:30:09 2014 UTC (8 years, 11 months ago) by pooka
Branch: MAIN
CVS Tags: yamt-pagecache-base9, tls-maxphys-base, tls-earlyentropy-base, tls-earlyentropy, rmind-smpnet-nbase, rmind-smpnet-base, riastradh-xf86-video-intel-2-7-1-pre-2-21-15, riastradh-drm2-base3, netbsd-7-nhusb-base-20170116, netbsd-7-nhusb-base, netbsd-7-nhusb, netbsd-7-base, netbsd-7-2-RELEASE, netbsd-7-1-RELEASE, netbsd-7-1-RC2, netbsd-7-1-RC1, netbsd-7-1-2-RELEASE, netbsd-7-1-1-RELEASE, netbsd-7-1, netbsd-7-0-RELEASE, netbsd-7-0-RC3, netbsd-7-0-RC2, netbsd-7-0-RC1, netbsd-7-0-2-RELEASE, netbsd-7-0-1-RELEASE, netbsd-7-0, netbsd-7
Changes since 1.10: +4 -16 lines
Diff to previous 1.10 (colored)

Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.

Revision 1.9.6.1 / (download) - annotate - [select for diffs], Tue Oct 30 17:20:50 2012 UTC (10 years, 3 months ago) by yamt
Branch: yamt-pagecache
CVS Tags: yamt-pagecache-tag8
Changes since 1.9: +7 -7 lines
Diff to previous 1.9 (colored)

sync with head

Revision 1.10 / (download) - annotate - [select for diffs], Sat Jun 2 21:36:43 2012 UTC (10 years, 8 months ago) by dsl
Branch: MAIN
CVS Tags: yamt-pagecache-base8, yamt-pagecache-base7, yamt-pagecache-base6, riastradh-drm2-base2, riastradh-drm2-base1, riastradh-drm2-base, riastradh-drm2, khorben-n900, agc-symver-base, agc-symver
Branch point for: tls-maxphys, rmind-smpnet
Changes since 1.9: +7 -7 lines
Diff to previous 1.9 (colored)

Add some pre-processor magic to verify that the type of the data item
  passed to sysctl_createv() actually matches the declared type for
  the item itself.
In the places where the caller specifies a function and a structure
  address (typically the 'softc') an explicit (void *) cast is now needed.
Fixes bugs in sys/dev/acpi/asus_acpi.c sys/dev/bluetooth/bcsp.c
  sys/kern/vfs_bio.c sys/miscfs/syncfs/sync_subr.c and setting
  AcpiGbl_EnableAmlDebugObject.
(mostly passing the address of a uint64_t when typed as CTLTYPE_INT).
I've test built quite a few kernels, but there may be some unfixed MD
  fallout. Most likely passing &char[] to char *.
Also add CTLFLAG_UNSIGNED for unsiged decimals - not set yet.

Revision 1.8.2.1 / (download) - annotate - [select for diffs], Mon Jun 6 09:07:41 2011 UTC (11 years, 8 months ago) by jruoho
Branch: jruoho-x86intr
Changes since 1.8: +19 -10 lines
Diff to previous 1.8 (colored) next main 1.9 (colored)

Sync with HEAD.

Revision 1.9.2.2 / (download) - annotate - [select for diffs], Sat Mar 5 20:53:02 2011 UTC (11 years, 11 months ago) by rmind
Branch: rmind-uvmplock
Changes since 1.9.2.1: +2103 -0 lines
Diff to previous 1.9.2.1 (colored) to branchpoint 1.9 (colored) next main 1.10 (colored)

sync with head

Revision 1.8.4.1 / (download) - annotate - [select for diffs], Thu Feb 17 12:00:09 2011 UTC (11 years, 11 months ago) by bouyer
Branch: bouyer-quota2
Changes since 1.8: +19 -10 lines
Diff to previous 1.8 (colored) next main 1.9 (colored)

Sync with HEAD

Revision 1.9.2.1, Wed Feb 16 09:05:12 2011 UTC (11 years, 11 months ago) by rmind
Branch: rmind-uvmplock
Changes since 1.9: +0 -2103 lines
FILE REMOVED

file acpi_display.c was added on branch rmind-uvmplock on 2011-03-05 20:53:02 +0000

Change the preprocessor defines around the module(9)'s modcmd() calls such
that the modules show in modstat(8) even though these are "builtin".

Revision 1.8 / (download) - annotate - [select for diffs], Mon Jan 10 09:07:27 2011 UTC (12 years ago) by jruoho
Branch: MAIN
CVS Tags: jruoho-x86intr-base
Branch point for: jruoho-x86intr, bouyer-quota2
Changes since 1.7: +41 -35 lines
Diff to previous 1.7 (colored)

Small clean-up in the match and attach functions. Namely, use the attach
args instead of referencing the global softc. No functional change.

Revision 1.7 / (download) - annotate - [select for diffs], Sun Nov 7 16:36:26 2010 UTC (12 years, 3 months ago) by gsutre
Branch: MAIN
CVS Tags: matt-mips64-premerge-20101231
Changes since 1.6: +17 -20 lines
Diff to previous 1.6 (colored)

Replace ACPI_UINT64 by ACPICA's ACPI_INTEGER.  Remove superfluous casts.
No functional change.

Revision 1.1.2.3 / (download) - annotate - [select for diffs], Sat Nov 6 08:08:27 2010 UTC (12 years, 3 months ago) by uebayasi
Branch: uebayasi-xip
Changes since 1.1.2.2: +90 -5 lines
Diff to previous 1.1.2.2 (colored) to branchpoint 1.1 (colored) next main 1.2 (colored)

Sync with HEAD.

Revision 1.6 / (download) - annotate - [select for diffs], Thu Nov 4 20:08:12 2010 UTC (12 years, 3 months ago) by jruoho
Branch: MAIN
CVS Tags: uebayasi-xip-base4
Changes since 1.5: +4 -2 lines
Diff to previous 1.5 (colored)

Initialize pointers to NULL to avoid accidentally free(9)'ing garbage.
Should address the panic reported by Alan Bueno in PR # 44042. The root
cause (an empty _DOD) is yet to be determined.

Revision 1.5 / (download) - annotate - [select for diffs], Fri Oct 29 09:04:38 2010 UTC (12 years, 3 months ago) by gsutre
Branch: MAIN
Changes since 1.4: +11 -2 lines
Diff to previous 1.4 (colored)

Lock the _DGS values (desired output state) during the display
output switch.

ok jruoho@

Revision 1.4 / (download) - annotate - [select for diffs], Thu Oct 28 21:45:02 2010 UTC (12 years, 3 months ago) by gsutre
Branch: MAIN
Changes since 1.3: +48 -4 lines
Diff to previous 1.3 (colored)

Simplify the sysctl variable for BIOS switch policy, and document it
in acpivga(4).  The previous hw.acpi.acpivga0.policy variable is
renamed into bios_policy for consistency, and is for ACPI_DEBUG only.

ok jruoho@

Revision 1.3 / (download) - annotate - [select for diffs], Tue Oct 26 22:27:44 2010 UTC (12 years, 3 months ago) by gsutre
Branch: MAIN
Changes since 1.2: +5 -3 lines
Diff to previous 1.2 (colored)

An _ADR object is not required for PCI root bridges.  To solve
this, the structure acpi_pciinfo now tells whether the ACPI
device node is a PCI bridge, a regular PCI device, or both.

Problem reported by jmcneill@, who also suggested the solution.

ok jmcneill@, jruoho@

Revision 1.2 / (download) - annotate - [select for diffs], Mon Oct 25 17:06:58 2010 UTC (12 years, 3 months ago) by jruoho
Branch: MAIN
Changes since 1.1: +30 -2 lines
Diff to previous 1.1 (colored)

Add support for module(9).

Revision 1.1.2.2 / (download) - annotate - [select for diffs], Fri Oct 22 07:21:52 2010 UTC (12 years, 3 months ago) by uebayasi
Branch: uebayasi-xip
Changes since 1.1.2.1: +2006 -0 lines
Diff to previous 1.1.2.1 (colored) to branchpoint 1.1 (colored)

Sync with HEAD (-D20101022).

Revision 1.1.2.1, Tue Oct 12 19:10:50 2010 UTC (12 years, 3 months ago) by uebayasi
Branch: uebayasi-xip
Changes since 1.1: +0 -2006 lines
FILE REMOVED

file acpi_display.c was added on branch uebayasi-xip on 2010-10-22 07:21:52 +0000

Revision 1.1 / (download) - annotate - [select for diffs], Tue Oct 12 19:10:50 2010 UTC (12 years, 3 months ago) by gsutre
Branch: MAIN
CVS Tags: uebayasi-xip-base3
Branch point for: uebayasi-xip

Merge ACPI display driver.  Provides generic support for brightness
control and output switching, through ACPI video extensions.

TODO: use wsconsctl(8) instead of sysctl(8) for brightness control.

ok jruoho@
also discussed with cegger@ and jmcneill@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.

Diffs between
and

Preferred Diff type:
View only Branch:
Sort log by:

CVSweb <webmaster@jp.NetBSD.org>