CVS log for src/sbin/gpt/add.c

Up to [cvs.NetBSD.org] / src / sbin / gpt

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Pull up following revision(s) (requested by kre in ticket #1920):

	sbin/gpt/add.c: revision 1.45

PR bin/58806  Never create a partition with a null guid

If a new partition entry being added doesn't already have a guid,
make one for it.

Pull up following revision(s) (requested by kre in ticket #1005):

	sbin/gpt/add.c: revision 1.45

PR bin/58806  Never create a partition with a null guid

If a new partition entry being added doesn't already have a guid,
make one for it.

PR bin/58806  Never create a partition with a null guid

If a new partition entry being added doesn't already have a guid,
make one for it.

Sync with HEAD

Catch up to current for the following, requested by sborrill in ticket #1629:

	sbin/gpt/gpt_private.h                          up to 1.2
	sbin/gpt/header.c                               up to 1.9
	sbin/gpt/main.c                                 up to 1.11
	sbin/gpt/drvctl.c				delete
	sbin/gpt/Makefile				up to 1.18
	sbin/gpt/add.c					up to 1.44
	sbin/gpt/backup.c				up to 1.18
	sbin/gpt/biosboot.c				up to 1.30
	sbin/gpt/create.c				up to 1.23
	sbin/gpt/destroy.c				up to 1.10
	sbin/gpt/gpt.8					up to 1.63
	sbin/gpt/gpt.c					up to 1.75
	sbin/gpt/gpt.h					up to 1.38
	sbin/gpt/gpt_uuid.c				up to 1.15
	sbin/gpt/gpt_uuid.h				up to 1.7
	sbin/gpt/label.c				up to 1.29
	sbin/gpt/map.c					up to 1.14
	sbin/gpt/map.h					up to 1.6
	sbin/gpt/migrate.c				up to 1.33
	sbin/gpt/recover.c				up to 1.18
	sbin/gpt/remove.c				up to 1.22
	sbin/gpt/resize.c				up to 1.23
	sbin/gpt/resizedisk.c				up to 1.17
	sbin/gpt/restore.c				up to 1.18
	sbin/gpt/set.c					up to 1.14
	sbin/gpt/show.c 				up to 1.41
	sbin/gpt/type.c 				up to 1.15
	sbin/gpt/unset.c				up to 1.14

Many changes including:
- Significant refactoring
- PR/51230: Add the ability to set the active flag in the PMBR
- Let individual commands decide if ioctl(DIOCMWEDGES) should be done
- Add a "header" subcommand that displays information about the size of
  the disk along with information from the GPT header if it exists
- Add listing commands for type, set and unset
- Add help and formatting for set and unset
- Change show to print all the attribute info in one line.
- Improve documentation, including booting and exit status
- Check device parameter to avoid segfaults

Sync with HEAD

Not all things that write to the disk do something that dk(4) will
be interested in.  Let individual commands decide if ioctl(DIOCMWEDGES)
should be done.  I was conservative and set the flag on any command
that might create/modify/delete partitions in any way.

- add more informational messages
- handle case where last argument is an option not a device (set -l)

CID 1341561: Argument memory leak

CID 1341560: Free arg.

CID 1341548: Check error returns

WARNS=6

eliminate static globals so that commands can be re-used.

hrmm...

i386devel: {245} ./gpt add -b 1000 -s 1000 disk
Segmentation fault (core dumped)

Where's my flyswatter?   .......zzzzzzzap

refactor the utf code so that it does not leak memory.

- write a function to set the entity, so that we don't reset to guid.
- entry 0 means create entry.

merge command line parsers and check all memory allocations.

refactor more duplicated code.

Refactor the command dispatching and help printing logic.

Firs step of refactoring, remove all globals, factor out some common code,
handle alternate usage but not advertise it.

- use gpt_msg to print informational messages (perhaps these should be printed
  only with -v)
- don't print any messages with gpt_msg if quiet
- print a message if we didn't reconfigure the wedges

- automatically sync the wedge information unless -n is specified.
- document the general options in the traditional way.
- split the main program into a separate file.

merge the create errors in one place and fix them.

Pull up following revision(s) (requested by jnemeth in ticket #774):
	sbin/gpt/Makefile: revisions 1.9-1.13
	sbin/gpt/add.c: revisions 1.25-1.27
	sbin/gpt/backup.c: revisions 1.2-1.8
	sbin/gpt/biosboot.c: revisions 1.8-1.14
	sbin/gpt/create.c: revisions 1.8-1.12
	sbin/gpt/destroy.c: revisions 1.5-1.6
	sbin/gpt/drvctl.c: revision 1.1
	sbin/gpt/gpt.8: revisions 1.29-1.36
	sbin/gpt/gpt.c: revisions 1.29-1.40
	sbin/gpt/gpt.h: revisions 1.12-1.18
	sbin/gpt/gpt_uuid.c: revisions 1.1-1.10
	sbin/gpt/gpt_uuid.h: revisions 1.1-1.3
	sbin/gpt/label.c: revisions 1.15-1.18
	sbin/gpt/map.c: revision 1.7
	sbin/gpt/migrate.c: revisions 1.15-1.21
	sbin/gpt/recover.c: revision 1.5
	sbin/gpt/remove.c: revisions 1.13-1.16
	sbin/gpt/resize.c: revisions 1.9-1.11
	sbin/gpt/resizedisk.c: revisions 1.1-1.6
	sbin/gpt/restore.c: revisions 1.2-1.7
	sbin/gpt/set.c: revisions 1.3-1.5
	sbin/gpt/show.c: revision 1.16-1.21
	sbin/gpt/type.c: revisions 1.1-1.6
	sbin/gpt/unset.c: revisions 1.3-1.5
- record the sector size of the disk
- correct confusion with end_cylinder and end_sector in MBRs
--
- dump all partitions, not just ones that are in use
- while here, squash a memory leak
     It shouldn't be necessary to backup unused partitions, however
the partition GUID is created at the time the GPT is created and
is never changed.  It shouldn't matter if the GUID of an unused
partition changes, but there may be some special case where it
does.  Since it isn't a big deal to record the unused partitions,
might as well do it.
--
Initial cut of gpt restore.  This functions correctly in testing,
but isn't all that pretty.  It has minimal error testing and may
leak memory.  It also only works with empty disks.  If passed "-F"
flag, it will blank the disk for you.
--
document the new restore subcommand
--
- make gpt_gpt() available for use directly by subcommands
- create new resizedisk disk subcommand for relocating backup GPT
--
Fix compile error observed on i386. Use PRIu64.
--
no C99isms in tool code
--
- handle a GPT that isn't an exact multiple of a sector
- adjust PMBR size, in case new disk is a different size
- don't leak as much memory
- clean up error handling somewhat
--
PR/44218 - David Young -- add "type" subcommand to change a partition type
--
PR/47990 - Dr. Wolfgang Stukenbrock -- add "-L <label>" as selector option
--
minor toolification: need libprop...
--
more toolification
--
more toolification changes
--
remove compat defines.
--
Add internal uuid support, since the linux+macos versions of the library
are different than than *bsd ones, and others might not have it at all.
--
Check size of correct buffer.  Note, just being pedantic as the buffer
being checked is the same size as the one that should have been checked.
--
correctly show partition type in the new world order
--
actually return the uuid when parsing one that is in numeric format
--
using random values for hdr->hdr_guid does not work very well
--
oops, forgot to update end of data area
--
It's HAVE_NBTOOL_CONFIG_H, not HAVE_NBTOOLS_CONFIG_H
--
Fix tools build on !NetBSD.
--
include <sys/endian.h> for both the non-tools build,
and the tools build on a host where the file exists.
Fixes a build problem on FreeBSD, reported by Herbert J. Skuhra, where
tools/compat's configure detected that be32dec() and friends were
available in the host's <sys/endian.h>, so tools/compat did not provide
its own versions.
--
"0" is not guaranteed to be unique
--
provide a copy of the kernel uuid generator (with portable API calls) for
tools.
--
Allow specifying sector and media size on the command line.
--
Remove trailing whitespace.
--
Make gpt(8) generate v4 (random) uuids.
Don't needlessly leak your date/time and MAC address when you edit
the disk.
Read from /dev/urandom rather than calling arc4random or anything,
since this is a tool.  (Cygwin seems to have /dev/urandom, but yell
if this breaks the build on your exotic platform because it lacks
/dev/urandom.)
ok apb
--
Paranoia: choke noisily on EOF from /dev/urandom.
--
Report the argument instead of (null) when opendisk fails.
--
handle constness
--
handle constness better
--
Add some more common partition types.
--
Bump date for previous.
--
Fix handling of -t option for the type command.
Match any type, when no option is given, just like for the label command.
--
Factor out the getdisksize() drvctl method, and provide an alternative that
directly uses the disk ioctl's instead of relying on the drvctl device driver
which is currently not mandatory.

Add internal uuid support, since the linux+macos versions of the library
are different than than *bsd ones, and others might not have it at all.

remove compat defines.

minor toolification: need libprop...

Rebase to HEAD as of a few days ago.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

Explicitly state which partition was added/modified.

For the add and resize subcommands, change the -s option.  If there is
no suffix, or the suffix is 's' or 'S', size is in sectors (as before)
otherwise size is in bytes.

Don't attempt to create/resize an unaligned partition if the attempt
to create/resize an aligned one failed.  This simplifies the code
and prevents surprises.  If the user wants an unaligned partition
in the case where an aligned one fails, they can simply retry the
command without the "-a" option.  This change was requested by
wiz@, and after some thought I agree with it.

when calling dehumanize_number() make sure the resulting number is >= 1

Remove FreeBSD specific code as per message to tech-userlevel.

change the "-b blocknr" parameter to accept a "human number"

In the manpage:
- s/-b number/-b blocknr/
- s/-s count/-s sectors/
- s/-p count/-p partitions/

In the program:
- s/-b lba/-b blocknr/
- s/-s lba/-s sectors/

This makes the documentation in the manpage and the program consistent
and makes it more clear what the parameters are.  Also, "-s lba" was
just plain wrong since LBA stands for Logical Block Address[ing], and
the -s option didn't represent any kind of address, but rather a size.

delete an errant where it is obvious what the code is doing

When setting a label on the new partition, be sure to set the label
in the secondary partition table as well.

     Add two new options to the "add" subcommand:

-a alignment -- attempt to align the start and size of the partition
-l label -- supply a label for the partition

These options were inspired by FreeBSD's gpart(8) command, but the
code was written by me.

resync from head

Instead of 'no space', say 'not enough space' in error message.

Make pre-initialized partition type uuid_t symbols 'static const'.

This conserves a few hundred bytes of total program size by
allowing the linker to merge duplicates.

Clean up gpt(8) a bit more

uuid_create_nil(3) and uuid_is_nil(3) take a uuid_t*, not a pointer to
an array of bytes merely casted to compatible type.

Additonally, there no need for extra casts and address-of operations when
using le_uuid_*() functions.

Furthermore, le_uuid_*() are identical to uuid_*_le functions in
libc/libuuid, so use those instead on NetBSD.

Use __dead

Clarify the 'dkctl addwedge' usage message after creating a GPT
partition.

UFS is called FFS in the NetBSD case.  Display as such and accept as input.

Let 'gpt add' suggest a collect device name so that opendisk(3) called by
dkctl(8) succeeds.

Make manual and usage consistent.  No functional changes.

Sync with netbsd-4.

Pull up revisions:
  src/sbin/gpt/add.c			1.6
  src/sbin/gpt/gpt.c			1.7
  src/sbin/gpt/show.c			1.4
  src/sys/dev/dkwedge/dkwedge_gpt.c	1.7
  src/sys/sys/disk.h			1.47
  src/sys/sys/disklabel_gpt.h		1.4
(requested by riz in ticket #1119).

As discussed on tech-userlevel, add NetBSD GPT partition types for
swap, ffs, lfs, raidframe, ccd and cgd.  gpt(8) now defaults to
NetBSD ffs if no type is given, but previous FreeBSD types are
still recognized in the DKWEDGE_AUTODISCOVER code.

Pull up revisions:
  src/sbin/gpt/add.c		1.5
  src/sbin/gpt/create.c		1.3
  src/sbin/gpt/destroy.c	1.3
  src/sbin/gpt/gpt.c		1.4-1.6
  src/sbin/gpt/label.c		1.5-1.6
  src/sbin/gpt/migrate.c	1.4
  src/sbin/gpt/recover.c	1.3
  src/sbin/gpt/remove.c		1.4
  src/sbin/gpt/show.c		1.3
(requested by riz in ticket #1117).

Produce more useful error messages.

Fix the usage strings for each command, and print them all for the
"global" usage.  It's still a little ugly, but hopefully not as
fantastically confusing as before...

Your friendly neighborhood 64-bit architecture here to remind you that
strlen returns size_t, and printf's precision specifier uses int.

Sync with HEAD.

sync with HEAD

As discussed on tech-userlevel, add NetBSD GPT partition types for
swap, ffs, lfs, raidframe, ccd and cgd.  gpt(8) now defaults to
NetBSD ffs if no type is given, but previous FreeBSD types are
still recognized in the DKWEDGE_AUTODISCOVER code.

Sync with HEAD.

Fix the usage strings for each command, and print them all for the
"global" usage.  It's still a little ugly, but hopefully not as
fantastically confusing as before...

Pull up following revision(s) (requested by riz in ticket #445):
	sbin/gpt/add.c: revision 1.4
	sbin/gpt/remove.c: revision 1.3
	sbin/gpt/label.c: revision 1.4
	sbin/gpt/gpt.c: revision 1.3
Use strtoll() when converting a 64-bit quantity.  This makes "gpt add"
work with an offset of more than 2147483647 sectors.  While I'm here,
use strtoul() when converting an unsigned quantity.

Use strtoll() when converting a 64-bit quantity.  This makes "gpt add"
work with an offset of more than 2147483647 sectors.  While I'm here,
use strtoul() when converting an unsigned quantity.

Add initialization of a variable where gcc for some archs thinks
that it may be used un-initialized.  From cursory inspection it is
not obvious that gcc is wrong.

Make this work under NetBSD.

Import the gpt tool from FreeBSD

Initial revision