CVS log for src/sbin/dump/main.c

Up to [cvs.NetBSD.org] / src / sbin / dump

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

dump: suppress lint warning about "effectively discards 'const'"

Pull up following revision(s) (requested by kre in ticket #1630):

	sbin/dump/dump.h: revision 1.59
	sbin/dump/main.c: revision 1.78

PR bin/55834

count blocks written in unsigned 64 bit counter
rather than signed int which overflows after 2^31-1
blocks (2TiB) after which neither the 5 minute
status updates or SIGINFO (^T) reports are issued
until the negative numbers increase past 0 and
wildly inaccurate reports would be written.

Pull up following revision(s) (requested by kre in ticket #1139):

	sbin/dump/dump.h: revision 1.59
	sbin/dump/main.c: revision 1.78

PR bin/55834

count blocks written in unsigned 64 bit counter
rather than signed int which overflows after 2^31-1
blocks (2TiB) after which neither the 5 minute
status updates or SIGINFO (^T) reports are issued
until the negative numbers increase past 0 and
wildly inaccurate reports would be written.

PR bin/55834

count blocks written in unsigned 64 bit counter
rather than signed int which overflows after 2^31-1
blocks (2TiB) after which neither the 5 minute
status updates or SIGINFO (^T) reports are issued
until the negative numbers increase past 0 and
wildly inaccurate reports would be written.

Mostly merge changes from HEAD upto 20200411

Merge changes from current as of 20200406

Fix depenency on common symbols in sbin.

Add -D flag to allow the user to specify an alternate dumpdates file.
Closes PR #54469.

Sync with HEAD

Pull up following revision(s) (requested by manu in ticket #1221):

	sbin/dump/tape.c: revision 1.55
	sbin/dump_lfs/dump_lfs.8: revision 1.18
	sbin/dump/dump.h: revision 1.56
	sbin/dump/dump.8: revision 1.69
	sbin/dump/dump.h: revision 1.57
	sbin/dump/ffs_inode.c: revision 1.23
	sbin/dump/optr.c: revision 1.43
	sbin/dump/itime.c: revision 1.21
	sbin/dump/main.c: revision 1.74
	sbin/dump/itime.c: revision 1.22
	sbin/dump/main.c: revision 1.75
	sbin/dump/dump.8: revision 1.70
	sbin/dump/traverse.c: revision 1.52
	sbin/dump/dump.8: revision 1.71

Document what rdump is (was once) for. PR 53442.

Use getfsspecname() to fill the filesystem argument in dumpdates.
While here, make sure that the error strings terminate with newline
consistently, and add a function that adds the system error string.

Add -U flag to dump(8) and dump_lfs(8) to specify dumpdates entry
This address situations where dump(8) cannot figure out the device being
dumped. It also allows tracking of subvolume dumps by using virtual
device as dumpdates entry.

Bump date for previous.

Add -U flag to dump(8) and dump_lfs(8) to specify dumpdates entry

This address situations where dump(8) cannot figure out the device being
dumped. It also allows tracking of subvolume dumps by using virtual
device as dumpdates entry.

Use getfsspecname() to fill the filesystem argument in dumpdates.
While here, make sure that the error strings terminate with newline
consistently, and add a function that adds the system error string.

Pull up following revision(s) (requested by bouyer in ticket #1332):
	sbin/dump/main.c: revision 1.73
	sbin/dump/tape.c: revision 1.54
Consistently use iswap64() and 64bit intermediate variable, as well as
64bit formats for c_tapea. Fixes tape useage report for large filesystems.

Pull up following revision(s) (requested by bouyer in ticket #1331):
	sbin/dump/dump.8: revision 1.67 via patch
	sbin/dump/main.c: revision 1.72
	sbin/dump/rcache.c: revision 1.25
Default the read block size (-k default value) to kern.maxphys (usually
64k these days). This gives a noticable performance boost on large filesystems.

Pull up following revision(s) (requested by bouyer in ticket #991):
	sbin/dump/tape.c: revision 1.54
	sbin/dump/main.c: revision 1.73
Consistently use iswap64() and 64bit intermediate variable, as well as
64bit formats for c_tapea. Fixes tape useage report for large filesystems.

Pull up following revision(s) (requested by bouyer in ticket #990):
	sbin/dump/rcache.c: revision 1.25
	sbin/dump/dump.8: revision 1.67
	sbin/dump/main.c: revision 1.72
Default the read block size (-k default value) to kern.maxphys (usually
64k these days). This gives a noticable performance boost on large filesystems.

Consistently use iswap64() and 64bit intermediate variable, as well as
64bit formats for c_tapea. Fixes tape useage report for large filesystems.

Default the read block size (-k default value) to kern.maxphys (usually
64k these days). This gives a noticable performance boost on large filesystems.

Rebase to HEAD as of a few days ago.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

Fix handling of NAME aliases in /etc/fstab.

resync from head

handle new lfs split

sync with head

factor out rawname() from dump, fsck, savecore.

use getfsspecname()

PR/45735: Bug Hunting: The dump(8) manpage, as well as the program's `usage'-line,
needs improvement

PR/42952: The Grey Wolf: Fix for "true incremental". Don't overload level
9, use a new level "i" which is logically 10.

PR/42883: Greywolf: Add -i flag which brings "true incremental" capability.

Sync with HEAD.

Sync with wrstuden-revivesa-base-2.

Remove the \n and tabs from the __COPYRIGHT() strings.
(Tweak some to use a consistent format.)

Pull up following revision(s) (requested by hannken in ticket #1573):
	sbin/dump/snapshot.h: revision 1.3 via patch
	sbin/dump/snapshot.c: revision 1.3 via patch
	sbin/dump/main.c: revision 1.63 via patch
	sbin/dump/tape.c: revision 1.47 via patch
	sbin/dump/dump.h: revision 1.44 via patch
When using a snapshot take the snapshot raw device on further open.
Fixes PR #34923  dump(8) only dumps a corefile with -X (snapshots)
Approved by: Manuel Bouyer <bouyer@netbsd.org>

Pull up following revision(s) (requested by hannken in ticket #1573):
	sbin/dump/snapshot.h: revision 1.3 via patch
	sbin/dump/snapshot.c: revision 1.3 via patch
	sbin/dump/main.c: revision 1.63 via patch
	sbin/dump/tape.c: revision 1.47 via patch
	sbin/dump/dump.h: revision 1.44 via patch
When using a snapshot take the snapshot raw device on further open.
Fixes PR #34923  dump(8) only dumps a corefile with -X (snapshots)
Approved by: Manuel Bouyer <bouyer@netbsd.org>

Pull up following revision(s) (requested by hannken in ticket #1573):
	sbin/dump/snapshot.h: revision 1.3 via patch
	sbin/dump/snapshot.c: revision 1.3 via patch
	sbin/dump/main.c: revision 1.63 via patch
	sbin/dump/tape.c: revision 1.47 via patch
	sbin/dump/dump.h: revision 1.44 via patch
When using a snapshot take the snapshot raw device on further open.
Fixes PR #34923  dump(8) only dumps a corefile with -X (snapshots)
Approved by: Manuel Bouyer <bouyer@netbsd.org>

When using a snapshot take the snapshot raw device on further open.

Fixes PR #34923  dump(8) only dumps a corefile with -X (snapshots)

Approved by: Manuel Bouyer <bouyer@netbsd.org>

Change LFCNWRAP{STOP,GO} to make them more suitable for snapshotting; in
particular, the caller can now choose whether to wait for the condition
to be met, and if the caller of LFCNWRAPSTOP dies or otherwise closes
the descriptor, the filesystem is started again.  Updated the ckckp
regression test to use the new semantics.

dump_lfs(8) now uses the fcntls to implement LFS-style snapshotting through
the -X flag, addressing PR#33457 albeit not using fss(4).  Fixed a couple
other problems with dump_lfs that manifested themselves during testing.

Pull up following revision(s) (requested by hannken in ticket #1283):
	sbin/dump/main.c: revision 1.61
Emit "a snapshot of" message for snap_internal case too.

Emit "a snapshot of" message for snap_internal case too.

Coverity CID 2297: Fix memory leak.

sprinkle const

Pull up revision 1.58 (requested by hannken in ticket #184):
Snapshot support for dump(8):
- New option `-x backup' takes the dump from a snapshot backed up by `backup'.
  The snapshot will be deleted on exit.
- New option `-X' as a synonym for `-x mountpoint' where `mountpoint' is the
  file system to be dumped.
Reviewed and Approved by: Manuel Bouyer <bouyer@netbsd.org>

Snapshot support for dump(8):

- New option `-x backup' takes the dump from a snapshot backed up by `backup'.
  The snapshot will be deleted on exit.

- New option `-X' as a synonym for `-x mountpoint' where `mountpoint' is the
  file system to be dumped.

Reviewed and Approved by: Manuel Bouyer <bouyer@netbsd.org>

Replace the statfs() family of system calls with statvfs().
Retain binary compatibility.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22308, verified by myself.

Add support for UFS2. UFS2 is an enhanced FFS, adding support for
64 bit block pointers, extended attribute storage, and a few
other things.

This commit does not yet include the code to manipulate the extended
storage (for e.g. ACLs), this will be done later.

Originally written by Kirk McKusick and Network Associates Laboratories for
FreeBSD.

Use "wall -g operator" (instead of private code) to broadcast() messages to
members of the operator group.
Don't install "setgid tty", and remove now unnecessary gid/egid swapping.
Remove utmp trawling code pulled in from usr.bin/who.
The Code is now simpler, and more portable (without the utmp cruft) too.

This is derived from similar work in OpenBSD.

should be safer to cast to u_long than to cast down to int

Add a cast to sizeof in printf() arg since _BSD_SIZE_T is unsigned long
on some ports.

use strlcpy.  use sizeof() instead of xxLEN to avoid de-synchronization

Pull up revisions 1.33-1.34 (via patch, requested by bouyer):
  Improve behaviour when a path is given:
   1) check if the path is an unmounted file system listed in fstab
   2) check if it is a path to a mounted file system not listed in fstab
  Fixes PR#15790.

Pull up revision 1.49 (via patch, requested by bouyer):
  Add an ``-a'' option to ``auto-size'' the tape, rather than
  relying upon other options to define the tape size.

Pull up revisions 1.46-1.48 (via patch, requested by bouyer):
  Various fixes:
   o Fix error if first tape is write-protected; fixes PR#4754 and PR#6098
   o Make error codes conform to manual page
   o Use \a to make noise
   o Fix estimated number of tapes for huge dumps to cartridges
   o Use <sys/queue.h> SLIST_* macros instead of homegrown variants
   o Do not exit if unable to read/create /etc/dumpdates
   o Support output (tape) device returning ENOSPC for end-of-media on write
   o Don't dump core if SIGINFO is received before 1 second has elapsed
   o Only process SIGINFO in currently active child
   o Ensure current (sub)block isn't past end of file system -- fixes
     "spins forever but does nothing" bug.
   o Some other minor fixes (types, whitespace, KNF, unifdef sunos, ...)

Pull up revisions 1.41,1.50 (via patch, requested by bouyer):
  Implement ``-l <timeout>'' option for use with e.g. autochangers.

For -l: specify the timeout on the command line (in seconds) instead of
hardwiring it to 2s, as suggested on tech-userlevel.

Add -a to "auto-size" the tape, rather than relying upon other options
to define the tape size.  Requires the tape driver to either return ENOSPC
at end of media, or 0 when a write is attempted (such as the "early warning"
support in st(4) enabled with "mt eew 1").   From FreeBSD.

Fixes from FreeBSD:
- Fix error if first tape was write protected.  Fix NetBSD PRs 4754 and 6098.
- Make dump exit codes confirm to manual page.
- Use \a instead of \7 to make noise.
- Fix estimated number of tapes for huge dumps to cartridges.
- Use <sys/queue.h> SLIST_* instead of home-rolled lists.
- Do not exit if unable to read or create /etc/dumpdates.
- Support output (tape) device returning ENOSPC for end-of-media on a write.

Fixes by me:
- Remove unused ddates_in.
- Don't dump core if SIGINFO is received before 1 second has elapsed.
- Only process SIGINFO in current "active" child.
- Don't dump core in -w if dumpdates wasn't readable and ddatev == NULL
- Minor KNF; wrap some lines

clean up from time_t -> int32_t change in dumprestore.h

unifdef sunos

nuke trailing whitespace

- use correct type for minTime in findlru()  (size_t instead of int)
- clean up whitespace

Another little mistake, spotted by wiz.

Sync getopt() / man page with actual getopt options.

Add a -l (autoload) flag. For multivolume dumps, this makes dump eject the
tape when a volume is full, and try to reopen the tape drive for 2 mn.
To be used with tape changers which load the next tape when the current one is
ejected.
While I'm there fix eject handling for remote tape.

relax the restriction on -F that the file system image argument must be a
regular file

Add the capability for dump to print timestamps on all informational
messages.

- implement -F, which indicates that files-to-dump is a regular file
  containing a file system image (instead of being a single file as
  part of a subtree dump)
- use "file system" instead of "filesystem" or "file-system"

Pull up revision 1.37 via patch (requested by david):
  Temporarily drop setgid (for setgid tty) privileges, but restore them
  if we fork to perform an operator notification. Generalize pre-existing
  #ifdef RDUMP code.

Patch to drop setgid tty privs until forking for operator notification

reset uid & gid around calling rmthost().

display what signal, not "unknown"

Assign a saved copy of dt->fs_file to mountpoint. dt->fs_file will be freed
otherwise resulting in a wrong spcl.c_filesys .

* improve parsing of file-systems-to-dump when a path is given:
      - if it's a path to an unmounted file-system listed in /etc/fstab, use
	that instead of assuming the user wanted a subtree dump of the parent
	directory. this restores the behaviour of dump before the subtree
	dumping code went in.
      - if it's a path to a mounted file-system which is not in /etc/fstab,
	use the info from getmntinfo(3). previously, dump would choke.
* implement error checked malloc(), calloc(), strdup(), and use
  appropriately (some of the calloc()s weren't being checked)
* use 'file-system' instead of 'filesystem' in the man page

more KNF

knf to ansi

Pull up revision 1.29 (requested by tron):
  Fix bug in new ``e'' option: only eject tape if it is full, not
  if the dump was finished.

Add "e" option to usage message. Problem pointed out by Takahiro Kambe
in private e-mail.

Fix bug in new "e" option: only eject tape if it is full, not if the dump
was finished.

Pull up revision 1.28 (requested by tron):
  Add a new option ``e'' to dump which directs it to eject tapes
  automatically if a tape change is required.

Add a new option "e" to "dump" which allows to eject tapes automatically
if a tape change is required.

Global variables don't need to be initialised to zero.

Pullup sbin string format fixes [is].
See "cvs log" for explicit revision numbers per file, from sommerfeld.

Pull up revision 1.26 (requested by he):
  Format string cleanup.

Fix format warnings

Pull up to last week's -current.

Working version of aborted dump{,_lfs} join.

Back out changes made on the 29th, not at all the changes I intended to commit.
(I don't know how I did it though ... I'll figure it out tonight.)
I'll reapply this, in a working form, this evening.

Adapt dump(8) to use filestore-independent (but still ufs-specific)
replacements for NINDIR, fsbtodb, etc.  Create dump_lfs by adding a few
LFS-filestore-specific routines.  As described in PR#8317.

Implement a read cache, as announced on tech-userlevel. Default is 32k
read buffer size, 512 buffer or 15% of the user memory. Can be changed
with the -k and -s options.

add support for '-L label', which file(1) and restore(1) can extract from the
header. mostly based on [bin/6715] from Brian Grayson <bgrayson@ece.utexas.edu>

old filesystems don't have fs_qbmask and fs_qfmask set in the superblock;
fudge them as per code in /sys/ufs/ffs/ffs_vfsops.c::ffs_oldfscompat().
bug and suggested fix from Robert Elz <kre@munnari.OZ.AU> in [bin/6610]
    XXX: there may be other variables required as well...

from Erik Bertelsen <erik@mediator.uni-c.dk>
 { put } { in } { lots } { of } { these } { to } { shut } { up } { egcs }

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

Add support for non-native byte order FFS. The dump is in filesystem byte
order, restore already knows how to byteswap dumps.

Various changes from Brian Grayson <bgrayson@ece.utexas.edu> in [bin/4103]
* exit after providing an estimate if -S was given. the PR used -e,
  but checking around indicated prior art in Solaris usin -S.
* remove superfluous 'DUMP:' prefix in two messages
* initialise blocksperfile explicitly (not necessary, but everything
  else in that section gets initialised, so be consistant :)
* display the ``pretty'' name of the dumped directory, so the user
  knows if it's a subset or not

resolve conflicts from lite-2 import

imported from lite-2

* cleanup for WARNS=1
* fix use of .Nm
* comment out some unused(?) functions

* Add the ability to dump specific files & directories of a single
  filesystem. This uses fts(3) to access the directory structure (and
  not the raw device), so the standard access permissions are adhered
  to (unlike dumping an entire filesystem, which just requires read
  access to the raw disk device).
* Support SIGINFO status reporting.
* Remove now unused variables that previously stored the (e)uid.
* Be more informative in a couple of error messages.

enable rcmd().  garbage collect.

be safe with buffers.

remove use of "register".

Implement changes from [bin/1915]
* 'w' and 'W' display the year
* verbosity additions displaying total & per-volume transfer times and rates

set bflag so that 'dump bd M N' works properly.  fix from Juergen
  Hannken-Illjes in PR bin/3254.

Be more paranoid with our effective uid.

support $TAPE.  update manual to reflect reality (#1937).

convert to new RCS Id conventions; reduce my headache

Use getopt(3), with obsolete() from restore(8) for backward compatibility.

Eliminate uses of some obsolete functions.

Import 4.4-Lite version.

Update from 4.4-Lite, with local changes.

don't segv if called with no options!

new version from CSRG, via BSDI, with fixes