CVS log for src/libexec/telnetd/sys_term.c

Up to [cvs.NetBSD.org] / src / libexec / telnetd

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Pull up following revision(s) (requested by riastradh in ticket #1927):

	lib/libtelnet/encrypt.h: revision 1.10
	libexec/telnetd/telnetd.c: revision 1.59
	libexec/telnetd/sys_term.c: revision 1.50
	lib/libtelnet/encrypt.c: revision 1.20
	lib/libtelnet/enc_des.c: revision 1.18
	lib/libtelnet/enc-proto.h: revision 1.11
	libexec/telnetd/state.c: revision 1.33
	libexec/telnetd/state.c: revision 1.35
	libexec/telnetd/telnetd.c: revision 1.60

Fix memory leak - free resources allocated by getaddrinfo

Fix off by one in telrcv()

In case of "\r" in the data buffer, the code was unconditionally looking ahead
to next character, even if "\r" was last character in the buffer. That
condition leads to read outside of the data (one byte after the array)
Thanks christos@ for the review
PR bin/58787  libtelnet - avoid using a global variable


From RVP -- make 'encrypt_debug_mode' be a static (file scope)
variable instead of extern, and convert the (had been recently
anyway) unused function encrypt_debug() into an accensor function
for it.

This is the minor (almost irrelevant) change from PR bin/58787
PR bin/58787  telnetd - handle auto authentication better
Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from

        https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

Pull up following revision(s) (requested by riastradh in ticket #1013):

	lib/libtelnet/encrypt.h: revision 1.10
	libexec/telnetd/telnetd.c: revision 1.59
	libexec/telnetd/sys_term.c: revision 1.50
	lib/libtelnet/encrypt.c: revision 1.20
	lib/libtelnet/enc_des.c: revision 1.18
	lib/libtelnet/enc-proto.h: revision 1.11
	libexec/telnetd/state.c: revision 1.33
	libexec/telnetd/state.c: revision 1.35
	libexec/telnetd/telnetd.c: revision 1.60

Fix memory leak - free resources allocated by getaddrinfo

Fix off by one in telrcv()

In case of "\r" in the data buffer, the code was unconditionally looking ahead
to next character, even if "\r" was last character in the buffer. That
condition leads to read outside of the data (one byte after the array)
Thanks christos@ for the review
PR bin/58787  libtelnet - avoid using a global variable


From RVP -- make 'encrypt_debug_mode' be a static (file scope)
variable instead of extern, and convert the (had been recently
anyway) unused function encrypt_debug() into an accensor function
for it.

This is the minor (almost irrelevant) change from PR bin/58787
PR bin/58787  telnetd - handle auto authentication better
Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from

        https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

PR bin/58787  telnetd - handle auto authentication better

Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from
	https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

Mostly merge changes from HEAD upto 20200411

Pull up following revision(s) (requested by kamil in ticket #61):

	libexec/telnetd/telnetd.c: revision 1.56
	libexec/telnetd/sys_term.c: revision 1.49

telnetd: Stop defining the same variables concurrently in bss and data
auth_level and require_secure_login were defined in two places:

 - global.c that picked it from headers and removed 'extern'
 - telnetd.c that initialized it to 0

line was defined twice: in global.c and sys_term.c with a non-zero value.

Remove the definition and initialization from sys_term.c and initialize
the variable early in main().

Detected during the build of telned with Address Sanitizer (MKSANITIZER).
Reviewed by <mrg>

telnetd: Stop defining the same variables concurrently in bss and data

auth_level and require_secure_login were defined in two places:

 - global.c that picked it from headers and removed 'extern'
 - telnetd.c that initialized it to 0

line was defined twice: in global.c and sys_term.c with a non-zero value.
Remove the definition and initialization from sys_term.c and initialize
the variable early in main().

Detected during the build of telned with Address Sanitizer (MKSANITIZER).

Reviewed by <mrg>

Sync with HEAD

Sync with HEAD, resolve a few conflicts

Remove unused macros.

Rebase to HEAD as of a few days ago.

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

fix wrong variable check, remove casts
http://m00nbsd.net/ae123a9bae03f7dde5c6d654412daf5a.html

sync with (a bit old) head

Resync to 2012-11-19 00:00:00 UTC

Only include the headers we use and remove useless variable.

sync with head

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

Remove duplicated #includes and some trailing whitespace while here.
From Slava Semushin <slava.semushin@gmail.com>

use _PATH_DEV instead of "/dev/"

de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

Pass -a [srrvis'd struct sockaddr] to login, so that login can record the
address where we have logged in from.

realloc pedannt

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

more cleanups

remove unused function
XXX what's the difference between #ifdef UTMPX and #ifdef SUPPORT_UTMPX

remove unneeded #ifdefs.  improves readability.
(confirmed that exact same *.o is produced)

use bounded string op (there still are remains)

use strlcpy.  minor style fixes

add some more ifdefs, so that we don't define variables we don't use.

PR/17999: FUKAUMI Naoki: Support wtmpx entries.

Fix #ifdef indentation after recent removal of #ifdef NEWINIT-code.
Patch by Brian Ginsbach.

Remove code #ifdef'd on NEWINIT (never used on NetBSD).
Sync with Cray, patch by Brian Ginsbach in private mail.

Cray-only patch (sync with cray). Patch by Brian Ginsbach in private mail.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Rename variable to avoid shadowing.

Improve whitespace a bit, per bin/13667 by Brian Ginsbach.

Typo fixes and syslog string improvements, from bin/13667 by Brian Ginsbach.

Fix type of last execl argument, inspired by bin/13667.

Pull up revision 1.23 via patch (requested by itojun):
  Security-related fixups for telnet
    Bound-check all "*nfrontp++" code.  From OpenBSD and Heimdal.
    Complain if file descriptor goes above FD_SETSIZE.  From OpenBSD.

bound-check all "*nfrontp++" code.  from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE.  from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code?  need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

use LOG_ERR for fatal errors, LOG_WARNING for other errors
minor knf
deprecate LOG_ODELAY; it's the default

Pull down (revert) revision 1.19 (requested by tv):
  1.19 would require a header file update, and is not really
  required.

Pull up revisions 1.19-1.20 (requested by assar):
  Fix buffer overflow and environment passing problems, and only
  accept a limites set of environment variables and non-filename
  TERMCAP variables.

(scrub_env): change to only accept a listed set of variables,
including only non-filename contents for TERMCAP

Buffer overflow and environment passing fixes [originally inspired from
FreeBSD]. We really didn't need the environment fixes, but for the sake
of keeping the code as close as possible...

Pull up revision 1.18 (requested by itojun):
  Abort if memory for execv(2) argument array cannot be allocated
  instead of passing an array with incomplete contents to login(1).
  Fixes PR#9082.

Abort if memory for execv(2) argument array cannot be allocated instead
of passing an array with incomplete contents to login(1).
Fix provided by Jun-ichiro itojun Hagino in PR bin/9082.

Kerberos5 ticket forwarding works.

Added kerberos5_cleanup() to cleanup if KRB5 defined.  This is to destroy
a forwarded ccache on cleanup.

Fix for PR 5821
- s/SecurID/SECURELOGIN/g and define SECURELOGIN in Makefile
- update man page to reflect S/Key and Kerboros authentication used
  not SecurID

Execute ttyaction on termination of rlogind/telnetd sessions.
Also, say a little bit about ttyaction in the getty and login manpages.

Fix for pr 5904 from Zdenek Salvet; we now use openpty() to get a pty.

No need to include <sys/tty.h>.

WARNS?=1.  RCS ids.

Lseek(2) usage cleanup: the use of L_SET/L_INCR/L_XTND is deprecated,
use SEEK_SET/SEEK_CUR/SEEK_END instead.

apply Thorsten's patch to add gettytab support to telnetd.

RCS id cosmetics.

restore lost local change (be careful with 'long' vs. 'int'
distinctions)

update to telnetd from 95.10.23 version.  Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

Make sure that the user name cannot ever be interpreted as an option to
login(8).  Note: This does *not* fix any security holes.

be a bit more careful with types, casts, and and function declarations.

Import original 4.4-Lite version.

new telnetd from ftp.cray.com.  Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

initial import of 386bsd-0.1 sources

Initial revision