CVS log for src/lib/libtelnet/encrypt.c

Up to [cvs.NetBSD.org] / src / lib / libtelnet

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Pull up following revision(s) (requested by riastradh in ticket #1927):

	lib/libtelnet/encrypt.h: revision 1.10
	libexec/telnetd/telnetd.c: revision 1.59
	libexec/telnetd/sys_term.c: revision 1.50
	lib/libtelnet/encrypt.c: revision 1.20
	lib/libtelnet/enc_des.c: revision 1.18
	lib/libtelnet/enc-proto.h: revision 1.11
	libexec/telnetd/state.c: revision 1.33
	libexec/telnetd/state.c: revision 1.35
	libexec/telnetd/telnetd.c: revision 1.60

Fix memory leak - free resources allocated by getaddrinfo

Fix off by one in telrcv()

In case of "\r" in the data buffer, the code was unconditionally looking ahead
to next character, even if "\r" was last character in the buffer. That
condition leads to read outside of the data (one byte after the array)
Thanks christos@ for the review
PR bin/58787  libtelnet - avoid using a global variable


From RVP -- make 'encrypt_debug_mode' be a static (file scope)
variable instead of extern, and convert the (had been recently
anyway) unused function encrypt_debug() into an accensor function
for it.

This is the minor (almost irrelevant) change from PR bin/58787
PR bin/58787  telnetd - handle auto authentication better
Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from

        https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

Pull up following revision(s) (requested by riastradh in ticket #1013):

	lib/libtelnet/encrypt.h: revision 1.10
	libexec/telnetd/telnetd.c: revision 1.59
	libexec/telnetd/sys_term.c: revision 1.50
	lib/libtelnet/encrypt.c: revision 1.20
	lib/libtelnet/enc_des.c: revision 1.18
	lib/libtelnet/enc-proto.h: revision 1.11
	libexec/telnetd/state.c: revision 1.33
	libexec/telnetd/state.c: revision 1.35
	libexec/telnetd/telnetd.c: revision 1.60

Fix memory leak - free resources allocated by getaddrinfo

Fix off by one in telrcv()

In case of "\r" in the data buffer, the code was unconditionally looking ahead
to next character, even if "\r" was last character in the buffer. That
condition leads to read outside of the data (one byte after the array)
Thanks christos@ for the review
PR bin/58787  libtelnet - avoid using a global variable


From RVP -- make 'encrypt_debug_mode' be a static (file scope)
variable instead of extern, and convert the (had been recently
anyway) unused function encrypt_debug() into an accensor function
for it.

This is the minor (almost irrelevant) change from PR bin/58787
PR bin/58787  telnetd - handle auto authentication better
Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from

        https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

PR bin/58787  libtelnet - avoid using a global variable

From RVP -- make 'encrypt_debug_mode' be a static (file scope)
variable instead of extern, and convert the (had been recently
anyway) unused function encrypt_debug() into an accensor function
for it.

This is the minor (almost irrelevant) change from PR bin/58787

fix various typos in comments, mainly immediatly/immediately/,
as well shared and recently fixed typos in OpenBSD code by Jonathan Grey.

Sync with HEAD

Synch with HEAD

Match the function prototype of encrypthandler instead of casting to it.
Make GCC 9 snapshot happier with the code

While here, remove unnecessary braces around return (KNF).

sync with head

Use C89 functions definitions.
Remove use of __P

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- minimal fixes to compile with WARNS=4
- separate kerberos (USE_KERBEROS) from encryption (MKCRYPTO)

Pull up following revision(s) (requested by christos in ticket #1440):
	lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD

Pull up following revision(s) (requested by christos in ticket #1440):
	lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD

Pull up following revision(s) (requested by christos in ticket #1704):
	lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD

Pull up following revision(s) (requested by christos in ticket #1704):
	lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD

Pull up following revision(s) (requested by christos in ticket #1704):
	lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD

Avoid buffer overflow, reported by Colin Percival at FreeBSD

Remove more duplicate #includes, and a few spurious whitespaces at EOL
From Slava Semushin <slava.semushin@gmail.com>

de-__P (really de-P)

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22280, verified by myself.

use bounded string op

The Double-Semi-Colon Police.

__STDC__ is always defined on NetBSD.

Pull up revision 1.8 (requested by assar):
  Upgrade Heimdal to version 0.3e.

eliminate redundant decls.

Update from trunk:
Bring the telnet situation back into better shape.  Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
  module.
- Add connection encryption support to the Heimdal Kerberos 5
  module.  Hints on this can be taken from the MIT Kerberos 5
  module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

Bring the telnet situation back into better shape.  Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
  module.
- Add connection encryption support to the Heimdal Kerberos 5
  module.  Hints on this can be taken from the MIT Kerberos 5
  module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

WARNSify and RCSID cleanups

WARNSify

update libtelnet with changes through 95.10.23 version

new libtelnet from ftp.cray.com.  Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

initial import of 386bsd-0.1 sources

Initial revision