CVS log for src/lib/libpuffs/dispatcher.c

Up to [cvs.NetBSD.org] / src / lib / libpuffs

Request diff between arbitrary revisions

Default branch: MAIN
Current tag: MAIN

Revision 1.44 / (download) - annotate - [select for diffs], Thu Aug 16 09:25:43 2012 UTC (9 months ago) by manu
Branch: MAIN
CVS Tags: yamt-pagecache-base8, yamt-pagecache-base7, yamt-pagecache-base6, tls-maxphys-nbase, tls-maxphys-base, tls-maxphys, agc-symver-base, agc-symver, HEAD
Changes since 1.43: +24 -13 lines
Diff to previous 1.43 (colored)

Fix regression that has been introduced when the lookup/reclaim race
condition was addressed in libpuffs by counting lookups.

The fix assumes that cookies map to struct puffs_cookie, which has not
been documented as a requirement for filesystems using libpuffs. As an
example, we got burnt by this assumption in libp2k (kern/46734), and
we fixed bit by actually mapping libp2k cookies to struct puffs_node.

It is unlikely, but there may be third party filesystems that use cookies
unmapped to struct puffs_node, and they were left broken for now.

- we introduce a puffs_init() flag PUFFS_FLAG_PNCOOKIE that let filesystems
inform libpuffs that they map cookies to struct puffs_node. Is that flag
is used, the lookup/reclaim race condition fix is enabled. We enable the
flag for libp2k.

- filesystems that use puffs_pn_new() obviouslty use struct puffs_node
and gain PUFFS_FLAG_PNCOOKIE automatically even if they did not specify
it in puffs_init(). This include all our PUFFS filesystem in-tree except
libp2k.

- for filesystems not willing to use struct puffs_node, we introduce a
reclaim2 vnop, which is reclaim with an additionnal lookup count argument.
This vnop let the filesystem implement the lookup/reclaim race fix on
its own.

Revision 1.43 / (download) - annotate - [select for diffs], Fri Aug 10 08:42:10 2012 UTC (9 months, 1 week ago) by manu
Branch: MAIN
Changes since 1.42: +26 -10 lines
Diff to previous 1.42 (colored)

Fix race condition between (create|mknod|mkdir|symlino) and reclaim, just
like we did it between lookup and reclaim.

Revision 1.42 / (download) - annotate - [select for diffs], Sat Jul 21 05:17:10 2012 UTC (10 months ago) by manu
Branch: MAIN
Changes since 1.41: +25 -3 lines
Diff to previous 1.41 (colored)

- Improve PUFFS_KFLAG_CACHE_FS_TTL by reclaiming older inactive nodes.

The normal kernel behavior is to retain inactive nodes in the freelist
until it runs out of vnodes. This has some merit for local filesystems,
where the cost of an allocation is about the same as the cost of a
lookup. But that situation is not true for distributed filesystems.
On the other hand, keeping inactive nodes for a long time hold memory
in the file server process, and when the kernel runs out of vnodes, it
produce reclaim avalanches that increase lattency for other operations.

We do not reclaim inactive vnodes immediatly either, as they may be
looked up again shortly. Instead we introduce a grace time and we
reclaim nodes that have been inactive beyond the grace time.

- Fix lookup/reclaim race condition.

The above improvement undercovered a race condition between lookup and
reclaim. If we reclaimed a vnode associated with a userland cookie while
a lookup returning that same cookiewas inprogress, then the kernel ends
up with a vnode associated with a cookie that has been reclaimed in
userland. Next operation on the cookie will crash (or at least confuse)
the filesystem.

We fix this by introducing a lookup count in kernel and userland. On
reclaim, the kernel sends the count, which enable userland to detect
situation where it initiated a lookup that is not completed in kernel.
In such a situation, the reclaim must be ignored, as the node is about
to be looked up again.

Revision 1.41 / (download) - annotate - [select for diffs], Wed Jun 27 13:25:23 2012 UTC (10 months, 3 weeks ago) by manu
Branch: MAIN
Changes since 1.40: +25 -8 lines
Diff to previous 1.40 (colored)

Pass the FAF flag to handlers:
- setattr_ttl is updated to add a flag argument. Since it was not present in
  a previous release, we can change its API
- write2 is introduced, this is write with an extra flag for FAF.
- fsync already has the FAF information in a flag and needs no change
- for other operations, FAF is unconditional

Revision 1.40 / (download) - annotate - [select for diffs], Wed Apr 18 00:57:22 2012 UTC (13 months ago) by manu
Branch: MAIN
CVS Tags: yamt-pagecache-base5
Changes since 1.39: +51 -82 lines
Diff to previous 1.39 (colored)

- When using PUFFS_KFLAG_CACHE_FS_TTL, do not use puffs_node to carry
  attribute and TTL fora newly created node. Instead extend puffs_newinfo
  and add puffs_newinfo_setva() and puffs_newinfo_setttl()
- Remove node_mk_common_final in libperfuse. It used to set uid/gid for
  a newly created vnode but has been made redundant along time ago since
  uid and gid are properly set in FUSE header.
- In libperfuse, check for corner case where opc = 0 on INACTIVE and   RECLAIM (how is it possible? Check for it to avoid a crash anyway)
- In libperfuse, make sure we unlimit RLIMIT_AS and RLIMIT_DATA so that
  we do notrun out of memory because the kernel is lazy at reclaiming vnodes.
- In libperfuse, cleanup style of perfuse_destroy_pn()

Revision 1.39 / (download) - annotate - [select for diffs], Sun Apr 8 15:07:45 2012 UTC (13 months, 2 weeks ago) by manu
Branch: MAIN
CVS Tags: yamt-pagecache-base4
Changes since 1.38: +75 -4 lines
Diff to previous 1.38 (colored)

Add PUFFS_KFLAG_CACHE_FS_TTL flag to puffs_init(3) to use name and
attribute cache with filesystem provided TTL.
lookup, create, mknod, mkdir, symlink, getattr and setattr messages
have been extended so that attributes and their TTL can be provided
by the filesytem. lookup, create, mknod, mkdir, and symlink messages
are also extended so that the filesystem can provide name TTL.
The filesystem updates attributes and TTL using
puffs_pn_getvap(3), puffs_pn_getvattl(3), and puffs_pn_getcnttl(3)

Revision 1.38 / (download) - annotate - [select for diffs], Fri Nov 25 15:02:02 2011 UTC (17 months, 3 weeks ago) by manu
Branch: MAIN
CVS Tags: netbsd-6-base
Branch point for: netbsd-6
Changes since 1.37: +2 -20 lines
Diff to previous 1.37 (colored)

Rollback previous change as it breaks autmates tests

Revision 1.37 / (download) - annotate - [select for diffs], Thu Nov 24 01:58:52 2011 UTC (17 months, 4 weeks ago) by manu
Branch: MAIN
Changes since 1.36: +20 -2 lines
Diff to previous 1.36 (colored)

Remove files specified in pcn.

When remove files using name from pnode, another link on this file
can be unlinked. E.g. "touch 1; ln 1 2; rm 2" will remove file named
"1". Thus puffs_null_node_remove should remove directory entry which
name is provided by pcn (as said in puffs_ops.3). Caller should
provide appropriately initialized pcn.

From Evgeniy Ivanov <lolkaantimat@gmail.com>

Revision 1.36 / (download) - annotate - [select for diffs], Mon Jul 4 08:07:30 2011 UTC (22 months, 2 weeks ago) by manu
Branch: MAIN
CVS Tags: yamt-pagecache-base3, yamt-pagecache-base2, yamt-pagecache-base
Branch point for: yamt-pagecache
Changes since 1.35: +5 -3 lines
Diff to previous 1.35 (colored)

Add a flag to VOP_LISTEXTATTR(9) so that the vnode interface can tell the
filesystem in which format extended attribute shall be listed.

There are currently two formats:
- NUL-terminated strings, used for listxattr(2), this is the default.
- one byte length-pprefixed, non NUL-terminated strings, used for
  extattr_list_file(2), which is obtanined by setting the
  EXTATTR_LIST_PREFIXLEN flag to VOP_LISTEXTATTR(9)

This approach avoid the need for converting the list back and forth, except
in libperfuse, since FUSE uses NUL-terminated strings, and the kernel may
have requested EXTATTR_LIST_PREFIXLEN.

Revision 1.35 / (download) - annotate - [select for diffs], Mon Dec 6 14:50:34 2010 UTC (2 years, 5 months ago) by pooka
Branch: MAIN
CVS Tags: matt-mips64-premerge-20101231, cherry-xenmp-base, cherry-xenmp, bouyer-quota2-nbase, bouyer-quota2-base, bouyer-quota2
Changes since 1.34: +2 -14 lines
Diff to previous 1.34 (colored)

Remove PUFFS_WITH_THREADS ifdef garbage, just use libc weak symbols.

Revision 1.34 / (download) - annotate - [select for diffs], Fri May 21 10:50:52 2010 UTC (3 years ago) by pooka
Branch: MAIN
Changes since 1.33: +135 -7 lines
Diff to previous 1.33 (colored)

* support extended attributes
* bump major due to structure growth
* add some spare space
* remove ABI sillyness

Revision 1.33 / (download) - annotate - [select for diffs], Sat Oct 17 23:19:52 2009 UTC (3 years, 7 months ago) by pooka
Branch: MAIN
CVS Tags: matt-premerge-20091211
Changes since 1.32: +23 -2 lines
Diff to previous 1.32 (colored)

Dispatch puffs_node_abortop().

Note: We use the storage of puffs_cache_write from puffs_ops for
this purpose.  It's not issued by the kernel and hence currently
unused, and this saves us from the trouble of bumping the lib major
version.

Revision 1.32 / (download) - annotate - [select for diffs], Tue Aug 12 19:44:39 2008 UTC (4 years, 9 months ago) by pooka
Branch: MAIN
CVS Tags: wrstuden-revivesa-base-3, wrstuden-revivesa-base-2, netbsd-5-base, netbsd-5-0-RELEASE, netbsd-5-0-RC4, netbsd-5-0-RC3, netbsd-5-0-RC2, netbsd-5-0-RC1, netbsd-5-0-2-RELEASE, netbsd-5-0-1-RELEASE, netbsd-5-0, matt-nb5-mips64-u2-k2-k4-k7-k8-k9, matt-nb5-mips64-u1-k1-k5, matt-nb5-mips64-premerge-20091211, matt-nb4-mips64-k7-u2a-k9b, matt-mips64-base2, jym-xensuspend-nbase, jym-xensuspend-base, jym-xensuspend
Branch point for: netbsd-5, matt-nb5-mips64
Changes since 1.31: +3 -3 lines
Diff to previous 1.31 (colored)

Replace void * by puffs_cookie_t where appropriate.  No functional change.

Revision 1.31 / (download) - annotate - [select for diffs], Thu Mar 20 15:28:03 2008 UTC (5 years, 2 months ago) by pooka
Branch: MAIN
CVS Tags: yamt-pf42-baseX, yamt-pf42-base4, yamt-pf42-base3, yamt-pf42-base2, yamt-pf42-base, yamt-pf42, wrstuden-revivesa-base-1, wrstuden-revivesa-base, matt-armv6-nbase, keiichi-mipv6-base, hpcarm-cleanup-nbase
Branch point for: wrstuden-revivesa
Changes since 1.30: +25 -5 lines
Diff to previous 1.30 (colored)

Reserve enough memory for ops which return more than they receive.

Revision 1.30 / (download) - annotate - [select for diffs], Mon Jan 28 18:35:50 2008 UTC (5 years, 3 months ago) by pooka
Branch: MAIN
CVS Tags: hpcarm-cleanup-base
Branch point for: keiichi-mipv6
Changes since 1.29: +80 -236 lines
Diff to previous 1.29 (colored)

Implement lazy contexts for file systems using puffs_mainloop().
Previously each request was executed on its own callcontext and
switched to every time the request was being processed.  Now requests
borrow the mainloop context and switch only if/when they yield.
This takes two context switches away from a file system request
bringing down the typical amounts 2->0 (e.g. dtfs) and 4->2 (e.g.
psshfs).

The interfaces for manually executing requests changed a bit:
puffs_dispatch_create() and puffs_dispatch_exec() must now be used.
They are not tested, as nothing in-tree wants them and I doubt
anyone else is really interested in them either.

Also do some misc code cleanup related to execution contexts.  The
"work-in-progress checkpoint" committed over a year ago was starting
to look slightly weed-infested.

Revision 1.29 / (download) - annotate - [select for diffs], Wed Jan 16 23:17:43 2008 UTC (5 years, 4 months ago) by pooka
Branch: MAIN
Changes since 1.28: +14 -6 lines
Diff to previous 1.28 (colored)

Comment out the puffs_executor hacks for now, they have races.
The issue should be solved in another fashion anyway.

Revision 1.28 / (download) - annotate - [select for diffs], Wed Jan 16 21:30:00 2008 UTC (5 years, 4 months ago) by pooka
Branch: MAIN
Changes since 1.27: +4 -4 lines
Diff to previous 1.27 (colored)

Cache a number of execution contexts instead of re-initializing
them every time.  Speeds up pure in-memory file systems such as
sysctlfs or dtfs quite a bit.  For actual I/O-workhorses the result
is of course less tasty.

Revision 1.27 / (download) - annotate - [select for diffs], Sun Dec 16 20:02:57 2007 UTC (5 years, 5 months ago) by pooka
Branch: MAIN
CVS Tags: matt-armv6-base
Changes since 1.26: +6 -6 lines
Diff to previous 1.26 (colored)

* nuke puffs_cc_get{specific,usermount} for good
* move prototypes for puffs_docc and puffs_dopufbuf into the
  public header, as they are should be exposed

Revision 1.26 / (download) - annotate - [select for diffs], Sat Dec 8 19:57:03 2007 UTC (5 years, 5 months ago) by pooka
Branch: MAIN
CVS Tags: cube-autoconf-base, cube-autoconf
Changes since 1.25: +2 -14 lines
Diff to previous 1.25 (colored)

Now that "l" is gone both as an argument to operations and from
componentname, remove all vestiges of puffs_cid.

Revision 1.25 / (download) - annotate - [select for diffs], Tue Dec 4 21:24:10 2007 UTC (5 years, 5 months ago) by pooka
Branch: MAIN
Changes since 1.24: +54 -54 lines
Diff to previous 1.24 (colored)

Part 3/n of extensive changes to message handling:

Get rid of the original puffs_req(3) framework and use puffs_framebuf(3)
instead for file system requests.  It has the advantage of being
suitable for transporting a distributed message passing protocol
and therefore us being able to run the file system server on any
host.

Ok, puffs is not quite here yet: libpuffs needs to grow request
routing support and the message contents need to be munged into a
host independent format.  Saying which format would be telling,
but it might begin with an X, end in an L and have the 13th character
in the middle.  Keep an eye out for the sequels: Parts 3+m/n.

Revision 1.24 / (download) - annotate - [select for diffs], Fri Nov 30 19:02:28 2007 UTC (5 years, 5 months ago) by pooka
Branch: MAIN
Changes since 1.23: +37 -37 lines
Diff to previous 1.23 (colored)

Rototill.

Ok, ok, a few more words about it: stop holding puffs_cc as a holy
value and passing it around to almost every possible place (popquiz:
which kernel variable does this remind you of?).  Instead, pass
the natural choice, puffs_usermount, and fetch puffs_cc via
puffs_cc_getcc() only in routines which actually need it.  This
not only simplifies code, but (thanks to the introduction of
puffs_cc_getcc()) enables constructs which weren't previously sanely
possible, say layering as a curious example.

There's still a little to do on this front, but this was the major
fs interface blast.

Revision 1.23 / (download) - annotate - [select for diffs], Thu Nov 29 17:47:55 2007 UTC (5 years, 5 months ago) by pooka
Branch: MAIN
Changes since 1.22: +3 -2 lines
Diff to previous 1.22 (colored)

* allocate pcc as a slice from the stack instead of allocating it
  separately
* provide puffs_cc_getcc()

This is in preparation for the removal of you-should-guess-what as
an argument to routines here and there and everywhere.

Revision 1.22 / (download) - annotate - [select for diffs], Tue Nov 27 11:31:19 2007 UTC (5 years, 5 months ago) by pooka
Branch: MAIN
Changes since 1.21: +15 -38 lines
Diff to previous 1.21 (colored)

Remove "puffs_cid" from the puffs interface following l-removal
from the kernel vfs interfaces.  puffs_cc_getcaller(pcc) can be
used now should the same information be desired.

Revision 1.21 / (download) - annotate - [select for diffs], Wed Oct 31 16:09:09 2007 UTC (5 years, 6 months ago) by pooka
Branch: MAIN
Changes since 1.20: +3 -6 lines
Diff to previous 1.20 (colored)

Fix a few bugs and memleaks with the threading code.

Revision 1.20 / (download) - annotate - [select for diffs], Mon Oct 29 17:47:33 2007 UTC (5 years, 6 months ago) by pooka
Branch: MAIN
Changes since 1.19: +4 -2 lines
Diff to previous 1.19 (colored)

lock massage, although I don't think there's a happy ending here

Revision 1.19 / (download) - annotate - [select for diffs], Mon Oct 29 15:52:44 2007 UTC (5 years, 6 months ago) by pooka
Branch: MAIN
Changes since 1.18: +14 -8 lines
Diff to previous 1.18 (colored)

Sprinkle some hackish locks here and there, just enough to allow
libp2k & rump to run multithreaded.

Revision 1.18 / (download) - annotate - [select for diffs], Sun Oct 28 18:40:30 2007 UTC (5 years, 6 months ago) by pooka
Branch: MAIN
Changes since 1.17: +11 -6 lines
Diff to previous 1.17 (colored)

Add possibility to set pre- and post callbacks which will be called
for all operations before or after executing the specific callback
(the api is not be final yet, though).

Revision 1.17 / (download) - annotate - [select for diffs], Fri Oct 26 17:35:01 2007 UTC (5 years, 6 months ago) by pooka
Branch: MAIN
Changes since 1.16: +142 -27 lines
Diff to previous 1.16 (colored)

Add some very initial support for a threading worker model as an
alternative to the (vastly superior ;) continuation model.  This
is very preliminary stuff and not compiled by default (which it
even won't do without some other patches I cannot commit yet).

The raison d'commit of the patch is a snippet which ensures proper
in-order dispatching of all operations, including those which don't
require a response.  Previously many of them would be dispatched
simultaneosly, e.g. fsync and reclaim on the same node, which
obviously isn't all that nice for correct operation.

Revision 1.16 / (download) - annotate - [select for diffs], Sun Oct 21 14:28:05 2007 UTC (5 years, 7 months ago) by pooka
Branch: MAIN
Changes since 1.15: +4 -2 lines
Diff to previous 1.15 (colored)

Always provide caller information from the kernel based on curlwp.
(but don't deprecate the old puffs_cid interface just yet)

Revision 1.15 / (download) - annotate - [select for diffs], Thu Oct 11 19:41:14 2007 UTC (5 years, 7 months ago) by pooka
Branch: MAIN
Changes since 1.14: +38 -43 lines
Diff to previous 1.14 (colored)

Part 1/n of some pretty extensive changes to how the kernel module
interacts with the userspace file server:

  * since the kernel-user communication is not purely request-response
    anymore (hasn't been since 2006), try to rename some "request" to
    "message".  more similar mangling will take place in the future.

  * completely rework how messages are allocated.  previously most of
    them were borrowed from the stack (originally *all* of them),
    but now always allocate dynamically.  this makes the structure
    of the code much cleaner.  also makes it possible to fix a
    locking order violation.  it enables plenty of future enhancements.

  * start generalizing the transport interface to be independent of puffs

  * move transport interface to read/write instead of ioctl.  the
    old one had legacy design problems, and besides, ioctl's suck.
    implement a very generic version for now; this will be
    worked on later hopefully some day reaching "highly optimized".

  * implement libpuffs support behind existing library request
    interfaces.  this will change eventually (I hate those interfaces)

Revision 1.14 / (download) - annotate - [select for diffs], Tue Oct 9 21:04:55 2007 UTC (5 years, 7 months ago) by pooka
Branch: MAIN
Changes since 1.13: +2 -136 lines
Diff to previous 1.13 (colored)

g/c #if 0'd code which isn't likely to get used any time soon

Revision 1.13 / (download) - annotate - [select for diffs], Mon Oct 1 21:10:50 2007 UTC (5 years, 7 months ago) by pooka
Branch: MAIN
Changes since 1.12: +3 -3 lines
Diff to previous 1.12 (colored)

Pass reason string to pu_errnotify.  Print it in the default
version before aborting.

Revision 1.12 / (download) - annotate - [select for diffs], Thu Sep 27 21:14:49 2007 UTC (5 years, 7 months ago) by pooka
Branch: MAIN
Changes since 1.11: +11 -2 lines
Diff to previous 1.11 (colored)

Add error notifications, which are used to deliver errors from the
kernel to the file server for silly things the file server did,
e.g. attempting to create a file with size VSIZENOTSET.  The file
server can handle these as it chooses, but the default action is
for it to throw its hands in the air and sing "goodbye, cruel world,
it's over, walk on by".

Revision 1.11 / (download) - annotate - [select for diffs], Fri Jul 27 08:28:16 2007 UTC (5 years, 9 months ago) by pooka
Branch: MAIN
CVS Tags: matt-mips64-base, hpcarm-cleanup
Branch point for: matt-mips64, matt-armv6
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

mmap fflags -> prot

Revision 1.10 / (download) - annotate - [select for diffs], Mon Jul 2 10:24:17 2007 UTC (5 years, 10 months ago) by pooka
Branch: MAIN
Changes since 1.9: +3 -5 lines
Diff to previous 1.9 (colored)

Get rid of the "int *refs" parameter to inactive: the same can be
accomplished now with puffs_setbacks.

Revision 1.9 / (download) - annotate - [select for diffs], Sun Jul 1 18:39:39 2007 UTC (5 years, 10 months ago) by pooka
Branch: MAIN
Changes since 1.8: +40 -15 lines
Diff to previous 1.8 (colored)

Instead of requesting various pieces of information from node-creating
methods using "please fill me"-pointers, pass "struct puffs_newinfo *"
and provide methods to fill in new node info.

Revision 1.8 / (download) - annotate - [select for diffs], Sun Jul 1 17:22:18 2007 UTC (5 years, 10 months ago) by pooka
Branch: MAIN
Changes since 1.7: +50 -18 lines
Diff to previous 1.7 (colored)

Instead of supplying a plain pid, supply an abstract struct puffs_cid *,
which can currently be used to query the pid and lwpid.

Revision 1.7 / (download) - annotate - [select for diffs], Sun Jul 1 15:30:15 2007 UTC (5 years, 10 months ago) by pooka
Branch: MAIN
Changes since 1.6: +58 -24 lines
Diff to previous 1.6 (colored)

make puffs_cred an opaque type

Revision 1.6 / (download) - annotate - [select for diffs], Wed Jun 6 01:55:01 2007 UTC (5 years, 11 months ago) by pooka
Branch: MAIN
Changes since 1.5: +2 -5 lines
Diff to previous 1.5 (colored)

Move puffs to a two clause license where it already isn't so.  And
as agc pointed out, even files with the third clause were already
effectively two clause because of a slight bug in the language...

Revision 1.5 / (download) - annotate - [select for diffs], Fri May 18 18:01:55 2007 UTC (6 years ago) by pooka
Branch: MAIN
Changes since 1.4: +3 -2 lines
Diff to previous 1.4 (colored)

default refcount to 1 in inactive

Revision 1.4 / (download) - annotate - [select for diffs], Fri May 18 13:53:54 2007 UTC (6 years ago) by pooka
Branch: MAIN
Changes since 1.3: +21 -15 lines
Diff to previous 1.3 (colored)

dispatch PUFFS_VN_POLL

Revision 1.3 / (download) - annotate - [select for diffs], Tue May 15 13:44:46 2007 UTC (6 years ago) by pooka
Branch: MAIN
Changes since 1.2: +55 -40 lines
Diff to previous 1.2 (colored)

Step 3 and currently final step of a more general purpose event loop:
support removal and addition of i/o file descriptors on the fly.

* detect closed file descriptors
* automatically free waiters of a dead file descriptor
* give the file server the possibility to specify a callback which
  notifies of a dead file descriptor
* move loop function to be a property of the mainloop instead of
  framebuf (doesn't change effective behaviour)
* add the possibility to configure a timespec parameter which
  attempts to call the loop function periodically
* move the event loop functions from the puffs_framebuf namespace
  to puffs_framev to differential between pure memory management
  functions

Revision 1.2 / (download) - annotate - [select for diffs], Fri May 11 21:44:00 2007 UTC (6 years ago) by pooka
Branch: MAIN
Changes since 1.1: +4 -5 lines
Diff to previous 1.1 (colored)

copyright adjustment

Revision 1.1 / (download) - annotate - [select for diffs], Fri May 11 21:42:42 2007 UTC (6 years ago) by pooka
Branch: MAIN

move puffs request dispatching code into it's own module.
no functional change

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.