CVS log for src/lib/libcompat/4.3/ruserpass.c

Up to [cvs.NetBSD.org] / src / lib / libcompat / 4.3

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

libc, libcompat: fix lint warning about "effectively discards 'const'"

lib/libc/time/zic.c(2810): warning: call to 'strchr' effectively
discards 'const' from argument [346]

lib/libcompat/4.3/ruserpass.c(145): warning: call to 'strchr'
effectively discards 'const' from argument [346]

No binary change.

Don't use NULL to compare against an int.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22280, verified by myself.

check LIBC_SCCS

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
  descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
  and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

		_DIAGASSERT(path != NULL)
	#ifdef _DIAGNOSTIC
		if (path == NULL) {
			errno = EFAULT;
			return (-1);
		}
	#endif

- add a comparison to NULL in a conditional.
- cast third argument of strn*() to size_t
- s/FALL THROUGH/FALLTHROUGH/

Add some braces to make egcs happy.

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

FTP uses ruserpass() differently from that in libcompat.  Fix rexec to
recognize that the new ruserpass returns an int (but ignore it for now),
and ruserpass does not accept an acct pointer.

Add a ruserpass() function to make rexec happy.  PR 901 (that's not a typo).