CVS log for src/lib/libc/gen/getpwent.c

Up to [cvs.NetBSD.org] / src / lib / libc / gen

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Catch up with all the lint warnings since exit on warning was disabled.
Disable 'missing header declaration' and 'nested extern' warnings for now.

lib: remove CONSTCOND comment

Since 2021-01-31, lint doesn't need it anymore for the common pattern of
'do ... while (0)'.

Sync with HEAD

don't include machine/param.h <sys/param.h> already does WTF?

Pull up following revision(s) (requested by christos in ticket #979):
	lib/libc/gen/getpwent.c: revision 1.79
PR/46279: Dr. W. Stukenbrock: Off-by-one in buffer length check and make sure
that the password fits in the supplied buffer.

sync with head

Revert previous temporary measure and fix the assertion properly instead.

Disable bogus _DIAGASSERT.

sync with head

PR/46279: Dr. W. Stukenbrock: Off-by-one in buffer length check and make sure
that the password fits in the supplied buffer.

PR?40728: W. Stukenbrock: Fix various issues with NIS-netgroups in users
and groups.

remove some stray __weak_aliases, where the target functions were
__RENAMEd due to the time_t/dev_t type changes, which caused bogus
references to compat functions
now a libc built with BUILDCOLD is usable

merge christos-time_t

don't hard-code 8.

- add a VERSION tag in the db files to handle new and old version passwd
  entries.
XXX: Need to add the tag in mkpasswd.

sync with head.

file getpwent.c was added on branch christos-time_t on 2008-11-23 21:44:07 +0000

Remove clause 3 and 4 from TNF licenses

make this compile with DIAGNOSTIC

fix incomplete initializers

Pull up following revision(s) (requested by ginsbach in ticket #1399):
	lib/libc/gen/getpwent.c: revision 1.72
Fix YP lookup latency reported by Stephen M. Jones on tech-net.  This is a
performance regression between 2.0 and 3.0.  The passwd compat method was
incorrectly querying the NIS server with yp_first()/yp_next() rather than
using yp_match() with the correct key.

Fix YP lookup latency reported by Stephen M. Jones on tech-net.  This is a
performance regression between 2.0 and 3.0.  The passwd compat method was
incorrectly querying the NIS server with yp_first()/yp_next() rather than
using yp_match() with the correct key.

Coverity CID 708: Remove dead code.

Pull up revision 1.68 (requested by lukem in ticket #540):
getpw{ent,nam,uid}_r():
Return 0 "entry not found" and errno for other failures.
("entry not found" still sets *result to NULL).
Various backends:
don't set the retval to errno (or modify errno) for NS_NOTFOUND.
Per discussion with Klaus Klein.

Pull up revision 1.67 (requested by lukem in ticket #540):
PR/29849, PR/29850: Add getpwent_r and getgrent_r

Cosmetic tweak previous; IMHO we don't need the XXX comment in this
case, since I prefer to NULL initialize variables in this situation.

Add an initialization to appease -Wuninitialized.  Apparently the
sparc64 compiler gets this wrong.

getpw{ent,nam,uid}_r():
Return 0 "entry not found" and errno for other failures.
("entry not found" still sets *result to NULL).

Various backends:
don't set the retval to errno (or modify errno) for NS_NOTFOUND.

Per discussion with Klaus Klein.

PR/29849, PR/29850: Add getpwent_r and getgrent_r

Restore getpwent() behaviour prior to rev 1.57; skip dodgy NIS & DNS entries
rather than failing with NS_UNAVAIL when encountering them.
Fixes PR 29272 by Antoine Reilles.

Use the common __nsdefaultFOO rather than private defaultFOO duplicates.

Use _GETPW_R_SIZE_MAX from <limits.h> rather than defining a private version.

default to "compat" not "files"

#include "reentrant.h" instead of <threadlib.h>

Protect access to all public functions via a mutex as some of the backends are
not reentrant (such as compat, because it uses the non reentrant getnetgrent(3)
to implement `+@netgrp' & `-@netgrp').

Fix MKYP=no MKHESIOD=no build.
Rename an internal function to a more appropriate name.

Ensure that _nis_start(&state) has been called before using PASSWD_BYNAME()
or PASSWD_BYUID(), otherwise state.maptype won't be correct and the wrong
map may be selected (e.g., "passwd.by*" instead of "master.passwd.by*").

Set _PASSWORD_NOWARN in flags to __pw_scan(), so libc won't display parse
errors to stderr.  (This was the behaviour before my recent rototill.)

Fixes PR 27168 from Markus W Kilbinger.

Use PASSWD_BYxxx(state) macros instead of "passwd.byxxx" to refer to
the NIS "passwd.by*" maps.
Fixes problem with "passwd_compat: nis" noted by Matthias Scheler.

Overhaul the use of nsdispatch(3) by public APIs so that the back-end
methods use va_list in a manner that is directly related to the public API.
This makes it much easier to write dynamic nsswitch backends for getpwent(3).
Per my proposal on tech-userlevel.

Implement getpwgid_r() and getpwnam_r() APIs per the POSIX 1003.1, 2004 Ed.
These aren't fully reentrant or threadsafe yet, because the compat stuff
currently uses non-reentrant data sources (getnetgrent(3), getpwent(3)),
and there is probably some locking to be improved in the backends.
This will be fixed in the near future.
We also need to add _SC_GETPW_R_SIZE_MAX to sysconf(3).

Fix the compat `+' prototype override so getpwnam(3) and getpwuid(3) DTRT.

Improve the description of pw_class and pw_gecos.

Fix compile problem if -UYP -DHESIOD.
Noted on current-users by Srinivasa Kanduru.

Move Jason Downs's code from a 4-clause to a 3-clause licence by
removing the advertising clause.  Diffs provided in PR 22410 by Joel
Baker, confirmed to the board by Jason Downs.

With additional thanks to Jason Thorpe.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22280, verified by myself.

Sync with HEAD.

use strlcpy where it is more appropriate.

Catch up to -current

Fix signed/unsigned comparison warnings.

Catch up to -current.

__STDC__ is always defined on NetBSD.

Catch up to -current.

Pull up revision 1.50 (requested by groo):
  Replace an instance of erroneous usage of strncpy() with strlcpy().

Pull up revision 1.49 (requested by he):
  Return an error if we try to look up a user name that is too long,
  rather than trying to truncate.  Fixes non-exploitable core dump
  problem inside DB.

botched strncpy -> strlcpy
from xs@kittenz.org

Catch up to -current.

Catch up to -current.

Just return an error if we try to look up a user name that's too long, rather
than trying to truncate.  The previous truncation code actually set key.size
too large and caused a (non-exploitable) core dump inside DB.

Pull up rev. 1.48 (approved by jhawk):
Reset allocated buffer size to 0 on allocation failure.

Reset allocated buffer size to 0 on allocation failure.

Pull up rev 1.47 (approved by thorpej):
  Fix potential buffer overflow processing long password database entries.
  Inspired by similar OpenBSD change.

Fix potential buffer overflow processing long password database entries.
Inspired by similar OpenBSD change.

Delint.
Remove trailing ; from uses of __weak_alias().  The macro inserts this if
needed.

* use _DIAGASSERT() to check pointer arguments against NULL and file
  descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
  and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

		_DIAGASSERT(path != NULL)
	#ifdef _DIAGNOSTIC
		if (path == NULL) {
			errno = EFAULT;
			return (-1);
		}
	#endif

pullup 1.43->1.44 (ross)

pullup 1.41->1.43 (lukem)

Unconditionalize `rval' declaration referenced in usr.bin/chpass/ via .PATH

change dns_getpw() to skip dodgy entries when doing getpwent(), rather
than returning NS_UNAVAIL. this means that a -ve uid entry in hesiod
doesn't stop getpwent() in its tracks. it also brings it in line with
how nis_getpw() works as well in this situation.
problem tracked down (with much pain & suffereing) by simonb.

XXX: we currently have no support for -ve uids, and this is painful in
XXX: hetrogenous environment... (this -ve check is enforced in __pwscan())

change getpwent() backends so that a flag (per source) is set once the
source has been exhausted. this allows getpwent() across multiple
sources (e.g, ``passwd: files nis'') to work correctly. the flags are
reset in setpassent()/endpwent().

this fixes a bug noted in [lib/7449] by thorpej, and tracked down to
getpwent() as being the culprit by simonb.

specifically include stdarg/varargs.h

always compile in support for `compat' backends (even if !YP & !HESIOD),
and make it the responsibility of the backends to fallback to `files'
if !YP & !HESIOD. fixes chsh problem noted by billc@netbsd.org.

convert from hes_*() -> hesiod_*()

Use the right map for Hesiod lookups by uid.

- remove unneeded casts
- remove unreachable code
- delint

* `passwd' defaults to `compat', and `passwd_compat' defaults to `nis'
* constify ns_dtab defs

* maximum limit of names is MAXLOGNAME not UT_NAMESIZE. fixes [bin/6847] from
  scott ellis.
* convert to new nsdispatch(3)

* fix _compat_getpw so that it returns _local_getpw(...) if there
  isn't a `+' token in the files database.
  (this bug probably crept in when a merge to current occurred)
* ensure that the _bad_getpw callbacks in __getpwcompat have an
  argument for error reporting.

fix some uid casts

pull nsswitch up to main branch

use new ns_dtab structure

missed an #if

avoid assignment of a read only location that lint does not pick, but gcc does.

delint

sync with current

fix bcopy->memcpy with memcpy->memmove -- not strictly needed, but...

bzero->memset, bcopy->memcpy, bcmp->memcmp

Fix a serious symbol collision problem introduced when pw_scan() was added
to libc.  Note, pw_scan() is NO LONGER exported from libc (it never should
have been, and we're just going to pretend like it never was).

* move pw_scan() from libutil to libc
* add support for YP "master.passwd.by*" (master.passwd in YP, including
  pw_passwd) and "passwd.adjunct.by*" (SunOS `secure' maps (?)), based
  on code in FreeBSD and partially from OpenBSD.
  this is only used if euid == 0.
  with this, the YP "passwd.by*" maps can have `*' in the pw_passwd field.
* use pw_scan() to parse YP "passwd.by*" and "master.passwd.by*" entries

XXX: i didn't test the "passwd.adjunct" support...

allow root to use pwd.db.

merge/update to lite-2

import lite-2

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore.  The library will use those
names internally.  Weak aliases are used to provide the original names
to the API.

This is only the first part of this change.  It is most of the functions
which are implemented in C for all NetBSD ports.  Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix gcc warnings (unused variables, missing prototypes, etc.)
Fix RCSID's

* set _pw_none = 1 && return NS_SUCCESS in _*_getpwent() at EOF, so that
  getpwent() won't merge sources.

only initialise ns_dtab if it hasn't been done yet

convert to using nsdispatch()

a valid uid/gid *ends* in \0 (i.e, barf if (*ep != '\0'), not if (*ep == '\0'))

* parse gid with strtoul() instead of atoi(), and sanity check a) the parsed
  value was just a number, b) it doesn't exceed GID_MAX
* convert gid to a string with %u not %d
* use [gu]id_t instead of int

* parse uid with strtoul() instead of atoi(), and sanity check a) the parsed
  value was just a number, b) it doesn't exceed UID_MAX
* convert uid to a string with %u not %d

fix potential memory leaks: before calling yp_next(), reset key to NULL. if
an error occurred, and key != NULL, free(key).

* fix [lib/3580], by ensuring that the outdata arg to the yp_xxx()
  calls is initialised to the null pointer so that the error condition
  doesn't fail by trying to free() memory that wasn't malloc()ed
* cleanup a bit; remove use of register, KNFify

- convert unsafe strcpy(), strcat() and sprintf() to the `n' versions.
- some KNF.

Longer login name support: use MAXLOGNAME, not UT_NAMESIZE

initial nsswitch implementation

snapshot namespace cleanup: gen

snapshot namespace cleanup

Improvements to YP support from Jason Downs.

Modify getpwent() to use __ypparse().

#include "namespace.h"

update from Lite, with local changes.  fix Ids, etc.

from lite, with minor name rearrangement to fit.

__initdb() should only warn about spwd.db errors once, fix from
Cornelis van der Laan <nils@merlin.ims.uni-stuttgart.de>

speed up getpwnam/getpwuid for standard cases

Update source and manual pages to match X/Open 1170 specification.
Updated setpassent() to understand YP (a bug), and changed setpwent()
to simply be a call to setpassent(0) (to remove duplicated code).

X/Open 1170 defines the return type of setpwent() to be void -- a trival
change since our setpwent() allways succeeded.

Declare rcsid strings so they are stored in text segment.

Add even more RCS frobs.

fixed a yp-related bug found by Paul Kranenburg <pk@cs.few.eur.nl>:
endpwent was free'ing passwd line.

I was horrified to find these had not been commited with the YP changes.

Opps, dbopen doesn't have an underscore. Fixed.

Fixed these twon files to use db_open instead of hash_open.

initial import of 386bsd-0.1 sources

Initial revision