CVS log for src/games/gomoku/bdinit.c

Up to [cvs.NetBSD.org] / src / games / gomoku

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

gomoku: remove redundant parentheses

No binary change.

gomoku: reduce usage of magic numbers in the code

No binary change.

gomoku: when starting a new game, start in the middle of the board

Previously, when starting a new game, the user coordinate was kept at
the previously selected spot. Since playing in the center is common
sense, reset the coordinate.

gomoku: don't use 'i' as special-purpose variable name

No binary change.

gomoku: consistently name the offset of a spot in a frame 'off'

Leave 'i' for general purpose loops.

No functional change.

gomoku: add data type for one of the 4 directions of a frame

No functional change.

gomoku: use proper types when indexing 'board' and 'frames'

No functional change.

gomoku: turn spotstr.s_frame into a frame index

Most calculations are done on the frame index, not the pointer. This
avoids dealing with ptrdiff_t conversion to int.

Changing the type of s_frame changes the size of struct spotstr, it is
now 56 bytes on LP64 and 48 bytes on ILP32, neither of which is a power
of two. Remove the dummy padding since compilers no longer generate
division instructions for divisions by small integer constants, so that
optimization is no longer necessary.

No functional change.

gomoku: migrate spot_index from int to unsigned short

This matches the type of 'intersect'.

No functional change.

gomoku: use consistent variable names

Previously, the name 's' was used for the index of a spot on the board,
as well as for the value of a combo, and for a few other purposes. Use
different names and mark the spot indexes using a custom type.

No binary change.

gomoku: clean up initialization of overlap information

Fix variable names 'ia' and 'ib', which I forgot in the previous commit.

Move the documentation in the right places.

Split off another part of init_overlap, to make each function fit on a
single screen. Reducing the number of nested 'for' loops allows the
indentation to follow the NetBSD style.

No functional change.

gomoku: clean up local variable names in init_overlap

By clearly associating each variable to either frame A or frame B,
suddenly the code becomes understandable. For the benefit of future
readers, explain the naming scheme.

No functional change.

gomoku: split initialization of the board into smaller functions

The comments about the "top border" and "bottom border" had been wrong
all the time. Mention the corners in the comments, to remove the magic
from the various '+ 1' in the code.

No functional change.

gomoku: highlight the winning frame

gomoku: group movelog and nmoves into a game struct

No functional change.

gomoku: replace 1-based movenum with 0-based nmoves

No functional change, not even the TIE that is wrongly announced when
the very last spot on the board is yet to be filled by Black.  Even
without this off-by-one error, it could be that filling the very last
spot completes a frame, so that code has been wrong all the time.

In practical terms, this situation only arises when the human player is
unconcentrated or the computer player has a bad strategy.  The latter
may well be, as the computer moves in the (boring) endgame are not
directed towards winning -- they fill irrelevant spots before relevant
ones.

gomoku: provide readable names for c.a and c.b

No binary change.

gomoku: inline macro MAXCOMBO

The name of the macro was not descriptive enough, the other constants in
bdinit also don't have names.

No binary change.

gomoku: use NULL instead of more verbose null pointer

No binary change.

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: de-obfuscate screen coordinate calculation

Modern compilers optimize linear integer arithmetic, so there is no
reason to use strange or misleading formulas.

Replace several magic numbers with proper formulas.

No binary change.

gomoku: reduce scope of local variables

No binary change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: rename local variable

Not every array of "characters" is a string.  In this case, it's rather
an array of bool.

No binary change.

gomoku: prepare lint's strict bool mode

No binary change.

gomoku: fix lint warnings

Most warnings were about implicit conversions from ptrdiff_t to int; add
explicit cast for them, as they are far from overflowing int.

The casts from one pointer type to 'struct combostr **' were indeed
suspicious.  In these cases, a single region of memory is allocated to
store two objects of different type, without declaring a struct type for
their combination.  The second object is an array of variable size.

No binary change.

gomoku: inline macros BSZ1, BSZ2, BSZ3, BSZ4

These macro names didn't convey any meaning, so replace them with their
replacement text, to have fewer identifiers to worry about.

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8.  Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

Resync to 2012-11-19 00:00:00 UTC

sync with head

Pass -Wstrict-overflow... mostly.

sprinkle static

Increase spending on vowels. No object file diffs.

ANSIfy function declarations.x

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

WARNSify

fix NetBSD RCS ID headers

add gomoku game, from 4.4BSD-Lite2

Import of 4.4BSD-Lite2 source

Initial revision