CVS log for src/external/cddl/osnet/dist/lib/libdtrace/common/dt_module.c

Up to [cvs.NetBSD.org] / src / external / cddl / osnet / dist / lib / libdtrace / common

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

elftoolchain: Be consistent about which ELF header files we use.

1. For tools that use elftoolchain: always use elftoolchain's
   elfdefinitions.h.  Don't even think about looking at the host's
   sys/exec_elf.h, which makes no sense and should never happen.

   (ELF tools that don't use elftoolchain, like m68k-elf2coff,
   continue to use nbincludes/sys/exec_elf.h.  But no more nbincludes
   hacks in elftoolchain.)

2. For kernel components (solaris, zfs, dtrace): always use
   sys/exec_elf.h, even in Solaris components via sys/elf.h.
   elfdefinitions.h is not wired up in the kernel build at all.

3. For most userland components that involve libelf: use
   elfdefinitions.h via libelf header files (libelf.h, gelf.h).

   libdtrace in particular requires _all_ R_* reloc type definitions,
   but sys/exec_elf.h brings in only the _current machine's_ R_*
   reloc type definitions.  (While here: Use uintptr_t instead of
   Elf_Addr for pointer-to-integer cast, since Elf_Addr is MD and
   provided only by sys/exec_elf.h, not by elfdefinitions.h.)

   And most userland components using libelf don't rely on any
   properties of the current machine from sys/exec_elf.h, so they can
   use libelf's elfdefinition.h.

   Exceptions:

   - dtrace drti.c relies on link.h -> link_elf.h -> sys/exec_elf.h,
     but it also relies on sys/dtrace.h -> sys/elf.h ->
     elfdefinitions.h like other userland components using sys/elf.h.

   - kdump-ioctl.c uses sys/exec_elf.h directly and sys/dtrace.h ->
     sys/elf.h -> elfdefinitions like other userland components using
     sys/elf.h.

   - t_ptrace_wait.c (via t_ptrace_core_wait.h) uses libelf to parse
     core files, but relies on sys/exec_elf.h for struct
     netbsd_elfcore_procinfo.

   None of these exceptions needs all R_* reloc type definitions, so
   as a workaround, we can just suppress libelf's elfdefinitions.h by
   defining _SYS_ELFDEFINITIONS_H_ and use sys/exec_elf.h in these
   exceptions.

And undo the whole BUILTIN_ELF_HEADERS mistake.  This was:

- half bogus workarounds for missing build_install dependencies in
  tools/Makefile, which are no longer missing now, and
- half futile attempt to use src/sys/sys/exec_elf.h via nbincludes in
  tools involving libelf instead of libelf's elfdefinitions.h, which
  collides.

Longer-term, we may wish to unify sys/exec_elf.h and libelf's
elfdefinitions.h, so we don't have to play these games.

But at least now the games are limited to three .c files (one of
which is generated by Makefile.ioctl-c), rather than haphazardly
applied tree-wide by monstrous kludges in widely used .h files with
broken hackarounds to get the tools build lurching to completion.

Merge changes from current as of 20200406

Pull up following revision(s) (requested by riastradh in ticket #701):

	external/cddl/osnet/dev/dtrace/aarch64/dtrace_isa.c: revision 1.2
	external/cddl/osnet/dist/lib/libdtrace/common/dt_open.c: revision 1.17
	external/cddl/osnet/dist/lib/libdtrace/common/dt_module.c: revision 1.18
	sys/modules/cyclic/Makefile: revision 1.5
	external/cddl/osnet/dev/dtrace/aarch64/dtrace_subr.c: revision 1.2
	external/cddl/osnet/dev/dtrace/aarch64/dtrace_subr.c: revision 1.3
	sys/arch/aarch64/aarch64/vectors.S: revision 1.10
	external/cddl/osnet/dev/fbt/aarch64/fbt_isa.c: revision 1.2
	external/cddl/osnet/dev/fbt/aarch64/fbt_isa.c: revision 1.3
	external/cddl/osnet/dev/fbt/aarch64/fbt_isa.c: revision 1.4
	external/cddl/osnet/dev/fbt/aarch64/fbt_isa.c: revision 1.5
	external/cddl/osnet/dev/fbt/aarch64/fbt_isa.c: revision 1.6
	sys/arch/aarch64/include/cpu.h: revision 1.20
	external/cddl/osnet/dist/lib/libdtrace/common/dt_impl.h: revision 1.9

Create a buffer space of 512 bytes before the trapframe.

dtrace fbt needs enough space to emulate an

        stp     x29, x30, [sp,#-FRAMESIZE]!

instruction in a function prologue.  In the aarch64 instruction
encoding, FRAMESIZE can be as large as 512 bytes, so reserve this
much space when KDTRACE_HOOKS is enabled.

Use db_write_bytes to overwrite kernel text.

Tidy up a bit.  No functional change intended.

aarch64 fbt_invop doesn't actually use the argument, but it would
make more sense for it to be the return value and/or first argument
register.  Certainly it's not `eax'!

Tidy up a bit: don't set things we won't use; assert nonzeroness.

Use /dev/ksyms, not /netbsd, for the running kernel's symbols.

Teach dtrace about el1_trap_exit frames on aarch64.

Implement dtrace_getarg and dtrace_getreg while here.

Count the number of artificial frames in aarch64 fbt probe correctly.

Change the address ranges that aarch64 considers toxic for dtrace.
`Toxic' means dtrace forbids D scripts from even attempting to read
or write at them.

Previously we considered [0, VM_MIN_KERNEL_ADDRESS) toxic, but
VM_MIN_KERNEL_ADDRESS is only the minimum address of the kernel map;
the direct-mapped region lies below it, and with PMAP_MAP_POOLPAGE we
allocate virtual pages for pool backing directly from physical pages
through the direct-mapped region.  Also, this did not consider I/O
mappings to be toxic, which they probably should be.

Instead, treat:

[0, AARCH64_KSEG_START)
and
[VM_KERNEL_IO_ADDRESS, 0xfff...ff)

as toxic.  (The upper bound for 0xfff...ff ought to be inclusive, not
exclusive, but I think we'll need another mechanism for expressing
that to dtrace!)

Switch from db_write_bytes to using direct-mapping.

This way there's no dependency on ddb.

Define the MULTIPROCESSOR cpu_number() for modules too.
Modules should work whether the main kernel is multiprocessor or not.
In particular, dtrace should not think cpu_number() is 0 while
cpu_index(curcpu()) and curcpu()->ci_index are nonzero, leading to
rather spectacularly bogus results...

cyclic.kmod needs -Wno-sign-compare for aarch64 CPU_INFO_FOREACH.
Provisional workaround; feel free to fix.

Use /dev/ksyms, not /netbsd, for the running kernel's symbols.

Sync with HEAD

Use a constant to prevent dynamic array allocation which messes up SSP.

merge a new version of the CDDL dtrace and ZFS code.
this changes the upstream vendor from OpenSolaris to FreeBSD,
and this version is based on FreeBSD svn r315983.

in addition to the 10 years of improvements from upstream,
this version also has these NetBSD-specific enhancements:
 - dtrace FBT probes can now be placed in kernel modules.
 - ZFS now supports mmap().

import new CDDL dtrace and ZFS code from FreeBSD svn r315983.

Sync with HEAD

machdep.booted_kernel is not an absolute path, make it so. Now u_int is
found but its parent is not :-)

Add missing dp_proc_unlock() in error path.

From PR kern/51285 (Henning Petersen)

XXX Pullup to 7 and 7-0

Introduce dt_bootfile() and use it to avoid hard-coded kernel values. Fixes
dtrace hang for kernels not named netbsd.

Make this build for me.

load the kernel for NetBSD (for now)

put back module filename finding code.

sync with FreeBSD

check and fix printf formats, negative array indices, uninitialized variables,
shadowed variables.

sync with head

Use the correct path in dt_module.c.
From clang via Henning Petersen in PR 46009.

remove a debug printf

DTrace: fix a few problems introduced by the recent ZFS update (expected
problems from the OpenSolaris merge).

Merge NetBSD local changes to new zfs version 22 sources.

Import new Opensolaris sources for zfs/dtrace.

Opensolaris mercurial changeset: 11751:58c0c8f4305f

Apply NetBSD changes to DTrace.

Ok with core@.

Add the FreeBSD 8-RC1 changes for DTrace.

Ok with core@.

Import the rest of Opensolaris 20081117 needed for DTrace. No conflicts
with ZFS.

Initial revision